Re: svn commit: r805384 - /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/FileSystemOptions.java

2009-08-18 Thread sebb
On 18/08/2009, joe...@apache.org joe...@apache.org wrote: Author: joehni Date: Tue Aug 18 12:22:35 2009 New Revision: 805384 URL: http://svn.apache.org/viewvc?rev=805384view=rev Log: Make FileSystemOptions cloneable (VFS-278). Modified:

Re: svn commit: r805384 - /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/FileSystemOptions.java

2009-08-18 Thread Jörg Schaible
Hi Sebb, sebb wrote at Dienstag, 18. August 2009 14:48: + +/** + * {...@inheritdoc} + */ +public Object clone() { +FileSystemOptions clone = new FileSystemOptions(); +clone.options = new TreeMap(options); +return clone; +} This

Re: svn commit: r805384 - /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/FileSystemOptions.java

2009-08-18 Thread sebb
On 18/08/2009, Jörg Schaible joerg.schai...@gmx.de wrote: Hi Sebb, sebb wrote at Dienstag, 18. August 2009 14:48: + +/** + * {...@inheritdoc} + */ +public Object clone() { +FileSystemOptions clone = new FileSystemOptions(); +

Re: svn commit: r805384 - /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/FileSystemOptions.java

2009-08-18 Thread ralph.goers @dslextreme.com
On Tue, Aug 18, 2009 at 7:48 AM, sebb seb...@gmail.com wrote: On 18/08/2009, Jörg Schaible joerg.schai...@gmx.de wrote: Hi Sebb, sebb wrote at Dienstag, 18. August 2009 14:48: + +/** + * {...@inheritdoc} + */ +public Object clone() { +

RE: svn commit: r805384 - /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/FileSystemOptions.java

2009-08-18 Thread Mario Ivankovits
Hi! From personal experience, I've found working with it to be awkward and brittle. I would much prefer to have each provider subclass FileSystemOptions and provide the getters and setters there. Then, at least, you could do an instanceof on the FileSystemOptions and determine what options

Re: [net] trunk vs branches

2009-08-18 Thread Niall Pemberton
On Thu, Aug 13, 2009 at 11:08 AM, Stefan Bodewigbode...@apache.org wrote: Hi, over in Ant land we've received a bug report that Ant's ftp task wouldn't compile against commons-net 2,0 because the IMAGE_FILE_TYPE constant was removed from the FTP class. Given that trunk still has that

Re: svn commit: r805384 - /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/FileSystemOptions.java

2009-08-18 Thread Jörg Schaible
sebb wrote: On 18/08/2009, Jörg Schaible joerg.schai...@gmx.de wrote: Hi Sebb, sebb wrote at Dienstag, 18. August 2009 14:48: + +/** + * {...@inheritdoc} + */ +public Object clone() { +FileSystemOptions clone = new FileSystemOptions(); +

RE: svn commit: r805384 - /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/FileSystemOptions.java

2009-08-18 Thread Jörg Schaible
Hi Mario, Mario Ivankovits wrote: Hi! From personal experience, I've found working with it to be awkward and brittle. I would much prefer to have each provider subclass FileSystemOptions and provide the getters and setters there. Then, at least, you could do an instanceof on the

Re: svn commit: r805384 - /commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs/FileSystemOptions.java

2009-08-18 Thread Ralph Goers
On Aug 18, 2009, at 10:18 AM, Mario Ivankovits wrote: Hi! From personal experience, I've found working with it to be awkward and brittle. I would much prefer to have each provider subclass FileSystemOptions and provide the getters and setters there. Then, at least, you could do an