Re: [io] missing java.io.PrintWriter.close() in org.apache.commons.io.testtools.FileBasedTestCase.checkWrite()

2010-10-26 Thread Niall Pemberton
On Tue, Oct 26, 2010 at 6:13 AM, Julien Aymé julien.a...@gmail.com wrote: Hi Huxing, since the PrintStream/PrintWriter are built around an existing (open) OutputStream/Writer: the parameter passed to the method, it is the responsibility of the caller to close the OutputStream/Writer. Thus,

[io] missing java.io.PrintWriter.close() in org.apache.commons.io.testtools.FileBasedTestCase.checkWrite()

2010-10-25 Thread Zhang, Huxing
Dear Apache Commons IO developers, I found there might be a close method missing in the source code of test cases, which may be an issue. No patch seems to be applied till revision 1026932. How do you guys think? The original code here is: In

Re: [io] missing java.io.PrintWriter.close() in org.apache.commons.io.testtools.FileBasedTestCase.checkWrite()

2010-10-25 Thread Julien Aymé
Hi Huxing, since the PrintStream/PrintWriter are built around an existing (open) OutputStream/Writer: the parameter passed to the method, it is the responsibility of the caller to close the OutputStream/Writer. Thus, there is no need to close the PrintStream/PrintWriter (they would close the