Re: [pool] Exception in GKOP allocate()

2009-05-26 Thread Phil Steitz
Note that clearOldest() (called in the middle of allocate()) itself calls allocate(). That could explain it. Phil - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail:

Re: [pool] Exception in GKOP allocate()

2009-05-26 Thread Mark Thomas
Phil Steitz wrote: Note that clearOldest() (called in the middle of allocate()) itself calls allocate(). That could explain it. Good catch. That will be it :) clearOldest() also needs to be moved outside of any syncs to prevent possible deadlocks. I'm just setting up commons-performance to

Re: [pool] Exception in GKOP allocate()

2009-05-26 Thread Mark Thomas
Mark Thomas wrote: Phil Steitz wrote: Note that clearOldest() (called in the middle of allocate()) itself calls allocate(). That could explain it. Good catch. That will be it :) clearOldest() also needs to be moved outside of any syncs to prevent possible deadlocks. I'm just setting

[pool] Exception in GKOP allocate()

2009-05-25 Thread Phil Steitz
I just saw this in one of my load tests [java] java.util.NoSuchElementException [java] at java.util.LinkedList.remove(LinkedList.java:644) [java] at java.util.LinkedList.removeFirst(LinkedList.java:134) [java] at

Re: [pool] Exception in GKOP allocate()

2009-05-25 Thread Mark Thomas
Phil Steitz wrote: I just saw this in one of my load tests [java] java.util.NoSuchElementException [java] at java.util.LinkedList.remove(LinkedList.java:644) [java] at java.util.LinkedList.removeFirst(LinkedList.java:134) [java] at

Re: [pool] Exception in GKOP allocate()

2009-05-25 Thread Phil Steitz
Mark Thomas wrote: Phil Steitz wrote: I just saw this in one of my load tests [java] java.util.NoSuchElementException [java] at java.util.LinkedList.remove(LinkedList.java:644) [java] at java.util.LinkedList.removeFirst(LinkedList.java:134) [java] at

Re: [pool] Exception in GKOP allocate()

2009-05-25 Thread Phil Steitz
When I do this // Second utilise any spare capacity to create new objects if ((_maxActive 0 || pool.activeCount + pool.internalProcessingCount _maxActive) (_maxTotal 0 || _totalActive + _totalIdle + _totalInternalProcessing _maxTotal)) {

Re: [pool] Exception in GKOP allocate()

2009-05-25 Thread Phil Steitz
-_allocationQueue.removeFirst(); +_allocationQueue.remove(latch); both places in allocate() makes the problem go away. I am not sure that is a good fix, but it eliminates the problem. Must have something to do with the latch notifies. I also don't