Re: svn commit: r746804 - /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolableConnectionFactory.java

2009-02-22 Thread Phil Steitz
We should note this change of behavior in the changelog. I am OK with it, but I think we discussed it a while back and decided not to do it due to concerns that removing the synch could result in hammering the db engine with concurrent bursts of createConnection requests when load spikes

Re: svn commit: r746804 - /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolableConnectionFactory.java

2009-02-22 Thread Mark Thomas
Phil Steitz wrote: We should note this change of behavior in the changelog. Will do. I'll finish off my work on DBCP-212 first. I don't think there is anything else we can do for DBCP-212 save add some notes to docs. I have patches for this I am about to commit. Mark

Re: svn commit: r746804 - /commons/proper/dbcp/trunk/src/java/org/apache/commons/dbcp/PoolableConnectionFactory.java

2009-02-22 Thread Phil Steitz
Mark Thomas wrote: Phil Steitz wrote: We should note this change of behavior in the changelog. Will do. I'll finish off my work on DBCP-212 first. I don't think there is anything else we can do for DBCP-212 save add some notes to docs. I have patches for this I am about to commit.