proposal to add platform field in the model used for build agents for continuum master

2010-12-06 Thread Mark John Kennedy Magallanes
hi all, I'm proposing to add a String field to the BuildAgentConfiguration model used in by the continuum master to save build agents. Right now BuildAgentConfiguration has the following fields String url, String description, boolean enabled, I'm suggesting to add another field String platform

Re: Implementation proposal for Continuum Issue #2592 Ability for build agents to use installations in their config file

2010-12-06 Thread Marc Jansen Chua
Hello Brett, Assuming that individual configuration of installation for build agents is supported. Build Agents are grouped into Build Agent Groups, and Build Agent Groups together with a set of Installations are grouped into Build Environments, so if in the case of an environmental variable "

Re: Implementation proposal for Continuum Issue #2592 Ability for build agents to use installations in their config file

2010-12-06 Thread Brett Porter
I'm not sure there should be any duplication. The ones on the agent will be the ones specific to that machine, the master things like MAVEN_OPTS settings which might be common. Are the installations keyed in some way that they can use the same ID if they are intended to "override" the master se

Re: Implementation proposal for Continuum Issue #2592 Ability for build agents to use installations in their config file

2010-12-06 Thread Marc Jansen Chua
Hello Deng, Forgot to mention on the duplicate installation case. I am planning to give more weight on the installations in build agents because configuring installations in build agents can cater to customizability in micro-managing build agents compared to build environment installations whic

Re: Implementation proposal for Continuum Issue #2592 Ability for build agents to use installations in their config file

2010-12-06 Thread Deng Ching
Extending the installation config sounds fine to me, but we need to make sure that it is clearly documented :) Btw, how would duplicate installations be handled? For example, if a JDK installation is defined in the build environment then another JDK installation is defined in the build agent. I wo