Re: Updating plugin code on prepare

2013-09-24 Thread James Jong
+1 This is a cleaner workflow and should reduce some confusion. -James Jong On Sep 24, 2013, at 3:09 PM, Michal Mocny wrote: > Just to add, the reason for the "if" statement in step (2) is that > uninstall & reinstall take a lot longer than just moving a few files, which > is the 99.9% case for

Re: [iOS] Keyboard Preferences - move to a plugin for 3.2.0

2013-09-24 Thread James Jong
+1 Separating this from the core into a plugin is a good idea. Not sure that this fits into any existing plugin though. -James Jong On Sep 24, 2013, at 2:37 PM, Shazron wrote: > Issue: https://issues.apache.org/jira/browse/CB-3020 > > I've got it mostly working but I'm thinking this really sh

Re: 3.1 Release

2013-09-24 Thread Steven Gill
I realize why Anis decided to do a new branch (3.1.0) because he didn't want to mess up dev/master. Before we release 3.1.0 we need to do a plugin release based off of http://wiki.apache.org/cordova/StepsForPluginRelease. Jesse has changes for the plugins that he has pushed to dev now based on this

how to enable Flash plug-in on Android 2.3 WebView

2013-09-24 Thread Sergey Armishev
Sorry for bothering you,dear developers but it seems like only you can answer. I have RTMP live stream that I want to show on Android 2.3 using Cordova v.3 The native Android browser shows streaming OK in Flash plug-in but when I convert HTML page to the Cordova/Android app it complains that

Re: Major refactoring of Plugman and CLI

2013-09-24 Thread Jesse
Oops, I missed that Braden, thanks. @Ryan, the code is committed, but won't be pushed to npm for at least a week. We will have a chance to run it through the rigors first, although it is seeming like there will be little to no impact. @purplecabbage risingj.com On Tue, Sep 24, 2013 at 1:22 PM

Re: Major refactoring of Plugman and CLI

2013-09-24 Thread Braden Shepherdson
I guess I wasn't clear in my email, but this is exactly the API that **didn't** change. I did more or less what you suggested to support it. You should still be able to make that call and it will work fine. If it's not, then something has gone wrong and we'll fix it. Braden On Tue, Sep 24, 2013

Re: Major refactoring of Plugman and CLI

2013-09-24 Thread Ryan Stewart
Apologies as I'm having a little bit of trouble following this conversation. Is this change already in Cordova CLI? Is it part of the 3.1.0 release? =Ryan On 9/24/13 1:18 PM, "Jesse" wrote: >So, in the phonegap-cli, which uses cordova-cli, we have this call: > >var cordova = require('cordova');

Re: Major refactoring of Plugman and CLI

2013-09-24 Thread Jesse
So, in the phonegap-cli, which uses cordova-cli, we have this call: var cordova = require('cordova'); ... cordova.create(options.path, options.id, options.name, function(e) { ... So this is definitely broken now as a result of this change, and has to be re-written to support promises. Couldn't

Re: [Android] In-App Browser UI - thenounproject.com

2013-09-24 Thread Joe Bowser
There's this for the Native Styling: http://developer.android.com/design/downloads/index.html I think this is still compatible with Apache, I'll probably go with these icons, since they're so similar to the platform itself. On Tue, Sep 24, 2013 at 12:56 PM, Jesse wrote: > Doesn't Android have i

Re: [Android] In-App Browser UI - thenounproject.com

2013-09-24 Thread Jesse
Doesn't Android have icons that can be used, and redistributed? I think it would be easier to do platform specific, windows phone includes 'metro-ui' look icons, but let the app developer supply their own images as well. @purplecabbage risingj.com On Tue, Sep 24, 2013 at 12:51 PM, Plaquette, Pa

Re: [Android] In-App Browser UI - thenounproject.com

2013-09-24 Thread Plaquette, Paul
Hi Joe, did you have a look at the open clip art project? http://openclipart.org/ they have arrows collections @Paul ~~~ Paul Plaquette, Senior Software Engineer Intel Corporation SAS * * *SSG/OTC: Open Source Technology Center* France, Montpellier On Tu

Re: Major refactoring of Plugman and CLI

2013-09-24 Thread purplecabbage
Thanks for clarifying Braden. My general rule is if I am changing many files, I will run it by the list. Also if I am touching other platforms, I will always consult the list. Luckily/unluckily, many of my drastic changes have happened in the win/wp area where there are far fewer hands in the

Re: Updating plugin code on prepare

2013-09-24 Thread Michal Mocny
Just to add, the reason for the "if" statement in step (2) is that uninstall & reinstall take a lot longer than just moving a few files, which is the 99.9% case for most end users who aren't making modifications to plugins. This way, we only do the heavy lifting if your plugin structure actually c

Updating plugin code on prepare

2013-09-24 Thread Braden Shepherdson
Michal and I were discussing how to make the plugin developer experience better, by having `cordova prepare` update the platform projects properly when you change a plugin in place. I propose the following changes: 1. On plugin install, we cache the plugin.xml in $PROJECT/.cordova somewhere. 2. O

Re: Major refactoring of Plugman and CLI

2013-09-24 Thread Braden Shepherdson
I get the impression that "talking about it internally" came out wrong. Here's what actually happened: - I started out to fix some bugs, including killing use of shell.exec because it leaks filehandles and sometimes causes fatal errors. - I adopted promises to control the horribly deep callback tr

[iOS] Keyboard Preferences - move to a plugin for 3.2.0

2013-09-24 Thread Shazron
Issue: https://issues.apache.org/jira/browse/CB-3020 I've got it mostly working but I'm thinking this really should move to a plugin, perhaps reside in an existing one? The things we are doing with hiding the keyboard accessory bar and shrinking the view etc are hackish and might break with any i

Re: Major refactoring of Plugman and CLI

2013-09-24 Thread Joe Bowser
On Tue, Sep 24, 2013 at 6:48 AM, Braden Shepherdson wrote: > We debated internally at Google how much to talk about this. In the end we > decided that since the external APIs were not changing, this could be > claimed as an internal refactoring. I'm not sure whether that was the right > call. > N

Re: Major refactoring of Plugman and CLI

2013-09-24 Thread Shazron
Definitely. Talking about changes is cool, not talking about it -- not cool. On Tue, Sep 24, 2013 at 11:01 AM, purplecabbage wrote: > Q is a good choice. Not talking about it was absolutely the wrong choice. > There are no internal teams , there is only this list. > > Sent from my iPhone > > > O

Re: Major refactoring of Plugman and CLI

2013-09-24 Thread purplecabbage
Q is a good choice. Not talking about it was absolutely the wrong choice. There are no internal teams , there is only this list. Sent from my iPhone > On Sep 24, 2013, at 6:48 AM, Braden Shepherdson wrote: > > We debated internally at Google how much to talk about this. In the end we > decide

[Android] In-App Browser UI - thenounproject.com

2013-09-24 Thread Joe Bowser
Hey I found these icons from Noun Project which are public domain. I'm wanting to replace are existing non-icon weirdness with these. I would have liked to use other icons to make it look more consistent, but I'm worried about licensing. For Arrows: http://thenounproject.com/noun/arrow/#icon-No

Re: 3.1 Release

2013-09-24 Thread Michal Mocny
Just to be super duper clear: the reason to work on 'dev' branch of plugins is not some process decision we are imposing, its a direct requirement imposed on us by the limitations of our tools (specifically, the state of the registry as it was with 3.0 launch). We discussed this in-depth just a we

Re: 3.1 Release

2013-09-24 Thread Braden Shepherdson
I agree with Joe that developing on anything other than master sucks. But unfortunately, our hands are tied in the near term because the registry doesn't know to fetch plugins from anywhere else. Also it makes life easier for being who are installing plugins from git URLs. I think we eventually wa

Re: Major refactoring of Plugman and CLI

2013-09-24 Thread Braden Shepherdson
We debated internally at Google how much to talk about this. In the end we decided that since the external APIs were not changing, this could be claimed as an internal refactoring. I'm not sure whether that was the right call. About fetch and platforms, to be clear, those are far from the only mod

Re: About Cordova, Adobe and W3C

2013-09-24 Thread Lisa Seacat DeLuca
I (and IBM) recently joined both the w3c DAP working group and the mobile and web interest group. Lisa Seacat DeLuca Emerging Mobile Software Engineer - IBM Master Inventor SWG Emerging Internet Standards Phone: 1-410-332-2128 | Mobile: 1-415-787-4589 E-mail: ldel...@us.ibm.com personal websit

Re: 3.1 Release

2013-09-24 Thread Shazron
Yes, let's get this cleared up - confused myself. On Tue, Sep 24, 2013 at 3:52 AM, Anis KADRI wrote: > 3.1.0 is coincidental and it's temporary for this release because I > wasn't sure where to get the code from and didn't want to compromise > master or dev. I could have called it something els

Re: Major refactoring of Plugman and CLI

2013-09-24 Thread Anis KADRI
cool. I don't think we're using fetch/platforms directly. -a On Tue, Sep 24, 2013 at 11:35 AM, Brian LeRoux wrote: > Kewl. I'm down and happen to really like Q. Not sure everyone will agree. > Maybe next time a heads up to the list so we can discuss arch changes like > this. > > > On Mon, Sep 2

Re: 3.1 Release

2013-09-24 Thread Anis KADRI
3.1.0 is coincidental and it's temporary for this release because I wasn't sure where to get the code from and didn't want to compromise master or dev. I could have called it something else. Jesse, I'd advise you to commit to dev. Everything will be merged to master eventually. So to re-iterate t

Re: Major refactoring of Plugman and CLI

2013-09-24 Thread Brian LeRoux
Kewl. I'm down and happen to really like Q. Not sure everyone will agree. Maybe next time a heads up to the list so we can discuss arch changes like this. On Mon, Sep 23, 2013 at 8:13 PM, Braden Shepherdson wrote: > Whoops, I forgot to mention, I created and pushed a cordova-3.1.x branch of > bo