adding 'browser' as a platform for cordova.js

2013-12-08 Thread Brian LeRoux
More for discussion than review. https://github.com/apache/cordova-js/pull/57/files Clocks in at a disturbing 44kb so we clearly have room for optimization on the baseline of our platform. (Not a criticism: an observation.) I have a few questions for them whom are more familiar w/ cordova.js tha

Review request for CB-5579

2013-12-08 Thread Leyonh W
Hi, Can someone review the request ? Thanks in advance. https://github.com/apache/cordova-plugman/pull/37 Cheers, Liyong

Re: proposal to simplify hello world

2013-12-08 Thread Michal Mocny
(apache reviews has a fairly poor UI/UX, but has some fairly useful integration with JIRA and ML. Those benefits matter not for this patch. Since on this aside already, does anyone know a way to sign up for github emails for pull request code comments without getting spammed with one email for ev

RE: Cordova and Crosswalk

2013-12-08 Thread Hu, Ningxin
+1. Renderer makes more sense. :) > -Original Message- > From: mmo...@google.com [mailto:mmo...@google.com] On Behalf Of Michal > Mocny > Sent: Monday, December 09, 2013 11:10 AM > To: dev > Subject: Re: Cordova and Crosswalk > > +1 to Renderer. I think that term is more applicable here

Re: Cordova and Crosswalk

2013-12-08 Thread Michal Mocny
+1 to Renderer. I think that term is more applicable here anyway. On Sun, Dec 8, 2013 at 6:13 PM, Brian LeRoux wrote: > I like it but one small nit: we already use the term 'engine' to describe a > downstream in plugins. Propose we call it 'renderer'. > > > On Sat, Dec 7, 2013 at 12:38 AM, Jon

Re: proposal to simplify hello world

2013-12-08 Thread Brian LeRoux
ok, for review https://github.com/apache/cordova-app-hello-world/pull/4 (I'm not really a fan of the apache reviews / seems like a step backward to me.) On Thu, Dec 5, 2013 at 7:02 AM, Josh Soref wrote: > > I have been thinking about this, > > is there a valid reason to have DisallowOverscrol

Re: Cordova and Crosswalk

2013-12-08 Thread Brian LeRoux
I like it but one small nit: we already use the term 'engine' to describe a downstream in plugins. Propose we call it 'renderer'. On Sat, Dec 7, 2013 at 12:38 AM, Jonathan Bond-Caron < jbo...@gdesolutions.com> wrote: > On Wed Dec 4 11:55 PM, Hu, Ningxin wrote: > > > -Original Message- >