[GitHub] cordova-plugin-network-information pull request: [CB-6350] Return ...

2014-03-26 Thread yannlugrin
GitHub user yannlugrin opened a pull request: https://github.com/apache/cordova-plugin-network-information/pull/8 [CB-6350] Return cellular connection type even if wifi is reachable on 64-bit iOS Pull request related to: https://issues.apache.org/jira/browse/CB-6350

[GitHub] cordova-docs pull request: [CB-5834] remove/hide references to uns...

2014-03-26 Thread mike-sierra
Github user mike-sierra closed the pull request at: https://github.com/apache/cordova-docs/pull/168 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-blackberry pull request: CB-6346 - Add node_modules to sou...

2014-03-26 Thread bryanhiggins
GitHub user bryanhiggins opened a pull request: https://github.com/apache/cordova-blackberry/pull/152 CB-6346 - Add node_modules to source control You can merge this pull request into a Git repository by running: $ git pull https://github.com/blackberry/cordova-blackberry

[GitHub] cordova-plugin-dialogs pull request: CB-4966 Removing FirefoxOS Qu...

2014-03-26 Thread zalun
GitHub user zalun opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/17 CB-4966 Removing FirefoxOS Quirks * no need to add special permission (it's different API with the same name) * notification.css is added automatically This still creates

Re: Many CLI tests failing

2014-03-26 Thread Josh Soref
Max wrote: Josh is having trouble accessing the buildbot page, so here is the relevant information. Thanks. Looking.

Re: Get your test results here! Medic/CI viewing available

2014-03-26 Thread Josh Soref
Steven wrote: DAMN YOU ADOBE NET!!! [cid:361@goomoji.gmail] I can access it on the guest network. I was able to access it from a cellular network, but I can’t access it from our corporate network.

Intro and multithread calls - file-transfer in particular

2014-03-26 Thread Jorge Torres
Dear all, My name is Jorge Torres, I love cordova! been using it for 3 years now. I would like to contribute. I have been getting warnings of filetransfer taking too long, its a quick fix to make that happen on a separate thread. I dont know how to request commit changes, but I attach the an

Re: config.xml parsing strategy

2014-03-26 Thread Andrew Grieve
CLI-only is my thought as well. If you add enough functionality to platforms to enable this, then I think you'd end up with CLI in the end anyways. On Tue, Mar 25, 2014 at 11:20 AM, Jesse purplecabb...@gmail.com wrote: I have given this some more thought, and discussed it a bit with Joe

Re: Intro and multithread calls - file-transfer in particular

2014-03-26 Thread Andrew Grieve
Hi Jorge, Best way to propose a change is to use a github pull request against the relevant repository. E.g. https://github.com/apache/cordova-plugin-file-transfer On Wed, Mar 26, 2014 at 7:59 AM, Jorge Torres jorge.torres.maldon...@gmail.com wrote: Dear all, My name is Jorge Torres, I

[GitHub] cordova-plugin-file-transfer pull request: Update CDVFileTransfer....

2014-03-26 Thread torrmal
GitHub user torrmal opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/24 Update CDVFileTransfer.m Since download can take time, for it to be non-blocking, moved the call to a separate thread. You can merge this pull request into a Git repository by

Re: Intro and multithread calls - file-transfer in particular

2014-03-26 Thread Jorge Torres
Done, Thank you :) On Wed, Mar 26, 2014 at 11:20 AM, Andrew Grieve agri...@chromium.orgwrote: Hi Jorge, Best way to propose a change is to use a github pull request against the relevant repository. E.g. https://github.com/apache/cordova-plugin-file-transfer On Wed, Mar 26, 2014 at 7:59

Re: Many CLI tests failing

2014-03-26 Thread Josh Soref
https://github.com/blackberry/cordova-cli/tree/cb_6337 Should cover both of my breaks. I¹m waiting for our CI tooling to confirm it¹s happy before I submit a pull request for it. Maybe sometime in the near future I¹ll try to rework the tests to use an in-memory-psuedo-filesystem so that we can

[GitHub] cordova-cli pull request: Add platform tizen

2014-03-26 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/125#discussion_r10983854 --- Diff: src/metadata/tizen_parser.js --- @@ -0,0 +1,131 @@ +var Q = require( q ), + shelljs = require( shelljs ), + util = require(

Re: Many CLI tests failing

2014-03-26 Thread Lorin Beer
Thanks Max, took a look, some tests for functionality that isn't implemented made it into master. I've reverted the offending change. As policy, I'm behind reverting any commit that fails tests or breaks functionality. It pollutes everyone's dev process with issues that should remain isolated. I

Re: Many CLI tests failing

2014-03-26 Thread Andrew Grieve
On Wed, Mar 26, 2014 at 9:05 AM, Josh Soref jso...@blackberry.com wrote: https://github.com/blackberry/cordova-cli/tree/cb_6337 Should cover both of my breaks. I¹m waiting for our CI tooling to confirm it¹s happy before I submit a pull request for it. Maybe sometime in the near future

[GitHub] cordova-cli pull request: Add platform tizen

2014-03-26 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/125#discussion_r10987445 --- Diff: spec/metadata/tizen_parser.spec.js --- @@ -0,0 +1,102 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more

[GitHub] cordova-cli pull request: Fix errors from CB-6337 CB-6338

2014-03-26 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-cli/pull/150 Fix errors from CB-6337 CB-6338 I can't actually find our CI to confirm that it likes everything, but `npm test` only shows the errors that aren't mine. You can merge this pull request into a

Re: Get your test results here! Medic/CI viewing available

2014-03-26 Thread Steven Gill
I just set up ci.cordova.io to point there! I'm guessing Adobe/Blackberry Net block it due to the port. On Wed, Mar 26, 2014 at 11:39 AM, Marcel Kinard cmarc...@gmail.com wrote: I'm able to see it from the IBM corporate network. Looks nice. Great work, David! On Mar 25, 2014, at 11:05

[GitHub] cordova-cli pull request: CB-6329 improve 'cordova info' command

2014-03-26 Thread martincgg
GitHub user martincgg opened a pull request: https://github.com/apache/cordova-cli/pull/151 CB-6329 improve 'cordova info' command info.js file has been modified to work mainly asynchronous. Added info-utils, which contains several useful functions required by info.js

Re: Get your test results here! Medic/CI viewing available

2014-03-26 Thread Josh Soref
Steven wrote: I'm guessing Adobe/Blackberry Net block it due to the port. Seems likely. Is there any reason it can¹t run on a standard port?

[GitHub] cordova-cli pull request: CB-5082 [CLI] BB10 add support in doPlat...

2014-03-26 Thread martincgg
GitHub user martincgg opened a pull request: https://github.com/apache/cordova-cli/pull/152 CB-5082 [CLI] BB10 add support in doPlatform() https://issues.apache.org/jira/browse/CB-5082 Support for blackberry10, when 'cordova info' command is used to retrieve information

[GitHub] cordova-cli pull request: CB-5082 [CLI] BB10 add support in doPlat...

2014-03-26 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/152#discussion_r10993531 --- Diff: src/info-utils.js --- @@ -0,0 +1,132 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more contributor

[GitHub] cordova-cli pull request: CB-5082 [CLI] BB10 add support in doPlat...

2014-03-26 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/152#discussion_r10993586 --- Diff: src/info-utils.js --- @@ -0,0 +1,132 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more contributor

[GitHub] cordova-cli pull request: CB-5082 [CLI] BB10 add support in doPlat...

2014-03-26 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/152#discussion_r10993657 --- Diff: src/info-utils.js --- @@ -0,0 +1,132 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more contributor

[GitHub] cordova-cli pull request: CB-5082 [CLI] BB10 add support in doPlat...

2014-03-26 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/152#discussion_r10993672 --- Diff: src/info-utils.js --- @@ -0,0 +1,132 @@ +/** --- End diff -- No one likes tabs --- If your project is set up for it, you can

[GitHub] cordova-cli pull request: CB-5082 [CLI] BB10 add support in doPlat...

2014-03-26 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-cli/pull/152#discussion_r10993698 --- Diff: src/info-utils.js --- @@ -0,0 +1,132 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or more contributor

[GitHub] cordova-cli pull request: CB-5082 [CLI] BB10 add support in doPlat...

2014-03-26 Thread martincgg
Github user martincgg commented on the pull request: https://github.com/apache/cordova-cli/pull/152#issuecomment-38729077 Well, I'm using windows as my main development environment, sorry about the misspell, I have fixed that up. I've added the line at the end as well. The set

Re: [GitHub] cordova-plugin-file-transfer pull request: Update CDVFileTransfer....

2014-03-26 Thread Jorge Torres
Hi Ian, Who do I send my ICLA? Thank you, Jorge On Wed, Mar 26, 2014 at 12:19 PM, clelland g...@git.apache.org wrote: Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/24#issuecomment-38704767 This looks like it should

[GitHub] cordova-docs pull request: 3.4.0

2014-03-26 Thread ldeluca
Github user ldeluca commented on the pull request: https://github.com/apache/cordova-docs/pull/199#issuecomment-38735163 What is this for? are you trying to add a new language @Watabe08 ? --- If your project is set up for it, you can reply to this email and have your reply appear on

Re: Fwd: [GitHub] cordova-docs pull request: 3.4.0

2014-03-26 Thread Lisa Seacat DeLuca
What is this about @Watabe08? Are you proposing adding a new language? If so please email me at ldel...@apache.org and I'll help get you setup using our translation tool, crowdin. https://crowdin.net/project/cordova Lisa From: Marcel Kinard cmarc...@gmail.com To: Lisa Seacat

Re: [GitHub] cordova-plugin-file-transfer pull request: Update CDVFileTransfer....

2014-03-26 Thread Ian Clelland
You can send a signed copy (either physically signed, or cryptographically) to secret...@apache.org. http://www.apache.org/licenses/#clas has the complete instructions. Ian On Wed, Mar 26, 2014 at 4:02 PM, Jorge Torres jorge.torres.maldon...@gmail.com wrote: Hi Ian, Who do I send my ICLA?

[GitHub] cordova-cli pull request: CB-5082 [CLI] BB10 add support in doPlat...

2014-03-26 Thread martincgg
Github user martincgg commented on the pull request: https://github.com/apache/cordova-cli/pull/152#issuecomment-38741745 Ok, got it, no problem. I can add logic to determine if the variable is already in place, and also something that when the function or the blackberry operations

[GitHub] cordova-registry-web pull request: Refactor

2014-03-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-registry-web/pull/1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-cli pull request: CB-5082 [CLI] BB10 add support in doPlat...

2014-03-26 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-cli/pull/152#issuecomment-38747218 While cordova-cli is usually run as `bin/cordova`, it's possible to use cordova as a library, which means that your env changes last longer. --- If your project is

[GitHub] cordova-plugman pull request: Add platform support for tizen

2014-03-26 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-plugman/pull/67#discussion_r11002341 --- Diff: spec/plugins/DummyPlugin/plugin.xml --- @@ -161,6 +161,11 @@ /js-module /platform + !-- tizen --

[GitHub] cordova-plugman pull request: Add platform support for tizen

2014-03-26 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-plugman/pull/67#discussion_r11002418 --- Diff: package.json --- @@ -34,6 +34,7 @@ request: 2.22.0 }, devDependencies: { +temp: 0.6.x, --- End diff --

[GitHub] cordova-plugman pull request: Add platform support for tizen

2014-03-26 Thread jsoref
Github user jsoref commented on a diff in the pull request: https://github.com/apache/cordova-plugman/pull/67#discussion_r11002375 --- Diff: README.md --- @@ -30,6 +30,7 @@ You must have `git` on your PATH to be able to install plugins directly from rem * BlackBerry 10 *

[GitHub] cordova-plugman pull request: Add platform support for tizen

2014-03-26 Thread imhotep
Github user imhotep commented on a diff in the pull request: https://github.com/apache/cordova-plugman/pull/67#discussion_r11004412 --- Diff: src/platforms/tizen.js --- @@ -0,0 +1,14 @@ +var path = require('path') +, xml_helpers = require('../util/xml-helpers') +

[GitHub] cordova-cli pull request: CB-6357 platform check - install each pl...

2014-03-26 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-cli/pull/153 CB-6357 platform check - install each platform to determine working + version number The other changesets (Refactor, exports, silence output, sort output, fix indentation) are split because

[GitHub] cordova-cli pull request: CB-6357 platform check - install each pl...

2014-03-26 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-cli/pull/153#issuecomment-38762210 Sigh, and now i need to deal w/ `npm test` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-blackberry pull request: CB-6346 - Add node_modules to sou...

2014-03-26 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-blackberry/pull/152#issuecomment-38762335 r+ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-cli pull request: Fix errors from CB-6337 CB-6338

2014-03-26 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-cli/pull/150#issuecomment-38767219 `npm test` is happy, would someone please merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-cli pull request: CB-6357 platform check - install each pl...

2014-03-26 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-cli/pull/153#issuecomment-38767269 ok, with #150 applied, this set of changes applies cleanly and doesn't introduce any new `npm test` failures. --- If your project is set up for it, you can reply to