Re: Suggestions for a problem

2014-04-08 Thread Gorkem Ercan
I think a tool can just go through all tagged version of the CLI's platforms.js and create the version map. I guess this effectively makes CLI versions the Cordova version. I was looking at the phonegap announcement[1], which got me thinking, I think independent releases may create complications

[GitHub] cordova-windows pull request: CB-6256 CB-6266 Add support for doma...

2014-04-08 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-windows/pull/23#issuecomment-39844429 ICLA has been filled --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-file pull request: fix the Windows 8 implementation...

2014-04-08 Thread yaurthek
GitHub user yaurthek opened a pull request: https://github.com/apache/cordova-plugin-file/pull/36 fix the Windows 8 implementation of the getFile method The storageFolder.getFileAsync(name) does not accept relative paths, only a simple file name... see

[GitHub] cordova-plugin-file pull request: fix the Windows 8 implementation...

2014-04-08 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/36#issuecomment-39853542 Looks like https://issues.apache.org/jira/browse/CB-6017 (and possibly also https://issues.apache.org/jira/browse/CB-6053) --- If your project is set up

[GitHub] cordova-plugin-inappbrowser pull request: Update index.md

2014-04-08 Thread denis-aes
GitHub user denis-aes opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/36 Update index.md Fixed examples - event should be added to function parameters. You can merge this pull request into a Git repository by running: $ git pull

RE: [Android] Refactoring for different engines

2014-04-08 Thread Hu, Ningxin
Joe, thanks for this. I am very excited. FYI. Crosswalk team is working on refactoring the WebView API to support embedding usage better [1]. (Previously the layer API was not exposed as public usage). I would like to review the PoC and work with you to get Crosswalk fits into the pluggable

Re: [Android] Refactoring for different engines

2014-04-08 Thread Michal Mocny
Would it be alright to set up a Hangout some time to introduce everyone? Joe has been leading the effort here, but there are other cordova contributors for whom this is top priority. It would be nice if we could all meet to say hello and make sure we are all going in the right direction. Quite

Re: [VOTE] cordova-plugman@0.21.0

2014-04-08 Thread Steven Gill
The vote has now closed! The results are: Positive binding votes: 4 Steven Gill Ian Clelland Michal Mocny Bryan Higgins The vote has passed On Mon, Apr 7, 2014 at 11:28 AM, Bryan Higgins br...@bryanhiggins.netwrote: +1 On Mon, Apr 7, 2014 at 11:15 AM, Michal Mocny mmo...@chromium.org

Re: [Andorid] Why does LOG exist?

2014-04-08 Thread Andrew Grieve
Yep, I certainly have no idea. On Fri, Apr 4, 2014 at 12:42 PM, Joe Bowser bows...@gmail.com wrote: I'm currently working on CB-4404 again and I'm wondering why we use LOG instead of the Android Log methods. This just seems like we're duplicating code for no reason. Does anyone know why we

Re: [VOTE] Cordova-ios@3.4.1

2014-04-08 Thread Steven Gill
The vote has now closed! The results are: Positive binding votes: 4 Steven Gill Ian Clelland Michal Mocny Shazron Abdullah The vote has passed On Mon, Apr 7, 2014 at 9:54 AM, Shazron shaz...@gmail.com wrote: +1 On Sunday, April 6, 2014, Steven Gill stevengil...@gmail.com wrote: Please

Re: [Andorid] Why does LOG exist?

2014-04-08 Thread Mike Billau
No idea, ran into this issue a few weeks ago, it's confusing and doesn't seem to add any usefulness. I don't think any of those old IBMers are still working on the project. We could probably track down Simon, or just rip it out. On Tue, Apr 8, 2014 at 1:13 PM, Andrew Grieve agri...@chromium.org

Re: Suggestions for a problem

2014-04-08 Thread Andrew Grieve
On Tue, Apr 8, 2014 at 3:30 AM, Gorkem Ercan gorkem.er...@gmail.com wrote: I think a tool can just go through all tagged version of the CLI's platforms.js and create the version map. I guess this effectively makes CLI versions the Cordova version. That's the way I think of it right now as

[GitHub] cordova-coho pull request: Updated the tools release process.

2014-04-08 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-coho/pull/16 Updated the tools release process. You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-coho patch-1 Alternatively you

Re: Suggestions for a problem

2014-04-08 Thread Michal Mocny
On Tue, Apr 8, 2014 at 1:32 PM, Andrew Grieve agri...@chromium.org wrote: On Tue, Apr 8, 2014 at 3:30 AM, Gorkem Ercan gorkem.er...@gmail.com wrote: I think a tool can just go through all tagged version of the CLI's platforms.js and create the version map. I guess this effectively makes

[GitHub] cordova-windows pull request: CB-5038 Modify execution policy rest...

2014-04-08 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/24#issuecomment-39879128 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: [cordova-js] What is the purpose of runs / ?

2014-04-08 Thread Andrew Grieve
If there's an option to not change the behaviour, I think we should use it. This is a pretty big change, so anything we can keep the same will help. We can't say that it's backwards compatible if the runtime behaviour changes. On Mon, Apr 7, 2014 at 6:39 AM, Braden Shepherdson

[GitHub] cordova-coho pull request: Updated the tools release process.

2014-04-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [cordova-js] pluginloader/modulemapper, cordova_plugins.js and script injection.

2014-04-08 Thread Andrew Grieve
I don't see it as an improvement to retire these. Even if we did retire them, I don't think we should do so at the same time as changing to browserify (the two don't seem related). On Fri, Apr 4, 2014 at 4:51 PM, Anis KADRI anis.ka...@gmail.com wrote: I believe that we can retire these things

[GitHub] cordova-plugin-globalization pull request: The ISO 639-2 code is r...

2014-04-08 Thread svkirans
GitHub user svkirans opened a pull request: https://github.com/apache/cordova-plugin-globalization/pull/8 The ISO 639-2 code is returned for the default language. Probable fix f... The ISO 639-2 code is returned for the default language. Probable fix for CB-4602. You can merge

CB-6415 [Blackberry] unable to add platform, using custom or local library

2014-04-08 Thread Martin Gonzalez Glez
https://issues.apache.org/jira/browse/CB-6415 I've faced this problem this morning, when I tried to use a local library to add the platform. Has anybody ever faced this problem?

Re: Update to docs.cordova.io Redirect Server

2014-04-08 Thread Andrew Grieve
Awesome stuff Michael! Sign me up :) agri...@gmail.com On Mon, Apr 7, 2014 at 10:44 AM, Michael Brooks mich...@michaelbrooks.cawrote: Yea, with a single server, I don't think there's any graceful way to transition from one host to another. Sorry :( On Mon, Apr 7, 2014 at 11:42 AM, Igor

Re: [cordova-js] do we need clobbers/, merges/ ?

2014-04-08 Thread Andrew Grieve
I think symbol mapping comes with some nuances, and having the them in a declarative way makes it easier than telling all plugins to write their JS in a certain way. It's a level of indirection that gives us the ability to control exactly *when* the mapping happens for example. The question of

Re: [VOTE] cordoav-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1

2014-04-08 Thread Steven Gill
This vote has failed and has been broken into separate vote threads. On Sun, Apr 6, 2014 at 10:44 PM, Steven Gill stevengil...@gmail.com wrote: Just chatted with Ian at the bar about this. I think the best way to move forward is to vote on plugman first, release it and then make sure cli

[GitHub] cordova-plugman pull request: CB-6414 - fixes the issue where two ...

2014-04-08 Thread jbavari
GitHub user jbavari opened a pull request: https://github.com/apache/cordova-plugman/pull/72 CB-6414 - fixes the issue where two config.xml munges exists, it will st... https://issues.apache.org/jira/browse/CB-6414 You can merge this pull request into a Git repository by running:

Re: Update to docs.cordova.io Redirect Server

2014-04-08 Thread Shazron
Thanks Michael -- my id is shaz...@gmail.com On Mon, Apr 7, 2014 at 11:39 AM, Michael Brooks mich...@michaelbrooks.cawrote: Hey all, In the past, we've used Nodejitsu to host a server that redirects / rewrites requests from docs.cordova.io to cordova.apache.org/docs/. Today, I've switched

Re: Suggestions for a problem

2014-04-08 Thread Andrew Grieve
On Tue, Apr 8, 2014 at 9:44 AM, Michal Mocny mmo...@chromium.org wrote: On Tue, Apr 8, 2014 at 1:32 PM, Andrew Grieve agri...@chromium.org wrote: On Tue, Apr 8, 2014 at 3:30 AM, Gorkem Ercan gorkem.er...@gmail.com wrote: I think a tool can just go through all tagged version of the

[RESULT][VOTE] cordova-plugman@0.21.0

2014-04-08 Thread sebb
The ASF convention is to change the subject line - as I have done here - to make it easier to find the result in the e-mail archives (and in user inboxes). Also the summary should please state whether there were any other votes, even if there were none. On 8 April 2014 18:03, Steven Gill

[GitHub] cordova-windows pull request: CB-6397 [windows8] Use the latest ve...

2014-04-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/20 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-windows pull request: CB-5038 Modify execution policy rest...

2014-04-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-windows pull request: CB-6256 CB-6266 Add support for doma...

2014-04-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/23 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[VOTE] cordova-cli@3.4.1-0.1.0

2014-04-08 Thread Steven Gill
Please review and vote on the release of cordova-cli. cordova-cli@3.4.1-0.1.0 has been published here: *https://dist.apache.org/repos/dist/dev/cordova/CB-6245/ https://dist.apache.org/repos/dist/dev/cordova/CB-6245/* The package was published from the corresponding git tag: cordova-cli:

[CANCELLED][VOTE] cordoav-cli@3.4.1-0.1.0, cordova-plugman@0.21.0 and cordova-ios@3.4.1

2014-04-08 Thread sebb
Please consider editting the subject - as I have done here - when a vote is cancelled in future. Makes it easier to follow when reading threads and archives. Thanks! On 8 April 2014 20:51, Steven Gill stevengil...@gmail.com wrote: This vote has failed and has been broken into separate vote

Re: [VOTE] cordova-cli@3.4.1-0.1.0

2014-04-08 Thread Steven Gill
oops. The git tag hash should be: cordova-cli: 3.4.1-0.1.0 (8b182961ab1f) If you have the old 3.4.1-0.1.0 from the last vote, you will have to run git fetch -t to pull the updated tag reference. On Tue, Apr 8, 2014 at 2:17 PM, Steven Gill stevengil...@gmail.com wrote: Please review and vote

Re: [VOTE] cordova-cli@3.4.1-0.1.0

2014-04-08 Thread Shazron
+1 verified checksums, sig, tag hash On Tue, Apr 8, 2014 at 1:22 PM, Steven Gill stevengil...@gmail.com wrote: oops. The git tag hash should be: cordova-cli: 3.4.1-0.1.0 (8b182961ab1f) If you have the old 3.4.1-0.1.0 from the last vote, you will have to run git fetch -t to pull the

Re: [cordova-js] pluginloader/modulemapper, cordova_plugins.js and script injection.

2014-04-08 Thread Anis KADRI
browserify does not use them at all, so if we switched to it, there would be no reason to keep them around. If you see one, please share specifics. On Tue, Apr 8, 2014 at 11:17 AM, Andrew Grieve agri...@chromium.org wrote: I don't see it as an improvement to retire these. Even if we did retire

[GitHub] cordova-cli pull request: CB-6415 [Blackberry] added path.join at ...

2014-04-08 Thread martincgg
GitHub user martincgg opened a pull request: https://github.com/apache/cordova-cli/pull/158 CB-6415 [Blackberry] added path.join at check requirements function I've tracked down this problem, and I've found it. Changed path.resolve for custom path, for path.join, is required

[GitHub] cordova-cli pull request: CB-6415 [Blackberry] added path.join at ...

2014-04-08 Thread martincgg
Github user martincgg commented on the pull request: https://github.com/apache/cordova-cli/pull/158#issuecomment-39902600 I've tracked down this problem, and I've found the problem. The custom path in check_requirements function in blackberry10_parser.js, It looks for a custom

Re: [cordova-js] do we need clobbers/, merges/ ?

2014-04-08 Thread Anis KADRI
On Tue, Apr 8, 2014 at 12:50 PM, Andrew Grieve agri...@chromium.org wrote: I think symbol mapping comes with some nuances, and having the them in a declarative way makes it easier than telling all plugins to write their JS in a certain way. Makes what exactly easier ? It's a level of

Re: Tools Release + cordova-ios 3.4.1 blog post proofread

2014-04-08 Thread Steven Gill
updated. New versions of `plugman`, `cordova` and `cordova-ios` are now live! * [plugman@0.20.2](https://www.npmjs.org/package/plugman) * [cordova@3.4.0-0.1.3](https://www.npmjs.org/package/cordova) * [cordova-ios@3.4.1](http://archive.apache.org/dist/cordova/platforms/ios) To update your

Re: [cordova-js] What is the purpose of runs / ?

2014-04-08 Thread Anis KADRI
It is not a breaking change therefore it is backward compatible [1]. If there is a good reason to keep the current feature then I'd like to know it. [1] http://en.wikipedia.org/wiki/Backward_compatibility On Tue, Apr 8, 2014 at 10:51 AM, Andrew Grieve agri...@chromium.org wrote: If there's an

[GitHub] cordova-windows pull request: Update cordova.js

2014-04-08 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/21#issuecomment-39904054 Cannot merge this pull-req, cordova.js is build output of the cordovajs project. I will fix it there. and DUPE --- If your project is set up for

[GitHub] cordova-windows pull request: Update cordova.js

2014-04-08 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/22#issuecomment-39904013 Cannot merge this pull-req, cordova.js is build output of the cordovajs project. I will fix it there. --- If your project is set up for it, you can

Re: [cordova-js] do we need clobbers/, merges/ ?

2014-04-08 Thread Jesse
Dump them, I see no use for a declarative level of indirection. @purplecabbage risingj.com On Tue, Apr 8, 2014 at 2:15 PM, Anis KADRI anis.ka...@gmail.com wrote: On Tue, Apr 8, 2014 at 12:50 PM, Andrew Grieve agri...@chromium.org wrote: I think symbol mapping comes with some nuances,

[GitHub] cordova-windows pull request: Update cordova.js

2014-04-08 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/22#issuecomment-39906082 Issue created here: https://issues.apache.org/jira/browse/CB-6419 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-windows pull request: Update cordova.js

2014-04-08 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/21#issuecomment-39906094 Issue created here: https://issues.apache.org/jira/browse/CB-6419 --- If your project is set up for it, you can reply to this email and have your reply

Re: CB-6415 [Blackberry] unable to add platform, using custom or local library

2014-04-08 Thread Josh Soref
Martin Gonzalez Glez wrote: https://issues.apache.org/jira/browse/CB-6415 SoŠ I was the one who tried to implement this thing. I probably failed to implement it the way something was expecting, but I implemented it the way I was expecting things to work. Before we spend time making changes,

[GitHub] cordova-registry-web pull request: CB-6285

2014-04-08 Thread jbavari
GitHub user jbavari opened a pull request: https://github.com/apache/cordova-registry-web/pull/3 CB-6285 Optimization - made pluggy.svg into pluggy.png - now referenced by stylesheets. Removed the livereload script - via grunt preprocess and copy. No longer should have

Re: Suggestions for a problem

2014-04-08 Thread Brian LeRoux
Hold up! The CLI needs to declare dependencies somehow and while we could implement our own thing npm will do it better. (Hence this thinking.) But the good news is we can use =X.X.X in package.json to allow npm to download the latest. Now that said, it would be cool to allow version pinning,

Re: Suggestions for a problem

2014-04-08 Thread Tommy Williams
+1 for reapproach On 09/04/2014 8:20 am, Brian LeRoux b...@brian.io wrote: Hold up! The CLI needs to declare dependencies somehow and while we could implement our own thing npm will do it better. (Hence this thinking.) But the good news is we can use =X.X.X in package.json to allow npm to

Cordova g11n implementation - Changes proposal

2014-04-08 Thread Pascale Dardailler
Hello, The globalization implementation of getLocaleName and getPreferredLanguage should return more consistent results across the different platforms, as it is very difficult to implement globalized applications. Looking at the issue database, other people have also been reported these

Re: Suggestions for a problem

2014-04-08 Thread Anis KADRI
+1 for platforms in package.json On Tue, Apr 8, 2014 at 3:22 PM, Tommy Williams to...@devgeeks.org wrote: +1 for reapproach On 09/04/2014 8:20 am, Brian LeRoux b...@brian.io wrote: Hold up! The CLI needs to declare dependencies somehow and while we could implement our own thing npm will

Re: Tools Release + cordova-ios 3.4.1 blog post proofread

2014-04-08 Thread Steven Gill
Trying out piratepad for this. http://piratepad.net/UFpAfTg2HK On Tue, Apr 8, 2014 at 3:18 PM, Steven Gill stevengil...@gmail.com wrote: updated. New versions of `plugman`, `cordova` and `cordova-ios` are now live! * [plugman@0.20.2](https://www.npmjs.org/package/plugman) *

[GitHub] cordova-coho pull request: Fixing todos

2014-04-08 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-coho/pull/17 Fixing todos You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-coho patch-2 Alternatively you can review and apply

[GitHub] cordova-plugman pull request: CB-6414 - fixes the issue where two ...

2014-04-08 Thread kamrik
Github user kamrik commented on the pull request: https://github.com/apache/cordova-plugman/pull/72#issuecomment-39915727 Looks like the root of the problem is in config_keeper. The files there are identified by the fake path [see note], so when the same file is referenced as

[GitHub] cordova-coho pull request: Fixing todos

2014-04-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [RESULT][VOTE] cordova-plugman@0.21.0

2014-04-08 Thread Andrew Grieve
I suppose this will make it more obvious when voting has concluded, but it puts the result out of the actual vote thread. Someone reading the vote thread might not realize that the vote is closed if the result is not made a part of the thread. On Tue, Apr 8, 2014 at 12:06 PM, sebb

Re: [VOTE] cordova-cli@3.4.1-0.1.0

2014-04-08 Thread Andrew Grieve
+1 verified checksum, sig, shrinkwrap.json On Tue, Apr 8, 2014 at 12:50 PM, Shazron shaz...@gmail.com wrote: +1 verified checksums, sig, tag hash On Tue, Apr 8, 2014 at 1:22 PM, Steven Gill stevengil...@gmail.com wrote: oops. The git tag hash should be: cordova-cli: 3.4.1-0.1.0

Re: [cordova-js] What is the purpose of runs / ?

2014-04-08 Thread Brian LeRoux
We should measure it. It will most certainly be slower if the init does some sort of native marshaling but lazy loading behavior can be coded into the plugins themselves to mitigate this. Having an entry file is more expected (imo) for a runtime behavior. On Wed, Apr 9, 2014 at 10:54 AM, Andrew

report for april / pls review

2014-04-08 Thread Brian LeRoux
https://github.com/cordova/apache-board-reports/blob/master/2014-04.md send a pull req if you have changes instead of cluttering the list further pls