If you read this immediately after reading the docs for
cordova.file.dataDirectory, you may think that files there do NOT
survive app restarts.
Which ones, the files from dataDirectory or the files from cacheDirectory?
If you mean dataDirectory, maybe the doc should be something like this:
Github user emarashliev commented on the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/14#issuecomment-47504184
Hi @agrieve, it's necessary because we have to disable auto rotation during
the splash screen is shown. And then after splash screen is hidden we
GitHub user morenoh149 opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/57
changed header
changed Firefox OS Quirks header to match ios quirks
You can merge this pull request into a Git repository by running:
$ git pull
Github user zalun commented on the pull request:
https://github.com/apache/cordova-firefoxos/pull/17#issuecomment-47512212
No idea why it's not closed - merged already
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user zalun commented on the pull request:
https://github.com/apache/cordova-firefoxos/pull/16#issuecomment-47512259
Merged - please close
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user JohnMcLear commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47515954
PR looks fine to me, this i how I would have made this change.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user sgrebnov opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/32
fixes CB-7003 navigator.contacts.pickContact picks wrong contact on Android
4.3 and 4.4.3 versions
https://issues.apache.org/jira/browse/CB-7003
pickContact: added logic
Here is fix for CB-7003. Tested on Android 4.3 and 2.3.6
https://github.com/apache/cordova-plugin-contacts/pull/32
Thx!
Sergey
-Original Message-
From: iclell...@google.com [mailto:iclell...@google.com] On Behalf Of Ian
Clelland
Sent: Friday, June 27, 2014 11:01 PM
To:
GitHub user kant2002 opened a pull request:
https://github.com/apache/cordova-docs/pull/214
CB-6262 Add StatusBar to Plugin APIs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kant2002/cordova-docs CB-6262
Alternatively you
GitHub user kant2002 opened a pull request:
https://github.com/apache/cordova-docs/pull/215
CB-6261 Add Vibration row to Platform Support
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kant2002/cordova-docs CB-6261
GitHub user kant2002 opened a pull request:
https://github.com/apache/cordova-docs/pull/216
CB-6257 Add BatteryStatus row to Platform Support
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kant2002/cordova-docs CB-6257
Yes, I meant that the doc for cacheDirectory implies, at least to me, that the
previous entry (dataDirectorry) will not persist. I think your modification
makes sense. Do you want to make a PR for the doc or should I?
From: julio cesar sanchez
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/58
CB-6571 Fix getParentForLocalURL to work correctly with directories with
trailing '/'
Fixes 2 failing unit tests in mobile spec.
You can merge this pull request into a Git
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/58#issuecomment-47548810
Which unit tests are failing?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user martincgg commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/58#issuecomment-47549670
It fixes file.spec.49, that was the only that I had failing, which other
was failing @mbektchiev ?
---
If your project is set up for it, you can reply to
Github user marti1125 commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47554060
why I removed this line? because it has a warning about CSP when I
validated in marketplace
https://developer.mozilla.org/en-US/Apps/CSP
Github user mbektchiev commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/58#issuecomment-47554562
My first attempt didn't fix the second unit test -- 112. Now both must be
fixed.
---
If your project is set up for it, you can reply to this email and
Github user rodms10 closed the pull request at:
https://github.com/apache/cordova-firefoxos/pull/16
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user JohnMcLear commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47555716
@marti1125 wut?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user SSRico opened a pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/21
[CB-6959] Port capture tests to plugin-test-framework
Ported the compass plugin (device-orientation) from mobile-spec to the
new test framework with Jasmine 2.0
-Added
GitHub user SSRico opened a pull request:
https://github.com/apache/cordova-plugin-device-orientation/pull/10
[CB-6960] Port compass tests to plugin-test-framework
Ported the compass plugin (device-orientation) from mobile-spec to the
new test framework with Jasmine 2.0
Github user mbektchiev commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/58#issuecomment-47559238
No, I have all 131 tests passing.
But I am not using the latest spec project -- mine is from
Github user marti1125 commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47559877
@JohnMcLear ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47561643
Code looks good to me too. @zalun, can you take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
GitHub user ankitjaininfo opened a pull request:
https://github.com/apache/cordova-android/pull/104
Displaying error when regex does not match.
On my ubuntu when `android` was not found typical output is:
```
/bin/sh: 1: android: not found
```
You can merge this
Github user ankitjaininfo commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/103#discussion_r14366860
--- Diff: bin/lib/check_reqs.js ---
@@ -81,7 +81,7 @@ module.exports.check_android = function() {
}
return Q();
Github user mwbrooks commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47569377
Generally, our philosophy for the Hello World app is to avoid over
complicating the code. This is why we use the `app` object instead of a self
Maybe we can wait to hear more opinios about my modification. Or you
can create the pull request and they will merge if they agree.
2014-06-30 16:44 GMT+02:00 Ray Camden rayca...@adobe.com:
Yes, I meant that the doc for cacheDirectory implies, at least to me, that
the previous entry
GitHub user jsoref opened a pull request:
https://github.com/apache/cordova-lib/pull/48
CB-7056 serve: return promise of server
+ restore serve tests
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jsoref/cordova-lib cb_7056
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47574133
The pull request looks fine to me. My only suggestion would be to leave a
comment explaining that initialization must happen after cordova.js:
Github user zalun commented on the pull request:
https://github.com/apache/cordova-app-hello-world/pull/8#issuecomment-47574935
Looks good to me - I haven't tested it though.
Moving JS to separate file is a good practice. I'd suggest doing that even
if it wouldn't be about CSP.
GitHub user marti1125 opened a pull request:
https://github.com/apache/cordova-lib/pull/49
removed pkgName
https://issues.apache.org/jira/browse/CB-7055
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/marti1125/cordova-lib
Kerri Shotts is going to be filing one soon.
From: julio cesar sanchez jcesarmob...@gmail.com
Sent: Monday, June 30, 2014 1:44 PM
To: dev@cordova.apache.org
Subject: Re: More questions on FileSystem directories
Maybe we can wait to hear more opinios about
GitHub user javierbb31 opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/36
CB-6958. Port camera tests to plugin-test-framework
Ported camera test from mobilespec to the new test-framework in jasmine
2.0
Added test folder.
Added tes.js file
GitHub user javierbb31 opened a pull request:
https://github.com/apache/cordova-plugin-dialogs/pull/22
CB-6965. Port notification tests to test-framework
Ported notification test from mobilespec to the new test-framework in
jasmine 2.0
Added test folder.
Added tests.js
GitHub user javierbb31 opened a pull request:
https://github.com/apache/cordova-plugin-network-information/pull/12
CB-6964. Port network tests to test-framework
Ported camera test from mobilespec to the new test-framework in jasmine
2.0
Added test folder.
Added tests.js
Github user rodms10 commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/49#discussion_r14377111
--- Diff: cordova-lib/src/cordova/metadata/firefoxos_parser.js ---
@@ -58,8 +58,7 @@ module.exports.prototype = {
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-lib/pull/49#issuecomment-47590172
Tested it, works fine. Just a minor nit on whitespaces. Thanks again!
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user marti1125 commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/49#discussion_r14377248
--- Diff: cordova-lib/src/cordova/metadata/firefoxos_parser.js ---
@@ -58,8 +58,7 @@ module.exports.prototype = {
Github user rodms10 commented on the pull request:
https://github.com/apache/cordova-lib/pull/49#issuecomment-47591641
r+! @zalun, good to merge by me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/48
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user kerrishotts opened a pull request:
https://github.com/apache/cordova-plugin-file/pull/59
[CB- 7057] Improve File API documentation, especially wrt to cordova.file.*
properties
As discussed on the google groups, the documentation for the
`cordova.file.*` properties is
42 matches
Mail list logo
