platformId for new windows template

2014-07-10 Thread Sergey Grebnov (Akvelon)
There is the following important property provided by cordova.js - 'cordova.platformId' which specifies the platform app runs on. Since we introduced support of new Windows Universal Apps which could be compiled for Windows 8.0, Windows 8.1, Windows Phone 8.1 we should agree what to report as

[GitHub] cordova-lib pull request: CB-7114 Android: add support of min/max/...

2014-07-10 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-lib/pull/56 CB-7114 Android: add support of min/max/target SDK to config.xml https://issues.apache.org/jira/browse/CB-7114 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-mobile-spec pull request: Fix CB-7115: Add manual test for...

2014-07-10 Thread schettino72
GitHub user schettino72 opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/80 Fix CB-7115: Add manual test for events volumedownbutton / volumeupbutto... ...n You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-js pull request: CB-870 Add volume button event support to...

2014-07-10 Thread schettino72
GitHub user schettino72 opened a pull request: https://github.com/apache/cordova-js/pull/72 CB-870 Add volume button event support to Android You can merge this pull request into a Git repository by running: $ git pull https://github.com/schettino72/cordova-js

RE: Android: add support of min/max/target SDK to config.xml

2014-07-10 Thread Sergey Grebnov (Akvelon)
Implemented, pls take a look: https://github.com/apache/cordova-lib/pull/56/files https://issues.apache.org/jira/browse/CB-7114 Thx! Sergey -Original Message- From: tommy-carlos williams [mailto:to...@devgeeks.org] Sent: Monday, July 7, 2014 5:33 PM To: dev@cordova.apache.org Subject:

[GitHub] cordova-lib pull request: CB-7114 Android: add support of min/max/...

2014-07-10 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/56#issuecomment-48583957 http://developer.android.com/guide/topics/manifest/uses-sdk-element.html#max Future versions of Android (beyond Android 2.0.1) will no longer check or

Re: Browserify JS is in

2014-07-10 Thread Ally Ogilvie
Ace, look forward to browser/web as platform. Combined Web and Native API plugin for Cordova! Yay! Thanks for the clarification Michal. On Tue, Jul 8, 2014 at 6:07 AM, Anis KADRI anis.ka...@gmail.com wrote: Right, browserify is just a way to package cordova.js that should make it easier to

[GitHub] cordova-js pull request: CB-870 Add volume button event support to...

2014-07-10 Thread rizasabuncu
Github user rizasabuncu commented on the pull request: https://github.com/apache/cordova-js/pull/72#issuecomment-48594140 Hll spr dvm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

Re: Android Plugin API

2014-07-10 Thread Erik Jan de Wit
Hi all, Created an plugin that does this: https://github.com/edewit/aerogear-reflect-cordova the repository also includes a example plugin that uses this. Also have a blog describing this a bit more http://blog.nerdin.ch/2014/07/improved-cordova-android-plugin-api.html Cheers, Erik

Introduction Florian BERTON/Touchify

2014-07-10 Thread Florian Berton
Hi, My name is Florian BERTON, I'm 25 years old, live in Paris and I have worked for 5 years on web technologies. I'm a new member of the Touchify team. Touchify is an online editor that let you easily create your touch optimized sales content and control how to publish them on any device

Re: Android CameraPlugin - App gets killed.

2014-07-10 Thread Joe Bowser
No. We can't just adopt this or own the camera because of these reasons: 1. Looks out of date 2. Has UI elements that we'd have to maintain 3. Does not actually solve the problem (Activities in the background can still die) 4. Makes apps more obviously look like Cordova apps. We should instead

Re: Introduction Florian BERTON/Touchify

2014-07-10 Thread Andrew Grieve
Welcome Florian, Thanks for the introduction :). Looking forward to having you help out. On Thu, Jul 10, 2014 at 6:21 AM, Florian Berton fber...@touchify.co wrote: Hi, My name is Florian BERTON, I’m 25 years old, live in Paris and I have worked for 5 years on web technologies. I’m a

[GitHub] cordova-plugin-camera pull request: added allowEdit support for an...

2014-07-10 Thread woozzel
Github user woozzel commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/12#issuecomment-48606463 Since confile's question isn't answered yet, I'd like to know, when this will be available, too?? --- If your project is set up for it, you can reply to

RE: Android CameraPlugin - App gets killed.

2014-07-10 Thread Maxime LUCE
Hi, Yes it's a little out of date but it doesn't launch a separate activity and instead a linked activity into the cordova one so it should not be killed. The problem is not only with low memory phones since if you have a lot of apps launched, the result could be the same. Preserving the

Re: Tools release blog post review

2014-07-10 Thread Michal Mocny
Anis, Thats a good write up but I'm worried may confuse what this does (see e.g. Ally's mails on this list). I propose a shorter description for the release notes a link to github docs? Perhaps something like: We are experimenting with using `browserify` to package our `cordova.js` build

[GitHub] cordova-js pull request: Fixed jshint whitespace issues

2014-07-10 Thread dwardu
GitHub user dwardu opened a pull request: https://github.com/apache/cordova-js/pull/73 Fixed jshint whitespace issues Fixes: Running whitespace-check task files with whitespace issues: (to fix: `grunt whitespace-fix`) src\cordova_b.js

Re: Android Plugin API

2014-07-10 Thread Anis KADRI
I want to say that this should be default...but we won't change the API again and won't break plugins again. On Thu, Jul 10, 2014 at 7:48 AM, Erik Jan de Wit ede...@redhat.com wrote: Hi all, Created an plugin that does this: https://github.com/edewit/aerogear-reflect-cordova the repository

Re: Android Plugin API

2014-07-10 Thread Erik Jan de Wit
On 10 Jul,2014, at 17:15 , Anis KADRI anis.ka...@gmail.com wrote: I want to say that this should be default...but we won't change the API again and won't break plugins again. Both could be supported at the same time, just by using a different base class

Re: Tools release blog post review

2014-07-10 Thread Anis KADRI
Sure. Looks good to me. On Thu, Jul 10, 2014 at 10:11 AM, Michal Mocny mmo...@chromium.org wrote: Anis, Thats a good write up but I'm worried may confuse what this does (see e.g. Ally's mails on this list). I propose a shorter description for the release notes a link to github docs?

Re: Tools release blog post review

2014-07-10 Thread Mark Koudritsky
Do we have some post about browserify to link to from the [see instructions here]? On Thu, Jul 10, 2014 at 11:31 AM, Anis KADRI anis.ka...@gmail.com wrote: Sure. Looks good to me. On Thu, Jul 10, 2014 at 10:11 AM, Michal Mocny mmo...@chromium.org wrote: Anis, Thats a good write up but

Re: Tools release blog post review

2014-07-10 Thread Michal Mocny
Anis sent a detailed email about it a few weeks ago. I guess we should paste that into our wiki, and link to that. Anis, would you mind doing that and making sure the instructions are still accurate? Thanks! On Thu, Jul 10, 2014 at 11:48 AM, Mark Koudritsky kam...@google.com wrote: Do we

Re: Tools release blog post review

2014-07-10 Thread Anis KADRI
We are experimenting with using `browserify` to package our `cordova.js` build artefact. This is an internal change to our tooling, and is currently still off-by-default. We would appreciate feedback since we hope to switch to on-by-default in a future release. If you want to try it out, please

[GitHub] cordova-plugin-camera pull request: added allowEdit support for an...

2014-07-10 Thread confile
Github user confile commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/12#issuecomment-48632796 Since there is no way to send you issues I write it here. When using Android and image as PNG from Camera auto rotation does not work even if it

[GitHub] cordova-plugin-camera pull request: added allowEdit support for an...

2014-07-10 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/12#issuecomment-48635041 @confile, you can file issues on our JIRA issue tracker [here](https://issues.apache.org/jira/browse/CB/) You'll have to create a (free) account,

Re: Introduction Florian BERTON/Touchify

2014-07-10 Thread Jesse
Welcome Florian! @purplecabbage risingj.com On Thu, Jul 10, 2014 at 6:34 AM, Andrew Grieve agri...@chromium.org wrote: Welcome Florian, Thanks for the introduction :). Looking forward to having you help out. On Thu, Jul 10, 2014 at 6:21 AM, Florian Berton fber...@touchify.co wrote:

[iOS] CDVPluginResult breaking change

2014-07-10 Thread Shazron
I would like to apply this fix: https://issues.apache.org/jira/browse/CB-6165 Essentially, right now if the plugin result is OK (or any other status) without a message, iOS inserts a the human readable part of the status ordinal as the message, which I think is wrong, this is not a message that

Re: [iOS] CDVPluginResult breaking change

2014-07-10 Thread Andrew Grieve
Likely most will not be affected and the fix is easy. go for it. On Thu, Jul 10, 2014 at 2:30 PM, Shazron shaz...@gmail.com wrote: I would like to apply this fix: https://issues.apache.org/jira/browse/CB-6165 Essentially, right now if the plugin result is OK (or any other status) without a

RE: Android: add support of min/max/target SDK to config.xml

2014-07-10 Thread Lisa Seacat DeLuca
Sergey, this is awesome! Once we get your changes pulled in we should also update the documentation. I can see this being a popular little feature for users. Lisa @LisaSeacat From: Sergey Grebnov (Akvelon) v-seg...@microsoft.com To: dev@cordova.apache.org dev@cordova.apache.org

Re: [iOS] CDVPluginResult breaking change

2014-07-10 Thread Ian Clelland
If it's not documented behaviour, I'd say it's a bug. Fit it :) On Thu, Jul 10, 2014 at 2:35 PM, Andrew Grieve agri...@chromium.org wrote: Likely most will not be affected and the fix is easy. go for it. On Thu, Jul 10, 2014 at 2:30 PM, Shazron shaz...@gmail.com wrote: I would like to

Re: [iOS] CDVPluginResult breaking change

2014-07-10 Thread julio cesar sanchez
I think I don't return just the ok without message on any of my plugins, I'll check, but you can fix it

Re: Directory Structure - CLI directory config proposal

2014-07-10 Thread Lisa Seacat DeLuca
I didn't have anything in mind as far as where the settings could be made available. I was more broaching the subject to see if it's possible or if there would be a lot of code rewrite to make it work. I'm not as familiar with how the CLI works or how the code decides to place certain files in

RE: Android: add support of min/max/target SDK to config.xml

2014-07-10 Thread Joe Bowser
-1 I like adding min, but max and target build can really break the build, especially when we try and use newer Chromium features. PG Build has this only because a method that we were using was removed from Cordova and they have to support old versions. We want people to upgrade Cordova and

[GitHub] cordova-lib pull request: CB-7118 iOS: add target-device and Minim...

2014-07-10 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-lib/pull/57 CB-7118 iOS: add target-device and MinimumOSVersion support to config.xml https://issues.apache.org/jira/browse/CB-7118 You can merge this pull request into a Git repository by running: $

Re: Android: add support of min/max/target SDK to config.xml

2014-07-10 Thread Jesse
this element is used to specify the API Level,*not* the version number of the SDK +1 max simply ensures that some new untested and potentially incompatible API level is not used. Where is the danger Joe? We just need to be sure that cordova-android@X.X.X somehow specifies what API levels it

[GitHub] cordova-blackberry pull request: CB-7119 cordova run --target xxx ...

2014-07-10 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-blackberry/pull/168 CB-7119 cordova run --target xxx dies if blackberry10.json is empty You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-blackberry pull request: CB-7119 cordova run --target xxx ...

2014-07-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-blackberry/pull/168 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: platformId for new windows template

2014-07-10 Thread Jesse
Sounds good to me. @purplecabbage risingj.com On Wed, Jul 9, 2014 at 11:38 PM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: There is the following important property provided by cordova.js - 'cordova.platformId' which specifies the platform app runs on. Since we introduced

Re: Android: add support of min/max/target SDK to config.xml

2014-07-10 Thread Joe Bowser
On 10 Jul 2014 19:13, Jesse purplecabb...@gmail.com wrote: this element is used to specify the API Level,*not* the version number of the SDK So, if we set the target and max API to 10, we can't build Cordova on Android, because it's targeted at 19. That's the danger. We currently use

[GitHub] cordova-android pull request: [CB-7104] Fix for the missing plugin...

2014-07-10 Thread nolanlawson
Github user nolanlawson commented on the pull request: https://github.com/apache/cordova-android/pull/105#issuecomment-48656575 I think I might be hitting the same issue as you ([comment

[GitHub] cordova-android pull request: [CB-7104] Fix for the missing plugin...

2014-07-10 Thread nolanlawson
Github user nolanlawson commented on the pull request: https://github.com/apache/cordova-android/pull/105#issuecomment-48657215 BTW I also tried, as a workaround, to consistently execute `callbackContext.success()` or `failure()` for every callback (since I believe you said it might

[GitHub] cordova-android pull request: [CB-7104] Fix for the missing plugin...

2014-07-10 Thread hnilsen
Github user hnilsen commented on the pull request: https://github.com/apache/cordova-android/pull/105#issuecomment-48657793 I saw your comment, but reading from a mobile device, so I can't really test it out. My fix is exclusively for 3.3.x, there has been made lots if changes since

[GitHub] cordova-android pull request: [CB-7104] Fix for the missing plugin...

2014-07-10 Thread hnilsen
Github user hnilsen commented on the pull request: https://github.com/apache/cordova-android/pull/105#issuecomment-48657992 True, success() doesn't keep the callback, but for us it's not important. I changed the success() function to always keep callback, but that changed nothing for

Re: Android: add support of min/max/target SDK to config.xml

2014-07-10 Thread Joe Bowser
On 10 Jul 2014 19:58, bows...@gmail.com wrote: Completely disagree. All this will do is make things not build and confuse users. It's our job to try and abstract this out and when we let users control this, their apps are terrible. This feature is harmful and shouldn't be included. Decided

[GitHub] cordova-android pull request: [CB-7104] Fix for the missing plugin...

2014-07-10 Thread nolanlawson
Github user nolanlawson commented on the pull request: https://github.com/apache/cordova-android/pull/105#issuecomment-48660618 Hmm, sounds like you actually have a different issue. This isn't Samsung-only from what I saw (repro'd on LG Nexus 5). --- If your project is set up for

Re: [GitHub] cordova-lib pull request: CB-7118 iOS: add target-device and Minim...

2014-07-10 Thread Axel Nennker
s/ettigns/ettings/g Am 10.07.2014 21:02 schrieb sgrebnov g...@git.apache.org: GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-lib/pull/57 CB-7118 iOS: add target-device and MinimumOSVersion support to config.xml

Re: [iOS] CDVPluginResult breaking change

2014-07-10 Thread Tommy Williams
I vaguely remember some plugins returning Just the boolean OK. As long as we document this and are noisy about it, it's probably OK, I guess. On 11 Jul 2014 04:50, julio cesar sanchez jcesarmob...@gmail.com wrote: I think I don't return just the ok without message on any of my plugins, I'll

Re: Tools release blog post review

2014-07-10 Thread Mark Koudritsky
Ok, added Michal's wording with the one line instruction from Anis. Publishing it.​

[GitHub] cordova-lib pull request: CB-7118 iOS: add target-device and Minim...

2014-07-10 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/57#issuecomment-4825 update_build_settigns should be update_build_settings --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Re: Tools release blog post review

2014-07-10 Thread Mark Koudritsky
Published. The site diff was way larger than it should've been (mostly white space related diff). Any site building settings I missed? On Thu, Jul 10, 2014 at 5:24 PM, Mark Koudritsky kam...@google.com wrote: Ok, added Michal's wording with the one line instruction from Anis. Publishing it.​

[GitHub] cordova-plugin-globalization pull request: CB-7102 - Initial imple...

2014-07-10 Thread rodms10
Github user rodms10 commented on a diff in the pull request: https://github.com/apache/cordova-plugin-globalization/pull/17#discussion_r14799288 --- Diff: src/firefoxos/GlobalizationProxy.js --- @@ -0,0 +1,217 @@ +/* + * + * Licensed to the Apache Software Foundation

[GitHub] cordova-plugin-globalization pull request: CB-7102 - Initial imple...

2014-07-10 Thread rodms10
Github user rodms10 commented on a diff in the pull request: https://github.com/apache/cordova-plugin-globalization/pull/17#discussion_r14799326 --- Diff: src/firefoxos/GlobalizationProxy.js --- @@ -0,0 +1,217 @@ +/* + * + * Licensed to the Apache Software Foundation

[GitHub] cordova-plugin-globalization pull request: CB-7102 - Initial imple...

2014-07-10 Thread rodms10
Github user rodms10 commented on a diff in the pull request: https://github.com/apache/cordova-plugin-globalization/pull/17#discussion_r14800066 --- Diff: src/firefoxos/GlobalizationProxy.js --- @@ -0,0 +1,217 @@ +/* + * + * Licensed to the Apache Software Foundation

[GitHub] cordova-plugin-globalization pull request: CB-7102 - Initial imple...

2014-07-10 Thread rodms10
Github user rodms10 commented on a diff in the pull request: https://github.com/apache/cordova-plugin-globalization/pull/17#discussion_r14800265 --- Diff: src/firefoxos/GlobalizationProxy.js --- @@ -0,0 +1,217 @@ +/* + * + * Licensed to the Apache Software Foundation

Re: Android: add support of min/max/target SDK to config.xml

2014-07-10 Thread Frederico Galvão
Are you guyus against the actual implementation being suggested or are you against the idea as a whole? If the answer to the above is I +1 the idea but -1 the current implementation being suggested, then ignore the rest of this message, and I'll say that I'm looking foward to this feature being

Re: Android: add support of min/max/target SDK to config.xml

2014-07-10 Thread Jesse
Somewhat to Joe's point, anyone who knows that they want this feature can probably find their own work-around. ( as Frederico proves ) Joe has the strongest feelings on this, such that he keeps getting pulled into the conversation even though he is on holiday. I think we should shelve this

[GitHub] cordova-android pull request: [CB-7104] Fix for the missing plugin...

2014-07-10 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-android/pull/105#issuecomment-48687118 I believe this issue is fixed on master. Have a look at the commit here: https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=445ddd8 And

recent tools update, Splash screen support

2014-07-10 Thread Ray Camden
I'm a bit behind on the recent tooling update so forgive me if this is a dumb question. The very first item listed is: Support for splash screens Which is odd since I thought splash screens had been available for some time now. We've had an API to hide show them. We've also had documented ways

Re: Android: add support of min/max/target SDK to config.xml

2014-07-10 Thread Joe Bowser
On 11 Jul 2014 00:22, Frederico Galvão frederico.gal...@pontoget.com.br wrote: Are you guyus against the actual implementation being suggested or are you against the idea as a whole? A bit of both, assuming you didn't add this feature. See below. If the answer to the above is I +1 the idea

[GitHub] cordova-lib pull request: CB-7118 iOS: add target-device and Minim...

2014-07-10 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-lib/pull/57#issuecomment-48696309 Fixed 'update_build_settings' issue and force pushed, thank you Jesse @purplecabbage --- If your project is set up for it, you can reply to this email and have