[GitHub] cordova-wp8 pull request: CB-6728 Support chip architecture as an ...

2014-07-31 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-wp8/pull/39#issuecomment-50854468 Hi @purplecabbage . I can't repro your issue with cordova-wp8 checked to this commit and latest cordova-cli/lib. Anyway, i've tried to change app version in

[GitHub] cordova-plugin-contacts pull request: Removed [optional] tag from ...

2014-07-31 Thread SebastianMH
GitHub user SebastianMH opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/37 Removed [optional] tag from contactFindOptions. Fixes #CB-7247 https://issues.apache.org/jira/browse/CB-7247 The parameter contactFindOptions of navigator.contacts.find is lab

Experimenting with JSCS + JSHint in cordova-lib

2014-07-31 Thread Mark Koudritsky
Just opened a pull request with an experimental JSCS config. Would be glad to get some feedback about this. My goal is to eventually run JSCS together with JSHint as part of `npm test`. This is a relatively liberal config that doesn't generate too many warnings with the existing code. https://gith

[GitHub] cordova-lib pull request: Add JSCS config file

2014-07-31 Thread kamrik
GitHub user kamrik opened a pull request: https://github.com/apache/cordova-lib/pull/69 Add JSCS config file Don't merge yet - feedback wanted. JSHint people want to focus on syntax linting and are dropping style oriented options. They recommend using JSCS (in addition

Re: [DISCUSS] Plugins Release

2014-07-31 Thread Steven Gill
So Globalization has issues with missing headers and needs a update to the notice file for new licenses. Both Blackberry and FFOS need to go do this before I release that plugin! What am I doing with test-harness? That isn't being released right? It also needs headers included + notice file update

[GitHub] cordova-mobile-spec pull request: CB-7242 Added wp8 subdirectory t...

2014-07-31 Thread martincgg
GitHub user martincgg opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/84 CB-7242 Added wp8 subdirectory to localPlatforms variable createmobilespec --wp8 fails, because the path for wp8 on localPlatforms is incomplete, it requires the wp8 subdirectory to

Re: Browserify support for cordova-lib/cordova-cli

2014-07-31 Thread Steven Gill
This looks good to me. Anyone else want to test it before I merge it in? On Wed, Jul 30, 2014 at 3:38 PM, Suraj Pindoria < suraj.pindo...@yahoo.com.invalid> wrote: > So I updated this to include some of the additional use cases discussed > earlier. Now, running "cordova prepare --browserify" in

[GitHub] cordova-plugin-media-capture pull request: CB-6959 ported capture ...

2014-07-31 Thread stacic
Github user stacic commented on the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/22#issuecomment-50808014 Tests removed from mobile-spec here: https://github.com/apache/cordova-mobile-spec/pull/83 --- If your project is set up for it, you can reply to th

[GitHub] cordova-mobile-spec pull request: CB-6959 Removed capture tests

2014-07-31 Thread stacic
GitHub user stacic opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/83 CB-6959 Removed capture tests Tests should be replaced with this ported ones in this PR: https://github.com/apache/cordova-plugin-media-capture/pull/22 You can merge this pull request in

Re: Cordova plugin : plugin-network-information

2014-07-31 Thread Shazron
I'll tag this 0.2.10: https://git-wip-us.apache.org/repos/asf?p=cordova-plugin-network-information.git;a=commit;h=07ff22accc1e0a22dbf97153a516ebef886aae41 Which corresponds to the sha from the Vote thread for 0.2.10: cordova-plugin-network-information: 0.2.10 (07ff22accc) On Thu, Jul 31, 2014 at

Re: Cordova plugin : plugin-network-information

2014-07-31 Thread Shazron
Hmm, indeed 0.2.10 was released but not tagged 0.2.10 in the plugin's Apaches git repo. On Thu, Jul 31, 2014 at 5:51 AM, BOURGE, Guillaume wrote: > Hello, > > We work on cordova app for a client and he requires that each externals > sources must be tagued. We used the 0.2.9 but we had the issue

Re: CLI breaking changes on master

2014-07-31 Thread Martin Gonzalez
Yes, you are right, linking it with the latest cordova-lib in master works pretty fine. I think that the master branch should be working stable and working just typing "npm install", it just seems like an extra burden, get to clone cordova-lib, then install it, then link it to the CLI node modules.

Cordova plugin : plugin-network-information

2014-07-31 Thread BOURGE, Guillaume
Hello, We work on cordova app for a client and he requires that each externals sources must be tagued. We used the 0.2.9 but we had the issue "CB-6907" https://issues.apache.org/jira/browse/CB-6907?jql=project%20%3D%20CB%20AND%20component%20%3D%20%22Plugin%20Network%20Information%22%20ORDER%20BY

[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...

2014-07-31 Thread sgrebnov
Github user sgrebnov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/55#discussion_r15658798 --- Diff: cordova-lib/src/hooks/scriptsFinder.js --- @@ -0,0 +1,164 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or

Re: CLI breaking changes on master

2014-07-31 Thread Josh Soref
That's just because ‎you didn't link cordova-lib into the cordova-cli node-modules directory.  A bug was filed today to fix the mobile spec create script to tell you what to do.  Sent from my BlackBerry 10 smartphone.

CLI breaking changes on master

2014-07-31 Thread Martin Gonzalez
Hi all, CLI on master, contains some changes that are breaking "--link-to" argument, throwing a error during usage. --link-to is highly used by createmobilespec module to link the custom resources in there, so by extension is breaking the workflow on that module as well. I've switched to "rb_3.5.

[GitHub] cordova-lib pull request: CB-6481 Add unified hooks support for co...

2014-07-31 Thread kamrik
Github user kamrik commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/55#discussion_r15655705 --- Diff: cordova-lib/src/hooks/scriptsFinder.js --- @@ -0,0 +1,164 @@ +/** + Licensed to the Apache Software Foundation (ASF) under one + or mo

[GitHub] cordova-mobile-spec pull request: CB-6958 Removed camera tests

2014-07-31 Thread stacic
GitHub user stacic opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/82 CB-6958 Removed camera tests Tests from this PR should be used instead: https://github.com/apache/cordova-plugin-camera/pull/38 You can merge this pull request into a Git repository by r

[GitHub] cordova-plugin-camera pull request: CB-6958 ported camera tests to...

2014-07-31 Thread stacic
Github user stacic commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/38#issuecomment-50786472 Tests are removed from mobile-spec in this PR: https://github.com/apache/cordova-mobile-spec/pull/82 --- If your project is set up for it, you can reply to

[GitHub] cordova-plugin-device-motion pull request: CB-7160 port tests for ...

2014-07-31 Thread stacic
Github user stacic commented on the pull request: https://github.com/apache/cordova-plugin-device-motion/pull/16#issuecomment-50784416 Tests are removed from mobile-spec in this PR: https://github.com/apache/cordova-mobile-spec/pull/81 --- If your project is set up for it, you can r

[GitHub] cordova-mobile-spec pull request: CB-7160 Removed accelerometer te...

2014-07-31 Thread stacic
Github user stacic commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/81#issuecomment-50784364 The tests ported in this PR should be used instead: https://github.com/apache/cordova-plugin-device-motion/pull/16 --- If your project is set up for it, you c

[GitHub] cordova-mobile-spec pull request: CB-7160 Removed accelerometer te...

2014-07-31 Thread stacic
GitHub user stacic opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/81 CB-7160 Removed accelerometer tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/stacic/cordova-mobile-spec CB-7160 Alternatively

Re: missing documentation and missing major version bump

2014-07-31 Thread Mark Koudritsky
Thanks for updating the help, Josh. On Thu, Jul 31, 2014 at 11:16 AM, Josh Soref wrote: > This is now done. > > I only documented run initially because I didn't really want to think > through the code (prepare is an interesting odd case) and I knew it > applied to run. > > On 7/30/14, 11:45 AM,

[GitHub] cordova-plugin-device-motion pull request: CB-7160 manual tests fo...

2014-07-31 Thread stacic
Github user stacic closed the pull request at: https://github.com/apache/cordova-plugin-device-motion/pull/14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cordova-plugin-device-motion pull request: CB-7160 port tests for ...

2014-07-31 Thread stacic
GitHub user stacic opened a pull request: https://github.com/apache/cordova-plugin-device-motion/pull/16 CB-7160 port tests for accelerometer -Added manual tests on top of existing automated tests -Removed changes to plugin.xml -Added nested plugin.xml -Changed 'test' dir

Re: missing documentation and missing major version bump

2014-07-31 Thread Josh Soref
This is now done. I only documented run initially because I didn't really want to think through the code (prepare is an interesting odd case) and I knew it applied to run. On 7/30/14, 11:45 AM, "Carlos Santana" wrote: >If it's applicable to more than build command, then it needs to be >documente

Re: [DISCUSS] Plugins Release

2014-07-31 Thread Bryan Higgins
I'm into it! BlackBerry now supports File plugin roots and Globalization :) On Tue, Jul 29, 2014 at 3:29 PM, Steven Gill wrote: > How do you all feel about a plugins release? > > I can aim to start a vote thread tomorrow or Thursday if people feel good > about it. > > -Steve >

[GitHub] cordova-plugin-globalization pull request: BB10 implementation

2014-07-31 Thread bryanhiggins
Github user bryanhiggins closed the pull request at: https://github.com/apache/cordova-plugin-globalization/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

Re: How to provide more files from plugin.xml for project and native?

2014-07-31 Thread Carlos Santana
Use element your folder will be included inside as blue folder inside the "www" bluefolder inside your Mobile App You can do a file or folder For example a folder named "workligh": On Thu, Jul 31, 2014 at 2:13 AM, julio cesar sanchez wrote: > I have a related question, is it possible to