[GitHub] cordova-plugin-inappbrowser pull request: CB- 5109 Windows 8.1 - I...

2014-09-18 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/53#issuecomment-56141194 Closing sine PR#52 was merged (same functionality) --- If your project is set up for it, you can reply to this email and have your reply appear on G

RE: Plugin PRs ( from Sergey )

2014-09-18 Thread Sergey Grebnov (Akvelon)
Thank you Jesse! Media-capture PR has been rebased. https://github.com/apache/cordova-plugin-media-capture/pull/26#issuecomment-56118695 InAppBrowser - I've closed my original PR but sent another one since it contains one critical fix to make it working correct (keepCallback), more details are

[GitHub] cordova-plugin-inappbrowser pull request: CB- 5109 Windows 8.1 - I...

2014-09-18 Thread sgrebnov
Github user sgrebnov closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/53 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-inappbrowser pull request: FirefoxOS Tweak: Setting...

2014-09-18 Thread nowned
Github user nowned commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/44#issuecomment-5614 Oh sorry, I missed your first message. Closed now! --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] cordova-plugin-inappbrowser pull request: FirefoxOS Tweak: Setting...

2014-09-18 Thread nowned
Github user nowned closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/44 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-inappbrowser pull request: Windows implementation f...

2014-09-18 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/64 Windows implementation fixes and improvements 1. Added {keepCallback: true} so that it can propagate several navigation events 2. "calc(100% - 80px)" style instead of o

[GitHub] cordova-windows pull request: CB-7493 Adds 'space-in-path' and 'un...

2014-09-18 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-windows/pull/43#issuecomment-56139471 Rebased. @purplecabbage, pls. review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-plugin-media-capture pull request: CB-7453 Adds fallback t...

2014-09-18 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/26#issuecomment-56139405 Rebased. @purplecabbage, pls. review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

Re: targetWidth and targetHeight are not being interpreted consistently across platforms

2014-09-18 Thread Shazron
Hi John, Thanks for that bug and sorry for overlooking it. I've been swamped by iOS 8 issues lately, but I will respond in the issue. On Thu, Sep 18, 2014 at 12:08 PM, John M. Wargo wrote: > Back in January I did a bunch of research on the issue I identified > regarding how with the Camera API,

[GitHub] cordova-plugin-inappbrowser pull request: FirefoxOS Tweak: Setting...

2014-09-18 Thread zalun
Github user zalun commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/44#issuecomment-56137912 Created the change manually so it won't conflict. Please close @nowned --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-plugin-inappbrowser pull request: zIndex fixed

2014-09-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/63 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-inappbrowser pull request: zIndex fixed

2014-09-18 Thread zalun
GitHub user zalun opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/63 zIndex fixed You can merge this pull request into a Git repository by running: $ git pull https://github.com/zalun/cordova-plugin-inappbrowser fix_zindex Alternatively you c

[GitHub] cordova-lib pull request: CB-7598 Android: Support for 9-patch spl...

2014-09-18 Thread dpogue
GitHub user dpogue opened a pull request: https://github.com/apache/cordova-lib/pull/87 CB-7598 Android: Support for 9-patch splash images If a splashscreen image for Android is specified in config.xml and ends with `.9.png`, it is a 9-patch image and should retain that extension wh

Re: [DISCUSS] shrinkwrap

2014-09-18 Thread Carlos Santana
@Michael I agree if we think it's going to affect contribution, let's implemented in a way that is not affect them at all. and find ways to keep it uptodate and part of the released process. On Thu, Sep 18, 2014 at 4:39 PM, Michael Brooks wrote: > > > > But here is the trick even if we put the s

[GitHub] cordova-plugin-splashscreen pull request: Support iPhone 6/6+ by u...

2014-09-18 Thread noisysocks
GitHub user noisysocks opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/27 Support iPhone 6/6+ by using UILaunchStoryboardName NIB if available I need to support the larger iPhone 6 and 6 Plus screens in a project I'm working on so adapted this plugi

Re: WKWebView for iOS8

2014-09-18 Thread Shazron
http://shazronatadobe.wordpress.com/2014/09/18/cordova-ios-and-ios-8/ On Thu, Sep 18, 2014 at 9:03 AM, Shazron wrote: > Yeah no update in iOS 8 GM. So moving to contingency. I still think it's a > bug and not a policy change: > https://issues.apache.org/jira/browse/CB-7539 > > Should be pretty e

Plugin PRs ( from Sergey )

2014-09-18 Thread Jesse
All reviewed and merged Sergey. Merge issue in media-capture#26, may already be implemented ... https://github.com/apache/cordova-plugin-media-capture/pull/26#issuecomment-56118695 And I chose #52 over #53 for inappbrowser You should be able to close https://github.com/apache/cordova-plugin-inapp

[GitHub] cordova-plugin-inappbrowser pull request: CB-5109 - Windows 8 and ...

2014-09-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/52 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-media-capture pull request: CB-7453 Adds fallback t...

2014-09-18 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/26#issuecomment-56118695 Merge issues. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-ios pull request: Fixed the CDV_IsIPhone5() macro for iOS8...

2014-09-18 Thread Clafou
Github user Clafou closed the pull request at: https://github.com/apache/cordova-ios/pull/105 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-ios pull request: Fixed the CDV_IsIPhone5() macro for iOS8...

2014-09-18 Thread Clafou
Github user Clafou commented on the pull request: https://github.com/apache/cordova-ios/pull/105#issuecomment-56118693 Thanks, glad to help! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] cordova-plugin-media-capture pull request: CB-7429, CB-7440 Media-...

2014-09-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/25 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cordova-plugin-media pull request: CB-7454 Adds support for m4a au...

2014-09-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/26 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-plugin-contacts pull request: CB-7373 Provides additional ...

2014-09-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/44 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-contacts pull request: CB-7357 Adds missing 'capabi...

2014-09-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/43 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-windows pull request: CB-7520 Add MRT image support for Wi...

2014-09-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/45 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-windows pull request: CB-7493 Adds 'space-in-path' and 'un...

2014-09-18 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/43#issuecomment-56117107 Conflicted! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have th

[GitHub] cordova-windows pull request: CB-7494 Fixes wrong replacements in ...

2014-09-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/44 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-wp8 pull request: CB-7493 Adds 'space-in-path' and 'unicod...

2014-09-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-wp8/pull/57 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-ios pull request: Fixed the CDV_IsIPhone5() macro for iOS8...

2014-09-18 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/105#issuecomment-56112665 Patch integrated: https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;h=b06ca8d You can close this PR now, thanks! --- If your project is set up for it, y

Re: onResume() of CordovaActivity

2014-09-18 Thread Archana Naik
Thanks Joe for your response. We have a use case where we have 2 activities with webviews. First activity is responsible for launching the 2nd one. Now when 2nd one is launched, 1st activity goes through onPause() which pauses timers because keepRunning flag is set to false. This pauseTimers() act

[Vote] Tools Release 3.6.3-0.2.13

2014-09-18 Thread Marcel Kinard
Please review and vote on this Tools Release. I believe this is the last redo of the long effort to get 3.6 out the door. Compared to the earlier vote, I cleaned up the shrinkwrap so the devDependencies don't get installed. Because I wanted to verify that it works, I published these RCs to npm

[GitHub] cordova-ios pull request: Fixed the CDV_IsIPhone5() macro for iOS8...

2014-09-18 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/105#issuecomment-56101072 Ouch, yeah this resulted in a bug for the statusbar plugin as well for landscape (fixed) :/ Filed https://issues.apache.org/jira/browse/CB-7596 --- If your proj

Re: onResume() of CordovaActivity

2014-09-18 Thread Joe Bowser
The purpose of this code is because when you start an app, onResume is called, even though you didn't pause anything. You aren't receiving any results, and you're not restoring any multi-tasking state. There is no state, because you just started the application. If you were to not have this, it'

Re: [DISCUSS] shrinkwrap

2014-09-18 Thread Michael Brooks
> > But here is the trick even if we put the specific version of the dependency > in our package.json that doesn't guarantee that down the dependency chain > different versions of node modules get install based on the time of the > install. @Carlos very true and I didn't cover that topic. Persona

Re: [DISCUSS] shrinkwrap

2014-09-18 Thread Carlos Santana
Like I said in my initial proposal to use shrinkwrap the minimum requirement is that is included when publishing to npm, is the only way that we can trace problems and what are the bits that end user is using in case of a problem. I don't want for committers to waste time troubleshooting something

onResume() of CordovaActivity

2014-09-18 Thread Archana Naik
Hi, Joe I have a question about a piece of code which has always been there in CordovaActivitie's onResume(). if (this.activityState == ACTIVITY_STARTING) { this.activityState = ACTIVITY_RUNNING; return; } Do you know why we have this? Archana

Re: cordova push plugin release

2014-09-18 Thread Jesse
I have also recently published this one: com.phonegap.plugins.pushplugin@2.2.1 With recently added support for wp8, and windows8 ( Thanks Sergey!) @purplecabbage risingj.com On Thu, Sep 18, 2014 at 11:25 AM, Carlos Santana wrote: > I think is the aerogear push > > http://plugins.cordova.io/

RE: [DISCUSS] shrinkwrap

2014-09-18 Thread Parashuram Narasimhan (MS OPEN TECH)
Also a quick question. Will we be withholding the 3.6.* release till we resolve this discussion? -Original Message- From: mikeywbro...@gmail.com [mailto:mikeywbro...@gmail.com] On Behalf Of Michael Brooks Sent: Thursday, September 18, 2014 12:18 PM To: dev@cordova.apache.org Subject: Re

Re: [DISCUSS] shrinkwrap

2014-09-18 Thread Michael Brooks
Personally, I've never got into shrinkwrap. In my opinion, it's another barrier to contribution and another place for mistakes to be made. I prefer on the old-school "shrinkwrap" approach, which is explicitly specifying each dependency version: https://github.com/phonegap/phonegap-cli/blob/master/

targetWidth and targetHeight are not being interpreted consistently across platforms

2014-09-18 Thread John M. Wargo
Back in January I did a bunch of research on the issue I identified regarding how with the Camera API, targetwidth and target height are not implemented consistently across platforms. I just noticed that nobody is assigned to this ticket: https://issues.apache.org/jira/browse/CB-5942. Is this

Re: [DISCUSS] shrinkwrap

2014-09-18 Thread Mark Koudritsky
> > > Mark, > I want to understand better your statement "resulted in a great deal of > confusion for contributors". Can you give more details about that. One simple case I had myself was when debugging a suspected problem with one of dependencies and wasting several hours to only discover that

RE: [VOTE] Plugins Release Sept 17 2014

2014-09-18 Thread Sergey Grebnov (Akvelon)
Hi, I'm still waiting for the following PRs to be reviewed/merged. Most of them are critical to have plugins working on Windows 8.1 and Windows Phone 8.1, so if they are not merged by my morning, I'll merge the fixes by myself since they are very local and affect windows only. Bugfixing relate

Re: cordova push plugin release

2014-09-18 Thread Carlos Santana
I think is the aerogear push http://plugins.cordova.io/#/package/org.jboss.aerogear.cordova.push On Thu, Sep 18, 2014 at 1:38 PM, Parashuram Narasimhan (MS OPEN TECH) < panar...@microsoft.com> wrote: > Hi Erik, > > Where is this push plugin available ? > > -Original Message- > From: Erik

Re: [DISCUSS] shrinkwrap

2014-09-18 Thread Carlos Santana
+1 on having shrinkwrap on git repos, only because that's what the majority of committers/contributors use for testing. Find a way that shrinkwrap is always update in git by automation bot or something similar. In theory it should be transparent to contributors only one that cares is "npm install"

Re: Downloading the 3.5.1 cordova files for android when building the project

2014-09-18 Thread Carlos Santana
Don't be confuse by the version number of cordova. In your case cordova command line interface (cordova-cli) with the command "cordova" is version 3.5.0-0.2.7 The android platform "files for cordova-android" is version 3.5.1 and yes it's OK to have cordova cli at version 3.5.x-x.x.x and cordova-an

[GitHub] cordova-plugin-globalization pull request: [BlackBerry10] Re-imple...

2014-09-18 Thread lyonplus
Github user lyonplus closed the pull request at: https://github.com/apache/cordova-plugin-globalization/pull/25 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

RE: cordova push plugin release

2014-09-18 Thread Parashuram Narasimhan (MS OPEN TECH)
Hi Erik, Where is this push plugin available ? -Original Message- From: Erik Jan de Wit [mailto:ede...@redhat.com] Sent: Tuesday, September 16, 2014 5:44 AM To: dev@cordova.apache.org Subject: Re: cordova push plugin release Ultimate goal is to enable swift as a language to create plu

RE: [DISCUSS] shrinkwrap

2014-09-18 Thread Parashuram Narasimhan (MS OPEN TECH)
If we do have shrinkwrap in git at all times, who would be responsible for updating not only the versions of our dependencies, but also the dependencies of these dependencies? Why should cordova-lib and cordova-plugman not have shrinkwraps? Not all tools use cordova-cli as a way to build cordo

[GitHub] cordova-plugin-globalization pull request: [BlackBerry10] Re-imple...

2014-09-18 Thread bryanhiggins
Github user bryanhiggins commented on the pull request: https://github.com/apache/cordova-plugin-globalization/pull/25#issuecomment-56073876 merged. @lyonplus please close --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

RE: [DISCUSS] continuous build and release process

2014-09-18 Thread Parashuram Narasimhan (MS OPEN TECH)
About the release branches, is the idea that we continue to push stuff on master and then create a new 3.7.0 branch when we would like to release 3.7.0? I am guessing that this would be for platforms and the tools. How would this look when the platforms start getting released independently (we d

Re: iOS8 support

2014-09-18 Thread Shazron
It should. The updates to support iOS 8 are all in the plugins, which are in a voting period right now before release to the plugin registry. On Wed, Sep 17, 2014 at 9:59 PM, Toda, Shingo wrote: > Hello > > I just wonder if the next version of Cordova iOS (3.6.3?) is going to > support iOS8. I r

Re: WKWebView for iOS8

2014-09-18 Thread Shazron
Yeah no update in iOS 8 GM. So moving to contingency. I still think it's a bug and not a policy change: https://issues.apache.org/jira/browse/CB-7539 Should be pretty easy (minus the securing it part is a bit more work). On Wed, Sep 17, 2014 at 8:31 PM, Ally Ogilvie wrote: > Interested in any

[GitHub] cordova-lib pull request: CB-7496 Fix --link option for plugman in...

2014-09-18 Thread mbektchiev
Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-lib/pull/85#issuecomment-56060031 Can anyone please review? :bug: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

Re: [DISCUSS] continuous build and release process

2014-09-18 Thread Mark Koudritsky
+1 for release branches, reverting version bumps feels really awkward +1 for more continuous integration. And just to make sure more people are aware of it, there is this buildbot running some CI http://108.170.217.131:8010/waterfall A half baked idea for a more automated release process: Talking

Re: [DISCUSS] shrinkwrap

2014-09-18 Thread Mark Koudritsky
> > I suggest that: > - The shrinkwrap exist in git at all times, not just during the release > process. > -1 for that. Having shrinkwrap at all times will result in postponed discovery of incompatibilities with newer versions (which are usually trickier than shrinkwrap problems) until you nuke nod

Downloading the 3.5.1 cordova files for android when building the project

2014-09-18 Thread naidu
I am developing an app using cordova 3.5.0 by using android-4.4.2 with an api level 19. It was working fine till morning but suddenly i am getting the following error, I know that the cordova 3.5.1 got released. I did not update my cordova version also and i have checked the version which is st

[GitHub] cordova-ios pull request: Fixed the CDV_IsIPhone5() macro for iOS8...

2014-09-18 Thread Clafou
GitHub user Clafou opened a pull request: https://github.com/apache/cordova-ios/pull/105 Fixed the CDV_IsIPhone5() macro for iOS8 landscape iOS8 introduces a change to screen orientation, making [UIScreen bounds] orientation-dependent. As a result, testing if the screen resolution m

cordova-android fails to run package

2014-09-18 Thread Vladimir Kotikov (Akvelon)
FYI, while playing with latest cordova-android (commit 3f83fdb [1]) I've found that packaged, built with ant can't be deployed to device/emulator. When running 'cordova run android' I get following message: Built the following APKs:     

[GitHub] cordova-android pull request: CB-7575 Fixes 'run' failure with --n...

2014-09-18 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-android/pull/121 CB-7575 Fixes 'run' failure with --nobuild option specified. Fix for https://issues.apache.org/jira/browse/CB-7575 'cordova run android -- --nobuild' fails on cordova 3.6.3

[GitHub] cordova-docs pull request: CB-6751 Added joDoc dependency

2014-09-18 Thread kant2002
Github user kant2002 commented on the pull request: https://github.com/apache/cordova-docs/pull/236#issuecomment-56008552 Added folowing: 1. TOC builder 2. YAML stripper 2. Tests for existing processors and new one added --- If your project is set up for it, you can reply