Re: Independent platform release summary

2014-10-13 Thread Andrew Grieve
Thanks Marcel, doc spells things out very clearly. On Mon, Oct 13, 2014 at 4:06 PM, Marcel Kinard wrote: > After all this discussion, it's a bit unclear to me where we are currently > at. So I took a shot at capturing it in writing it for coho/docs/ > versioning-and-release-strategy.md. > > http

[GitHub] cordova-coho pull request: CB-7774 capture updates from Hangout an...

2014-10-13 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/53#discussion_r18806936 --- Diff: docs/versioning-and-release-strategy.md --- @@ -19,17 +19,100 @@ # --> -# Versioning and Release Strategy +# Versioning

[GitHub] cordova-coho pull request: CB-7774 capture updates from Hangout an...

2014-10-13 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/53#discussion_r18806877 --- Diff: docs/versioning-and-release-strategy.md --- @@ -19,17 +19,100 @@ # --> -# Versioning and Release Strategy +# Versioning

[GitHub] cordova-plugin-splashscreen pull request: Support iPhone 6/6+ by u...

2014-10-13 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/27#issuecomment-58969504 Sorry everyone but I had to do a major re-factor to support unit-testing the different configurations of splash screens (effectively over 200 plus tes

[GitHub] cordova-plugin-splashscreen pull request: CB-3562 Disable screen r...

2014-10-13 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/14#issuecomment-58969444 Sorry everyone but I had to do a major re-factor to support unit-testing the different configurations of splash screens (effectively over 200 plus tes

[GitHub] cordova-plugin-splashscreen pull request: fixed "WARNING: The spla...

2014-10-13 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/23#issuecomment-58969362 Sorry everyone but I had to do a major re-factor to support unit-testing the different configurations of splash screens (effectively over 200 plus tes

[GitHub] cordova-plugin-splashscreen pull request: Add support for UILaunch...

2014-10-13 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/17#issuecomment-58969228 Sorry everyone but I had to do a major re-factor to support unit-testing the different configurations of splash screens (effectively over 200 plus tes

[GitHub] cordova-plugin-splashscreen pull request: Added support for iPhone...

2014-10-13 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/26#issuecomment-58969064 Sorry everyone but I had to do a major re-factor to support unit-testing the different configurations of splash screens (effectively over 200 plus tes

[GitHub] cordova-plugin-splashscreen pull request: CB-7204 Fixed race condi...

2014-10-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/21 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-splashscreen pull request: Fix for portrait/landsca...

2014-10-13 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/29#issuecomment-58968040 Pulled in: https://github.com/apache/cordova-plugin-splashscreen/commit/2f37eed1840619c31f5fdc746cbf9324ef6afb53 You can close this PR now.

[GitHub] cordova-ios pull request: CDVWebViewDelegate fails to update the w...

2014-10-13 Thread pbenschop
Github user pbenschop commented on the pull request: https://github.com/apache/cordova-ios/pull/110#issuecomment-58965142 Hi @shazron, I've emailed secret...@apache.org with my personal CLA. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-ios pull request: Creating a customizable user agent for i...

2014-10-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/112 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-ios pull request: Creating a customizable user agent for i...

2014-10-13 Thread khawkins
Github user khawkins commented on the pull request: https://github.com/apache/cordova-ios/pull/112#issuecomment-58958989 So it does! I'll rebase now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] cordova-ios pull request: Creating a customizable user agent for i...

2014-10-13 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/112#issuecomment-58958943 Ah, sorry. However as you can see in this pull request, according to Github your PR has merge conflicts that need to be re-based. --- If your project is set up for

[GitHub] cordova-ios pull request: Creating a customizable user agent for i...

2014-10-13 Thread khawkins
Github user khawkins commented on the pull request: https://github.com/apache/cordova-ios/pull/112#issuecomment-58958702 They're compound changes. There are changes in the JS *and* the native layer. I've reverted the JS changes here, but the native code changes remain. --- If your

[GitHub] cordova-ios pull request: CDVWebViewDelegate fails to update the w...

2014-10-13 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/110#issuecomment-58958577 Thanks @cwarden - in this case @pbenschop needs to file an iCLA him/herself, a corporate CLA does not suffice for Apache's purposes. --- If your project is set up f

[GitHub] cordova-ios pull request: CDVWebViewDelegate fails to update the w...

2014-10-13 Thread cwarden
Github user cwarden commented on the pull request: https://github.com/apache/cordova-ios/pull/110#issuecomment-58958239 Hi @shazron, this change was done by @pbenschop under contract to @greatvines. I've emailed secret...@apache.org with our corporate CLA. --- If your project is set

[GitHub] cordova-ios pull request: Creating a customizable user agent for i...

2014-10-13 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/112#issuecomment-58957912 I meant that you've already submitted a PR to cordova-js (https://github.com/apache/cordova-js/pull/84), this one is obsolete because it is not the right repo. ---

[GitHub] cordova-ios pull request: Creating a customizable user agent for i...

2014-10-13 Thread khawkins
Github user khawkins commented on the pull request: https://github.com/apache/cordova-ios/pull/112#issuecomment-58957206 Are we not going to merge it? Sorry, it's been a while and I don't remember the exact order of things for getting changes into the repo. --- If your project is se

[GitHub] cordova-ios pull request: CDVWebViewDelegate fails to update the w...

2014-10-13 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/110#issuecomment-58955636 Thank you for the pull request. I can't tell from your username whether you have signed the Apache iCLA, but you need to do so before I can pull this in. Let me know

[GitHub] cordova-ios pull request: Check if Javascript function handleOpenU...

2014-10-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/109 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-ios pull request: Check if Javascript function handleOpenU...

2014-10-13 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/109#issuecomment-58953313 Filed https://issues.apache.org/jira/browse/CB- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-ios pull request: Made isValidCallbackId threadsafe (Bug C...

2014-10-13 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/108#issuecomment-58952755 Thank you, looks good to me. I've searched and it appears that you haven't signed and submitted the Apache iCLA. Could you please do so?: http://www.apache.or

[GitHub] cordova-ios pull request: Creating a customizable user agent for i...

2014-10-13 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/112#issuecomment-58952165 Thanks Kevin, can you close this PR. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-ios pull request: Add component.json

2014-10-13 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/102#issuecomment-58952017 Filed for coho: https://issues.apache.org/jira/browse/CB-7776 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-ios pull request: Add component.json

2014-10-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/102 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-ios pull request: Add component.json

2014-10-13 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/102#issuecomment-58951211 Filed: https://issues.apache.org/jira/browse/CB-7775 Note that updating of the versions will have to be a manual process, unless coho is updated here: h

Re: Independent platform release summary

2014-10-13 Thread Marcel Kinard
After all this discussion, it's a bit unclear to me where we are currently at. So I took a shot at capturing it in writing it for coho/docs/versioning-and-release-strategy.md. https://github.com/apache/cordova-coho/pull/53 I intend this to be the "Current State" of the discussion, not the "End

[GitHub] cordova-coho pull request: CB-7774 capture updates from Hangout an...

2014-10-13 Thread cmarcelk
GitHub user cmarcelk opened a pull request: https://github.com/apache/cordova-coho/pull/53 CB-7774 capture updates from Hangout and mailing list You can merge this pull request into a Git repository by running: $ git pull https://github.com/cmarcelk/cordova-coho CB-7774 Alter

Re: Cordova Media-Capture Plugin Issue

2014-10-13 Thread Joe Bowser
Remember to search before filing. There may already be a related open issue. On Oct 13, 2014 11:56 AM, "Shazron" wrote: > Hi David, > Thanks for the report. Please file an issue at: > http://issues.apache.org/jira/browse/CB > > ... so it can be tracked and evaluated by the devs, and you can be >

Re: Cordova Media-Capture Plugin Issue

2014-10-13 Thread Shazron
Hi David, Thanks for the report. Please file an issue at: http://issues.apache.org/jira/browse/CB ... so it can be tracked and evaluated by the devs, and you can be notified. Sign up here: https://issues.apache.org/jira/secure/Signup!default.jspa Thanks! On Sun, Oct 12, 2014 at 7:25 PM, Dav

Measuring Perf of Cordova apps (Android/iOS)

2014-10-13 Thread Parashuram
Over the weekend, I created a tool to measure the rendering and network performance for Cordova apps, and I thought of sharing it on the list. I am able to pick up numbers from iOS and Android (4.4). Here is a demo video - https://www.youtube.com/watch?v=TG_eTe_H-s4 More details on how to run it o

RE: [Vote] Tools Release

2014-10-13 Thread Sergey Grebnov (Akvelon)
I vote +1: * Verified signatures and hashes via 'coho verify-archive' * Verified tags manually * Extracted archives, ensured everything install without errors * Ensured license headers are present everywhere via 'coho audit-license-headers' * Ensured all dependencies