RE: Buildbot for Cordova on Apache Infra - Update

2014-12-05 Thread Parashuram Narasimhan (MS OPEN TECH)
Awesome - Thanks Marcel. Once the master is ready, we will start setting up the slaves. -Original Message- From: Marcel Kinard [mailto:cmarc...@gmail.com] Sent: Friday, December 5, 2014 1:42 PM To: dev@cordova.apache.org Subject: Re: Buildbot for Cordova on Apache Infra - Update The IB

RE: Introduction

2014-12-05 Thread Chuck Lantz
Covered, right down to links to the source MSDN articles. -Chuck -Original Message- From: Marcel Kinard [mailto:cmarc...@gmail.com] Sent: Friday, December 5, 2014 1:50 PM To: dev@cordova.apache.org Subject: Re: Introduction Not already covered at [1] or [2]? [1]: http://cordova.apache.

[GitHub] cordova-plugin-splashscreen pull request: CB-3679 Break Android sp...

2014-12-05 Thread jbavari
Github user jbavari commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/32#issuecomment-65865043 Works great. :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

Re: Code coverage report for Cordova-js, cordova-cli and cordova-lib

2014-12-05 Thread Marcel Kinard
Personally, I think of test results as a tuple: success metrics, and coverage metrics. So yeah, they are useful. Even having the summary is better than nothing. Cool! On Dec 3, 2014, at 6:00 PM, Parashuram Narasimhan (MS OPEN TECH) wrote: > Hi, > > As we are working on the various Medic/Buil

Re: Introduction

2014-12-05 Thread Marcel Kinard
Not already covered at [1] or [2]? [1]: http://cordova.apache.org/docs/en/edge/guide_platforms_wp8_vmware.md.html [2]:http://cordova.apache.org/docs/en/edge/guide_platforms_wp8_parallels.md.html On Dec 5, 2014, at 5:02 AM, Ally Ogilvie wrote: > Chuck! Lifesaver!!! > > Had to be the only VM sof

Re: Buildbot for Cordova on Apache Infra - Update

2014-12-05 Thread Marcel Kinard
The IBM team here would be willing to set up a slave with some of our devices. We have a collection of Android, iOS, BB10, WP8. Looking forward to instructions on slave setup ;-) On Dec 5, 2014, at 12:20 PM, Parashuram Narasimhan (MS OPEN TECH) wrote: > It would be great if we could have othe

Re: Code Review Plz

2014-12-05 Thread Joe Bowser
I'll take a look on Monday. Spent this week bashing my head against my desk trying to deal with the MozillaView js. On Fri, Dec 5, 2014, 1:12 PM Andrew Grieve wrote: > Will go ahead with this next week if no one has a look. That said, would > love a look. > > On Wed, Nov 26, 2014 at 10:10 PM, An

Re: WebView Promise and W3C standards

2014-12-05 Thread Joe Bowser
+1 to userland. I see other approaches causing more problems. BTW: The only time I use promises is when the platform explicitly requires it, and right now that's just MozillaView. While I think it looks awesome, I view Promises as a luxury right now and not a standard feature as of yet. I also r

[GitHub] cordova-android pull request: CB-3679 Move splashscreen logic into...

2014-12-05 Thread jbavari
Github user jbavari commented on the pull request: https://github.com/apache/cordova-android/pull/134#issuecomment-65858347 Andrew, I looked through the code. Everything looks good from what I saw here. :+1: --- If your project is set up for it, you can reply to this email and ha

Re: WebView Promise and W3C standards

2014-12-05 Thread Brian LeRoux
This has me more convinced it should be a userland library and not even a plugin. Problem solved! ;) On Fri, Dec 5, 2014, 12:28 PM Ian Clelland wrote: > I have two reasons for not wanting this as a plugin (both of which, I'm > sure, are entirely subjective) > > The biggest one is just that nativ

Re: Code Review Plz

2014-12-05 Thread Andrew Grieve
Will go ahead with this next week if no one has a look. That said, would love a look. On Wed, Nov 26, 2014 at 10:10 PM, Andrew Grieve wrote: > I've taken a stab at refactoring Android's splashscreen logic into the > splashscreen plugin. > > https://github.com/apache/cordova-android/pull/134 > ht

[GitHub] cordova-plugin-file-transfer pull request: [CB-8014] fileKey optio...

2014-12-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/51 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cordova-plugin-file-transfer pull request: CB-8093 Fixes incorrect...

2014-12-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/52 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

Re: WebView Promise and W3C standards

2014-12-05 Thread Ian Clelland
I have two reasons for not wanting this as a plugin (both of which, I'm sure, are entirely subjective) The biggest one is just that native support for this really is coming quickly, and one day, we'll be able to remove it, because just about every platform that we care about will have support buil

Re: WebView Promise and W3C standards

2014-12-05 Thread Jesse
Thanks Max, Yeah, I saw my earlier comment, but given more time to think about it, I feel that plugin-ization of all things is a better approach. ( my dislike of promises aside ) Ultimately these apis will make their way into the browser controls themselves, then plugin authors could drop their dep

Re: WebView Promise and W3C standards

2014-12-05 Thread Max Woghiren
I can easily change to expanded (non-minified) code; I went with smaller size, expecting that people wouldn't be wanting to inspect the promise polyfill code. No big deal. Earlier in this very thread, people (Jesse included) asserted that it should be in core, and Andrew outlined rationale. I wa

Re: WebView Promise and W3C standards

2014-12-05 Thread Brian LeRoux
Minified code is a flat out bad idea and needs to be reverted immediately. Jesse is right about promises too. Given that native support is immediately inbound it most certainly should be a plugin. Not core. I'll reserve debate about it as a lang feature for the drama queens on hacker news and twit

[GitHub] cordova-windows pull request: Fixed regex used in getPackageFileIn...

2014-12-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/52 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: WebView Promise and W3C standards

2014-12-05 Thread Jesse
We would be mandating its support, we have plenty of issues in Jira, and this solves none of them. ... and minified code? Why? How can I evaluate it? My mantra is and will remain "Plugins are everything, and everything is a plugin" What is the inconvenience in having a dependency on a promise plug

Re: WebView Promise and W3C standards

2014-12-05 Thread Max Woghiren
I think it's nice to remove that obstacle from in front of plugin developers who want to use promises. If we're going to suggest that people drop the polyfill in themselves, I don't see the harm in just having it there, especially if we don't mandate its use. Going forward, many/most APIs will us

RE: Buildbot for Cordova on Apache Infra - Update

2014-12-05 Thread Parashuram Narasimhan (MS OPEN TECH)
It would be great if we could have other platforms also run using Apache Infra. Blackberry, Tizen, FirefoxOS, Amazon - any takers for this? We would be happy to help. -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Wednesday, December 3, 2014 12:23 PM To: dev

Re: WebView Promise and W3C standards

2014-12-05 Thread Jesse
Nice, but please don't add this. Anyone who wants or needs this can do what you did, and if I start seeing promise code throughout Cordova.js I may run. We should be looking to get rid of Cordova.js entirely, not add more deps. Why not a promise plugin? Fyi: promises invoke my fight or fligh

Re: WebView Promise and W3C standards

2014-12-05 Thread Max Woghiren
I've created a topic branch called "promise" to cordova-js. It has a commit that adds this ES6 promise polyfill (minified) to cordova.js and a simple test to en

[GitHub] cordova-mobile-spec pull request: CB-8131 Rewrote non plugin auto ...

2014-12-05 Thread MariaBukharina
GitHub user MariaBukharina opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/113 CB-8131 Rewrote non plugin auto tests for Jasmine 2.0 https://issues.apache.org/jira/browse/CB-8131 You can merge this pull request into a Git repository by running: $ git p

RE: Introduction

2014-12-05 Thread Chuck Lantz
Strange - I'm using it right now. Here's the Parallels article on it: http://kb.parallels.com/en/115211 They recommend altering a hyper-v setting, but I haven't found that necessary. -Chuck -Original Message- From: Ally Ogilvie [mailto:aogil...@wizcorp.jp] Sent: Friday, December 5, 201

[GitHub] cordova-plugin-inappbrowser pull request: InAppBrowser, iOS: Setti...

2014-12-05 Thread vinnyrose
Github user vinnyrose commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/72#issuecomment-65798865 I should clarify that the error was: "CGContextSaveGState: invalid context 0x0. This is a serious error..." --- If your project is set up for it,

[GitHub] cordova-plugin-inappbrowser pull request: InAppBrowser, iOS: Setti...

2014-12-05 Thread vinnyrose
Github user vinnyrose commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/72#issuecomment-65798571 I think this also solves a problem where the status bar was disappearing occasionally on closing a hidden browser. --- If your project is set up f

[GitHub] cordova-plugin-inappbrowser pull request: InAppBrowser, iOS: Setti...

2014-12-05 Thread vinnyrose
Github user vinnyrose commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/72#issuecomment-65796774 ICLA was submitted today. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] cordova-plugin-inappbrowser pull request: InAppBrowser, iOS: Setti...

2014-12-05 Thread vinnyrose
Github user vinnyrose commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/72#issuecomment-65796475 JIRA: CB-8130 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-lib pull request: CB-7803 allow adding any platform on any...

2014-12-05 Thread oliversalzburg
Github user oliversalzburg commented on the pull request: https://github.com/apache/cordova-lib/pull/126#issuecomment-65796285 @eymorale Oh, I see. I assumed that this change is supposed to allow to continue execution even if the build for a platform fails. --- If your project is set

[GitHub] cordova-plugin-inappbrowser pull request: InAppBrowser, iOS: Setti...

2014-12-05 Thread vinnyrose
Github user vinnyrose commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/72#issuecomment-65796343 This can happened when hidden=yes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-plugin-inappbrowser pull request: InAppBrowser, iOS: Setti...

2014-12-05 Thread vinnyrose
GitHub user vinnyrose opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/72 InAppBrowser, iOS: Setting setStatusBarStyle to -1 causes CGContextSaveG... ...State. Simple if statement to ensure -1 is not submitted to setStatusBarStyle. You can m

[GitHub] cordova-lib pull request: CB-7803 allow adding any platform on any...

2014-12-05 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-lib/pull/126#issuecomment-65794810 Hi @oliversalzburg , the way I have implemented it that should be expected. iOS won't compile on anything other than OSX. I have included an explanation for this in

[GitHub] cordova-lib pull request: CB-7803 allow adding any platform on any...

2014-12-05 Thread oliversalzburg
Github user oliversalzburg commented on the pull request: https://github.com/apache/cordova-lib/pull/126#issuecomment-65783734 I tested this with our app. The build process is still aborted when failing to compile the ios target on Windows. --- If your project is set up for it, you c

[GitHub] cordova-plugin-inappbrowser pull request: hack: very bad fix but j...

2014-12-05 Thread mysegfault
GitHub user mysegfault opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/71 hack: very bad fix but just works for fixing the dialog closing on Andro... On Android, it's very frequent to fall into this bug : you cannot close the inappbrowser dialog whe

Re: Introduction

2014-12-05 Thread Ally Ogilvie
Spoke to soon. Xde.exe crashes heavy. https://github.com/garethr/vagrantboxes-heroku/issues/334 On Fri, Dec 5, 2014 at 7:02 PM, Ally Ogilvie wrote: > Chuck! Lifesaver!!! > > Had to be the only VM soft I didn't try ><, no luck on VMware or > virtualbox. > > Thanks! > > > On Fri, Dec 5, 2014 at 1:

Re: Introduction

2014-12-05 Thread Ally Ogilvie
Chuck! Lifesaver!!! Had to be the only VM soft I didn't try ><, no luck on VMware or virtualbox. Thanks! On Fri, Dec 5, 2014 at 1:04 AM, Chuck Lantz wrote: > Hey Ally, > > Thanks for letting us know! > > Here's what I do: The Windows Phone emulator works inside of Parallels on > an OSX machin

[GitHub] cordova-ios pull request: typo fix for CB-7872

2014-12-05 Thread jschweiger
GitHub user jschweiger opened a pull request: https://github.com/apache/cordova-ios/pull/120 typo fix for CB-7872 You can merge this pull request into a Git repository by running: $ git pull https://github.com/jschweiger/cordova-ios fix Alternatively you can review and apply