[GitHub] cordova-android pull request: Fix compile error when build multipl...

2014-12-12 Thread fujunwei
GitHub user fujunwei opened a pull request: https://github.com/apache/cordova-android/pull/138 Fix compile error when build multiple apks Task 'lintVitalRelease' not found in root project when build multiple apks, add a empty task for comipling. You can merge this pull request into

[GitHub] cordova-android pull request: Fix compile error when build multipl...

2014-12-12 Thread fujunwei
Github user fujunwei commented on the pull request: https://github.com/apache/cordova-android/pull/138#issuecomment-66743053 @clelland PTAL. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-wp8 pull request: Improved console logging

2014-12-12 Thread oliversalzburg
GitHub user oliversalzburg opened a pull request: https://github.com/apache/cordova-wp8/pull/66 Improved console logging Previously, when using console.log facilities, only the first argument was respected by ConsoleHelper, resulting in information not being logged when `console.lo

[GitHub] cordova-plugin-statusbar pull request: CB-8001

2014-12-12 Thread IvanKarpan
GitHub user IvanKarpan opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/19 CB-8001 StatusBar Plugin 0.1.8 crashes application on tap Reproduced only in projects without ARC Now retaining callbackId, without a retain there it gets dealloced and c

Re: Build proyect on different Android Cordova in the same PC

2014-12-12 Thread julio cesar sanchez
I have not tried what Ivan said, but as you are on version 2.9.0 I don't think you can because cordova 2.9.0 wasn't installed on the system, just downloaded, and there is no direct update from 2.9.X to 3.X.X. What I did when upgraded from 2.9.1 to 3.6.4 was, I generated the cordova-3.6.4.jar, dele

[GitHub] cordova-docs pull request: Instructions about signing and releasin...

2014-12-12 Thread fredgalvao
Github user fredgalvao commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/212#discussion_r21742998 --- Diff: docs/en/3.4.0/guide/platforms/android/index.md --- @@ -242,3 +242,31 @@ You can push the app to the device from the command line:

Re: Build proyect on different Android Cordova in the same PC

2014-12-12 Thread Ivan Karpan
Hello Julio, I think we are just answering different questions, both valid. I was speaking to possibility of maintaining source code that uses different version of Cordova, you addressed the necessity of upgrading from 2.9 to 3.X. I agree with you that the upgrade process is going to be v

[GitHub] cordova-js pull request: ubuntu: port to oxide

2014-12-12 Thread Zaspire
GitHub user Zaspire opened a pull request: https://github.com/apache/cordova-js/pull/94 ubuntu: port to oxide You can merge this pull request into a Git repository by running: $ git pull https://github.com/Zaspire/cordova-js master Alternatively you can review and apply these

[GitHub] cordova-ubuntu pull request: 4.0

2014-12-12 Thread Zaspire
GitHub user Zaspire opened a pull request: https://github.com/apache/cordova-ubuntu/pull/9 4.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cordova-ubuntu/cordova-ubuntu master Alternatively you can review and apply these cha

[GitHub] cordova-plugin-inappbrowser pull request: ubuntu: port to oxide

2014-12-12 Thread Zaspire
GitHub user Zaspire opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/74 ubuntu: port to oxide You can merge this pull request into a Git repository by running: $ git pull https://github.com/Zaspire/cordova-plugin-inappbrowser master Alternativ

How to handle CSP for XHR in Cordova 4.0

2014-12-12 Thread Ian Clelland
I'm just building the new optional whitelist plugins for Cordova Android and iOS 4.x, and I'm thinking about how to encourage developers to use CSP for network requests, as opposed to a Cordova-implemented-whitelist-which-probably-leaks-like-a-sieve. (Note: This is really just about things like XH

[GitHub] cordova-plugin-vibration pull request: android: respect silent aud...

2014-12-12 Thread master-of-magic
Github user master-of-magic commented on the pull request: https://github.com/apache/cordova-plugin-vibration/pull/28#issuecomment-66779531 Changed the formatting a bit in case this was the "conflict" --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] cordova-plugin-vibration pull request: android: respect silent aud...

2014-12-12 Thread daserge
Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-vibration/pull/28#issuecomment-66780698 I think you just need to rebase your changes on the latest origin/master code. --- If your project is set up for it, you can reply to this email and ha

Re: Browserify JS is in

2014-12-12 Thread Michal Mocny
Okay, well we've got some tests to do and can come back here with results. One feature I would like to not lose: cordova_plugins.js is bad for many reasons, but I have found it useful on several occasions to get a full list of plugins & versions that shipped with an app. One reason is for the mob

Re: WebView Promise and W3C standards

2014-12-12 Thread Andrew Grieve
I believe there's not API to insert this early for Android / iOS other than in the new WKWebView. On Thu, Dec 11, 2014 at 3:23 PM, Jesse wrote: > The native side knows the browser capabilities long before it's > loaded, or even created, compile time even. They will never change > after the app i

[GitHub] cordova-lib pull request: CB-8155 Do not fail plugin installation ...

2014-12-12 Thread mbektchiev
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-lib/pull/129 CB-8155 Do not fail plugin installation from git url with --link This is wrong when installing a local plugin with dependencies from git repositories. https://issues.apache.org/jira

[GitHub] cordova-plugin-vibration pull request: android: respect silent aud...

2014-12-12 Thread master-of-magic
GitHub user master-of-magic opened a pull request: https://github.com/apache/cordova-plugin-vibration/pull/30 android: respect silent audio setting Do not vibrate on android, if AudioManager.RINGER_MODE_SILENT is set. You can merge this pull request into a Git repository by running:

[GitHub] cordova-plugin-vibration pull request: android: respect silent aud...

2014-12-12 Thread master-of-magic
Github user master-of-magic commented on the pull request: https://github.com/apache/cordova-plugin-vibration/pull/28#issuecomment-66791356 done: https://github.com/apache/cordova-plugin-vibration/pull/30 --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-js pull request: Android: use base64.toArrayBuffer to conv...

2014-12-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/93 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

Re: How to handle CSP for XHR in Cordova 4.0

2014-12-12 Thread Michal Mocny
I'm fine with 1. coupled with a default CSP in the template application. For older apps not written from scratch, we can perhaps strongly suggest installing the legacy-whitelist, which would change the default-open behaviour to default-closed. Together, that would give sensible defaults that aren

RE: Buildbot for Cordova on Apache Infra - Update

2014-12-12 Thread Dmitriy Barkalov (Akvelon)
Hi all, I'd like to provide a status update on this task: - External slaves could be wired to Apache infra. (I've successfully wired windows slave to Apache Infra in testing purposes) - Need to resolve some build bot configuration issues - After configuration is ready we will add Github hooks to

Re: How to handle CSP for XHR in Cordova 4.0

2014-12-12 Thread Ian Clelland
Default CSP is a good idea. I was worried about leaving new apps vulnerable by default but that should close that. Do we know what the CSP story is on all platforms, to know that it won't break anything else? On 12 Dec 2014 11:56, "Michal Mocny" wrote: > I'm fine with 1. coupled with a default C

Re: Browserify JS is in

2014-12-12 Thread Andrew Grieve
On Thu, Dec 11, 2014 at 2:38 PM, Andrew Grieve wrote: > I'd really like to get it fully spelled out *why* browserify is the right > tool for this. Some thoughts below: > > On Wed, Dec 10, 2014 at 8:35 PM, Brian LeRoux wrote: > >> we should move browserify to main and drop that insane concat code

Re: Browserify JS is in

2014-12-12 Thread Joe Bowser
On Fri Dec 12 2014 at 10:25:51 AM Andrew Grieve wrote: > > I'm not actually worried about my disk filling up. Dependencies must be > vetted for appropriate licenses, so now there's more overhead here. If we > need to make a change to the module system now we need to poor through docs > and make P

Re: WebView Promise and W3C standards

2014-12-12 Thread Shazron
Yup, WKWebView has an option to add a script at WKUserScriptInjectionTimeAtDocumentStart. On Fri, Dec 12, 2014 at 7:21 AM, Andrew Grieve wrote: > I believe there's not API to insert this early for Android / iOS other than > in the new WKWebView. > > On Thu, Dec 11, 2014 at 3:23 PM, Jesse wrote:

[GitHub] cordova-ios pull request: CB-6637 - Removed - request:isFragmentId...

2014-12-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/121 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: WebView Promise and W3C standards

2014-12-12 Thread Jesse
On Fri, Dec 12, 2014 at 11:10 AM, Shazron wrote: > Yup, WKWebView has an option to add a script at > WKUserScriptInjectionTimeAtDocumentStart. > > On Fri, Dec 12, 2014 at 7:21 AM, Andrew Grieve > wrote: > > I believe there's not API to insert this early for Android / iOS other > than > > in the

Re: WebView Promise and W3C standards

2014-12-12 Thread Andrew Grieve
On Fri, Dec 12, 2014 at 2:28 PM, Jesse wrote: > On Fri, Dec 12, 2014 at 11:10 AM, Shazron wrote: > > > Yup, WKWebView has an option to add a script at > > WKUserScriptInjectionTimeAtDocumentStart. > > > > On Fri, Dec 12, 2014 at 7:21 AM, Andrew Grieve > > wrote: > > > I believe there's not API

[GitHub] cordova-plugin-dialogs pull request: Added support for the new "br...

2014-12-12 Thread BigstickCarpet
Github user BigstickCarpet commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/46#issuecomment-66826408 @kamrik I just got an email confirming that my iCLA is now on file. --- If your project is set up for it, you can reply to this email and have you

[GitHub] cordova-plugin-device pull request: Internet Explorer browser supp...

2014-12-12 Thread BigstickCarpet
Github user BigstickCarpet commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/28#issuecomment-66826434 @purplecabbage I just got an email confirming that my iCLA is now on file. --- If your project is set up for it, you can reply to this email and ha

Re: WebView Promise and W3C standards

2014-12-12 Thread Jesse
Oops, I was wrong. My test works on the first page loaded, but any page after that it does not. Your faith was well placed. I won't bother trying Android, as no-iOS is a blocker. > On Dec 12, 2014, at 11:55 AM, Andrew Grieve wrote: > >> On Fri, Dec 12, 2014 at 2:28 PM, Jesse wrote: >> >>

Re: Browserify JS is in

2014-12-12 Thread Andrew Grieve
On Fri, Dec 12, 2014 at 1:51 PM, Joe Bowser wrote: > On Fri Dec 12 2014 at 10:25:51 AM Andrew Grieve > wrote: > > > > > I'm not actually worried about my disk filling up. Dependencies must be > > vetted for appropriate licenses, so now there's more overhead here. If we > > need to make a change

[GitHub] cordova-lib pull request: CB-8154 - Fix errors adding platforms or...

2014-12-12 Thread jpchase
GitHub user jpchase opened a pull request: https://github.com/apache/cordova-lib/pull/130 CB-8154 - Fix errors adding platforms or plugins - Added utility function to unpack a package.tgz file (gzip + tar) - Use the new utility function when fetching plugins from the registry

Re: Browserify JS is in

2014-12-12 Thread Joe Bowser
What are we actually distributing? On Fri Dec 12 2014 at 12:36:03 PM Andrew Grieve wrote: > On Fri, Dec 12, 2014 at 1:51 PM, Joe Bowser wrote: > > > On Fri Dec 12 2014 at 10:25:51 AM Andrew Grieve > > wrote: > > > > > > > > I'm not actually worried about my disk filling up. Dependencies must b

[GitHub] cordova-plugin-dialogs pull request: Added support for the new "br...

2014-12-12 Thread kamrik
Github user kamrik commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/46#issuecomment-66841786 Cool, I see you on the list now http://people.apache.org/committer-index.html I'll get back to this over the weekend or early next week. --- If your p

Re: Browserify JS is in

2014-12-12 Thread Brian LeRoux
yeah we are *not* proposing to distribute browserify or its deps On Fri, Dec 12, 2014 at 1:38 PM, Joe Bowser wrote: > What are we actually distributing? > > On Fri Dec 12 2014 at 12:36:03 PM Andrew Grieve > wrote: > > > On Fri, Dec 12, 2014 at 1:51 PM, Joe Bowser wrote: > > > > > On Fri Dec 12

Re: WebView Promise and W3C standards

2014-12-12 Thread Brian LeRoux
you could do sneakier haicker things …at any rate -1 on promises remains the case On Fri, Dec 12, 2014 at 12:25 PM, Jesse wrote: > Oops, I was wrong. My test works on the first page loaded, but any page > after that it does not. Your faith was well placed. I won't bother trying > Android, as no