[GitHub] cordova-plugin-inappbrowser pull request: On WP 8.0 `execScript` n...

2014-12-14 Thread durkiewicz
GitHub user durkiewicz opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/75 On WP 8.0 `execScript` need to be used instead of `eval`. Executing `browser.InvokeScript("eval", new string[] { anyJsExpression })` on WP 8.0 ends up with an exception. You

[GitHub] cordova-android pull request: Fix compile error when build multipl...

2014-12-14 Thread fujunwei
Github user fujunwei commented on the pull request: https://github.com/apache/cordova-android/pull/138#issuecomment-66951476 ping @clelland Could you please help to review it, thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] cordova-docs pull request: 3.4.x

2014-12-14 Thread Watabe08
Github user Watabe08 commented on the pull request: https://github.com/apache/cordova-docs/pull/230#issuecomment-66951090 Lisa, I have a question on the workflow of translating the Cordova doc on Crowdin. I just translated a couple of lines on cordova-plugin-camera.

Re: Browserify JS is in

2014-12-14 Thread Steven Gill
For the lazy: cordova_plugins.js discussion https://issues.apache.org/jira/plugins/servlet/mobile#issue/CB-8153 On Dec 14, 2014 6:58 PM, "Michal Mocny" wrote: > Lets discuss the cordova_plugins.js thing elsewhere, this thread has forked > a lot already. > > On Sun, Dec 14, 2014 at 6:22 PM, Carlos

[GitHub] cordova-lib pull request: CB-8154 - Fix errors adding platforms or...

2014-12-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/130 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-8154 - Fix errors adding platforms or...

2014-12-14 Thread kamrik
Github user kamrik commented on the pull request: https://github.com/apache/cordova-lib/pull/130#issuecomment-66945316 lgtm, merging --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

Re: Browserify JS is in

2014-12-14 Thread Michal Mocny
Lets discuss the cordova_plugins.js thing elsewhere, this thread has forked a lot already. On Sun, Dec 14, 2014 at 6:22 PM, Carlos Santana wrote: > > This is the part that I like the most: > "and start > writing plugins as proper node modules. Maybe even push them to npm and > manage dependencies

Re: Apache license in "cordova create"

2014-12-14 Thread Josh Soref
Stripping a license from a file isn't generally allowed by the license. Almost all licenses are at least somewhat "sticky". There are exceptions (possibly Artistic / Perl). There's a general spectrum from sticky, to poisonous, to viral. But even at sticky, a file is still stuck.  ‎ smime.p7s

Re: Apache license in "cordova create"

2014-12-14 Thread Brian LeRoux
go for it; pretty sure you'll get the same answer tho (we have to license stuff we distribute but we could strip on create) On Sun, Dec 14, 2014 at 3:40 PM, Parashuram Narasimhan (MS OPEN TECH) < panar...@microsoft.com> wrote: > Maybe we could ask legal-disc...@apache.org about this issue? They

RE: Apache license in "cordova create"

2014-12-14 Thread Parashuram Narasimhan (MS OPEN TECH)
Maybe we could ask legal-disc...@apache.org about this issue? They should be able to give us a definitive answer about the alternatives. From: Brian LeRoux Sent: ‎Wednesday‎, ‎December‎ ‎10‎, ‎2014 ‎12‎:‎46‎ ‎PM To: dev@cordova.apache.org guess so yea, great first patch Martin ;) On Wed, Dec 1

Re: Browserify JS is in

2014-12-14 Thread Carlos Santana
This is the part that I like the most: "and start writing plugins as proper node modules. Maybe even push them to npm and manage dependencies that way." Agree with having less XHR, and concatenate cordova + plugins. Not in love with cordova_plugins.js to know what plugins are included in the app,

[GitHub] cordova-plugin-geolocation pull request: Wrong parameter in Firefo...

2014-12-14 Thread DrJojo
Github user DrJojo commented on the pull request: https://github.com/apache/cordova-plugin-geolocation/pull/31#issuecomment-66934375 Sorry, but I'm new to git. The changes are now in a separate branch ([firefox-fix] (https://github.com/DrJojo/cordova-plugin-geolocation/tree/firefo