[GitHub] cordova-docs pull request: 3.4.x

2014-12-16 Thread Watabe08
Github user Watabe08 commented on the pull request: https://github.com/apache/cordova-docs/pull/230#issuecomment-67278180 Many grammatical mistakes in my sentences. Hope u guys are not fed up with them. Thanks for your advises. Helps a lot. Vitor. About the link yo

[GitHub] cordova-android pull request: Make JUnit tests to test pluggable w...

2014-12-16 Thread fujunwei
Github user fujunwei commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/140#discussion_r21949939 --- Diff: test/src/org/apache/cordova/test/splashscreen.java --- @@ -30,6 +32,8 @@ public void onCreate(Bundle savedInstanceState) { //

[GitHub] cordova-android pull request: Make JUnit tests to test pluggable w...

2014-12-16 Thread huningxin
Github user huningxin commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/140#discussion_r21949530 --- Diff: test/src/org/apache/cordova/test/splashscreen.java --- @@ -30,6 +32,8 @@ public void onCreate(Bundle savedInstanceState) { //

[GitHub] cordova-android pull request: Make JUnit tests to test pluggable w...

2014-12-16 Thread huningxin
Github user huningxin commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/140#discussion_r21949468 --- Diff: test/src/org/apache/cordova/test/errorurl.java --- @@ -22,12 +22,14 @@ Licensed to the Apache Software Foundation (ASF) under one im

[GitHub] cordova-android pull request: Make JUnit tests to test pluggable w...

2014-12-16 Thread huningxin
Github user huningxin commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/140#discussion_r21949451 --- Diff: test/src/org/apache/cordova/test/SabotagedActivity.java --- @@ -33,10 +34,9 @@ Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-android pull request: Make JUnit tests to test pluggable w...

2014-12-16 Thread huningxin
Github user huningxin commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/140#discussion_r21949465 --- Diff: test/src/org/apache/cordova/test/backgroundcolor.java --- @@ -33,5 +33,4 @@ public void onCreate(Bundle savedInstanceState) {

[GitHub] cordova-android pull request: Fix compile error when build multipl...

2014-12-16 Thread fujunwei
Github user fujunwei commented on the pull request: https://github.com/apache/cordova-android/pull/138#issuecomment-67268132 @clelland Can you reproduce this compiled error? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-android pull request: Make JUnit tests to test pluggable w...

2014-12-16 Thread fujunwei
GitHub user fujunwei opened a pull request: https://github.com/apache/cordova-android/pull/140 Make JUnit tests to test pluggable webview The JUnit tests can only test Android webView now, the XWalk is a pluggable webView, we want to reuse the tests to test the pluggable webView aft

Request for Code Review of plugin-file-transfer PR

2014-12-16 Thread Dmitry Blotsky
Hi all, If anyone familiar with the file transfer plugin has several minutes to spare, would they please be able to review and if acceptable to merge the pull request, https://github.com/apache/cordova-plugin-file-transfer/pull/55, regarding a cleanup of the file transfer plugin tests? The JIRA

[GitHub] cordova-plugin-dialogs pull request: Added support for the new "br...

2014-12-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/46 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-registry-web pull request: CB-8175 Expose Fire OS

2014-12-16 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-registry-web/pull/8 CB-8175 Expose Fire OS You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-registry-web fireos Alternatively you can revi

[GitHub] cordova-docs pull request: 3.4.x

2014-12-16 Thread ldeluca
Github user ldeluca commented on the pull request: https://github.com/apache/cordova-docs/pull/230#issuecomment-67206099 @sosahvictor @Watabe08 Victor is correct. The documentation for Cordova doesn't typically change significantly to where the entire thing is retranslated with each

Re: --list argument for CLI

2014-12-16 Thread Shazron
Welcome, and +1! On Tue, Dec 16, 2014 at 10:23 AM, Andrew Grieve wrote: > Sounds great! > > On Tue, Dec 16, 2014 at 4:55 AM, Jesse wrote: >> >> Yes to all of this, and welcome aboard! >> >> Cheers, >> Jesse >> >> > On Dec 15, 2014, at 3:22 PM, Murat Sutunc wrote: >> > >> > Hi all, >> > My nam

[GitHub] cordova-docs pull request: 3.4.x

2014-12-16 Thread sosahvictor
Github user sosahvictor commented on the pull request: https://github.com/apache/cordova-docs/pull/230#issuecomment-67203313 Hello Watabe. You can get a glance looking at this document, it shows the process of contributing translation work in CrowdIn. https://github.com/apache/

Re: Cordova 3.0 - getPicture crashing in android

2014-12-16 Thread Shazron
Hi, This is the list to discuss development of Cordova itself. For your situation, please file an issue at: http://issues.apache.org/jira/browse/CB ... so it can be tracked and evaluated by the devs, and you can be notified. Sign up here: https://issues.apache.org/jira/secure/Signup!default.jspa

Re: --list argument for CLI

2014-12-16 Thread Andrew Grieve
Sounds great! On Tue, Dec 16, 2014 at 4:55 AM, Jesse wrote: > > Yes to all of this, and welcome aboard! > > Cheers, > Jesse > > > On Dec 15, 2014, at 3:22 PM, Murat Sutunc wrote: > > > > Hi all, > > My name is Murat Sutunc, I'm part of the Visual Studio team @ Microsoft > and new to Cordova. >

Re: How to handle CSP for XHR in Cordova 4.0

2014-12-16 Thread Andrew Grieve
On Mon, Dec 15, 2014 at 8:19 PM, Chuck Lantz wrote: > > Near term, for Windows 8.0/8.1, a custom security policy is in place at > the platform level for store apps so CSP doesn't really apply there at the > moment. (And, to be really specific, CSP support is pretty limited in > IE10/11 focusing on

New Cordova Committer Nomination - Victor Sosa Herrera

2014-12-16 Thread Lisa Seacat DeLuca
Apache Cordova commiters~ I'd like to nominate Victor Sosa Herrera as a committer to Apache Cordova. As many of you are aware I have been the component owner for the Translation work for the past year. I felt it was important that another Cordova contributor understand the process for translati

Re: --list argument for CLI

2014-12-16 Thread Jesse
Yes to all of this, and welcome aboard! Cheers, Jesse > On Dec 15, 2014, at 3:22 PM, Murat Sutunc wrote: > > Hi all, > My name is Murat Sutunc, I'm part of the Visual Studio team @ Microsoft and > new to Cordova. > > I was looking at the Cordova Tooling Wiki at > (https://wiki.apache.org/c

[GitHub] cordova-wp8 pull request: Use the newer AppDeployCmd when availabl...

2014-12-16 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-wp8/pull/67#issuecomment-67134189 Can't repro CB-8060, but this code seems to be valid and works correct. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-wp8 pull request: CB-8139 WP8. Fix callback for plugins wi...

2014-12-16 Thread sgrebnov
Github user sgrebnov closed the pull request at: https://github.com/apache/cordova-wp8/pull/68 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-wp8 pull request: CB-8139 WP8. Fix callback for plugins wi...

2014-12-16 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-wp8/pull/68#issuecomment-67132056 I see this PR has been merged, thank you @purplecabbage ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

Re: [DISCUSS] Cordova-WP8 Release

2014-12-16 Thread Jesse
I have merged the pull request. I too would like to see a release to get this out as well, but I won't be able to participate, I am on vacation until January. @purplecabbage risingj.com On Mon, Dec 15, 2014 at 11:47 AM, Parashuram Narasimhan (MS OPEN TECH) < panar...@microsoft.com> wrote: > > Hi

[GitHub] cordova-wp8 pull request: NodeVersion 0.10.x

2014-12-16 Thread purplecabbage
Github user purplecabbage closed the pull request at: https://github.com/apache/cordova-wp8/pull/69 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] cordova-wp8 pull request: NodeVersion 0.10.x

2014-12-16 Thread purplecabbage
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-wp8/pull/69 NodeVersion 0.10.x Test You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-wp8 AppveyorNodeDep Alternatively you ca