[GitHub] cordova-docs pull request: CB-7983 Indicate that volume up and vol...

2015-01-07 Thread kant2002
GitHub user kant2002 opened a pull request: https://github.com/apache/cordova-docs/pull/255 CB-7983 Indicate that volume up and volume down button events supported on Android You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-docs pull request: CB-5116: Fix links

2015-01-07 Thread kant2002
GitHub user kant2002 opened a pull request: https://github.com/apache/cordova-docs/pull/256 CB-5116: Fix links Links to configuration description page fixed. You can merge this pull request into a Git repository by running: $ git pull https://github.com/kant2002/cordova-docs

[GitHub] cordova-docs pull request: CB-8259 Report error when generation fo...

2015-01-07 Thread kant2002
GitHub user kant2002 opened a pull request: https://github.com/apache/cordova-docs/pull/257 CB-8259 Report error when generation for language failed You can merge this pull request into a Git repository by running: $ git pull https://github.com/kant2002/cordova-docs CB-8259

Re: Thought on improving translation and docs

2015-01-07 Thread Andrey Kurdumov
One more speed improvement and https://github.com/apache/cordova-docs/pull/257 After that I only improve speed by movign joDoc-js inside our generation process, and start moving to Make-ish processing. Right now generation speed almos doubled, so I could concentrate on translation tools. If no

[GitHub] cordova-ios pull request: Fixed callbackFromNative

2015-01-07 Thread mdudek
GitHub user mdudek opened a pull request: https://github.com/apache/cordova-ios/pull/123 Fixed callbackFromNative NO_RESULT status was resolved as failure. This bug is there from Oct 14, 2014. You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-lib pull request: CB-8226 'cordova platform add' : Look up...

2015-01-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/140 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-contacts pull request: Windows phone contact picker...

2015-01-07 Thread Hurtyto
Github user Hurtyto commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/51#issuecomment-69142471 Sure. I will sign it as soon as possible then :) -Original Message- From: Jesse MacFadyen notificati...@github.com Sent:

Re: Thought on improving translation and docs

2015-01-07 Thread Andrey Kurdumov
@Marcel Thanks for feedback and don't worry you don't hurt me. What I want is to improve translation, and I want to double-check that any changes does not hurts in the final results. So this would be a lot of generation of ru-edge. I decide to take any low hanging fruit in the generation speed,

[GitHub] cordova-lib pull request: CB-8226 'cordova platform add' : Look up...

2015-01-07 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-lib/pull/140#issuecomment-69129747 Merged! However - after a closer look at the unit tests, I highly encourage you to try and refactor things so that the tests do not mock out private methods within

Re: Deprecation Wars: ICS vs Gingerbread

2015-01-07 Thread Andrew Grieve
I never test on gingerbread. My opinion is that devs that really need it can just use older Cordova versions, or can fight through the testing themselves. With multi-apk support in the play store, you could even use a different version of Cordova for gingerbread vs. ICS+ On Wed, Jan 7, 2015 at

[GitHub] cordova-ios pull request: [CB-8270] rename category methods for JS...

2015-01-07 Thread lingoer
GitHub user lingoer opened a pull request: https://github.com/apache/cordova-ios/pull/124 [CB-8270] rename category methods for JSON handling with a prefix. According to [Apple's

[GitHub] cordova-js pull request: Fixed callbackFromNative method

2015-01-07 Thread mdudek
GitHub user mdudek opened a pull request: https://github.com/apache/cordova-js/pull/98 Fixed callbackFromNative method NO_RESULT status was resolved as failure. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mdudek/cordova-js

[GitHub] cordova-ios pull request: Fixed callbackFromNative

2015-01-07 Thread mdudek
Github user mdudek commented on the pull request: https://github.com/apache/cordova-ios/pull/123#issuecomment-69145160 Thanks for info. I will fix it there... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-ios pull request: Fixed callbackFromNative

2015-01-07 Thread mdudek
Github user mdudek closed the pull request at: https://github.com/apache/cordova-ios/pull/123 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: Link java files

2015-01-07 Thread agrieve
GitHub user agrieve opened a pull request: https://github.com/apache/cordova-lib/pull/142 Link java files You can merge this pull request into a Git repository by running: $ git pull https://github.com/agrieve/cordova-lib link-java-files Alternatively you can review and

[GitHub] cordova-ios pull request: Fixed callbackFromNative

2015-01-07 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-ios/pull/123#issuecomment-69112909 You cannot fix this here. cordova.js is the output of https://github.com/apache/cordova-js --- If your project is set up for it, you can reply to this

Deprecation Wars: ICS vs Gingerbread

2015-01-07 Thread Joe Bowser
Hey So, 2015 is here, and we have the new Android Pie Chart: http://developer.android.com/about/dashboards/index.html#2015 Due to two percentage points on ICS and three on Gingerbread, we're stuck supporting these platforms for the near future, but it looks like we're in the bad spot of them

Re: [Vote] Tools Release Jan 6, 2015

2015-01-07 Thread Mark Koudritsky
+1 Tests: - npm install -g cordova@rc - Built and ran the default HelloWorld app on Android - ran coho verify-tags On Wed, Jan 7, 2015 at 4:27 PM, Andrew Grieve agri...@chromium.org wrote: +1 * Confirmed sigs hashes with `coho verify-archive` * Verified sha1s match tags with `coho

[GitHub] cordova-plugin-statusbar pull request: update docs for StatusBarBa...

2015-01-07 Thread cjpearson
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/20 update docs for StatusBarBackgroundColor The default value is no longer black. (CB-7486) You can merge this pull request into a Git repository by running: $ git pull

Re: Deprecation Wars: ICS vs Gingerbread

2015-01-07 Thread tommy-carlos williams
It seems to me that if we are only going to drop *one*, that it should be Gingerbread first, since it is a lower SDK version. How can an app support GB and *not* ICS? Having said that, I am also interested in the discussion of better numbers on usage than just the Play Store (even if my gut

Re: Deprecation Wars: ICS vs Gingerbread

2015-01-07 Thread Joe Bowser
I'm just mentioning it because my only Android 4.0.3 devices are an ASUS Transformer 2 tablet and a Motorola RAZR phone that did weird things to my computer when I tried installing the extra software to upgrade it. However, if we did deprecate 2.3, I can just flash 4.0.3 on the Nexus S and use

Re: Deprecation Wars: ICS vs Gingerbread

2015-01-07 Thread Joe Bowser
Also, who actually tests on Gingerbread? Please comment on this thread. On Wed Jan 07 2015 at 5:09:49 PM Joe Bowser bows...@gmail.com wrote: I'm just mentioning it because my only Android 4.0.3 devices are an ASUS Transformer 2 tablet and a Motorola RAZR phone that did weird things to my

Re: Reviewboard

2015-01-07 Thread Joe Bowser
What's reviewboard? j/k, yeah kill it! On Wed Jan 07 2015 at 1:13:55 PM Andrew Grieve agri...@chromium.org wrote: Anyone still interested in using ReviewBoard? I feel like we gave it a decent shot, but github pull requests are working better. If no one objects, I'm going to delete the

Reviewboard

2015-01-07 Thread Andrew Grieve
Anyone still interested in using ReviewBoard? I feel like we gave it a decent shot, but github pull requests are working better. If no one objects, I'm going to delete the .reviewboardrc files from the repos and update https://github.com/apache/cordova-coho/blob/master/docs/code-reviews.md

[GitHub] cordova-plugin-vibration pull request: index.md(jp)

2015-01-07 Thread HirofumiTamori
GitHub user HirofumiTamori opened a pull request: https://github.com/apache/cordova-plugin-vibration/pull/32 index.md(jp) Correct Japanese Translation You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-cli pull request: CB-7950 CLI make CordovaCliCreate.protot...

2015-01-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/201 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-cli pull request: CB-7950 CLI make CordovaCliCreate.protot...

2015-01-07 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-cli/pull/201 CB-7950 CLI make CordovaCliCreate.prototype.run vaguely correct You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-cli cb_7950

[GitHub] cordova-cli pull request: CB-5316 Spell Cordova as a brand unless ...

2015-01-07 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-cli/pull/202 CB-5316 Spell Cordova as a brand unless it's a command or script * Change `cordova command` to `cordova-cli command` to match the rest of the file * Change `cordova library` to `Cordova

[GitHub] cordova-cli pull request: CB-5316 Spell Cordova as a brand unless ...

2015-01-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/202 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [Vote] Tools Release Jan 6, 2015

2015-01-07 Thread Andrew Grieve
+1 * Confirmed sigs hashes with `coho verify-archive` * Verified sha1s match tags with `coho verify-tags` * Re-created archives to ensure contents match release candidate (did so for cordova-js and cordova-cli) On Tue, Jan 6, 2015 at 8:46 PM, Steven Gill stevengil...@gmail.com wrote: Please

Re: Reviewboard

2015-01-07 Thread Jesse
Yeah, kill it. gh-pulls are much easier to review I think. @purplecabbage risingj.com On Wed, Jan 7, 2015 at 1:14 PM, Joe Bowser bows...@gmail.com wrote: What's reviewboard? j/k, yeah kill it! On Wed Jan 07 2015 at 1:13:55 PM Andrew Grieve agri...@chromium.org wrote: Anyone still

[GitHub] cordova-lib pull request: CB-8226 'cordova platform add' : Look up...

2015-01-07 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/140#issuecomment-69095149 @agrieve, have you had a chance to take another look at this ? --Thanks. --- If your project is set up for it, you can reply to this email and have your reply

Cordova-Android 3.7.0 and 4.0.x releases.

2015-01-07 Thread Joe Bowser
Hey Do we have a 3.7.0 branch ready yet? I want us to get that ready and merge the 4.0.x stuff into the master branch once we get 3.7.0 out. That way we can finally go back to having a regular dev process. Are people opposed to us merging the 4.0.x branch into master once we release 3.7.x and

RE: How to test the cordova-android 4.0 by mobile spec

2015-01-07 Thread Fu, Junwei
Thank you very much, it's fine after update your commit. Is the mobilespec being tested for Cordova 4.0, Because there are still some other issue such as the splash screen can't show in splashscreen manual tests. -Original Message- From: agri...@google.com [mailto:agri...@google.com]

Re: Deprecation Wars: ICS vs Gingerbread

2015-01-07 Thread Brian LeRoux
I say we go 4.x all in and drop everything below. Time to draw a line. On Wed, Jan 7, 2015, 6:24 PM Joe Bowser bows...@gmail.com wrote: Also, who actually tests on Gingerbread? Please comment on this thread. On Wed Jan 07 2015 at 5:09:49 PM Joe Bowser bows...@gmail.com wrote: I'm just

Re: Deprecation Wars: ICS vs Gingerbread

2015-01-07 Thread Brian LeRoux
! On Wed, Jan 7, 2015, 6:49 PM tommy-carlos williams to...@devgeeks.org wrote: -- tommy-carlos williams On 8 January 2015 at 12:37:59, Brian LeRoux (b...@brian.io) wrote: I say we go 4.x all in and drop everything below. Time to draw a line. On Wed, Jan 7, 2015, 6:24 PM Joe Bowser

Re: Deprecation Wars: ICS vs Gingerbread

2015-01-07 Thread Joe Bowser
Those stickers are old! I don't go to Android conferences, sine Android devs hate us these days. On Wed Jan 07 2015 at 5:53:04 PM Brian LeRoux b...@brian.io wrote: ! On Wed, Jan 7, 2015, 6:49 PM tommy-carlos williams to...@devgeeks.org wrote: -- tommy-carlos williams On 8 January 2015

Re: Deprecation Wars: ICS vs Gingerbread

2015-01-07 Thread tommy-carlos williams
I know they are old, but I have always wanted one, heh. --  tommy-carlos williams On 8 January 2015 at 12:54:24, Joe Bowser (bows...@gmail.com) wrote: Those stickers are old! I don't go to Android conferences, sine Android devs hate us these days. On Wed Jan 07 2015 at 5:53:04 PM Brian

[GitHub] cordova-lib pull request: Tizen Support

2015-01-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/47 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-5082 [cordova info] Add support for B...

2015-01-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: For platform downloads, support git clon...

2015-01-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: Breaking src into submodules

2015-01-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/62 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: Adding tizen support

2015-01-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-6661 Add platform 'web server' to cor...

2015-01-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/22 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-7067 run jasmine tests individually

2015-01-07 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-lib/pull/51#issuecomment-69127345 What's the status of this. Leave open? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-lib pull request: CB-8043 CB-6462 CB-6105 Refactor orienta...

2015-01-07 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-lib/pull/128#issuecomment-69127706 Think this looks good to me. If you're ready for it to go in, could you attempt to rebase it ontop of master and squash your commits? --- If your project is set up

[GitHub] cordova-blackberry pull request: CB-7807 Add BlackBerry10 platform...

2015-01-07 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-blackberry/pull/179 CB-7807 Add BlackBerry10 platform to a project on any workstation OS * Split init reqs checks out of init * Consistently use CORDOVA_DIR (instead of occasionally using BIN_DIR)

[GitHub] cordova-plugin-media-capture pull request: CB-7977 Mention devicer...

2015-01-07 Thread jsoref
GitHub user jsoref reopened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/29 CB-7977 Mention deviceready in plugin docs You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-media-capture pull request: CB-7977 Mention devicer...

2015-01-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-docs pull request: CB-8261 Brand: BlackBerry

2015-01-07 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-docs/pull/258 CB-8261 Brand: BlackBerry You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-docs blackberry Alternatively you can review and

[GitHub] cordova-docs pull request: CB-8261 Brand: BlackBerry

2015-01-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/258 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

picking up task in JIRA

2015-01-07 Thread Kinzie, Alan
Yesterday I created an issue in JIRA (https://issues.apache.org/jira/browse/CB-8253) intending to pick it up myself and start working on it. But I find that I can't assign it to myself. Do I need someone else to assign it to me or am I missing something obvious? Thanks, Alan

[GitHub] cordova-plugin-contacts pull request: Windows phone contact picker...

2015-01-07 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/51#issuecomment-69064486 Yeah, we can't accept the code without a signed CLA on file. It'll wait. --- If your project is set up for it, you can reply to this email and

Re: How to test the cordova-android 4.0 by mobile spec

2015-01-07 Thread Andrew Grieve
Went to try this out and decided it's a bad idea. Much better is to just fix createmobilespec.js to use the proper platform versions when generating the .js. I've done this and checked it in. On Wed, Jan 7, 2015 at 10:45 AM, Andrew Grieve agri...@chromium.org wrote: Hmm, I hadn't tried the key

[GitHub] cordova-cli pull request: CB-7739 document installing specific ver...

2015-01-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/195 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: How to test the cordova-android 4.0 by mobile spec

2015-01-07 Thread Andrew Grieve
Hmm, I hadn't tried the key event manual tests with 4.0.x in MS. I do think that would break based on the version being MSTEST, since there is now code to make an exec() to CoreAndroid based on the platformVersion. Maybe let's just set the plugin bridge name back to App on 4.0.x so that the js

[GitHub] cordova-lib pull request: CB-8226 'cordova platform add' : Look up...

2015-01-07 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/140#issuecomment-69056950 travis-ci failure not related to my changes. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your