[GitHub] cordova-mobile-spec pull request: CB-8131 Rewrote non plugin auto ...

2015-01-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-mobile-spec/pull/113 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-mobile-spec pull request: CB-7713 Add new-style tests when...

2015-01-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-mobile-spec/pull/110 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

Re: platforms/plugins save and restore from config.xml

2015-01-17 Thread Andrew Grieve
Both proposals are sounding quite good to me at this point! There's merit to both for sure. I left a few more comments, but the only one I actually feel strongly about is about storing .fetch.json for platforms within the existing platform.json files rather than a separate file. On Thu, Jan 15, 20

[GitHub] cordova-lib pull request: CB-8239 Add support for git urls to 'cor...

2015-01-17 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/148#discussion_r23130176 --- Diff: cordova-lib/spec-cordova/util.spec.js --- @@ -183,4 +184,138 @@ describe('util module', function() { expect(res.indexOf('CVS'))

[GitHub] cordova-lib pull request: CB-8239 Add support for git urls to 'cor...

2015-01-17 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/148#discussion_r23130172 --- Diff: cordova-lib/spec-cordova/util.spec.js --- @@ -183,4 +184,138 @@ describe('util module', function() { expect(res.indexOf('CVS'))

[GitHub] cordova-lib pull request: CB-8239 Add support for git urls to 'cor...

2015-01-17 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/148#discussion_r23130079 --- Diff: cordova-lib/src/cordova/lazy_load.js --- @@ -284,4 +286,47 @@ function custom(platforms, platform) { }); } +// Returns a

[GitHub] cordova-lib pull request: CB-8239 Add support for git urls to 'cor...

2015-01-17 Thread agrieve
Github user agrieve commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/148#discussion_r23130053 --- Diff: cordova-lib/src/cordova/lazy_load.js --- @@ -284,4 +286,47 @@ function custom(platforms, platform) { }); } +// Returns a

[GitHub] cordova-docs pull request: CB-8259 Report error when generation fo...

2015-01-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/257 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: CB-5116: Fix links

2015-01-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/256 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: CB-7983 Indicate that volume up and vol...

2015-01-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/255 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i