[GitHub] cordova-lib pull request: CB-8227 CB8237 CB-8238 Add --save option...

2015-02-02 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-72538019 @gorkem I''m planning on adding corresponding PR's for plugins. --- If your project is set up for it, you can reply to this email and have your reply appear on

Cordova-Android 3.7.0 Blog Post

2015-02-02 Thread Joe Bowser
Hey I pushed a commit to the repo, if we could get some pull requests on this for updates, that would be great, otherwise we should probably publish this in the next 24 hours. https://github.com/cordova/apache-blog-posts/commit/ca282a120923bcca9bb3c0ab3d9ca11781ff78f8 Thanks Joe

[GitHub] cordova-mobile-spec pull request: [CB-5183] Put the node executabl...

2015-02-02 Thread dblotsky
Github user dblotsky closed the pull request at: https://github.com/apache/cordova-mobile-spec/pull/116 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

RE: Build signed archives using CLI

2015-02-02 Thread Mefire O .
+1 for having an additional file to abstract away all the platform specific stuff. Currently, we support both gradle and ant for android for example, I think it wouldn't make sense for end-users to have to change their specs depending on what specific tool is used behind the scenes. Maybe we

[GitHub] cordova-lib pull request: CB-8227 CB8237 CB-8238 Add --save option...

2015-02-02 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-72536563 @gorkem, I agree with doing the save if config_json has an auto_save option. that's what I was working on adding, unless you want to take it on. :) --- If your

JavaScript comment tags in FileSystem plugin distort, www/*.js: What tool are they designed for?

2015-02-02 Thread Joe Malin
Greetings! I’m looking at the JavaScript libraries distributed in the FileSystem plugin, org.apache.cordova.file, www/*.js, such as FileEntry.js. They contain comments and @ tag descriptors. What tool are they aimed at? They don’t seem to be for YUIdoc, since most of them don’t contain the

[GitHub] cordova-mobile-spec pull request: [CB-5183] Put the node executabl...

2015-02-02 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/116 [CB-5183] Put the node executable invocation in quotes. Fixing the problem with running `createmobilespec.js` when there are spaces in the path to `node`. You can merge this pull

[GitHub] cordova-mobile-spec pull request: [CB-5183] Put the node executabl...

2015-02-02 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/117 [CB-5183] Put the node executable invocation in quotes. Fixing the problem with running `createmobilespec.js` when there are spaces in the path to `node`. You can merge this pull

[GitHub] cordova-lib pull request: CB-8227 CB8237 CB-8238 Add --save option...

2015-02-02 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-72537095 No, just go ahead.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-windows pull request: CB-8400 enable jshint for windows pl...

2015-02-02 Thread muratsu
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-windows/pull/57 CB-8400 enable jshint for windows platform - Created a `npm run jshint` command integrate into `npm run test` - Created jshint rules files for spec and rest of the repo - Added

[GitHub] cordova-lib pull request: CB-8239 Add support for git urls to 'cor...

2015-02-02 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/141#issuecomment-72557870 I think we don't need this anymore as the functionality this PR wanted to introduce has already been included here :

[GitHub] cordova-plugin-contacts pull request: CB-8395 marked unsupported t...

2015-02-02 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/55 CB-8395 marked unsupported tests pending on wp8 This fixes https://issues.apache.org/jira/browse/CB-8395 You can merge this pull request into a Git repository by running: $

[GitHub] cordova-plugin-test-framework pull request: CB-8385 Ensure plugin-...

2015-02-02 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/10 CB-8385 Ensure plugin-test-framework trigger tests only once https://issues.apache.org/jira/browse/CB-8385 Simplified medic config loading logic by making it synch =

[GitHub] cordova-plugin-globalization pull request: CB-8394 - included wind...

2015-02-02 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-globalization/pull/35 CB-8394 - included windows and wp8 quirks into tests This is a fix for https://issues.apache.org/jira/browse/CB-8394 The idea is to split failing tests into two parts

[GitHub] cordova-plugin-device-motion pull request: Returning an OK PluginR...

2015-02-02 Thread jlkalberer
GitHub user jlkalberer opened a pull request: https://github.com/apache/cordova-plugin-device-motion/pull/25 Returning an OK PluginResult.Status when starting If a status of `No_Result` is returned the plugin will not work when using `navigator.accelerometer.watchAcceleration` on

RE: cordova-android 4.0 JUnit tests

2015-02-02 Thread Hu, Ningxin
Hi Joe, That's part of it. What's the setup code for that look like? https://github.com/crosswalk-project/crosswalk/blob/master/runtime/android/core_shell/src/org/xwalk/core/xwview/shell/XWalkViewSectionFragment.java#L40 Thanks, -ningxin On Wed Jan 28 2015 at 7:15:10 PM Hu, Ningxin

Re: JavaScript comment tags in FileSystem plugin distort, www/*.js: What tool are they designed for?

2015-02-02 Thread Andrew Grieve
I'm fairly certain that they've never been run through a tool :S On Mon, Feb 2, 2015 at 4:27 PM, Joe Malin jma...@exou.com wrote: Greetings! I’m looking at the JavaScript libraries distributed in the FileSystem plugin, org.apache.cordova.file, www/*.js, such as FileEntry.js. They contain

[GitHub] cordova-lib pull request: CB-8390 android: Make framework custom=...

2015-02-02 Thread agrieve
GitHub user agrieve opened a pull request: https://github.com/apache/cordova-lib/pull/158 CB-8390 android: Make framework custom=false to work with Gradle You can merge this pull request into a Git repository by running: $ git pull https://github.com/agrieve/cordova-lib

[GitHub] cordova-lib pull request: CB-6973 Add spec-plugman to jshint

2015-02-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/157 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [DISCUSS] Tools Release

2015-02-02 Thread Steven Gill
Issue created: https://issues.apache.org/jira/browse/CB-8398 On Thu, Jan 29, 2015 at 5:01 PM, Steven Gill stevengil...@gmail.com wrote: We need to do a tools release with android 3.7.0 pinned as default. Any other PRS we should look at squeezing in before the release? I'm planning on

[GitHub] cordova-lib pull request: CB-8227 CB8237 CB-8238 Add --save option...

2015-02-02 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-72536059 @omefire Do you have a corresponding PR for plugins? Do you plan to create one? --- If your project is set up for it, you can reply to this email and have your

Re: Usage of jscs JSHint in Cordova

2015-02-02 Thread Murat Sutunc
Now that cordova-lib is done, I'm considering extending the jshint support to individual platforms. Any concerns or thoughts? On Jan 21, 2015, at 5:23 PM, Mark Koudritsky kam...@google.com wrote: On Wed, Jan 21, 2015 at 5:47 PM, Murat Sutunc mura...@microsoft.com wrote: I can take a look

Re: Plugin management ?

2015-02-02 Thread Gorkem Ercan
We have cordova save plugins and cordova restore plugins commmands that saves/restores from config.xml [1]. They are considered experimental but we are in the process of moving the functionality to their permanent locations. [1]

Re: Cordova Android plugin with a maven dependency?

2015-02-02 Thread Ian Clelland
Hi Brien, Are you building with Gradle, or with Ant? The new Gradle build system has the ability to do that -- it's what I've been using for the Crosswalk plugin. You can see how it's done in the GitHub repo at https://github.com/clelland/cordova-crosswalk-engine , but basically, the plugin.xml

Re: JavaScript comment tags in FileSystem plugin distort, www/*.js: What tool are they designed for?

2015-02-02 Thread Jesse
They are informational, the only docs we 'own' for the file api. Supposedly they were based on the original File-API spec[1], which is why you see DOMString as a type. [1] http://dev.w3.org/2006/webapi/FileAPI/ @purplecabbage risingj.com On Mon, Feb 2, 2015 at 6:02 PM, Andrew Grieve

[GitHub] cordova-lib pull request: CB-8390 android: Make framework custom=...

2015-02-02 Thread agrieve
Github user agrieve closed the pull request at: https://github.com/apache/cordova-lib/pull/158 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: Usage of jscs JSHint in Cordova

2015-02-02 Thread Andrew Grieve
I find the jshint task super helpful when making changes to cordova-lib. Would love it if it appeared in the platforms as well! On Mon, Feb 2, 2015 at 12:17 PM, Murat Sutunc mura...@microsoft.com wrote: Now that cordova-lib is done, I'm considering extending the jshint support to individual

[GitHub] cordova-lib pull request: CB-6973 Add spec-plugman to jshint

2015-02-02 Thread muratsu
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-lib/pull/157 CB-6973 Add spec-plugman to jshint -Added the base rules for spec-plugman -Fixed all the existing issues -Make automation include spec-plugman You can merge this pull request into a