RE: [DISCUSS] Cordova-Android 4.0.0 Release

2015-02-03 Thread Fu, Junwei
Crosswalk engine have been tested in mobile-spec and owned functionality tests with Crosswalk-11, and it was our plan to be released. I request a PR in here https://github.com/MobileChromeApps/cordova-crosswalk-engine/pull/17. Thanks, Junwei. -Original Message- From:

Re: [DISCUSS] cordova-ios 3.8.0 release

2015-02-03 Thread Andrew Grieve
I know you've been single-handing iOS lately, so thanks for your hard work Shaz! Your list sounds well thought-out, and I've not got anything to add other than +1! On Tue, Feb 3, 2015 at 8:42 PM, Shazron shaz...@gmail.com wrote: Bug fix release. The two major fixes that are already in are:

[GitHub] cordova-wp8 pull request: CB-8412

2015-02-03 Thread muratsu
Github user muratsu commented on the pull request: https://github.com/apache/cordova-wp8/pull/75#issuecomment-72776758 We were previously using sync exec with shelljs. Looks like it was causing a time out as noted

[Vote] 3.7.1 Android Release

2015-02-03 Thread Andrew Grieve
Please review and vote on this 3.5.0 Android Release. Release issue: https://issues.apache.org/jira/browse/CB-8415 Repos ready to be released have been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-8415 The package was published from its corresponding git tag:

Travis config for cordova-android

2015-02-03 Thread Murat Sutunc
Hi, Does anyone know what's required to make travis pick up PRs from cordova-android master branch? The travis.yml file seems to be in place but looks like it's currently not in use. It would like to fix this. Thanks, Murat

[GitHub] cordova-lib pull request: CB-8227 CB-8237 CB-8238 Add --save optio...

2015-02-03 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-72790912 appveyor failed because Build execution time has reached the maximum allowed time for your plan (40 minutes). --- If your project is set up for it, you can reply

[GitHub] cordova-plugin-test-framework pull request: CB-8385 Ensure plugin-...

2015-02-03 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/10#discussion_r24058292 --- Diff: www/medic.js --- @@ -35,30 +35,27 @@ exports.log = function() { }; exports.load = function (callback) {

Re: Crowdin and translation process

2015-02-03 Thread Victor Sosa
Hello community. So that everybody is aware about the proceedings on this topic. Andrey and I just had a quick call about this topic and here the agreement We want to still continue using Crowdin as our tool for automatic translation, but we do acknowledge the problems depicted on this thread

[GitHub] cordova-plugin-inappbrowser pull request: Added editablelocation o...

2015-02-03 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/73#issuecomment-72804585 I think you can install it with: cordova plugin add https://github.com/tgalal/cordova-plugin-inappbrowser.git --- If your project is set up

Pending PRs for browser platform

2015-02-03 Thread Vladimir Kotikov (Akvelon)
Hi all. Could anyone please review/merge the following pending pull requests, aimed to add support for browser platform: https://github.com/apache/cordova-plugin-globalization/pull/33 https://github.com/apache/cordova-plugin-splashscreen/pull/34

[GitHub] cordova-windows pull request: CB-8400 enable jshint for windows pl...

2015-02-03 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/57#issuecomment-72660381 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-file-transfer pull request: CB-8095 Adds support fo...

2015-02-03 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/53#issuecomment-72664197 @purplecabbage Is any news here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-lib pull request: CB-8406 BugFix: 'cordova platform update...

2015-02-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/159 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

RE: cordova-android 4.0 JUnit tests

2015-02-03 Thread Hu, Ningxin
Hi Joe, OK, and how do you set that up so that it has the Cordova APIs? This code is from Crosswalk shell which does nothing with Cordova API. However, crosswalk downstream fork of cordova-android is using inheritance as:

[GitHub] cordova-lib pull request: CB-8227 CB-8237 CB-8238 Add --save optio...

2015-02-03 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-72642865 I have made the following modifications : - added support for autosave as suggested by Gorkem - refactored --save feature to blend into the new code -

[GitHub] cordova-plugin-inappbrowser pull request: Added editablelocation o...

2015-02-03 Thread akreienbring
Github user akreienbring commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/73#issuecomment-72641732 Hello, i think there is an issue on this: https://issues.apache.org/jira/browse/CB-5772 But it was closed a year ago with won't fix.

[GitHub] cordova-cli pull request: CB-8227 CB-8237 CB-8238 Add --save optio...

2015-02-03 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-cli/pull/203#issuecomment-72644631 @jsoref , thanks! space issue fixed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: Cordova-Android 3.7.0 Blog Post

2015-02-03 Thread Michal Mocny
Its nice when people have a place to look up what changed when they notice a new version is out. (Also, when we do a tools release and updated pinned platforms, we can point back to these posts). Additionally, some of our users have come to this list asking for a blog post just recently, so its

[GitHub] cordova-lib pull request: CB-8406 BugFix: 'cordova platform update...

2015-02-03 Thread omefire
GitHub user omefire opened a pull request: https://github.com/apache/cordova-lib/pull/159 CB-8406 BugFix: 'cordova platform update' should not be upgrading the pl... CB-8406: -'cordova platform update' updates platform to the version in config.xml instead of to the pinned

[GitHub] cordova-lib pull request: CB-8239 Add support for git urls to 'cor...

2015-02-03 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/148#issuecomment-72642965 Here's a pull request for the fix of the afore-mentionned bug : https://github.com/apache/cordova-lib/pull/159 --- If your project is set up for it, you can reply

[GitHub] cordova-lib pull request: CB-8239 Add support for git urls to 'cor...

2015-02-03 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/148#issuecomment-72637685 Hey @agrieve, It seems like the refactoring you did before merging this in introduced a bug : Suppose the latest android version is: 3.7.0 and my project

RE: [GitHub] cordova-coho pull request: CB-8375 Improve windows support for for...

2015-02-03 Thread Murat Sutunc
Can someone take a look at this PR? Thanks, Murat -Original Message- From: muratsu [mailto:g...@git.apache.org] Sent: Wednesday, January 28, 2015 3:57 PM To: dev@cordova.apache.org Subject: [GitHub] cordova-coho pull request: CB-8375 Improve windows support for for... GitHub user

Re: Cordova-Android 3.7.0 Blog Post

2015-02-03 Thread Andrew Grieve
Did some pruning: https://github.com/cordova/apache-blog-posts/pull/30 On Tue, Feb 3, 2015 at 8:55 AM, Michal Mocny mmo...@chromium.org wrote: Its nice when people have a place to look up what changed when they notice a new version is out. (Also, when we do a tools release and updated pinned

Re: Cordova-Android 3.7.0 Blog Post

2015-02-03 Thread Joe Bowser
I'm pretty sure a lot of the API and gradle changes were important to leave in there, but I still accepted it because I just want to move on. :P On Tue Feb 03 2015 at 9:55:30 AM Andrew Grieve agri...@chromium.org wrote: Did some pruning: https://github.com/cordova/apache-blog-posts/pull/30 On

Re: JavaScript comment tags in FileSystem plugin distort, www/*.js: What tool are they designed for?

2015-02-03 Thread Joe Malin
Noted. Would it make sense to submit the comments I’ve done. I have them working in JSDoc, and it would be simple for me to set them up so they work in YUIdoc as well. Joe Joe Malin Senior Technical Writer EXO U, Inc. Palo Alto, CA, USA jma...@exou.com -Original Message-

Re: Pending PRs for browser platform

2015-02-03 Thread Steven Gill
I will try to take a look at them this afternoon. -Steve On Tue, Feb 3, 2015 at 6:54 AM, Vladimir Kotikov (Akvelon) v-vlk...@microsoft.com wrote: Hi all. Could anyone please review/merge the following pending pull requests, aimed to add support for browser platform:

[GitHub] cordova-lib pull request: CB-8409 compile: bubble failures

2015-02-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/160 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

RE: Pending PRs for browser platform

2015-02-03 Thread Vladimir Kotikov (Akvelon)
Thanks, Steve. --- Best regards, Vladimir -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Tuesday, February 3, 2015 10:17 PM To: dev@cordova.apache.org Subject: Re: Pending PRs for browser platform I will try to take a look at them this afternoon.

Re: Cordova-Android 3.7.0 Blog Post

2015-02-03 Thread Graham Mueller
I don't really think any of our users actually read this Hey, user here -- just wanted to say that I do read and rely on these notes as a way to judge what's part of the release. It doesn't have to be a full blog, but we (users) need some form of release notes, so that we can see and understand

Re: Cordova-Android 3.7.0 Blog Post

2015-02-03 Thread Josh Soref
I fixed a spelling typo: https://github.com/cordova/apache-blog-posts/pull/31 It's definitely much more readable. And thanks to the people who report that they read it. That was very valuable feedback :) On 2/3/15, 12:54 PM, Andrew Grieve agri...@chromium.org wrote: Did some pruning:

Re: [DISCUSS] Cordova-Android 4.0.0 Release

2015-02-03 Thread Darryl Pogue
I just remembered that there should be a plugins release before Android 4.0.0 goes out because of the moving of the splashscreen logic out of the platform and into the plugin. As far as I can tell, that's still unreleased. - To

Re: [DISCUSS] Cordova-Android 4.0.0 Release

2015-02-03 Thread Andrew Grieve
And, of course, for your FileTransfer change :P I just last night finished up the fixing of framework custom=false for gradle-based builds, so we're certainly nearing the finish line for 4.0.0 known issues. Of the list from before, only remaining are: - Ian's been working on getting crosswalk

[GitHub] cordova-lib pull request: CB-8409 compile: bubble failures

2015-02-03 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-lib/pull/160 CB-8409 compile: bubble failures You can merge this pull request into a Git repository by running: $ git pull https://github.com/jsoref/cordova-lib cb_8409 Alternatively you can review

[GitHub] cordova-plugin-file-transfer pull request: CB-8095 Adds support fo...

2015-02-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/53 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

JIRA : permission to assign tasks to self

2015-02-03 Thread Mefire O .
Can someone please grant me permission to assign JIRA tasks to myself ? https://issues.apache.org/jira/browse/CB-8414 https://issues.apache.org/jira/browse/CB-8413 Thanks, Mefire

RE: Found a regression in cordova-android@3.7.0

2015-02-03 Thread Murat Sutunc
Looks like this fix broke `cordova build` for windows: :CordovaLib:compileDebugJava

[GitHub] cordova-plugin-device pull request: adds new property 'manufacture...

2015-02-03 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/20#issuecomment-72761694 I have decided to accept this pull request, and implement the windows/wp8 functions. The fact that the native api makes this information

[GitHub] cordova-plugin-device pull request: Support for Windows Phone 8 AN...

2015-02-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device/pull/26 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: JIRA : permission to assign tasks to self

2015-02-03 Thread Shazron
Assigned your userid into the appropriate role, and for those two issues. On Tue, Feb 3, 2015 at 3:11 PM, Mefire O. ommen...@microsoft.com wrote: Can someone please grant me permission to assign JIRA tasks to myself ? https://issues.apache.org/jira/browse/CB-8414

Re: Found a regression in cordova-android@3.7.0

2015-02-03 Thread Steven Gill
Nice catch. I will patiently wait until this is ready before I move on this release (release issue: https://issues.apache.org/jira/browse/CB-8415) On Tue, Feb 3, 2015 at 3:31 PM, Murat Sutunc mura...@microsoft.com wrote: Looks like this fix broke `cordova build` for windows:

[GitHub] cordova-android pull request: CB-8410 enable jshint for Android pl...

2015-02-03 Thread muratsu
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-android/pull/153 CB-8410 enable jshint for Android platform - Created a npm run jshint command integrate into npm run test - Created jshint rules files for spec and rest of the repo - Fixed all

Re: [iOS] Possible Cordova bug with WebSocket in plugin callback

2015-02-03 Thread Shazron
This could be related https://issues.apache.org/jira/browse/CB-2301 (a really old one) On Tue, Feb 3, 2015 at 8:58 AM, Edna Y Morales eymor...@us.ibm.com wrote: Hi all, I'm working on a bug that was reported for iOS (not through Jira), and I'm running out of ideas on figuring out what is

[GitHub] cordova-android pull request: CB-8410 enable jshint for Android pl...

2015-02-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/153 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Found a regression in cordova-android@3.7.0

2015-02-03 Thread Andrew Grieve
Regression: https://issues.apache.org/jira/browse/CB-8411 Already applied the fix to the 3.7.x branch (and to master). Question is whether we should skip pinning of 3.7.0, and go straight to 3.7.1? Wouldn't take much extra effort, but we should hold off the blog post though. The bug breaks

Re: cordova-android 4.0 JUnit tests

2015-02-03 Thread Joe Bowser
OK, and how do you set that up so that it has the Cordova APIs? On Mon Feb 02 2015 at 9:51:55 PM Hu, Ningxin ningxin...@intel.com wrote: Hi Joe, That's part of it. What's the setup code for that look like? https://github.com/crosswalk-project/crosswalk/blob/master/

Re: Cordova-Android 3.7.0 Blog Post

2015-02-03 Thread Joe Bowser
I don't really like how this is part of the release process at all, and the only reason that I'm doing it is because we have to for some reason. I don't really think any of our users actually read this, and I really just want to see this done so that it can't be used as an excuse to not ship

[GitHub] cordova-plugin-device pull request: adds new property 'manufacture...

2015-02-03 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/20#issuecomment-72762464 @basvanbeek Can you sign and submit an ICLA? http://cordova.apache.org/#contribute --- If your project is set up for it, you can reply to this

[GitHub] cordova-plugin-device pull request: adds new property 'manufacture...

2015-02-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device/pull/20 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-wp8 pull request: CB-8412

2015-02-03 Thread muratsu
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-wp8/pull/75 CB-8412 - Created a `npm run jshint` command integrate into `npm run test` - Created jshint rules files for spec and rest of the repo - Added node_module jshint to repo - Fixed all

Re: Found a regression in cordova-android@3.7.0

2015-02-03 Thread Joe Bowser
Is this an issue on master, or on 3.7.x. If it's only master, it shouldn't hold up the .1 release. Also, Andrew, you didn't even build before committing this? On Tue Feb 03 2015 at 3:38:25 PM Steven Gill stevengil...@gmail.com wrote: Nice catch. I will patiently wait until this is ready

Re: Found a regression in cordova-android@3.7.0

2015-02-03 Thread Joe Bowser
OK, I see what happened. I think we outsmarted ourselves. I'm going to revert the API change that Andrew and I talked about this morning, since it seems that's currently what's breaking on master. This is why we need to make sure we run a sanity check every time we do a commit, since we could

RE: JIRA : permission to assign tasks to self

2015-02-03 Thread Mefire O .
Thanks, Shazron. Thanks, Mefire -Original Message- From: Shazron [mailto:shaz...@gmail.com] Sent: Tuesday, February 3, 2015 3:21 PM To: dev@cordova.apache.org Cc: agri...@google.com Subject: Re: JIRA : permission to assign tasks to self Assigned your userid into the appropriate role,

[Review] Plugins Package.json

2015-02-03 Thread Steven Gill
Please review at https://github.com/stevengill/cordova-plugin-device/blob/npmpub/package.json You will notice that I added cordova-PLATFORM as a keyword. I have also kept the platforms tag for now. I can remove it but maybe we can find some future use for it. We currently need it when publising

Re: Found a regression in cordova-android@3.7.0

2015-02-03 Thread Joe Bowser
BTW: This works fine on 3.7.x, the issue was on master. I reverted CordovaActivity.java only so that master now builds again, but master and 4.0.x have now merged. We can proceed with doing a 3.7.1 release. On Tue Feb 03 2015 at 4:55:18 PM Joe Bowser bows...@gmail.com wrote: OK, I see what

Re: Found a regression in cordova-android@3.7.0

2015-02-03 Thread Steven Gill
Cool. Thanks for looking into this Joe. I will get the vote thread for 3.7.1 started tomorrow. -Steve On Tue, Feb 3, 2015 at 5:04 PM, Joe Bowser bows...@gmail.com wrote: BTW: This works fine on 3.7.x, the issue was on master. I reverted CordovaActivity.java only so that master now builds

Re: Found a regression in cordova-android@3.7.0

2015-02-03 Thread Joe Bowser
Was the plugin using public APIs? I'm fine with a 3.7.1, but I am less OK with calling this a regression if we never supported this. On Tue, 3 Feb 2015 1:38 pm Steven Gill stevengil...@gmail.com wrote: Okay, lets get android 3.7.1 vote started, update blog post for 3.7.1 and publish it when

Re: Found a regression in cordova-android@3.7.0

2015-02-03 Thread Steven Gill
Okay, lets get android 3.7.1 vote started, update blog post for 3.7.1 and publish it when vote is successful. Do tools release following completion of 3.7.1 vote with 3.7.1 pinned. On Tue, Feb 3, 2015 at 1:09 PM, Andrew Grieve agri...@chromium.org wrote: Regression:

[GitHub] cordova-lib pull request: CB-8227 CB-8237 CB-8238 Add --save optio...

2015-02-03 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-72743163 related PR: https://github.com/apache/cordova-cli/pull/203 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-cli pull request: CB-8227 CB-8237 CB-8238 Add --save optio...

2015-02-03 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-cli/pull/203#issuecomment-72743227 related PR: https://github.com/apache/cordova-lib/pull/144 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Re: Found a regression in cordova-android@3.7.0

2015-02-03 Thread Joe Bowser
BTW: The issue was that the patch made a change and CordovaActivity longer implemented the CordovaInterface, but still passed itself. I fixed it and re-added the code with some comments. I think that we really should have unit tests to make sure that we have a CordovaInterfaceImpl, since that

Re: [Review] Plugins Package.json

2015-02-03 Thread Andrew Grieve
From looking at it, only thought is whether we should put all of the non-standard fields into a cordova parent key. E.g.: { name: cordova-plugin-device, cordova: { id: org.apache.cordova.device, platforms: [...] } } Sounds like we need to re-write the file when publishing to CPR

Re: Found a regression in cordova-android@3.7.0

2015-02-03 Thread Andrew Grieve
Thanks for fixing this up for me Joe! Found this right at the end of the day and clearly did not compile it on master after merging :(. Lots on your plate release-wise Steve. I can take care of this one, and will hopefully look at doing a plugins release tomorrow as well since that's needed for

[DISCUSS] cordova-ios 3.8.0 release

2015-02-03 Thread Shazron
Bug fix release. The two major fixes that are already in are: 1. https://issues.apache.org/jira/browse/CB-8002 2.https://issues.apache.org/jira/browse/CB-8036 Others are here (post Oct 30th 2014): https://github.com/apache/cordova-ios/commits/master I've triaged all the iOS issues in JIRA,