[GitHub] cordova-lib pull request: CB-8227 CB-8237 CB-8238 Add --save optio...

2015-02-05 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-73197538 Hey @gorkem, I just tested 'cordova platform add https://github.com/apache/cordova-android.git --save', and it works for me. did you make sure to use two dashes inst

[GitHub] cordova-wp8 pull request: CB-8412

2015-02-05 Thread muratsu
Github user muratsu commented on the pull request: https://github.com/apache/cordova-wp8/pull/75#issuecomment-73196289 Hmm, who owns the test machine? I thought it was owned by infra, I couldn't find a way to configure it. It currently doesnt have Silverlight installed but looks like

[GitHub] cordova-wp8 pull request: CB-8412

2015-02-05 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-wp8/pull/75#issuecomment-73195925 Infra has nothing to do with appveyor other than setting up the github integration. --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-wp8 pull request: CB-8412

2015-02-05 Thread muratsu
Github user muratsu commented on the pull request: https://github.com/apache/cordova-wp8/pull/75#issuecomment-73194673 Turns out the build errors are unrelated. I'm seeing the following error on Appveyor console: `C:\Program Files (x86)\MSBuild\Microsoft\WindowsPhone\v8.0\Microsof

[GitHub] cordova-plugin-media pull request: Add Media.prototype.setRate met...

2015-02-05 Thread whitecolor
Github user whitecolor commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/40#discussion_r24225284 --- Diff: src/ios/CDVSound.m --- @@ -686,6 +714,7 @@ @implementation CDVAudioFile @synthesize resourcePath; @synthesize resourceURL;

[GitHub] cordova-lib pull request: CB-8227 CB-8237 CB-8238 Add --save optio...

2015-02-05 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-73172414 @omefire I am integrating your changes to mine to implement the full circle. One thing that I have noticed this does not support the url based case for instance the

[GitHub] cordova-lib pull request: CB-8227 CB-8237 CB-8238 Add --save optio...

2015-02-05 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-73156531 Hey @gorkem, the commits have been squashed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: Crosswalk-powered InAppBrowser plugin

2015-02-05 Thread Joe Bowser
It SHOULD be its own thing. InAppBrowser should always use the default Chromium present, and having customizable webviews in a plugin in a world where webviews are a plugin sounds like a recipe for disaster. I would be interested in seeing how dependency management could be dealt with in a post 4

Re: Crosswalk-powered InAppBrowser plugin

2015-02-05 Thread Brian LeRoux
could be its own thing but if it came under the actual inappbrowser that'd be cool too https://github.com/apache/cordova-plugin-inappbrowser On Thu, Feb 5, 2015 at 3:25 PM, Sidney Bofah wrote: > Hi all, > > my company recently required the availability of a high-performance > Android modal Web

Crosswalk-powered InAppBrowser plugin

2015-02-05 Thread Sidney Bofah
Hi all, my company recently required the availability of a high-performance Android modal WebView (that is, Chromium-based, disposable, free of memory leaks, etc.) in context of a Crosswalk-based Cordova/Ionic project. My research had shown that the widely used InAppBrowser plugin has not made

Re: Independent Platform Releases and JIRA

2015-02-05 Thread Shazron
For iOS, like you mentioned regarding filters, I use a filter on Component=iOS and FixVersion=3.8.0 for example. Still, not ideal. I did like Jesse mentioned, for wkwebview branch, a parent task with subtasks. JIRA has (Kanban?) boards available: https://issues.apache.org/jira/secure/ManageRapidVi

Re: Travis config for cordova-android

2015-02-05 Thread Shazron
You'll have to file an INFRA issue. See https://issues.apache.org/jira/browse/INFRA-9017 as an example On Tue, Feb 3, 2015 at 7:13 PM, Murat Sutunc wrote: > Hi, > Does anyone know what's required to make travis pick up PRs from > cordova-android master branch? > The travis.yml file seems to be i

Re: Publish cordova-android to npm

2015-02-05 Thread Andrew Grieve
cordova-android@3.7.1 published! On Thu, Feb 5, 2015 at 2:06 PM, Steven Gill wrote: > done! > > On Thu, Feb 5, 2015 at 6:52 AM, Andrew Grieve > wrote: > > > Looks like I'm not an owner for it in npm. Can someone add me? > > >

[GitHub] cordova-windows pull request: CB-8321 Add supported orientations c...

2015-02-05 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-windows/pull/56#issuecomment-73126603 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-browser pull request: CB-8182 - port 'cordova serve' to 'c...

2015-02-05 Thread kirkshoop
Github user kirkshoop commented on the pull request: https://github.com/apache/cordova-browser/pull/9#issuecomment-73123947 @nikhilkh I rebased on your changes in #8 Please take a look to see if it is ok. --- If your project is set up for it, you can reply to this email and have y

[GitHub] cordova-ios pull request: CB-8412 enable jshint for iOS platform

2015-02-05 Thread muratsu
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-ios/pull/129 CB-8412 enable jshint for iOS platform - Created a npm run jshint command & integrate into npm run test - Created jshint rules files for spec and rest of the repo - Fixed all jshint issu

node firefox

2015-02-05 Thread Steven Gill
This looks cool! https://hacks.mozilla.org/2015/02/introducing-node-firefox/ Should be able to support "cordova emulate firefoxos" with this. Wondering if any of our Mozilla contributors have plans for that? This can't launch on device right now I believe (unless I missed something)

[GitHub] cordova-plugin-camera pull request: Make dest NATIVE_URI compatibl...

2015-02-05 Thread boboldehampsink
Github user boboldehampsink commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/20#issuecomment-73113534 Any news on this? This has been bugging me for a while --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-medic pull request: Fix Windows suspension issue and print...

2015-02-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-medic pull request: Fix Windows suspension issue and print...

2015-02-05 Thread muratsu
Github user muratsu commented on the pull request: https://github.com/apache/cordova-medic/pull/28#issuecomment-73110592 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] cordova-plugin-media pull request: Add Media.prototype.setRate met...

2015-02-05 Thread spenceropope
Github user spenceropope commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/40#discussion_r24190296 --- Diff: src/ios/CDVSound.m --- @@ -686,6 +714,7 @@ @implementation CDVAudioFile @synthesize resourcePath; @synthesize resourceURL

[GitHub] cordova-medic pull request: Fix Windows suspension issue and print...

2015-02-05 Thread nikhilkh
GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-medic/pull/28 Fix Windows suspension issue and print summary of failing tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-medic

Re: Publish cordova-android to npm

2015-02-05 Thread Steven Gill
done! On Thu, Feb 5, 2015 at 6:52 AM, Andrew Grieve wrote: > Looks like I'm not an owner for it in npm. Can someone add me? >

[GitHub] cordova-medic pull request: Re-direct output of removing working d...

2015-02-05 Thread nikhilkh
GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-medic/pull/27 Re-direct output of removing working directory task I had a bug in my previous commit for this that I had updated on my local git but forgot to push. The issue is that rm.txt is getting place

[GitHub] cordova-lib pull request: CB-8227 CB-8237 CB-8238 Add --save optio...

2015-02-05 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-73100070 The single/double quote and jshintrc changes were showing as part of this pr. After the squash it is all okay. --- If your project is set up for it, you can r

[GitHub] cordova-plugin-inappbrowser pull request: CB-8432 Correct styles f...

2015-02-05 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/79 CB-8432 Correct styles for browser wrapper to display it correctly on some pages Fix for [CB-8432](https://issues.apache.org/jira/browse/CB-8432) * Force z-orde

[GitHub] cordova-lib pull request: CB-8227 CB-8237 CB-8238 Add --save optio...

2015-02-05 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-73092687 @purplecabbage , yes there were errors in the tests but those were not related to these changes and those tests only occasionally fail in appveyor while travis passe

[GitHub] cordova-lib pull request: CB-8227 CB-8237 CB-8238 Add --save optio...

2015-02-05 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-73092239 @agrieve , sorry. I ran into an issue with git refusing to do a rebase : http://stackoverflow.com/questions/14410421/git-rebase-merge-conflict-cannot-continue.

[GitHub] cordova-lib pull request: CB-8227 CB-8237 CB-8238 Add --save optio...

2015-02-05 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-73091506 The fact that the tests cannot run in the allotted 40 minutes means there is an error in the tests. I would dump all the jshintrc related commits into anoth

[GitHub] cordova-lib pull request: [ADD] GET attribute 'version' config.xml...

2015-02-05 Thread ramonornela
GitHub user ramonornela opened a pull request: https://github.com/apache/cordova-lib/pull/161 [ADD] GET attribute 'version' config.xml Restore Platform - Add attribute 'version' restore platform You can merge this pull request into a Git repository by running: $ git pull https:

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2015-02-05 Thread LanceEa
Github user LanceEa commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-73067401 I'm trying to upload some images to Azure Blob Storage and it doesn't seem to like the multipart-form. I would like to be able to upload using "imag

[GitHub] cordova-plugin-media pull request: CB-8428 Fix multiple `done()` c...

2015-02-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/44 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-plugin-media pull request: CB-8425 Media plugin .ctr: make...

2015-02-05 Thread sgrebnov
Github user sgrebnov closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/43 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-media pull request: CB-8425 Media plugin .ctr: make...

2015-02-05 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/43#issuecomment-73066354 tested and merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not h

[GitHub] cordova-lib pull request: CB-8227 CB-8237 CB-8238 Add --save optio...

2015-02-05 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-73062562 @omefire be sure to review yourself before asking someone else to. The "Files Changed" tab hardly even loads the diff is so big! --- If your project is set up for i

Publish cordova-android to npm

2015-02-05 Thread Andrew Grieve
Looks like I'm not an owner for it in npm. Can someone add me?

Re: [Vote] 3.7.1 Android Release

2015-02-05 Thread Andrew Grieve
The vote has now closed. The results are: Positive Binding Votes: 3 Andrew Grieve Joe Bowser Sergey Grebnov Negative Binding Votes: 0 The vote has passed. On Thu, Feb 5, 2015 at 7:18 AM, Sergey Grebnov (Akvelon) < v-seg...@microsoft.com> wrote: > I vote +1: > > • Verified archives and t

[GitHub] cordova-medic pull request: [INFRA-8588] Stability improvements fo...

2015-02-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/25 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-medic pull request: Re-direct output of removing working d...

2015-02-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/26 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

RE: [Vote] 3.7.1 Android Release

2015-02-05 Thread Sergey Grebnov (Akvelon)
I vote +1: • Verified archives and tags • Verified blank app: platform add, build, run • Run mobilespec autotests. -Sergey -Original Message- From: Joe Bowser [mailto:bows...@gmail.com] Sent: Thursday, February 5, 2015 2:48 AM To: dev Subject: Re: [Vote] 3.7.1 Android

[GitHub] cordova-plugin-geolocation pull request: Add missing module refere...

2015-02-05 Thread fredtitao
GitHub user fredtitao opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/36 Add missing module references for Android You can merge this pull request into a Git repository by running: $ git pull https://github.com/wingz-inc/cordova-plugin-geolocat

[GitHub] cordova-browser pull request: CB-8224: Add support to launch a spe...

2015-02-05 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-browser/pull/8 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-file pull request: CB-8090 Fixes incorrect error wh...

2015-02-05 Thread vladimir-kotikov
Github user vladimir-kotikov closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/92 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-file pull request: CB-8090 Fixes incorrect error wh...

2015-02-05 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/92#issuecomment-73034315 Nope, closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] cordova-plugin-media pull request: CB-7962 Adds browser platform s...

2015-02-05 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-media/pull/45 CB-7962 Adds browser platform support Implementation for [CB-7962](https://issues.apache.org/jira/browse/CB-7962) You can merge this pull request into a Git repository by runni

[GitHub] cordova-plugin-media-capture pull request: CB-7963 Adds support fo...

2015-02-05 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/31 CB-7963 Adds support for browser platform Implements [CB-7963](https://issues.apache.org/jira/browse/CB-7963) You can merge this pull request into a Git repository by r

[GitHub] cordova-ios pull request: CB-8084 conform AppDelegate.m with provi...

2015-02-05 Thread Mitko-Kerezov
GitHub user Mitko-Kerezov opened a pull request: https://github.com/apache/cordova-ios/pull/128 CB-8084 conform AppDelegate.m with provisioning profile Hide the two methods in AppDelegate.m for push notifications when provisioning profile doesn't include the push notifications se

[GitHub] cordova-ios pull request: CB-8084 conform AppDelegate.m with provi...

2015-02-05 Thread Mitko-Kerezov
Github user Mitko-Kerezov closed the pull request at: https://github.com/apache/cordova-ios/pull/127 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] cordova-plugin-device pull request: adds new property 'manufacture...

2015-02-05 Thread basvanbeek
Github user basvanbeek commented on the pull request: https://github.com/apache/cordova-plugin-device/pull/20#issuecomment-73009009 @purplecabbage ICLA signed and sent --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If y