[GitHub] cordova-plugin-file-transfer pull request: CB-8407 Fix downloading...

2015-02-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/63 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-file-transfer pull request: CB-8407 Fix downloading...

2015-02-06 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/63#issuecomment-73199798 Reviewed and tested - LGTM :ship: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

RE: [VOTE] Plugins Release

2015-02-06 Thread Alexander Sorokin (Akvelon)
Hi guys, I just wanted to let you know that there is a bug on windows in file transfer plugin in this release. It is related to recent changes in file plugin and it breaks download functionality on windows completely: https://issues.apache.org/jira/browse/CB-8407 The fix has been merged to

[GitHub] cordova-ios pull request: CB-8436 Remove unneeded when composin...

2015-02-06 Thread Fatme
GitHub user Fatme opened a pull request: https://github.com/apache/cordova-ios/pull/130 CB-8436 Remove unneeded when composing xcodebuild arguments Fixes https://issues.apache.org/jira/browse/CB-8436 You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-file-transfer pull request: CB-8407 Fix downloading...

2015-02-06 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/63 CB-8407 Fix downloading of ms-appdata:/// urls on Windows JIRA issue [CB-8407](https://issues.apache.org/jira/browse/CB-8407) download() in file-transfer

[GitHub] cordova-plugin-media pull request: Add Media.prototype.setRate met...

2015-02-06 Thread whitecolor
Github user whitecolor commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/40#issuecomment-73300979 Fixed it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-ios pull request: CB-8412 enable jshint for iOS platform

2015-02-06 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-ios/pull/129#issuecomment-73290860 The failing test is because your 'end-to-end list validation handles list parameter' test requires ios-sim which is not installed. Installation of ios-sim

[GitHub] cordova-ios pull request: CB-8412 enable jshint for iOS platform

2015-02-06 Thread muratsu
Github user muratsu commented on the pull request: https://github.com/apache/cordova-ios/pull/129#issuecomment-73293570 Seems like an artifact. The original design changed and that checkin was supposed to be reverted. I'll take a look --- If your project is set up for it, you can

[GitHub] cordova-ios pull request: CB-8084 conform AppDelegate.m with provi...

2015-02-06 Thread ligaz
Github user ligaz commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/128#discussion_r24230887 --- Diff: bin/templates/scripts/cordova/lib/push-notifications.js --- @@ -0,0 +1,82 @@ +(function () { +var fs = require('fs'), +

[GitHub] cordova-ios pull request: CB-8084 conform AppDelegate.m with provi...

2015-02-06 Thread ligaz
Github user ligaz commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/128#discussion_r24230911 --- Diff: bin/templates/scripts/cordova/lib/push-notifications.js --- @@ -0,0 +1,82 @@ +(function () { +var fs = require('fs'), +

[GitHub] cordova-medic pull request: Re-direct output of removing working d...

2015-02-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/27 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-media pull request: Add Media.prototype.setRate met...

2015-02-06 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/40#issuecomment-73211998 @synthesize player, volume, rate; OR @synthesize player, volume; @synthesize rate; --- If your project is set up for it, you can reply to

[GitHub] cordova-ios pull request: CB-8084 conform AppDelegate.m with provi...

2015-02-06 Thread ligaz
Github user ligaz commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/128#discussion_r24230792 --- Diff: bin/templates/scripts/cordova/lib/push-notifications.js --- @@ -0,0 +1,82 @@ +(function () { +var fs = require('fs'), +

[GitHub] cordova-wp8 pull request: CB-8412

2015-02-06 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-wp8/pull/75#issuecomment-73223016 This is an issue of AppVeyor itself and it should be [fixed now](http://help.appveyor.com/discussions/questions/921-support-for-silverlight-4-available). We

[GitHub] cordova-wp8 pull request: CB-8412

2015-02-06 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-wp8/pull/75#issuecomment-73208876 Not sure where you are seeing this error ... I see nothing in any of the failed build logs about Silverlight. --- If your project is set up for it, you can

[GitHub] cordova-wp8 pull request: CB-8412

2015-02-06 Thread muratsu
Github user muratsu commented on the pull request: https://github.com/apache/cordova-wp8/pull/75#issuecomment-73209662 On build 103 you can see this error message: https://ci.appveyor.com/project/Humbedooh/cordova-wp8/build/1.0.103 In order to see the failure, you have to pipe

[GitHub] cordova-ios pull request: CB-8084 conform AppDelegate.m with provi...

2015-02-06 Thread ligaz
Github user ligaz commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/128#discussion_r24230690 --- Diff: bin/templates/scripts/cordova/lib/push-notifications.js --- @@ -0,0 +1,82 @@ +(function () { +var fs = require('fs'), +

Re: [VOTE] Plugins Release

2015-02-06 Thread Jesse
-1 on (b05bcff378)cordova-plugin-file-transfer: 0.5.0 (15591b) Let's get the fix in first. @purplecabbage risingj.com On Fri, Feb 6, 2015 at 12:31 AM, Alexander Sorokin (Akvelon) v-als...@microsoft.com wrote: Hi guys, I just wanted to let you know that there is a bug on windows in

[GitHub] cordova-ios pull request: CB-8084 conform AppDelegate.m with provi...

2015-02-06 Thread ligaz
Github user ligaz commented on a diff in the pull request: https://github.com/apache/cordova-ios/pull/128#discussion_r24230979 --- Diff: bin/templates/scripts/cordova/lib/push-notifications.js --- @@ -0,0 +1,82 @@ +(function () { +var fs = require('fs'), +

[GitHub] cordova-lib pull request: CB-8227 CB-8237 CB-8238 Add --save optio...

2015-02-06 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/144#issuecomment-73205488 asdf --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: [GitHub] cordova-wp8 pull request: CB-8412

2015-02-06 Thread Jesse
http://www.appveyor.com/docs/installed-software @purplecabbage risingj.com On Fri, Feb 6, 2015 at 1:28 AM, muratsu g...@git.apache.org wrote: Github user muratsu commented on the pull request: https://github.com/apache/cordova-wp8/pull/75#issuecomment-73209662 On build 103 you can

[GitHub] cordova-docs pull request: CB-8243 cordova-docs documentation tran...

2015-02-06 Thread sosahvictor
Github user sosahvictor closed the pull request at: https://github.com/apache/cordova-docs/pull/262 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-splashscreen pull request: CB-3679 Break Android sp...

2015-02-06 Thread cgwyllie
Github user cgwyllie commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/32#issuecomment-73274586 @agrieve @jbavari Hey, been looking into this for a while this afternoon and was wondering how it's possible to use the version of Cordova that

[GitHub] cordova-ios pull request: CB-8084 conform AppDelegate.m with provi...

2015-02-06 Thread Mitko-Kerezov
Github user Mitko-Kerezov commented on the pull request: https://github.com/apache/cordova-ios/pull/128#issuecomment-73229125 Thanks, @ligaz - comments addressed. Hey @shazron or @agrieve could someone please take a look at this --- If your project is set up for it, you can reply

[GitHub] cordova-wp8 pull request: CB-8412

2015-02-06 Thread muratsu
Github user muratsu commented on the pull request: https://github.com/apache/cordova-wp8/pull/75#issuecomment-73285130 Ahh, finally we're all green on AppVeyor :rocket: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

Re: [cordova-android] Commit related to CB-8317 brings issue reported in CB-7371

2015-02-06 Thread Martin Gonzalez
The initial problem was the whitelist letting pass something like 'about:blank' to be loaded into the view, when all network access was allowed(access=*), currently that problems is not present. Although, the the recreation triggers always a destruction, and during that event, loadUrlNow method

[GitHub] cordova-ios pull request: CB-8412 enable jshint for iOS platform

2015-02-06 Thread muratsu
Github user muratsu commented on the pull request: https://github.com/apache/cordova-ios/pull/129#issuecomment-73285875 `node node_modules/jshint/bin/jshint bin node node_modules/jshint/bin/jshint tests` is passing. Failing tests are not related to this PR --- If your project is