Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/174#issuecomment-76663106
@gorkem, the change you've committed to fix this issue (
https://github.com/apache/cordova-lib/commit/4c0fec7d30df238cfc4c834a4235b2c8fcf330ad
) introduces another b
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/commit/4c0fec7d30df238cfc4c834a4235b2c8fcf330ad#commitcomment-9979467
@gorkem, this change introduces another bug : the variables list now
contains all the `` such as 'id', 'url', 'installPath', w
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/174
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user gorkem commented on the pull request:
https://github.com/apache/cordova-lib/pull/174#issuecomment-76643012
I agree, but this is temporary. Special params are going away with the
plugin tag. And ConfigParser's current implementation already does a special
treatment of FEATU
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/174#issuecomment-76641530
Fixing it in Config.getFeature(id) would mean that we would have to
differentiate between `` types : variables and non-variables. I think
that would be unecessarily
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/174#issuecomment-76641117
Fixing it in Config.getFeature(id) would mean that we would have to
differentiate between `` types : variables and non-variables. I think
that could be unecessarily
Github user gorkem commented on the pull request:
https://github.com/apache/cordova-lib/pull/174#issuecomment-76639381
Ahhh. I see what you mean now. I think we should fix this on the
Config.getFeature(id) so that the existing information on config.xml files are
not discarded.
---
Welcome, Eric !
Nice to have you contributing.
Thanks,
Mefire
-Original Message-
From: Jesse [mailto:purplecabb...@gmail.com]
Sent: Saturday, February 28, 2015 10:37 PM
To: dev@cordova.apache.org
Subject: Re: Hello
Welcome Eric! No more lurking. Glad to hear you're involved in many plat
GitHub user EddyVerbruggen opened a pull request:
https://github.com/apache/cordova-wp8/pull/77
Fix for plugins responding with NO_RESULT
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/EddyVerbruggen/cordova-wp8 CB-8580
Alterna
