Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/184#issuecomment-78815446
@vladimir-kotikov Can you please help review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If you
Thanks for the explanations, Andrew. Most of this makes sense now. Also, I
liked your comments.
We've noticed up to 30% performance slow down by disabling eval through CSP in
angular and other popular frameworks. I'm concerned in not adding 'unsafe-eval'
as the default. We should add it to the
GitHub user lukeharback opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/92
Make toolbar more iOS7 & 8 like
Change the UIToolbar to be full height with no offset to be more like a
UINavigationBar
Change the bar style from UIBarStyleBlackOpaque to
Please review and vote on this 3.8.0 Cordova App Hello World Release.
Release issue: https://issues.apache.org/jira/browse/CB-8645
Repos ready to be released have been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8645
The package was published from its corresponding gi
Github user brodybits commented on the pull request:
https://github.com/apache/cordova-wp8/pull/62#issuecomment-78657210
:+1: Any idea if and when this will be included?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user brodybits commented on the pull request:
https://github.com/apache/cordova-wp8/pull/72#issuecomment-78656933
Any idea when a new release for WP8 will be made (with the change)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user kamrik commented on the pull request:
https://github.com/apache/cordova-lib/pull/183#issuecomment-78635997
Addressed the comments and merged as a single squashed commit.
Thanks for reviewing.
---
If your project is set up for it, you can reply to this email and have yo
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/183
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Thanks for taking a look at this. Addressing the PR comments and merging.
On Wed, Mar 11, 2015 at 9:28 PM, Andrew Grieve wrote:
> LGTM!
>
> On Wed, Mar 11, 2015 at 1:59 PM, Rob Paveza
> wrote:
>
> > LGTM. Only weird thing is that the platforms lib is in
> > '../platforms/platforms' moved from
I know we discussed a couple of approaches implementing the default whitelist
policy for Android/iOS - either every app would be required to include the
whitelist plugin or have it have smart defaults in the platform implementation
and the plugin being able to override them.
I don’t think that
OK, so right now it's just docs? How soon can we get a VOTE thread started
for 4.0.0?
On Wed, Mar 4, 2015 at 10:47 AM Andrew Grieve wrote:
> mobilespec is now working again... Took longer than I would have liked, but
> did you know that on Android FileReader triggers shouldInterceptRequest()
> w
Added comment with these points to the template.
On Wed, Mar 11, 2015 at 9:37 PM, Andrew Grieve wrote:
> Great questions! Certainly was hoping to get more eyes on this!
>
> Not sure where a good spot to document this is, but maybe right in the
> template is okay? That way users will also know th
This vote has failed. I'll start a new vote thread.
On Mar 11, 2015 6:26 PM, "Parashuram N (MS OPEN TECH)" <
panar...@microsoft.com> wrote:
> I think if we change the tag, we will have to vote again. However, we
> don't have to necessarily wait for 72 hours, for a fix that is small.
>
> -Origi
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26305196
--- Diff: buildbot-conf/cordova-config.json.sample ---
@@ -0,0 +1,43 @@
+{
+"couchdb": {
+"uri": "http://localhost:5984
Github user alsorokin closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/69
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, o
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26294930
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,336 @@
+import os
+import re
+import json
+
+from buildbot.schedulers.ba
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26292395
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,336 @@
+import os
+import re
+import json
+
+from buildbot.schedulers.ba
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26291762
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,336 @@
+import os
+import re
+import json
+
+from buildbot.schedulers.ba
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26291601
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,336 @@
+import os
+import re
+import json
+
+from buildbot.schedulers.ba
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26289567
--- Diff: buildbot-conf/cordova-internal.conf ---
@@ -0,0 +1,101 @@
+import os
+import json
+
+from buildbot.changes.gitpoller i
Github user sandstrom commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/28#issuecomment-78448058
Any existing value for `NSLocationAlwaysUsageDescription ` in the plist
gets overwritten with an empty string. This makes it harder to provide a cust
Voting +1 for this. Also did initial tests on Windows, seems to work
• Verified signatures and hashes
• Verified tags
• Verified that app can be built and ran under windows, wp8 and android
platforms
• Verified release notes:
+ added license header to config.xml
+ added relea
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-mobile-spec/pull/121
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26228651
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,336 @@
+import os
+import re
+import json
+
+from buildbot.schedulers.basic impo
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26228578
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,336 @@
+import os
+import re
+import json
+
+from buildbot.schedulers.basic impo
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26228516
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,336 @@
+import os
+import re
+import json
+
+from buildbot.schedulers.basic impo
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26228485
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,336 @@
+import os
+import re
+import json
+
+from buildbot.schedulers.basic impo
Voting + 1
€Verified signatures and hashes
€Verified tags
€Verified plugins added correctly to blank app
€Verified blank app can be successfully ran and built
€Ran smoke testing of mobilespec app (ran autotests)
€Performed manual ad-hoc testing
€Verified Release Notes
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26227126
--- Diff: buildbot-conf/cordova-config.json.sample ---
@@ -0,0 +1,43 @@
+{
+"couchdb": {
+"uri": "http://localhost:5984";
+
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26227510
--- Diff: buildbot-conf/cordova-internal.conf ---
@@ -0,0 +1,101 @@
+import os
+import json
+
+from buildbot.changes.gitpoller import Gi
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26214059
--- Diff: cordova-lib/src/platforms/platforms.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user gorkem closed the pull request at:
https://github.com/apache/cordova-lib/pull/182
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/178#discussion_r26284598
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -267,7 +271,8 @@ module.exports = function plugin(command, targets,
opts) {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/178#discussion_r26284638
--- Diff: cordova-lib/src/plugman/util/metadata.js ---
@@ -59,3 +59,10 @@ exports.save_fetch_metadata = function(pluginsDir,
pluginId, data) {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/178#discussion_r26284597
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -234,7 +239,6 @@ module.exports = function plugin(command, targets,
opts) {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/178#discussion_r26284609
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -144,7 +144,10 @@ function fetchPlugin(plugin_src, plugins_dir, options)
{
});
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/178#discussion_r26284601
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -278,9 +283,16 @@ module.exports = function plugin(command, targets,
opts) {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/178#discussion_r26284603
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -295,14 +307,87 @@ module.exports = function plugin(command, targets,
opts) {
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26154307
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,326 @@
+import os
+import re
+import json
+
+from buildbot.schedulers.basic impo
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-medic/pull/37#issuecomment-78122882
Also good catch with the clone step: I was running an older branch, and
this didn't come up in my tests. Fixed the issue by adding an `exclude`
parameter to `check
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/69#discussion_r26153526
--- Diff: tests/tests.js ---
@@ -305,7 +306,17 @@ exports.defineAutoTests = function () {
// - 'http://exam
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/38#discussion_r26150136
--- Diff: src/wp/SplashScreen.cs ---
@@ -40,26 +40,35 @@ namespace WPCordovaClassLib.Cordova.Commands
///
public clas
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26200617
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,336 @@
+import os
+import re
+import json
+
+from buildbot.schedulers.ba
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26226876
--- Diff: buildbot-conf/cordova-config.json.sample ---
@@ -0,0 +1,43 @@
+{
+"couchdb": {
+"uri": "http://localhost:5984";
+
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26141990
--- Diff: bin/checkout.js ---
@@ -0,0 +1,46 @@
+#!/usr/bin/env node
+
+// node dependencies
+var fs = require('fs');
+
+
Perfect. Thanks Steve.
On Mon, Mar 9, 2015 at 7:46 PM, Steven Gill wrote:
> Release steps:
>
> https://github.com/apache/cordova-coho/blob/master/docs/app-hello-world-release-process.md
>
> I will have to run through a release to see if I got it all right.
>
> Okay, I'm going to merge the copy-
Github user CJRChang commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/61#discussion_r26282196
--- Diff: cordova-js-src/exec.js ---
@@ -60,18 +60,32 @@ module.exports = function (success, fail, service,
action, args) {
// CB-58
47 matches
Mail list logo
