Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/178#discussion_r26284601
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -278,9 +283,16 @@ module.exports = function plugin(command, targets,
opts) {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/178#discussion_r26284603
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -295,14 +307,87 @@ module.exports = function plugin(command, targets,
opts) {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/178#discussion_r26284597
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -234,7 +239,6 @@ module.exports = function plugin(command, targets,
opts) {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/178#discussion_r26284609
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -144,7 +144,10 @@ function fetchPlugin(plugin_src, plugins_dir, options)
{
});
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/178#discussion_r26284638
--- Diff: cordova-lib/src/plugman/util/metadata.js ---
@@ -59,3 +59,10 @@ exports.save_fetch_metadata = function(pluginsDir,
pluginId, data) {
Github user mmocny commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/183#discussion_r26214059
--- Diff: cordova-lib/src/platforms/platforms.js ---
@@ -0,0 +1,102 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user gorkem closed the pull request at:
https://github.com/apache/cordova-lib/pull/182
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26141990
--- Diff: bin/checkout.js ---
@@ -0,0 +1,46 @@
+#!/usr/bin/env node
+
+// node dependencies
+var fs = require('fs');
+
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26226876
--- Diff: buildbot-conf/cordova-config.json.sample ---
@@ -0,0 +1,43 @@
+{
+couchdb: {
+uri: http://localhost:5984;
+
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26200617
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,336 @@
+import os
+import re
+import json
+
+from
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-splashscreen/pull/38#discussion_r26150136
--- Diff: src/wp/SplashScreen.cs ---
@@ -40,26 +40,35 @@ namespace WPCordovaClassLib.Cordova.Commands
/// /summary
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/69#discussion_r26153526
--- Diff: tests/tests.js ---
@@ -305,7 +306,17 @@ exports.defineAutoTests = function () {
// -
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-medic/pull/37#issuecomment-78122882
Also good catch with the clone step: I was running an older branch, and
this didn't come up in my tests. Fixed the issue by adding an `exclude`
parameter to
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26154307
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,326 @@
+import os
+import re
+import json
+
+from buildbot.schedulers.basic
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/178#discussion_r26284598
--- Diff: cordova-lib/src/cordova/plugin.js ---
@@ -267,7 +271,8 @@ module.exports = function plugin(command, targets,
opts) {
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26228578
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,336 @@
+import os
+import re
+import json
+
+from buildbot.schedulers.basic
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26228651
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,336 @@
+import os
+import re
+import json
+
+from buildbot.schedulers.basic
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26228516
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,336 @@
+import os
+import re
+import json
+
+from buildbot.schedulers.basic
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26228485
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,336 @@
+import os
+import re
+import json
+
+from buildbot.schedulers.basic
Voting + 1
€Verified signatures and hashes
€Verified tags
€Verified plugins added correctly to blank app
€Verified blank app can be successfully ran and built
€Ran smoke testing of mobilespec app (ran autotests)
€Performed manual ad-hoc testing
€Verified Release
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-mobile-spec/pull/121
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Voting +1 for this. Also did initial tests on Windows, seems to work
• Verified signatures and hashes
• Verified tags
• Verified that app can be built and ran under windows, wp8 and android
platforms
• Verified release notes:
+ added license header to config.xml
+ added
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26227510
--- Diff: buildbot-conf/cordova-internal.conf ---
@@ -0,0 +1,101 @@
+import os
+import json
+
+from buildbot.changes.gitpoller import
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26227126
--- Diff: buildbot-conf/cordova-config.json.sample ---
@@ -0,0 +1,43 @@
+{
+couchdb: {
+uri: http://localhost:5984;
+
Github user sandstrom commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/28#issuecomment-78448058
Any existing value for `NSLocationAlwaysUsageDescription ` in the plist
gets overwritten with an empty string. This makes it harder to provide a
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26291762
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,336 @@
+import os
+import re
+import json
+
+from
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26289567
--- Diff: buildbot-conf/cordova-internal.conf ---
@@ -0,0 +1,101 @@
+import os
+import json
+
+from buildbot.changes.gitpoller
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26294930
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,336 @@
+import os
+import re
+import json
+
+from
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26305196
--- Diff: buildbot-conf/cordova-config.json.sample ---
@@ -0,0 +1,43 @@
+{
+couchdb: {
+uri: http://localhost:5984;
Thanks for the explanations, Andrew. Most of this makes sense now. Also, I
liked your comments.
We've noticed up to 30% performance slow down by disabling eval through CSP in
angular and other popular frameworks. I'm concerned in not adding 'unsafe-eval'
as the default. We should add it to the
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/184#issuecomment-78815446
@vladimir-kotikov Can you please help review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
GitHub user lukeharback opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/92
Make toolbar more iOS7 8 like
Change the UIToolbar to be full height with no offset to be more like a
UINavigationBar
Change the bar style from UIBarStyleBlackOpaque to
Added comment with these points to the template.
On Wed, Mar 11, 2015 at 9:37 PM, Andrew Grieve agri...@chromium.org wrote:
Great questions! Certainly was hoping to get more eyes on this!
Not sure where a good spot to document this is, but maybe right in the
template is okay? That way users
This vote has failed. I'll start a new vote thread.
On Mar 11, 2015 6:26 PM, Parashuram N (MS OPEN TECH)
panar...@microsoft.com wrote:
I think if we change the tag, we will have to vote again. However, we
don't have to necessarily wait for 72 hours, for a fix that is small.
-Original
OK, so right now it's just docs? How soon can we get a VOTE thread started
for 4.0.0?
On Wed, Mar 4, 2015 at 10:47 AM Andrew Grieve agri...@chromium.org wrote:
mobilespec is now working again... Took longer than I would have liked, but
did you know that on Android FileReader triggers
I know we discussed a couple of approaches implementing the default whitelist
policy for Android/iOS - either every app would be required to include the
whitelist plugin or have it have smart defaults in the platform implementation
and the plugin being able to override them.
I don’t think
Github user kamrik commented on the pull request:
https://github.com/apache/cordova-lib/pull/183#issuecomment-78635997
Addressed the comments and merged as a single squashed commit.
Thanks for reviewing.
---
If your project is set up for it, you can reply to this email and have
Github user brodybits commented on the pull request:
https://github.com/apache/cordova-wp8/pull/62#issuecomment-78657210
:+1: Any idea if and when this will be included?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26292395
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,336 @@
+import os
+import re
+import json
+
+from
Github user alsorokin closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/69
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so,
Github user dmitriy-barkalov commented on a diff in the pull request:
https://github.com/apache/cordova-medic/pull/37#discussion_r26291601
--- Diff: buildbot-conf/cordova.conf ---
@@ -0,0 +1,336 @@
+import os
+import re
+import json
+
+from
Github user CJRChang commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/61#discussion_r26282196
--- Diff: cordova-js-src/exec.js ---
@@ -60,18 +60,32 @@ module.exports = function (success, fail, service,
action, args) {
//
Perfect. Thanks Steve.
On Mon, Mar 9, 2015 at 7:46 PM, Steven Gill stevengil...@gmail.com wrote:
Release steps:
https://github.com/apache/cordova-coho/blob/master/docs/app-hello-world-release-process.md
I will have to run through a release to see if I got it all right.
Okay, I'm going to
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/61#discussion_r26280733
--- Diff: cordova-js-src/exec.js ---
@@ -60,18 +60,32 @@ module.exports = function (success, fail, service,
action, args) {
//
Only question is if callback.status might be undefined (stands to reason if it
can be null). If so, the present check is insufficient and changes because you
test with ===.
-Rob
-Original Message-
From: robpaveza [mailto:g...@git.apache.org]
Sent: Wednesday, March 11, 2015 11:14 PM
Github user CJRChang commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/61#discussion_r26280804
--- Diff: cordova-js-src/exec.js ---
@@ -60,18 +60,32 @@ module.exports = function (success, fail, service,
action, args) {
//
Github user robpaveza commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/61#discussion_r26281092
--- Diff: cordova-js-src/exec.js ---
@@ -60,18 +60,32 @@ module.exports = function (success, fail, service,
action, args) {
//
47 matches
Mail list logo
