Re: [Vote] 3.8.0 Cordova App Hello World Release (attempt 2)

2015-03-13 Thread Steven Gill
Going to redo this vote one more time due to unsafe-eval being added by default to the csp. This vote has failed. On Fri, Mar 13, 2015 at 8:47 AM, Andrew Grieve agri...@chromium.org wrote: +1 On Fri, Mar 13, 2015 at 11:40 AM, Mark Koudritsky kam...@google.com wrote: +1 Built and ran

[GitHub] cordova-wp8 pull request: CB-8516 Support DefaultLanguage selectio...

2015-03-13 Thread muratsu
Github user muratsu closed the pull request at: https://github.com/apache/cordova-wp8/pull/76 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-js pull request: [CB-8667][Windows]Handle case where check...

2015-03-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/103 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-windows pull request: Cb 8667

2015-03-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/62 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-whitelist pull request: Test PR for github / JIRA i...

2015-03-13 Thread agrieve
GitHub user agrieve opened a pull request: https://github.com/apache/cordova-plugin-whitelist/pull/2 Test PR for github / JIRA integration You can merge this pull request into a Git repository by running: $ git pull https://github.com/agrieve/cordova-plugin-whitelist patch-1

[GitHub] cordova-plugin-whitelist pull request: Test PR for github / JIRA i...

2015-03-13 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/2#issuecomment-79145875 Test CB-4789 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-13 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26409868 --- Diff: buildbot-conf/cordova.conf --- @@ -0,0 +1,336 @@ +import os +import re +import json + +from buildbot.schedulers.basic

RE: CSP policy

2015-03-13 Thread Nikhil Khandelwal
Thanks, Andrew for making the prompt change and Steve for starting the re-vote! Thanks, Nikhil -Original Message- From: Rob Paveza [mailto:rob.pav...@microsoft.com] Sent: Friday, March 13, 2015 11:10 AM To: dev@cordova.apache.org Subject: RE: CSP policy I think that would be

Re: CSP policy

2015-03-13 Thread Andrew Grieve
Up to you. It's just the template, and it's clearly commented as-is. On Fri, Mar 13, 2015 at 12:55 PM, Steven Gill stevengil...@gmail.com wrote: Revote? Lol On Mar 13, 2015 9:53 AM, Andrew Grieve agri...@chromium.org wrote: Makes sense. I've added it to the template. On Fri, Mar 13,

RE: CSP policy

2015-03-13 Thread Rob Paveza
I think that would be preferable. Templating engines like to use eval because they allow the templates to have code generated for them at runtime. Given a template, the engine can do codegen that does string-concat - innerHTML, which tends to be very fast for large templates. Without eval,

Developing Cordova Plugin for Geofencing

2015-03-13 Thread Kasun Weerakoon
Hey, I'm undergraduate student of University of Moratuwa Sri Lanka. I'm developing a Geofencing plugin as my 2nd year industrial project. I did some background work and have some understanding about creating a plugin. I also made some simple plugins. It would be very helpful if you can provide

RE: Cordova medic buildbot

2015-03-13 Thread Dmitry Blotsky
Hi Willy, Thanks for pointing this out! That change is already in the works. The old steps are still imported in the config for backward compatibility (and Buildbot 8.10 still supports them for compatibility), but they will be removed soon just like you proposed. Kindly, Dmitry -Original

Re: [Vote] 3.8.0 Cordova App Hello World Release (attempt 3)

2015-03-13 Thread Mark Koudritsky
+1 Built and ran on - Android 5.0.2 on Nexus 7 - iOS simulator On Fri, Mar 13, 2015 at 2:32 PM, Steven Gill stevengil...@gmail.com wrote: Please review and vote on this 3.8.0 Cordova App Hello World Release. Release issue: https://issues.apache.org/jira/browse/CB-8645 Repos ready to be

[GitHub] cordova-plugin-whitelist pull request: Test PR for github / JIRA i...

2015-03-13 Thread agrieve
Github user agrieve closed the pull request at: https://github.com/apache/cordova-plugin-whitelist/pull/2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

Re: [VOTE] Camera Plugin Release 0.3.6

2015-03-13 Thread Andrew Grieve
+1 On Wed, Mar 11, 2015 at 12:19 PM, Parashuram N (MS OPEN TECH) panar...@microsoft.com wrote: Voting + 1 €Verified signatures and hashes €Verified tags €Verified plugins added correctly to blank app €Verified blank app can be successfully ran and built €Ran smoke

google maps glitch on wp

2015-03-13 Thread Staci Cooper
I just opened https://issues.apache.org/jira/browse/CB-8671 for an issue with google maps on WP. When zooming/scrolling in the map repeated/overlapping frames appear (screenshots posted on the issue). It's not happening on Android. I'm only seeing the problem on WP devices, not any of the

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-13 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26409985 --- Diff: buildbot-conf/cordova.conf --- @@ -0,0 +1,336 @@ +import os +import re +import json + +from buildbot.schedulers.basic

Re: [VOTE] Camera Plugin Release 0.3.6

2015-03-13 Thread Steven Gill
The vote has now closed. The results are: Positive Binding Votes: 3 Steve Gill Andrew Grieve Parashuram N The vote has passed. I will now publish it to CPR and NPM On Fri, Mar 13, 2015 at 10:24 AM, Andrew Grieve agri...@chromium.org wrote: +1 On Wed, Mar 11, 2015 at 12:19 PM, Parashuram

Re: [VOTE] Camera Plugin Release 0.3.6

2015-03-13 Thread Steven Gill
This has been published to CPR [1], NPM [2] and moved to dist [3]. [1] http://plugins.cordova.io/#/package/org.apache.cordova.camera [2] https://www.npmjs.com/package/cordova-plugin-camera [3] https://dist.apache.org/repos/dist/release/cordova/plugins/ On Fri, Mar 13, 2015 at 11:45 AM, Steven

Re: CSP policy

2015-03-13 Thread Steven Gill
We aren't in a rush to ship this. I'd rather have it in a state that everyone is happy with. 30% slowdown can really impact a lot of our developers. I'll restart the vote thread for it On Fri, Mar 13, 2015 at 10:14 AM, Andrew Grieve agri...@chromium.org wrote: Up to you. It's just the

RE: Developing Cordova Plugin for Geofencing

2015-03-13 Thread Rob Paveza
Are you looking for clarification on what geofencing is, or on how to build a Cordova plugin in general? -Original Message- From: Kasun Weerakoon [mailto:kasun...@gmail.com] Sent: Friday, March 13, 2015 6:22 AM To: dev@cordova.apache.org Subject: Developing Cordova Plugin for Geofencing

[GitHub] cordova-windows pull request: Fix for callback invocation with NO_...

2015-03-13 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/61#issuecomment-79148007 No, that would/could work also, but I decided to just use the loosely falsey comparison {{ if (callbackOptions.status != null) ... }} which is true

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-13 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26409576 --- Diff: buildbot-conf/cordova-internal.conf --- @@ -0,0 +1,101 @@ +import os +import json + +from buildbot.changes.gitpoller import

[Vote] 3.8.0 Cordova App Hello World Release (attempt 3)

2015-03-13 Thread Steven Gill
Please review and vote on this 3.8.0 Cordova App Hello World Release. Release issue: https://issues.apache.org/jira/browse/CB-8645 Repos ready to be released have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-8645 The package was published from its corresponding

Re: Introduction for Julian Horn

2015-03-13 Thread Shazron
Welcome! You mean https://issues.apache.org/jira/browse/CB-7992 of course ;) On Fri, Mar 13, 2015 at 2:20 PM, Horn, Julian C julian.c.h...@intel.com wrote: Hello! I am Julian Horn. I'm a software engineer in the Intel XDK team. I am the team lead for the Device Emulator component, our

Introduction for Julian Horn

2015-03-13 Thread Horn, Julian C
Hello! I am Julian Horn. I'm a software engineer in the Intel XDK team. I am the team lead for the Device Emulator component, our derivative of the Ripple emulator. I have signed and sent in an individual contributor agreement, and my company has a corporate contributor agreement signed. I

Re: Introduction for Julian Horn

2015-03-13 Thread Jesse
Hello and welcome (back?) Julian! I have added you as an assignable user in JIRA, and assigned this issue to you. You also should be able to assign issues to yourself now. Regarding this specific issue, I think I agree with Joe's comment in JIRA that this is probably not a bug. There are

[GitHub] cordova-plugin-inappbrowser pull request: CB-8659 - Update InAppBr...

2015-03-13 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/93 CB-8659 - Update InAppBrowser to support both cordova-ios 4.0.x and 3.x You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-wp8 pull request: Use WP8 thread pool for each command, in...

2015-03-13 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-wp8/pull/72#issuecomment-79535726 @brodybits - We'll start a new release soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-windows pull request: CB8673: Initial orientation settings

2015-03-13 Thread robpaveza
GitHub user robpaveza opened a pull request: https://github.com/apache/cordova-windows/pull/63 CB8673: Initial orientation settings This feature had already been done so I took the opportunity to clean up the existing code. There were multiple cases where the code scanned

RE: Introduction for Julian Horn

2015-03-13 Thread Nikhil Khandelwal
Welcome Julian! Looking forward to working with you! Thanks, Nikhil -Original Message- From: Jesse [mailto:purplecabb...@gmail.com] Sent: Friday, March 13, 2015 3:14 PM To: dev@cordova.apache.org Subject: Re: Introduction for Julian Horn Hello and welcome (back?) Julian! I have added

Assigning JIRA issues to myself...

2015-03-13 Thread Tim Barham
Hey Jesse (or someone else with rights)... Could you give me rights in JIRA so I can assign bugs to myself? Thanks! Tim From: Jesse [purplecabb...@gmail.com] Sent: Saturday, March 14, 2015 8:14 AM To: dev@cordova.apache.org Subject: Re: Introduction for

RE: Introduction for Julian Horn

2015-03-13 Thread Tim Barham
Welcome Julian! From: Horn, Julian C [julian.c.h...@intel.com] Sent: Saturday, March 14, 2015 7:20 AM To: dev@cordova.apache.org Subject: Introduction for Julian Horn Hello! I am Julian Horn. I'm a software engineer in the Intel XDK team. I am the team

[GitHub] cordova-windows pull request: Fix for callback invocation with NO_...

2015-03-13 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/61#issuecomment-78841786 Hi Ray, I have created an issue in JIRA for this, thanks for bringing it to my attention. I have merged your pull request into my own. here:

[GitHub] cordova-medic pull request: Medic Refactor

2015-03-13 Thread dmitriy-barkalov
Github user dmitriy-barkalov commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/37#discussion_r26375456 --- Diff: buildbot-conf/cordova-repos.json --- @@ -0,0 +1,452 @@ +{ +mobile-chrome-apps: { +codebase: chrome, +

[GitHub] cordova-wp8 pull request: JsonHelper testing, and use of Newtonsof...

2015-03-13 Thread mowcixo
Github user mowcixo commented on the pull request: https://github.com/apache/cordova-wp8/pull/62#issuecomment-78895170 No one of the main countributors has pronounced about this... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-plugin-file pull request: fix(ios): always use setters to ...

2015-03-13 Thread mgcrea
GitHub user mgcrea opened a pull request: https://github.com/apache/cordova-plugin-file/pull/104 fix(ios): always use setters to fix memory issues without ARC Encountered memory issues with a non-ARC project (cordova+unity3d). Setter should be used to prevent memory issues, eg:

[GitHub] cordova-lib pull request: CB-7698 BugFix: For plugins which requir...

2015-03-13 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/184#discussion_r26392721 --- Diff: cordova-lib/src/cordova/plugin.js --- @@ -185,8 +185,9 @@ module.exports = function plugin(command, targets, opts) {

RE: [Vote] 3.8.0 Cordova App Hello World Release (attempt 2)

2015-03-13 Thread Sergey Grebnov (Akvelon)
I vote +1 * Verified that app can be built and ran (android, windows, wp8) Thx! Sergey -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Friday, March 13, 2015 2:22 AM To: dev@cordova.apache.org Subject: [Vote] 3.8.0 Cordova App Hello World Release (attempt 2)

[GitHub] cordova-windows pull request: Fix for callback invocation with NO_...

2015-03-13 Thread CJRChang
Github user CJRChang commented on the pull request: https://github.com/apache/cordova-windows/pull/61#issuecomment-78938907 Hi Jesse, Thanks for raising the issue on JIRA - the changes look great, definitely more elegant than my initial proposal. Thanks for the input! --- If

[GitHub] cordova-lib pull request: CB-8670 Error when set engine name to c...

2015-03-13 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/185 CB-8670 Error when set engine name to cordova-windows in plugin.xml If you create an `engine` element with `name=cordova-windows` (rather than `cordova-windows8`) in `plugin.xml`, like this:

Re: Where does cordova-android@4.0.0-dev live?

2015-03-13 Thread Michal Mocny
Indeed, it has been merged into master and will be the next version of cordova-android released. On Fri, Mar 13, 2015 at 11:24 AM, Axel Nennker ignisvul...@gmail.com wrote: This? https://github.com/apache/cordova-android Version file says 4.0.0-dev

[GitHub] cordova-lib pull request: CB-8521 `cordova plugin save` should sav...

2015-03-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/178 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [Vote] 3.8.0 Cordova App Hello World Release (attempt 2)

2015-03-13 Thread Mark Koudritsky
+1 Built and ran the app on iOS simulator and Android on Nexus 7. On Fri, Mar 13, 2015 at 10:41 AM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: I vote +1 * Verified that app can be built and ran (android, windows, wp8) Thx! Sergey -Original Message- From: Steven Gill

[GitHub] cordova-lib pull request: CB-7698 BugFix: For plugins which requir...

2015-03-13 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/184#issuecomment-79026418 This is merged in https://github.com/apache/cordova-lib/commit/b03b4d7ddec982b00e6f009468ffa8db59c56e1c. @omefire could you please close this --- If

Cordova medic buildbot

2015-03-13 Thread Willy Aguirre
Hi!, Is it possible to update the version of buildbot for cordova-medic I am using buildbot 0.8.10 Here you are an example. I found exceptions https://issues.apache.org/jira/browse/CB-8489?filter=-2 https://github.com/marti1125/cordova-medic-firefoxos/blob/master/master_buildbot0810.cfg

Re: [Vote] 3.8.0 Cordova App Hello World Release (attempt 2)

2015-03-13 Thread Andrew Grieve
+1 On Fri, Mar 13, 2015 at 11:40 AM, Mark Koudritsky kam...@google.com wrote: +1 Built and ran the app on iOS simulator and Android on Nexus 7. On Fri, Mar 13, 2015 at 10:41 AM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: I vote +1 * Verified that app can be built and

[GitHub] cordova-windows pull request: Fix for callback invocation with NO_...

2015-03-13 Thread robpaveza
Github user robpaveza commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/61#discussion_r26400963 --- Diff: cordova-js-src/exec.js --- @@ -60,18 +60,32 @@ module.exports = function (success, fail, service, action, args) { //

Re: CSP policy

2015-03-13 Thread Andrew Grieve
Makes sense. I've added it to the template. On Fri, Mar 13, 2015 at 1:13 AM, Nikhil Khandelwal nikhi...@microsoft.com wrote: Thanks for the explanations, Andrew. Most of this makes sense now. Also, I liked your comments. We've noticed up to 30% performance slow down by disabling eval through

Re: CSP policy

2015-03-13 Thread Steven Gill
Revote? Lol On Mar 13, 2015 9:53 AM, Andrew Grieve agri...@chromium.org wrote: Makes sense. I've added it to the template. On Fri, Mar 13, 2015 at 1:13 AM, Nikhil Khandelwal nikhi...@microsoft.com wrote: Thanks for the explanations, Andrew. Most of this makes sense now. Also, I liked