Re: Deprecation of Config and the embedded use case (4.0.x related)

2015-03-17 Thread Carlos Santana
Andrew when you say denote your app as an android library Your thinking a AAR archive, which includes the cordova-platform core, cordova.js, and plugins native and web assets? On Tue, Mar 17, 2015 at 11:06 AM, Carlos Santana csantan...@gmail.com wrote: Andrew similar requirement we have for

Re: Deprecation of Config and the embedded use case (4.0.x related)

2015-03-17 Thread Carlos Santana
Andrew similar requirement we have for iOS. If we implement something like that in CLI to have an option to produce a library instead of an App. In theory this is something we have discussed here in IBM, to do something similar with Cocoa Pods, produce a cocoapod that represent the iOS Cordova

[GitHub] cordova-ios pull request: generates a workspace instead of subproj...

2015-03-17 Thread edewit
Github user edewit commented on the pull request: https://github.com/apache/cordova-ios/pull/104#issuecomment-82403994 now that swift options are added is this still relevant? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-plugin-file pull request: Reading a slice of an asset from...

2015-03-17 Thread vvasabi
GitHub user vvasabi opened a pull request: https://github.com/apache/cordova-plugin-file/pull/105 Reading a slice of an asset from photo library on iOS always gets the full file When reading a file from photo library, `file.slice()` does not work. Consider this code: ```

Re: [GitHub] cordova-plugin-file-transfer pull request: Fix NoSuchMethodExcepti...

2015-03-17 Thread Darryl Pogue
On 16 March 2015 at 22:54, Jesse purplecabb...@gmail.com wrote: They are independent no? Is this plugin relying on cordova-android 4.0? Or vice versa The plugin doesn't rely on cordova-android 4.0, but this change fixes a crash on Android 4.0-4.3 when using File Transfer and Crosswalk together

[GitHub] cordova-plugin-media pull request: CB-8686 - remove musicLibrary c...

2015-03-17 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/48#issuecomment-82173214 LGTM. @muratsu , could you please remove MSOT branch if it is not needed anymore? --- If your project is set up for it, you can reply to this

[GitHub] cordova-plugin-media-capture pull request: CB-8687 consolidate man...

2015-03-17 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/35#issuecomment-82189433 Perfect, thanks for clarifying! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-plugin-media-capture pull request: CB-8687 consolidate man...

2015-03-17 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/35#issuecomment-82185933 Can you explain why we don't need to update all the manifest files. apache/cordova-windows/tree/master/template/ still contains 3 separate

[GitHub] cordova-plugin-media-capture pull request: CB-8687 consolidate man...

2015-03-17 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/35#issuecomment-82153885 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-media-capture pull request: CB-8687 consolidate man...

2015-03-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/35 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-media pull request: CB-8686 - remove musicLibrary c...

2015-03-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/48 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-media-capture pull request: CB-8687 consolidate man...

2015-03-17 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/35#issuecomment-82188912 This is because cordova-lib applies changes to all three appxmanifests. Proof:

Re: Infra neglect

2015-03-17 Thread Carlos Santana
I checked and its already resolved. On Tue, Mar 17, 2015 at 4:10 PM Jesse purplecabb...@gmail.com wrote: The issue I created has been sitting around for 2 weeks with no attention from infra. Please vote up! https://issues.apache.org/jira/browse/INFRA-9210 @purplecabbage risingj.com

plugin for hot updates

2015-03-17 Thread Ariel Jakobovits
My understanding is that Apple (via Meteor.js, link below) has indicated a willingness to approve apps that continuously deploy changes to a mobile app without resubmitting to the App Store review process and without requiring users to download updates. I'm not sure, so I am asking, if this at

RE: Build signed archives using CLI

2015-03-17 Thread Nikhil Khandelwal
I just submitted a PR for this for Android: https://github.com/apache/cordova-android/pull/164 Here's the rough design: - Build.json or command line args can be used to specify details required for packaging: - Keystore - Alias - Keystore password - Password

Re: Infra neglect

2015-03-17 Thread Jesse
Seems Shaz has some pull! His comment got action. Thanks all! @purplecabbage risingj.com On Tue, Mar 17, 2015 at 2:29 PM, Carlos Santana csantan...@gmail.com wrote: I checked and its already resolved. On Tue, Mar 17, 2015 at 4:10 PM Jesse purplecabb...@gmail.com wrote: The issue I created

Re: Google IO?

2015-03-17 Thread Steven Gill
I also applied On Tue, Mar 17, 2015 at 10:05 AM, Joe Bowser bows...@gmail.com wrote: I put my name in for Google IO as well. I don't know for sure if Google is doing the puzzle thing, but I wouldn't be surprised if there were codes in the Google Developer documentation again this year.

RE: Medic Improvements

2015-03-17 Thread Alexander Sorokin (Akvelon)
Hi Willy, I just finished working on such parameter and created a PR: https://github.com/apache/cordova-mobile-spec/pull/123/ You could change medic config to specify the list of plugins you want to install as soon as it will be merged. Thanks, Alexander Sorokin -Original Message-

[GitHub] cordova-plugin-file pull request: Reading a slice of an asset from...

2015-03-17 Thread vvasabi
Github user vvasabi commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/105#issuecomment-82490657 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-device-motion pull request: CB-8312 Multiply accele...

2015-03-17 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-device-motion/pull/24#issuecomment-82492936 This will not work on the moon. Might want to add that to the quirks. --- If your project is set up for it, you can reply to this email and

Re: Medic Improvements

2015-03-17 Thread Willy Aguirre
thanks! 2015-03-17 12:18 GMT-05:00 Alexander Sorokin (Akvelon) v-als...@microsoft.com: Hi Willy, I just finished working on such parameter and created a PR: https://github.com/apache/cordova-mobile-spec/pull/123/ You could change medic config to specify the list of plugins you want to

Re: [Vote] 3.8.0 Cordova App Hello World Release (attempt 3)

2015-03-17 Thread Steven Gill
The vote has now closed. The results are: Positive Binding Votes: (# of PMC members that +1'ed) Steve Gill Mark Koudritsky Andrew Grieve The vote has passed. I will now publish to dist npm On Mon, Mar 16, 2015 at 9:01 AM, Andrew Grieve agri...@chromium.org wrote: +1 On Fri, Mar 13, 2015

[GitHub] cordova-mobile-spec pull request: CB-8694 Replaced dependencies pl...

2015-03-17 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/123#issuecomment-82510437 This fails to get tests when `--plugins` is specified. Also, this is a major breaking change to any tool or person that depends on modifying the

[GitHub] cordova-plugin-camera pull request: CB-7667 iOS8: Handle case wher...

2015-03-17 Thread dpolivy
Github user dpolivy commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/49#issuecomment-82518530 @shazron I just re-merged master and rebased the changes so it's a clean commit. Any chance of getting this pulled in to the next release? --- If your

[GitHub] cordova-plugin-file-transfer pull request: CB-5059 Add a CookieMan...

2015-03-17 Thread Kukiwon
Github user Kukiwon commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/60#issuecomment-82487250 Looks like it's working! Thanks a lot @dpogue ! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-mobile-spec pull request: CB-8694 Replaced dependencies pl...

2015-03-17 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/123#issuecomment-82486029 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-splashscreen pull request: Fixed plugin name in the...

2015-03-17 Thread adamsc64
GitHub user adamsc64 opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/39 Fixed plugin name in the readme. While I was installing this on a small project, I noticed that the reference to the plugin name was wrong in the README. Here is a quick pull

[GitHub] cordova-plugin-battery-status pull request: install cordova-parame...

2015-03-17 Thread purplecabbage
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-battery-status/pull/21 install cordova-paramedic from npm You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-js pull request: CB-7992 prohibit multiple cordova include...

2015-03-17 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-js/pull/104#issuecomment-82634650 @nikhilkh Look deeper: https://ci.appveyor.com/project/Humbedooh/cordova-js/history --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-js pull request: CB-7992 prohibit multiple cordova include...

2015-03-17 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-js/pull/104#issuecomment-82636317 I am digging into it now, since I am there. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-js pull request: CB-7992 prohibit multiple cordova include...

2015-03-17 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-js/pull/104#issuecomment-82635278 Looks like they have not been passing for a while? Is there a JIRA for this? Failing tests are noise. --- If your project is set up for it, you can reply to this

[GitHub] cordova-plugin-inappbrowser pull request: CB-8432 Correct styles f...

2015-03-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/79 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-network-information pull request: CB-8185 Use `navi...

2015-03-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-network-information/pull/25 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

Option to have iOS App Delegate be created in Swift CB-8680

2015-03-17 Thread Carlos Santana
I think this is a good idea, any thoughts? https://issues.apache.org/jira/browse/CB-8680 -- Carlos Santana csantan...@gmail.com

[GitHub] cordova-js pull request: CB-7992 prohibit multiple cordova include...

2015-03-17 Thread jchorn
Github user jchorn commented on the pull request: https://github.com/apache/cordova-js/pull/104#issuecomment-82335380 Wow, thanks! I was going to fix this in another way (putting an if statement at the top of src/scripts/require.js), but you beat me to it. It's nice to have some

Re: Medic Improvements

2015-03-17 Thread Willy Aguirre
this script must stay in mobile-spec o cordova-medic =? how to I can this modification? 2015-03-16 8:41 GMT-05:00 Dmitriy Barkalov (Akvelon) v-dmb...@microsoft.com : Hi Willy, I suppose just deleting repositories from cordova-repos.json will not help. Medic uses mobile-spec application to

Re: Introduction for Byoungro So

2015-03-17 Thread Carlos Santana
Welcome Byoungro Very exciting to see downstream contributing enhancements !!! That's good open source On Mon, Mar 16, 2015 at 2:32 PM, Shazron shaz...@gmail.com wrote: Welcome Byoungro So! I've given you the appropriate role and assigned you. On Sun, Mar 15, 2015 at 11:47 PM, So, Byoungro

Re: Introduction for Julian Horn

2015-03-17 Thread Carlos Santana
I agree with Joe this looks like a User space problem. But in this particular case, I would say that if cordova.js is ran a second time cordova.js should be robust and no errors no side effects should happened. checking with window.cordova, that feels like a hack, I would I agree a good hack :-)

Re: [DISCUSS] Cordova-Android 4.0.0 Release

2015-03-17 Thread Carlos Santana
I would say let's start RC testing and voting, But not pin the version in Cordova CLI until the tasks that Andrew mentioned are done. Andrew can you create the JIRA Items for the tasks that need to be done. I thought there was a discussion about creating JIRA Items to help track and know what's

Re: [GitHub] cordova-plugin-file-transfer pull request: Fix NoSuchMethodExcepti...

2015-03-17 Thread Carlos Santana
Where is the JIRA #? On Tue, Mar 17, 2015 at 2:46 AM, Darryl Pogue dvpdin...@gmail.com wrote: On 16 March 2015 at 22:54, Jesse purplecabb...@gmail.com wrote: They are independent no? Is this plugin relying on cordova-android 4.0? Or vice versa The plugin doesn't rely on cordova-android

Re: Deprecation of Config and the embedded use case (4.0.x related)

2015-03-17 Thread Andrew Grieve
On Tue, Mar 17, 2015 at 10:10 AM, Carlos Santana csantan...@gmail.com wrote: @Michal I would get together with Marcel and Martin, they are our Android goto SME @Joe Do we have all the test cases created now are some missing? How do you run this specific test cases on Android Studio? Google

Re: Deprecation of Config and the embedded use case (4.0.x related)

2015-03-17 Thread Andrew Grieve
The place where we're lacking on the plugins side (IMO), is that CLI / plugman create an application target in Gradle. This is no different form ANT, but it would be nice if you could denote your app as an android library so that it's easily usable by those wanting to embed. On Tue, Mar 17, 2015

Re: Introduction for Byoungro So

2015-03-17 Thread Andrew Grieve
Thanks for the intro Byoungro! --nohooks has been asked for a few times, so certainly a great place to start! On Tue, Mar 17, 2015 at 9:52 AM, Carlos Santana csantan...@gmail.com wrote: Welcome Byoungro Very exciting to see downstream contributing enhancements !!! That's good open source

[GitHub] cordova-ios pull request: CB-8084 conform AppDelegate.m with provi...

2015-03-17 Thread boboldehampsink
Github user boboldehampsink commented on the pull request: https://github.com/apache/cordova-ios/pull/128#issuecomment-82383984 Do you have an example for a build hook that implements `GCC_PREPROCESSOR_DEFINITIONS = $(inherited) DISABLE_PUSH_NOTIFICATIONS=1` --- If your

Re: Deprecation of Config and the embedded use case (4.0.x related)

2015-03-17 Thread Carlos Santana
Andrew where is this new enhancements documented, Only place I can find any documentation is here: http://cordova.apache.org/docs/en/4.0.0/guide_platforms_android_webview.md.html#Android%20WebViews Can you update this Docs? In addition to having the docs updated I think it will be great

[GitHub] cordova-plugin-file-transfer pull request: CB-5059 Add a CookieMan...

2015-03-17 Thread Kukiwon
Github user Kukiwon commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/60#issuecomment-82469301 Hi, I'm getting the same error with an app that's using Crosswalk though the Ionic CLI. After looking at the cli's source code, I found that it does

Re: Deprecation of Config and the embedded use case (4.0.x related)

2015-03-17 Thread Andrew Grieve
Not documented yet. That's one of the TODOs for 4.0.x On Tue, Mar 17, 2015 at 11:03 AM, Carlos Santana csantan...@gmail.com wrote: Andrew where is this new enhancements documented, Only place I can find any documentation is here:

Re: Deprecation of Config and the embedded use case (4.0.x related)

2015-03-17 Thread Andrew Grieve
I just mean use: apply plugin: 'android-library' rather than apply plugin: 'android' On Tue, Mar 17, 2015 at 11:09 AM, Carlos Santana csantan...@gmail.com wrote: Andrew when you say denote your app as an android library Your thinking a AAR archive, which includes the cordova-platform core,

[GitHub] cordova-plugin-file-transfer pull request: CB-5059 Add a CookieMan...

2015-03-17 Thread dpogue
Github user dpogue commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/60#issuecomment-82471654 https://github.com/apache/cordova-plugin-file-transfer/pull/68 should fix any remaining crashes when using Crosswalk. --- If your project is set up

[GitHub] cordova-plugin-file pull request: CB-8554 Updated source to pass F...

2015-03-17 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/102#issuecomment-82477043 Changes look good I think, but I've sadly landed some code before looking at this that causes it to not merge cleanly. Would you be able to rebase? --- If

[GitHub] cordova-plugin-file pull request: fix(ios): always use setters to ...

2015-03-17 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/104#issuecomment-82476143 Why not just enable ARC on the file? Cordova its plugins now assume ARC to be enabled, so problems will just keep popping up without it I think. --- If

[GitHub] cordova-plugin-file pull request: Reading a slice of an asset from...

2015-03-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/105 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Introduction for Julian Horn

2015-03-17 Thread Carlos Santana
Sorry hack, was not in a bad way, I meant in a clever and fast way. :-) I don't see any problems adding the check for the global and returning. On Tue, Mar 17, 2015 at 12:30 PM, Jesse purplecabb...@gmail.com wrote: The problem is the multiple document.addEventListener duck punch calls, and

[GitHub] cordova-mobile-spec pull request: CB-8694 Replaced dependencies pl...

2015-03-17 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/123 CB-8694 Replaced dependencies plugin with command line parameter https://issues.apache.org/jira/browse/CB-8694 You can merge this pull request into a Git repository by running:

[GitHub] cordova-plugin-file pull request: fix(ios): always use setters to ...

2015-03-17 Thread mgcrea
Github user mgcrea commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/104#issuecomment-82480827 Having to manually add the `-fobjc-arc` for every plugin file is quite a burden, not sure if I can add a whole folder. --- If your project is set up for it,

Google IO?

2015-03-17 Thread Carlos Santana
I applied to Google IO today If I win I'm wondering if any cordova committers applied it will be cool to meet. Also Google team do you guys some spare io secret codes for registration? I wil be glad to take one :-), send me private message -- Carlos Santana csantan...@gmail.com

Re: Google IO?

2015-03-17 Thread Joe Bowser
I put my name in for Google IO as well. I don't know for sure if Google is doing the puzzle thing, but I wouldn't be surprised if there were codes in the Google Developer documentation again this year. On Tue, Mar 17, 2015 at 10:03 AM Carlos Santana csantan...@gmail.com wrote: I applied to

[GitHub] cordova-plugin-file pull request: CB-7109: Android: Parse argument...

2015-03-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/97 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the