[GitHub] cordova-lib pull request:

2015-04-02 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/commit/c7f441b302aa13f8f42d7b8b6979d3efeb030ec3#commitcomment-10540924 In cordova-lib/src/cordova/lazy_load.js: In cordova-lib/src/cordova/lazy_load.js on line 120: This won't

[GitHub] cordova-lib pull request:

2015-04-02 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/commit/c7f441b302aa13f8f42d7b8b6979d3efeb030ec3#commitcomment-10541120 In cordova-lib/src/cordova/platform.js: In cordova-lib/src/cordova/platform.js on line 663: We may want to

[GitHub] cordova-plugin-camera pull request: Fix build error no orog.apache...

2015-04-02 Thread masakura
GitHub user masakura opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/82 Fix build error no orog.apache.cordova.file Although uses the org.apache.cordova.file.FileUtils package in ac4af88f551406fa7b38a1343a3fc423a9ae9233, there is no dependency

[GitHub] cordova-mobile-spec pull request: CB-8786 Updated plugin ids in cr...

2015-04-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-mobile-spec/pull/126 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request:

2015-04-02 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/commit/c7f441b302aa13f8f42d7b8b6979d3efeb030ec3#commitcomment-10540944 In cordova-lib/src/cordova/lazy_load.js: In cordova-lib/src/cordova/lazy_load.js on line 120: just a nit:

[GitHub] cordova-lib pull request:

2015-04-02 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/commit/c7f441b302aa13f8f42d7b8b6979d3efeb030ec3#commitcomment-10540985 In cordova-lib/src/cordova/lazy_load.js: In cordova-lib/src/cordova/lazy_load.js on line 109: Here is the

[GitHub] cordova-docs pull request: Document iOS specific callback for orie...

2015-04-02 Thread mmrko
Github user mmrko commented on the pull request: https://github.com/apache/cordova-docs/pull/276#issuecomment-88833458 Actually, that is a bug. If 'default' is specified in config.xml, it should produce plist values to support both landscape and portrait. I think this is

[GitHub] cordova-cli pull request: CB-8790 - Add information about Firefox ...

2015-04-02 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-cli/pull/211#issuecomment-89048242 Thanks Michael! Please submit a signed iCLA for future contributions. http://cordova.apache.org/#contribute --- If your project is set up for it, you

Re: ApacheCon NA, Austin, April 13-16

2015-04-02 Thread Homer, Tony
I hadn¹t been planning on attending ApacheCon, but I just found out that I need to go to Austin in April! Currently I am scheduled to be there April 21-22, but I might be able to bump that up a week. Would it be worth it to be in Austin during ApacheCon even if I am not able to actually attend

[GitHub] cordova-lib pull request: CB-8784 Prepare with no platforms should...

2015-04-02 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/200#issuecomment-89064360 +1 Restore platforms if none specified (like you're doing here) +1 Restore the given platform(s) if they are not yet added but are listed in the config.xml

[GitHub] cordova-lib pull request: Fix plugman install failure on iOS conta...

2015-04-02 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-lib/pull/193#issuecomment-89059205 Patch verified to work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

Cordova Monthly Hangouts - April Edition

2015-04-02 Thread Parashuram N (MS OPEN TECH)
Wanted to bump up the thread about Cordova hangouts. We have 10 responses so far. I plan to close the poll early tomorrow morning so that we have enough time to schedule the hangout and folks can make it. If you have not yet responded to the time, please add your preference here

[GitHub] cordova-cli pull request: CB-8790 - Add information about Firefox ...

2015-04-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/211 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: Fix plugman install failure on iOS conta...

2015-04-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/193 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [iOS] Converting to use Xcode Workspaces (in cordova-ios 4.x)

2015-04-02 Thread Shazron
Thanks Sidney, I'll take you up on that. Yeah I know the pain of the static framework -- we had cordova-ios as that once (pre 3.x I think), using that workflow you mentioned, it was indeed tedious. As for dynamic frameworks -- I managed to track down an iOS 7 iPhone, and without any changes to my

plugins, npm, and package.json …other art

2015-04-02 Thread Brian LeRoux
both reactnative [1] and nativescript [2] treading into the territory fleeting hope we could share work/code but probably good everyone does a bit of homework on the topic [1] https://github.com/facebook/react-native/issues/235 [2] https://github.com/NativeScript/NativeScript/issues/25

[GitHub] cordova-lib pull request: CB-8596 Expose APIs to retrieve platform...

2015-04-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/177 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-8784 Prepare with no platforms should...

2015-04-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/200 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-8703: Add support for semver and devi...

2015-04-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/187 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: ApacheCon NA, Austin, April 13-16

2015-04-02 Thread Andrew Grieve
Can't speak for everyone obviously, but looking at the schedule I'd be happy to miss Tuesday afternoon or any of Wednesday in favour of a Cordova coding session / social time. On Thu, Apr 2, 2015 at 5:54 PM, Homer, Tony tony.ho...@intel.com wrote: I hadn¹t been planning on attending ApacheCon,

Re: [proposal] [ANDROID] move inAppBrowser intents from onPageStarted to shouldOverrideUrlLoading

2015-04-02 Thread Andrew Grieve
shouldOverrideUrlLoading is what the main cordova webview uses, so that's certainly the right approach. I believe it should also add CATEGORY_BROWSABLE to the intent to ensure that the user is prompted to confirm whether they actually want to make the call. On Thu, Apr 2, 2015 at 7:07 PM, julio

[GitHub] cordova-lib pull request: CB-8791 Recognize UAP as a valid TargetP...

2015-04-02 Thread muratsu
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-lib/pull/201 CB-8791 Recognize UAP as a valid TargetPlatformIdentifier On jsprojManager.js we currently don't have UAP as TargetPlatformIdentifier. We should have UAP as a TargetPlatformIdentifier and

[proposal] [ANDROID] move inAppBrowser intents from onPageStarted to shouldOverrideUrlLoading

2015-04-02 Thread julio cesar sanchez
I've been looking into issues and I have seen this one: https://issues.apache.org/jira/browse/CB-8180 Right now the code to handle the tel links is inside the onPageStarted if (url.startsWith(WebView.SCHEME_TEL)) { try { Intent intent = new

[GitHub] cordova-plugin-dialogs pull request: CB-8773: Fix for iOS 8 keyboa...

2015-04-02 Thread sean-hill
Github user sean-hill commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/50#issuecomment-89077944 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

RE: ApacheCon NA, Austin, April 13-16

2015-04-02 Thread Ross Gardler (MS OPEN TECH)
We are organizing a Cordova BoF on Tue evening and there will be a dedicated table in the hack room for Cordova. Sent from my Windows Phone From: Andrew Grievemailto:agri...@chromium.org Sent: ‎4/‎2/‎2015 5:37 PM To: devmailto:dev@cordova.apache.org Subject: Re:

[GitHub] cordova-plugin-file-transfer pull request: CB-8721 Fixes incorrect...

2015-04-02 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/72#issuecomment-88864506 @purplecabbage, @nikhilkh are you ok with merging this? --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-inappbrowser pull request: CB-8661 Return executed ...

2015-04-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/97 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-inappbrowser pull request: CB-8635 Improves UX on w...

2015-04-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/98 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-inappbrowser pull request: CB-7689 Adds insertCSS s...

2015-04-02 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/100 CB-7689 Adds insertCSS support for windows platform You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-plugin-file-transfer pull request: CB-8589 Fixes upload fa...

2015-04-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/75 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-file-transfer pull request: CB-8583 Forces download...

2015-04-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/77 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-cli pull request: CB-8790 - Add information about Firefox ...

2015-04-02 Thread MichaelKohler
GitHub user MichaelKohler opened a pull request: https://github.com/apache/cordova-cli/pull/211 CB-8790 - Add information about Firefox OS to the README - Add Firefox OS as supported platform - Change App Manager to the newer WebIDE

[GitHub] cordova-plugin-file-transfer pull request: CB-8721 Fixes incorrect...

2015-04-02 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/72#issuecomment-88908206 Not yet. After we do wp8 4.0.0 with json.net. Otherwise we need to write every possible data contract. --- If your project is set

Re: Add Windows on OSX system fails in cordova 4.3 (window 3.8)

2015-04-02 Thread Steven Gill
Cool. Will start a discuss thread for 3.8.1. Agreed we need to do a tools release very soon. Lots of changes in the next one. On Wed, Apr 1, 2015 at 9:25 PM, Parashuram N (MS OPEN TECH) panar...@microsoft.com wrote: +1 to start a 3.8.1 We will also have a bunch of platforms that would have

[discuss] windows 3.8.1 release

2015-04-02 Thread Steven Gill
Any concerns?

RE: [discuss] windows 3.8.1 release

2015-04-02 Thread Sergey Grebnov (Akvelon)
+1 windows 3.8.1 release -Sergey -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, April 2, 2015 8:21 PM To: dev@cordova.apache.org Subject: [discuss] windows 3.8.1 release Any concerns?

Re: [discuss] windows 3.8.1 release

2015-04-02 Thread Jesse
+1, let's do it. @purplecabbage risingj.com On Thu, Apr 2, 2015 at 10:27 AM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: +1 windows 3.8.1 release -Sergey -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Thursday, April 2, 2015 8:21 PM To:

[GitHub] cordova-lib pull request: Fix plugman install failure on iOS conta...

2015-04-02 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/193#issuecomment-89059948 Thanks Casey! You should consider signing the CLA for future contributions. http://cordova.apache.org/#contribute btw, Best github picture