Re: Adding Other Platform Slaves to Medic

2015-04-17 Thread Parashuram N (MS OPEN TECH)
In an earlier mail, folks had said that they would also contribute slaves. Is there a process to begin that now ? On 4/17/15, 4:47 PM, "Dmitry Blotsky" wrote: >Hi list, > >Right now medic runs Android, iOS, Windows, and Windows Phone builds. The >instructions for adding new slaves are here: >htt

[GitHub] cordova-plugin-camera pull request: CB-8404 Rotate camera feed wit...

2015-04-17 Thread muratsu
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/88 CB-8404 Rotate camera feed with device orientation Fixed 2 bugs in windows where we have trouble rotating the image on preview and saving You can merge this pull request into a Git re

[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...

2015-04-17 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94106987 In preparing my test project: https://github.com/shazron/CB-7734 I had to remove the build artifacts folder, and I did a re-test. Now I can repro your

[iOS] can somebody reproduce this bug?

2015-04-17 Thread julio cesar sanchez
Hi, Can somebody see this issue and try to reproduce it on an iOS 8.1 or 8.2 device? https://issues.apache.org/jira/browse/CB-7734 shazron says he can't reproduce it

[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...

2015-04-17 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94105276 I'm testing on Xcode 6.3 too, that's strange, can you test on a real device with 8.1 or 8.2? can you test on a 8.1 simulator? can you repo the bug

[GitHub] cordova-medic pull request: [CB-8803] Properly fixing the intermit...

2015-04-17 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/44#discussion_r28638999 --- Diff: bin/medic.js --- @@ -0,0 +1,110 @@ +#!/usr/bin/env node + +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-medic pull request: [CB-8803] Properly fixing the intermit...

2015-04-17 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/44#discussion_r28638738 --- Diff: bin/medic.js --- @@ -0,0 +1,110 @@ +#!/usr/bin/env node + +/* + * Licensed to the Apache Software Foundation (ASF) under one

Medic Test Matrix

2015-04-17 Thread Dmitry Blotsky
Hi list, What are the changes what we would like made to the test/build matrix on Medic? Crosswalk is one that’s come up. Ant/Gradle and device/emulator are others. Once we get a good overview of the scenarios we want for testing, we can split up the builds accordingly. Kindly, Dmitry

Adding Other Platform Slaves to Medic

2015-04-17 Thread Dmitry Blotsky
Hi list, Right now medic runs Android, iOS, Windows, and Windows Phone builds. The instructions for adding new slaves are here: https://github.com/apache/cordova-medic/blob/master/SLAVES.md#connecting-to-apaches-master

[GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...

2015-04-17 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/4#issuecomment-94093160 Hi @Hirbod -- I created a new project, added the ios platform and the statusbar plugin (from github). Then added this: ```window.addEventListener("sta

[GitHub] cordova-medic pull request: [CB-8805] Added ability to specify a c...

2015-04-17 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/41#issuecomment-94092731 Ping. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...

2015-04-17 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94089798 My assertion is, I can't repro the failing bug at all. I'm using Xcode 6.3, deploying to iOS 8.2 and 7.1 Simulators. --- If your project is set up for it

[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...

2015-04-17 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94087506 This: "with the code on my pull request removing this line: alertController.view.frame = [[UIScreen mainScreen] applicationFrame];" --- If your projec

[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...

2015-04-17 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94087108 You mean without all the code on my pull request or with the code on my pull request removing this line: alertController.view.frame = [[UIScreen m

[GitHub] cordova-medic pull request: [CB-8803] Properly fixing the intermit...

2015-04-17 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-medic/pull/44 [CB-8803] Properly fixing the intermittent cleanup issue. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-medic CB-880

Re: Buildbot for Cordova on Apache Infra - Update

2015-04-17 Thread Dmitry Blotsky
I’m a bit confused. Is this related to FirefoxOS? Kindly, Dmitry > On Apr 17, 2015, at 9:06 AM, Nikhil Khandelwal wrote: > > Sure - that sounds like a good idea. One approach for this to work could be > as part of the cordova-android-osx & cordova-android-win builder, there could > be two ste

[GitHub] cordova-plugin-dialogs pull request: add password and login/passwo...

2015-04-17 Thread toromand
Github user toromand commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/14#issuecomment-94051322 Yes, you are right. I noticed late that the proposed change is IOS only. On the other hand, I know this is easy to implement on Android (similar is al

[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...

2015-04-17 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-94049313 Starting over again. On iOS 8.2, and 7.1 Simulators -- I'm trying to make this "fail". Without your fix: ``` alertController.view.frame = [[UI

[GitHub] cordova-plugin-dialogs pull request: add password and login/passwo...

2015-04-17 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/14#issuecomment-94024286 Still waiting to hear on the icla Also, adding this to iOS only is adding a quirk, not a feature. And, spin changes should have accompanying

RE: Buildbot for Cordova on Apache Infra - Update

2015-04-17 Thread Nikhil Khandelwal
Sure - that sounds like a good idea. One approach for this to work could be as part of the cordova-android-osx & cordova-android-win builder, there could be two steps added: - Add the latest version of the Crosswalk plugin from npm - Run the core plugin tests again. Does Crosswalk have any of it

[GitHub] cordova-plugin-camera pull request: added allowEdit support for an...

2015-04-17 Thread roysG
Github user roysG commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/12#issuecomment-94015245 there is still problem with cropping in android, when choose to capture image. I can׳t crop, why ? --- If your project is set up for it, you can reply

Re: [Vote] Tools Release

2015-04-17 Thread Parashuram N (MS OPEN TECH)
Voting +1 * Verified signatures and hashes * Verified tags * Ability to install/uninstall Cordova * Ability to update Cordova * Ability to create blank app for Windows, WP8, Android * Ability to run apps * Reviewed release notes On 4/16/15, 1:24 PM, "Steven Gill" wrote: >Please review and v

[GitHub] cordova-blackberry pull request: CB-8872 Add parens to disambiguat...

2015-04-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-blackberry/pull/182 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] cordova-blackberry pull request: CB-8872 Add parens to disambiguat...

2015-04-17 Thread jsoref
GitHub user jsoref opened a pull request: https://github.com/apache/cordova-blackberry/pull/182 CB-8872 Add parens to disambiguate ! / instanceof You can merge this pull request into a Git repository by running: $ git pull https://github.com/blackberry/cordova-blackberry cb_88

[GitHub] cordova-plugin-dialogs pull request: add password and login/passwo...

2015-04-17 Thread toromand
Github user toromand commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/14#issuecomment-93971700 Any news on this? Seems like a nice (and needed) feature. If the original author of the change is not available and not willing to contribute, can som

[GitHub] cordova-plugin-whitelist pull request: Fixed error in Content-Secu...

2015-04-17 Thread starquake
GitHub user starquake opened a pull request: https://github.com/apache/cordova-plugin-whitelist/pull/3 Fixed error in Content-Security-Policy example There's an error in the example. There's a colon after script-src that shouldn't be there. You can merge this pull request into a Gi

[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...

2015-04-17 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-93894696 No, I've just tried and doesn't work if I do it that way (alertController.view.frame = [self invertFrameIfNeeded:[UIScreen mainScreen].applicationFra

[GitHub] cordova-medic pull request: [CB-8853] Killing Android emulator bef...

2015-04-17 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-medic/pull/43 [CB-8853] Killing Android emulator before build. This works around the issue with the running emulator process preventing running builds. A full solution will come later with a deeper dive in

Re: Keyboard plugin

2015-04-17 Thread Kerri Shotts
Well, it’s been a while, but I finally found some time to work up some keyboard avoidance examples. Here’s a link to the post on the forum: https://groups.google.com/d/msg/phonegap/1nRXfhI7JtQ/ENPL-MNIadYJ, and the corresponding repository: https://github.com/kerrishotts/cordova-keyboard-examp

[GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...

2015-04-17 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/39#issuecomment-93868240 I think for the landscape problem, you should do this instead: https://github.com/apache/cordova-plugin-statusbar/blob/2b3935af315034fdf6626a1010e91d3d8f44