[GitHub] cordova-plugin-camera pull request: solves CB-8804 https://github....

2015-04-21 Thread thehuijb
Github user thehuijb commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/83#issuecomment-94649473 Anyone had a chance to look at this yet? I would appreciate any comments that help improve this PR --- If your project is set up for it, you can

[GitHub] cordova-plugin-file-transfer pull request: CB-6313 [wp8]: Extra bo...

2015-04-21 Thread dpolivy
Github user dpolivy commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/73#issuecomment-94885204 @stevengill Is there someone who can review and merge this? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-splashscreen pull request: CB-8750 [wp8]: Allow res...

2015-04-21 Thread dpolivy
Github user dpolivy commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/41#issuecomment-94884712 @purplecabbage Is that strictly necessary, given the code is quite straightforward and fairly common? I'd love to get this merged in if possible.

Re: [VOTE] Plugins Release

2015-04-21 Thread Jesse
+1 @purplecabbage risingj.com On Tue, Apr 21, 2015 at 10:29 AM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: I vote +1 * Performed manual ad-hoc testing -Sergey Grebnov -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Tuesday, April 21, 2015

[GitHub] cordova-plugin-camera pull request: CB-8404 Rotate camera feed wit...

2015-04-21 Thread muratsu
Github user muratsu commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/88#issuecomment-94889877 Rebased and squashed - ready to merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-plugin-statusbar pull request: CB-8001

2015-04-21 Thread Nonsense331
Github user Nonsense331 commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/19#issuecomment-94914549 This also fixed an issue i had where my app was crashing after taking a photo using the cordova camera plugin. :+1: --- If your project is set up

Re: [VOTE] Plugins Release

2015-04-21 Thread Steven Gill
Need 1 more vote On Thu, Apr 16, 2015 at 9:50 AM, Parashuram N (MS OPEN TECH) panar...@microsoft.com wrote: +1 vote * Verified signatures and hashes * Verified tags * Verified plugins added correctly to blank * Verified blank app can be successfully ran and built for * Ran smoke testing

[GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...

2015-04-21 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/4#issuecomment-94913693 Hi @Hirbod, Please file a separate issue at https://issues.apache.org/jira/browse/CB. I fear this will be buried in Github since it is already

[GitHub] cordova-plugin-camera pull request: CB-7667 iOS8: Handle case wher...

2015-04-21 Thread dpolivy
Github user dpolivy commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/49#issuecomment-94880942 @stevengill @shazron Is it possible to get a review on this and some feedback on whether it is OK to merge? --- If your project is set up for it, you can

[GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...

2015-04-21 Thread Hirbod
Github user Hirbod commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/4#issuecomment-94915215 Is it enough when I just link to our conversation? Or do I need to paste everything again there @shazron ? And thanks for your help! --- If your project

RE: [VOTE] Plugins Release

2015-04-21 Thread Sergey Grebnov (Akvelon)
I vote +1 * Performed manual ad-hoc testing -Sergey Grebnov -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent: Tuesday, April 21, 2015 10:16 AM To: dev@cordova.apache.org Subject: Re: [VOTE] Plugins Release Need 1 more vote On Thu, Apr 16, 2015 at 9:50 AM,

[GitHub] cordova-plugin-splashscreen pull request: CB-8758 [wp8]: Unauthori...

2015-04-21 Thread dpolivy
Github user dpolivy commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/42#issuecomment-94884271 @stevengill @purplecabbage @sgrebnov Is it possible to get someone to review and merge this? --- If your project is set up for it, you can reply to

[GitHub] cordova-plugin-file-transfer pull request: CB-8761 [wp8]: Copy coo...

2015-04-21 Thread dpolivy
Github user dpolivy commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/74#issuecomment-94885261 @stevengill Is there someone who can review and merge this? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-camera pull request: solves CB-8804 https://github....

2015-04-21 Thread agrieve
Github user agrieve commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/83#issuecomment-94831626 just went to have a look but the diff has changes that you didn't make in it. Can you try rebasing? --- If your project is set up for it, you can reply

Re: Scoped package names for npm?

2015-04-21 Thread Andrew Grieve
Given the state of some of our plugins, dropping the distinguishing namespace might be a good thing :P On Tue, Apr 21, 2015 at 8:45 AM, Horn, Julian C julian.c.h...@intel.com wrote: I am also against another rename. These name changes are very costly and disruptive. There is code in several

[GitHub] cordova-windows pull request: Alt for discussion: CB-8866: add Mi...

2015-04-21 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-windows/pull/69#issuecomment-94813170 Withdrawn for reasons described in #68. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

RE: Scoped package names for npm?

2015-04-21 Thread Horn, Julian C
I am also against another rename. These name changes are very costly and disruptive. There is code in several places that assumes that you can enumerate the plugins selected by a project by enumerating the subdirectories of plugins. If you allow a plugin root folder to be more than a single

[GitHub] cordova-windows pull request: For discussion: CB-8869 remove Windo...

2015-04-21 Thread brodybits
Github user brodybits commented on the pull request: https://github.com/apache/cordova-windows/pull/68#issuecomment-94813044 Withdrawn. It is possible to configure an app to target Windows 8.1 in config.xml. To completely remove Windows 8.0 would entail removing

[GitHub] cordova-windows pull request: For discussion: CB-8869 remove Windo...

2015-04-21 Thread brodybits
Github user brodybits closed the pull request at: https://github.com/apache/cordova-windows/pull/68 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-windows pull request: Alt for discussion: CB-8866: add Mi...

2015-04-21 Thread brodybits
Github user brodybits closed the pull request at: https://github.com/apache/cordova-windows/pull/69 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-medic pull request: [CB-8803] Properly fixing the intermit...

2015-04-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/44 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-camera pull request: CB-8054 Support taking picture...

2015-04-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/86 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Scoped package names for npm?

2015-04-21 Thread Michal Mocny
Okay fair enough. I was hoping that with the lack of tools release to stable, we can rename without affecting end users *right now*, but not *soon*. If we never want to use scopes, fair enough. If we ever do, it will only get more difficult. -Michal On Tue, Apr 21, 2015 at 11:04 AM, Andrew

[GitHub] cordova-ios pull request: CB-8485 Support for creating signed arch...

2015-04-21 Thread nikhilkh
GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-ios/pull/138 CB-8485 Support for creating signed archive for iOS Allows the user to specify the provisioning profile and the signing identity using the command line and a build.json file. You can merge

RE: Build signed archives using CLI

2015-04-21 Thread Nikhil Khandelwal
Support for iOS is in this PR now: https://github.com/apache/cordova-ios/pull/138 It allows you to specify a signing identity and a provisioning profile using command line arguments or build.json. Thanks, Nikhil -Original Message- From: Nikhil Khandelwal

[GitHub] cordova-plugin-camera pull request: solves CB-8804 https://github....

2015-04-21 Thread thehuijb
Github user thehuijb commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/83#issuecomment-94953716 alright, rebased to master, should be only my changes now. sorry about that, it still git's me sometimes --- If your project is set up for it, you

Re: Deprecation Wars: ICS vs Gingerbread

2015-04-21 Thread Shazron
Joe, perhaps that can be part of the Tools Release blog post? Steve put out a link to the draft in another thread. On Tue, Apr 21, 2015 at 10:14 AM, Joe Bowser bows...@gmail.com wrote: Resurrecting this thread! I think we need to let our users know that Cordova 4.0 doesn't support

[GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...

2015-04-21 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/4#issuecomment-94920959 If you could paste it in (only the relevant parts), that will be great. Thanks! --- If your project is set up for it, you can reply to this email and

[ANNOUNCEMENT] Cordova Tools (CLI 5.0.0) + Plugins (renamed) have been released

2015-04-21 Thread Steven Gill
Tools and plugins have been released. Includes fetching from npm and renamed plugins. Plugins: http://cordova.apache.org/announcements/2015/04/21/plugins-release-and-move-to-npm.html Tools: http://cordova.apache.org/news/2015/04/21/tools-release.html Tweets:

[GitHub] cordova-plugin-file-transfer pull request: CB-6313 [wp8]: Extra bo...

2015-04-21 Thread gmbad
Github user gmbad commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/73#issuecomment-94990412 dpolivy, maybe in new version 1.0.0 (Apr 15, 2015), its ok. No? --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-plugin-file-transfer pull request: CB-6313 [wp8]: Extra bo...

2015-04-21 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/73#issuecomment-94991229 This didn't get reviewed for 1.0.0 release but will review it so it makes the next one --- If your project is set up for it, you can reply to

RE: [DISCUSS] Docs release

2015-04-21 Thread Sergey Grebnov (Akvelon)
I've sent a PR to update platform guides as per discussion in a separate thread; it will be great if we can review and include it to docs release https://github.com/apache/cordova-docs/pull/279 Thx! Sergey -Original Message- From: Steven Gill [mailto:stevengil...@gmail.com] Sent:

[GitHub] cordova-plugin-file-transfer pull request: CB-6313 [wp8]: Extra bo...

2015-04-21 Thread gmbad
Github user gmbad commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/73#issuecomment-94999385 Well, while the correction is not published, i did an upload via base64 scheme for windows phone . If anyone is interested, contact me ... --- If

Re: [ANNOUNCEMENT] Cordova Tools (CLI 5.0.0) + Plugins (renamed) have been released

2015-04-21 Thread Raymond Camden
Query - the blog listing on the home page isn't updated. Is that a known issue? On Tue, Apr 21, 2015 at 5:46 PM, Steven Gill stevengil...@gmail.com wrote: Tools and plugins have been released. Includes fetching from npm and renamed plugins. Plugins:

Re: [ANNOUNCEMENT] Cordova Tools (CLI 5.0.0) + Plugins (renamed) have been released

2015-04-21 Thread Shazron
It should be, I see it? On Tue, Apr 21, 2015 at 8:12 PM, Raymond Camden raymondcam...@gmail.com wrote: Query - the blog listing on the home page isn't updated. Is that a known issue? On Tue, Apr 21, 2015 at 5:46 PM, Steven Gill stevengil...@gmail.com wrote: Tools and plugins have been

[GitHub] cordova-coho pull request: Fixed dist-tag command

2015-04-21 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-coho/pull/72 Fixed dist-tag command You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-coho patch-35 Alternatively you can review

[GitHub] cordova-coho pull request: Fixed dist-tag command

2015-04-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/72 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-coho pull request: Added npm publish step to plugins relea...

2015-04-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/71 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

How to get plugin lists for cordova-android 3.7.x

2015-04-21 Thread Fu, Junwei
Hi All, Mobile-spec has no 3.7.x branch, how can I get the plugin lists for cordova-android 3.7.x, and how to build mobile-spec to test cordova-android 3.7.x, do we use the latest cordova-plugin-test-framework, cordova-cli, cordova-mobile-spec and so on. Thanks, Junwei.

[DISCUSS] Docs release

2015-04-21 Thread Steven Gill
I'm going to look into doing this. Any blockers, let me know Don't believe we have to vote on this one.

[GitHub] cordova-coho pull request: Added npm publish step to plugins relea...

2015-04-21 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-coho/pull/71 Added npm publish step to plugins release You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevengill/cordova-coho patch-34

[GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...

2015-04-21 Thread Hirbod
Github user Hirbod commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/4#issuecomment-94870732 @shazron, it seems like the Google Maps Plugin cause this error: https://github.com/wf9a5m75/phonegap-googlemaps-plugin The plugin

[GitHub] cordova-plugin-statusbar pull request: Added javascript event on s...

2015-04-21 Thread Hirbod
Github user Hirbod commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/4#issuecomment-94876888 At least it seems that https://github.com/j-mcnally/cordova-statusTap/blob/master/src/ios/TapToScroll.m is doing something right which doenst get

Re: Deprecation Wars: ICS vs Gingerbread

2015-04-21 Thread Joe Bowser
Resurrecting this thread! I think we need to let our users know that Cordova 4.0 doesn't support Gingerbread, or at least some of the features don't work on Gingerbread. I've been trying to clean up the JIRA a bit today, and it seems that while we came to a consensus to drop 2.3, we didn't tell

Re: Scoped package names for npm?

2015-04-21 Thread Brian LeRoux
the npm team has granted us the cordova org/scope when/if we're ready for it. On Tue, Apr 21, 2015 at 8:37 AM, Michal Mocny mmo...@chromium.org wrote: Okay fair enough. I was hoping that with the lack of tools release to stable, we can rename without affecting end users *right now*, but not