[GitHub] cordova-medic pull request: CB-8936 Gathering logs for Android

2015-05-08 Thread alsorokin
Github user alsorokin commented on the pull request: https://github.com/apache/cordova-medic/pull/53#issuecomment-100157491 @dblotsky thanks for the review, I've addressed your comments and updated the PR. --- If your project is set up for it, you can reply to this email and have you

[GitHub] cordova-plugin-statusbar pull request: Stop "object has no method"...

2015-05-08 Thread Gillardo
GitHub user Gillardo opened a pull request: https://github.com/apache/cordova-plugin-statusbar/pull/25 Stop "object has no method" errors on windows If you called show or hide, you would get an "object has no method" error as getViewStatusBar would return null. You can merge thi

[GitHub] cordova-mobile-spec pull request: CB-8992 Do not install mobilespe...

2015-05-08 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-mobile-spec/pull/128 CB-8992 Do not install mobilespec tests when --plugins specified https://issues.apache.org/jira/browse/CB-8992 You can merge this pull request into a Git repository by running: $

[GitHub] cordova-mobile-spec pull request: CB-8992 Do not install mobilespe...

2015-05-08 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/128#issuecomment-100219011 :1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

Re: Cordova 5.0 user feedback - move to npm & whitelist plugin

2015-05-08 Thread Raymond Camden
On Thu, May 7, 2015 at 8:16 PM, Steven Gill wrote: > > (2) It is a fairly recent change. Any new app made with cordova-cli 5+ will > auto include the whitelist plugin due to the hello world config.xml > including it as a dependency. I think we need to document it more and make > more noise within

[GitHub] cordova-mobile-spec pull request: CB-8727 Fix failing WebSQL test ...

2015-05-08 Thread ktop
Github user ktop commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/124#issuecomment-100264782 Can someone take a look at this? I think it should be a simple merge --- If your project is set up for it, you can reply to this email and have your reply app

RE: No Readme for plugin packages on npm

2015-05-08 Thread Nikhil Khandelwal
Thanks, Steve. Let me know if you run into headwind with fixing this - I'll be happy to help out removing the problematic comments. Though that would require another plugin release to get it out. From Shaz's previous reference to Apache policy, it might be fine for the .md files to not have the

[GitHub] cordova-plugin-splashscreen pull request: CB-8988: Fix rotation on...

2015-05-08 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/46#issuecomment-100305790 Thanks for the PR Dan -- I'm away, will take a look Monday. --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] cordova-plugin-camera pull request: CB-7667 iOS8: Handle case wher...

2015-05-08 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/49#issuecomment-100305930 Thanks for the PR Dan -- I'm away, will take a look Monday. --- If your project is set up for it, you can reply to this email and have your reply appear o

[GitHub] cordova-plugin-splashscreen pull request: CB-3562: Disable screen ...

2015-05-08 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/47#issuecomment-100306319 Thanks for the PR Dan -- I'm away, will take a look Monday. --- If your project is set up for it, you can reply to this email and have your reply ap

Re: No Readme for plugin packages on npm

2015-05-08 Thread Steven Gill
Not sure if we need to do a release if all we change is the readme. Shaz, any thoughts? On Fri, May 8, 2015 at 10:02 AM, Nikhil Khandelwal wrote: > Thanks, Steve. Let me know if you run into headwind with fixing this - > I'll be happy to help out removing the problematic comments. Though that >

[GitHub] cordova-mobile-spec pull request: CB-8992 Do not install mobilespe...

2015-05-08 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/128#issuecomment-100320977 Why not install the mobilespec tests when the plugin is installed? Why is this undesired behaviour? --- If your project is set up for it, you can reply t

[GitHub] cordova-plugin-media pull request: Handles the "playAudioWhenScree...

2015-05-08 Thread romedius
GitHub user romedius opened a pull request: https://github.com/apache/cordova-plugin-media/pull/54 Handles the "playAudioWhenScreenIsLocked" similar to the iOS behaviour. If the Flag is not set the media will be played (standard behaviour up to now. If the Flag is set to fa

[GitHub] cordova-mobile-spec pull request: CB-8727 Fix failing WebSQL test ...

2015-05-08 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/124#issuecomment-100322451 What was the purpose of the call before? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] cordova-mobile-spec pull request: CB-8727 Fix failing WebSQL test ...

2015-05-08 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/124#issuecomment-100323303 I think it was to make sure the most recent additions were seen. Seems someone magically assumed it would always be less than 2 lines. --- If y

Re: No Readme for plugin packages on npm

2015-05-08 Thread Shazron
It's a new release - so in short, yes in regards to a vote (you'll need to up the ver# to publish to npm correct? So it's a new release). On Friday, May 8, 2015, Steven Gill wrote: > Not sure if we need to do a release if all we change is the readme. Shaz, > any thoughts? > > On Fri, May 8, 201

[GitHub] cordova-mobile-spec pull request: CB-8727 Fix failing WebSQL test ...

2015-05-08 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/124#issuecomment-100325757 Oh, so it's mostly a convenience for a human tester? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHu

[GitHub] cordova-mobile-spec pull request: CB-8727 Fix failing WebSQL test ...

2015-05-08 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/124#issuecomment-100326111 yes. I believe that was the intent, although it obviously failed. This is an easy merge. +1 --- If your project is set up for it, you can reply t

Re: No Readme for plugin packages on npm

2015-05-08 Thread Steven Gill
alright finee On Fri, May 8, 2015 at 11:41 AM, Shazron wrote: > It's a new release - so in short, yes in regards to a vote (you'll need to > up the ver# to publish to npm correct? So it's a new release). > > > On Friday, May 8, 2015, Steven Gill wrote: > > > Not sure if we need to do a

[GitHub] cordova-mobile-spec pull request: CB-8727 Fix failing WebSQL test ...

2015-05-08 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/124#issuecomment-100330631 Merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have thi

Buildbot: buildslave cordova-ios-slave was lost

2015-05-08 Thread buildbot
The Buildbot working for 'ASF Buildbot' has noticed that the buildslave named cordova-ios-slave went away It last disconnected at Fri May 8 19:04:55 2015 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Dmitry Blotsky '. Sincerely, The Buildbot http://

[GitHub] cordova-mobile-spec pull request: CB-8727 Fix failing WebSQL test ...

2015-05-08 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/124#issuecomment-100331095 I done goofed and forgot to say "This closes #124". Merged though. --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] cordova-mobile-spec pull request: CB-8992 Do not install mobilespe...

2015-05-08 Thread sgrebnov
Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/128#issuecomment-100331390 If I explicitly specify list of plugins to be tested I don't want to run org.apache.cordova.mobilespec.tests (they represent some extra tests not related

[GitHub] cordova-plugin-contacts pull request: CB-8987: Support for save an...

2015-05-08 Thread robpaveza
GitHub user robpaveza opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/62 CB-8987: Support for save and remove for Windows 10 This change adds save and remove support to the contacts plugin when running on Windows 10. When the functionality isn't availa

RE: Plugins release prep: Cherry-picking plugin updates

2015-05-08 Thread Rob Paveza
Steven, thanks so much for all your help getting the plugins released. -Original Message- From: Murat Sutunc [mailto:mura...@microsoft.com] Sent: Wednesday, May 6, 2015 1:42 PM To: dev@cordova.apache.org Subject: RE: Plugins release prep: Cherry-picking plugin updates Hey, took me a whil

RE: Buildbot: buildslave cordova-ios-slave was lost

2015-05-08 Thread Dmitry Blotsky
Booted the machine to resolve a strange emulator bug, and machine took over 10 minutes to boot. -Original Message- From: build...@apache.org [mailto:build...@apache.org] Sent: Friday, May 8, 2015 12:10 PM To: dev@cordova.apache.org Subject: Buildbot: buildslave cordova-ios-slave was los

Re: [DISCUSS] wp8@3.8.1, windows@3.8.2, android@4.0.1 release

2015-05-08 Thread Steven Gill
Release issue: https://issues.apache.org/jira/browse/CB-8997 Going to get this out today. I think the pinned platform discussion should get its own thread. If I recall correctly, it was done so it would be easier to identify which platforms are working with which tool versions. If we are staying

[GitHub] cordova-plugin-file-transfer pull request: CB-8951 Fixed crash rel...

2015-05-08 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/82#issuecomment-100380328 Gotcha. That JIRA seems enough. I was concerned that we might forget to do the "correct fix", but my concerns were largely unfounded; seems like th

[GitHub] cordova-mobile-spec pull request: CB-8992 Do not install mobilespe...

2015-05-08 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-mobile-spec/pull/128#discussion_r29981882 --- Diff: createmobilespec/createmobilespec.js --- @@ -56,7 +56,8 @@ function popd(dir) { } function pluginAdd(pluginName, search

[GitHub] cordova-mobile-spec pull request: CB-8992 Do not install mobilespe...

2015-05-08 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-mobile-spec/pull/128#discussion_r29981911 --- Diff: createmobilespec/createmobilespec.js --- @@ -546,11 +547,12 @@ function installPlugins() { console.log("Installing local t

[GitHub] cordova-mobile-spec pull request: CB-8992 Do not install mobilespe...

2015-05-08 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/128#issuecomment-100384365 Ok. Sounds reasonable. I left some comments in review. --- If your project is set up for it, you can reply to this email and have your reply appear on Git

[GitHub] cordova-plugin-contacts pull request: CB-8987: Support for save an...

2015-05-08 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/62#issuecomment-100388932 Will run tests on medic, since Travis doesn't run the tests on Windows. --- If your project is set up for it, you can reply to this email and have your

[Vote] Android@4.0.1, WP8@3.8.1, Windows@3.8.2 Releases

2015-05-08 Thread Steven Gill
Please review and vote on these releases by replying to this email (and keep discussion on the DISCUSS thread) These releases are just including an updated snapshot of cordova.js so it works with ripple again. Release issue: https://issues.apache.org/jira/browse/CB-8997 The archive has been publ

[BUG] Mobilespec hangs on Windows

2015-05-08 Thread Dmitry Blotsky
Hi list, >From some point between 10PM May 7th and 2AM May 8th, mobilespec on Windows >has started hanging upon loading of the automated tests page. I've tried to >list the commits in that time, but got nowhere. Is anyone else seeing this? If >you have any idea on the cause, or a fix, please sh

RE: [BUG] Mobilespec hangs on Windows

2015-05-08 Thread Dmitry Blotsky
Correction: the commit time range is 10PM to 6AM. -Original Message- From: Dmitry Blotsky [mailto:dblot...@microsoft.com] Sent: Friday, May 8, 2015 6:06 PM To: dev@cordova.apache.org Subject: [BUG] Mobilespec hangs on Windows Hi list, >From some point between 10PM May 7th and 2AM May 8t

[GitHub] cordova-coho pull request: CB-8950 Add NSP to travis

2015-05-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/74 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is