[GitHub] cordova-lib pull request: The concat() method returns a new array.

2015-05-13 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/216#issuecomment-101574980 This should probably also use __.uniq Instead of the double loop, or __.union --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-plugin-camera pull request: solves CB-8804 https://github....

2015-05-13 Thread Serge Huijben
Any chance this PR https://github.com/apache/cordova-plugin-camera/pull/83 https://github.com/apache/cordova-plugin-camera/pull/83 could get merged in? regards Serge a.k.a: thehuijb signature.asc Description: Message signed with OpenPGP using GPGMail

[GitHub] cordova-lib pull request: The concat() method returns a new array.

2015-05-13 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/216#issuecomment-101572757 +1 'concat does not alter this or any of the arrays ... '

[GitHub] cordova-plugin-camera pull request: fix wp8.1 UI, added wp8.1 focu...

2015-05-13 Thread Gillardo
Github user Gillardo commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/77#issuecomment-101711464 Found an issue though that if you zoom in, then the buttons disappear and you cannot take the photo --- If your project is set up for it, you can reply

Re: Cordova 5.0 user feedback - move to npm whitelist plugin

2015-05-13 Thread Raymond Camden
Ah interesting. Where is the default config.xml actually defined? I assume it is baked in and a user can't change the default used? On Tue, May 12, 2015 at 11:02 AM, Andrew Grieve agri...@chromium.org wrote: if you use --copy-from and the template doesn't already have a config.xml, then the

Re: Cordova 5.0 user feedback - move to npm whitelist plugin

2015-05-13 Thread Andrew Grieve
It's here: cordova-lib/cordova-lib/node_modules/cordova-app-hello-world/config.xml A use can change the defaults by providing a config.xml within their own template (--copy-from target) On Wed, May 13, 2015 at 10:51 AM, Raymond Camden raymondcam...@gmail.com wrote: Ah interesting. Where is the

[GitHub] cordova-windows pull request: CB-9015: Merge windows10 support to ...

2015-05-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/76 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera pull request: CB-8879 fix stripe issue with ...

2015-05-13 Thread muratsu
Github user muratsu commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/94#discussion_r30262108 --- Diff: src/windows/CameraProxy.js --- @@ -337,28 +336,48 @@ function takePictureFromCameraWP(successCallback, errorCallback, args) {

[GitHub] cordova-plugin-camera pull request: CB-8879 fix stripe issue with ...

2015-05-13 Thread muratsu
Github user muratsu commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/94#discussion_r30262317 --- Diff: src/windows/CameraProxy.js --- @@ -438,6 +457,61 @@ function takePictureFromCameraWP(successCallback, errorCallback, args) {

[GitHub] cordova-plugin-contacts pull request: CB-8987: Support for save an...

2015-05-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/62 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

Re: plugins.cordova.io

2015-05-13 Thread Shazron
Good idea. Maybe also file an issue under the 'cordova-registry-web' component On Wed, May 13, 2015 at 12:42 PM, Josh Soref jso...@blackberry.com wrote: I think it'd be helpful if plugins.cordova.io included a banner informing people that it's going away. Preferably w/ a link to something

[GitHub] cordova-plugin-camera pull request: CB-8879 fix stripe issue with ...

2015-05-13 Thread muratsu
Github user muratsu closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/94 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-windows pull request: CB-9015: Merge windows10 support to ...

2015-05-13 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/76#issuecomment-101816672 Looks good to me too! +1 to merge. I am not yet completely setup to test win10, so I am taking some things on faith, but looking over the code it all

[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-05-13 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-101816514 Is this required for development time experience or every app needs access to localhost port 8472 to run on the phone? --- If your project is set up

[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-05-13 Thread jsoref
Github user jsoref commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-101817138 It's required for runtime if an app (running on BlackBerry 10) has any plugins. The app doesn't actually talk to port 8472, it's just magically

Re: [DISCUSS] Cordova-Windows Release

2015-05-13 Thread Jesse
Rob, I am looking through it now and will get back to you later today. I'll start a new thread on it too. Cheers, Jesse @purplecabbage risingj.com On Tue, May 12, 2015 at 1:59 PM, Rob Paveza rob.pav...@microsoft.com wrote: Jesse, where have we landed on the issue of the local-notifications

RE: [GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-05-13 Thread Josh Soref
https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-10142 9782 Problem: As is, today, Cordova projects created w/ the default cordova hello-world template which have any plugins won't work on BlackBerry 10 at-all My fix is to add a CSP whitelist for the BlackBerry 10 magic

Re: [DISCUSS] Dropping the -dev suffix

2015-05-13 Thread Andrew Grieve
I think -dev is working fine and doing what it's supposed to do. The logic of -label is subtle: var sem = require('semver') undefined sem.satisfies('4.0.0-dev', '=4.0.0') false sem.satisfies('4.0.0-dev', '=4.0') true So, the engine check should just to =4.0, or =4.0.0-dev On Wed, May 13,

Re: [DISCUSS] Docs release

2015-05-13 Thread Steven Gill
Pushed a 5.0.0 for russian docs, updated edge docs for others On Mon, May 11, 2015 at 10:52 AM, Steven Gill stevengil...@gmail.com wrote: Thanks Andrey, I'll regenerate 5.0.0 and push an update later today. -Steve On Mon, May 11, 2015 at 6:53 AM, Andrey Kurdumov kant2...@googlemail.com

plugins.cordova.io

2015-05-13 Thread Josh Soref
I think it'd be helpful if plugins.cordova.io included a banner informing people that it's going away. Preferably w/ a link to something explaining the transition plan+schedule. smime.p7s Description: S/MIME cryptographic signature

Re: [GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-05-13 Thread Jesse
Can we use a plugin hook to modify the csp in the bb10 start html page? localhost is not defined on most platforms afaik, so it may be less of an issue. @purplecabbage risingj.com On Wed, May 13, 2015 at 1:00 PM, Josh Soref jso...@blackberry.com wrote:

[GitHub] cordova-windows pull request: CB-9015: Merge windows10 support to ...

2015-05-13 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-windows/pull/76#issuecomment-101816033 LGTM for merge! @purplecabbage for review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

Re: [DISCUSS] Dropping the -dev suffix

2015-05-13 Thread Jesse
It is and it is failing currently. In the file-transfer plugin [1] engine name=cordova-wp8 version==4.0.0/ ... Failed to install 'cordova-plugin-file-transfer':CordovaError: Plugin doesn't support this project's cordova-wp8 version. cordova-wp8: 4.0.0-dev, failed version requirement: 1.0.0 ...

[GitHub] cordova-js pull request: CB-9016: Added template-packaged WinJS re...

2015-05-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/111 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

RE: plugins.cordova.io

2015-05-13 Thread Josh Soref
https://issues.apache.org/jira/browse/CB-9026 -Original Message- From: Shazron [mailto:shaz...@gmail.com] Sent: Wednesday, May 13, 2015 4:19 PM To: dev@cordova.apache.org Subject: Re: plugins.cordova.io Good idea. Maybe also file an issue under the 'cordova-registry-web' component

Re: [DISCUSS] Dropping the -dev suffix

2015-05-13 Thread Steven Gill
switching engine to =4.0 (no patch version) seems to make the most sense for this problem. On Wed, May 13, 2015 at 4:21 PM, Jesse purplecabb...@gmail.com wrote: Yes, I just verified the same. Changing the plugin.xml engine to : cordova-wp8 =4.0.0-- will allow install for both wp8@4.0.0 and

Re: [DISCUSS] Dropping the -dev suffix

2015-05-13 Thread Jesse
So back to the initial discussion, should we keep our -dev suffixes? If so we need to be sure to use engine tags like '=4.0' or if you specifically want to force a specific min patch, and still allow the dev suffix, you can do '=4.0.0--' And of course this should be documented. @purplecabbage

Re: [DISCUSS] Dropping the -dev suffix

2015-05-13 Thread Tim Barham
No, you were correct - any sort of pre-release identifier makes the version less than the version without the pre-release identifier (since it signifies a pre-release). Hence '4.0.0-dev', '4.0.0-alpha', '4.0.0-0.0.1' and '4.0.0-iwishiwasarealreease' are all 4.0.0. It seems to me the problem

Re: [DISCUSS] Dropping the -dev suffix

2015-05-13 Thread Jesse
Yes, I just verified the same. Changing the plugin.xml engine to : cordova-wp8 =4.0.0-- will allow install for both wp8@4.0.0 and wp8@4.0.0-dev @purplecabbage risingj.com On Wed, May 13, 2015 at 4:18 PM, Tim Barham tim.bar...@microsoft.com wrote: No, you were correct - any sort of pre-release

RE: [CI] WP8 mobilespec failing to get created (CB-9021)

2015-05-13 Thread Nikhil Khandelwal
+1 for dropping the suffix - if there is no real good reason for it. I will make the change to WP8 as it's blocking WP8 CI testing. Thanks, Nikhil -Original Message- From: Jesse [mailto:purplecabb...@gmail.com] Sent: Tuesday, May 12, 2015 5:15 PM To: dev@cordova.apache.org Subject:

[GitHub] cordova-plugin-camera pull request: CB-8879 fix stripe issue with ...

2015-05-13 Thread robpaveza
Github user robpaveza commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/94#discussion_r30254781 --- Diff: src/windows/CameraProxy.js --- @@ -337,28 +336,48 @@ function takePictureFromCameraWP(successCallback, errorCallback, args) {

[DISCUSS] Dropping the -dev suffix

2015-05-13 Thread Steven Gill
Recently, a issue (CB-9021) popped up where mobile spec was failing because the semver check failed on a platform due to `-dev` being in the version and not valid. I think we should remove -dev from our versions. Right now, after we do a release, we add -dev to show that the repo is in

RE: [DISCUSS] Dropping the -dev suffix

2015-05-13 Thread So, Byoungro
Semver should be able to understand '4.0.0-dev' as the valid version string. There could be some other requirement problems, like =, . For example, 4.0.0-dev is 4.0.0. So, if the requirement is =4.0.0, then the version string '4.0.0-dev' will fail to satisfy the requirement. Byoungro So SSG /

Re: [CI] WP8 mobilespec failing to get created (CB-9021)

2015-05-13 Thread Steven Gill
I will create a new thread for dropping the suffix On Wed, May 13, 2015 at 9:20 AM, Nikhil Khandelwal nikhi...@microsoft.com wrote: +1 for dropping the suffix - if there is no real good reason for it. I will make the change to WP8 as it's blocking WP8 CI testing. Thanks, Nikhil

RE: [DISCUSS] Dropping the -dev suffix

2015-05-13 Thread So, Byoungro
Sorry, I got the other way around. :) 4.0.0-dev is 4.0.0. Byoungro So SSG / DPD / Mobile Computing and Compilers Intel Corporation -Original Message- From: So, Byoungro Sent: Wednesday, May 13, 2015 10:37 AM To: dev@cordova.apache.org Subject: RE: [DISCUSS] Dropping the -dev suffix

[GitHub] cordova-plugin-splashscreen pull request: CB-7204 Fixed race condi...

2015-05-13 Thread jacobg
Github user jacobg commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/21#issuecomment-101761529 Hi @shazron: I'm still getting the same crash from users after applied the latest fix. Any ideas? Thanks. --- If your project is set up for it, you

Re: [ios-deploy] version 1.6.0 released

2015-05-13 Thread Shazron
If any of you downloaded 1.6.0, sorry -- please download the latest 1.6.1 https://github.com/phonegap/ios-deploy/issues/129 On Tue, May 12, 2015 at 3:39 PM, Shazron shaz...@gmail.com wrote: Release notes: https://github.com/phonegap/ios-deploy/releases/tag/1.6.0

Re: cordova-plugin-background-app

2015-05-13 Thread Andrew Grieve
Here we go! https://github.com/MobileChromeApps/cordova-plugin-background-app/tree/master/example-app Also makes use of CLI's ability to store plugins platforms in config.xml :) On Tue, May 5, 2015 at 2:50 PM, Andrew Grieve agri...@chromium.org wrote: Hmm, just have mobile chrome apps'

[GitHub] cordova-plugin-contacts pull request: CB-8987: Support for save an...

2015-05-13 Thread robpaveza
Github user robpaveza commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/62#issuecomment-101757332 Ping Can I get a merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-contacts pull request: CB-8987: Support for save an...

2015-05-13 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/62#issuecomment-101766786 LGTM. I'm sure Dooney Evans would approve. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-plugin-device pull request: Update README.md

2015-05-13 Thread deslee
Github user deslee closed the pull request at: https://github.com/apache/cordova-plugin-device/pull/33 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request: The concat() method returns a new array.

2015-05-13 Thread 007slm
GitHub user 007slm opened a pull request: https://github.com/apache/cordova-lib/pull/216 The concat() method returns a new array. the ios plist file can not add more than one dict CFBundleURLTypes arrays when use cordova plugman add plugin in ios platform. You can merge this pull

[GitHub] cordova-lib pull request: The concat() method returns a new array.

2015-05-13 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-lib/pull/216#issuecomment-101544132 Can you briefly describe what bug this bug fix solves? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-plugin-camera pull request: CB-8879 fix stripe issue with ...

2015-05-13 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/94#discussion_r30210499 --- Diff: src/windows/CameraProxy.js --- @@ -438,6 +457,61 @@ function takePictureFromCameraWP(successCallback, errorCallback, args) {

[GitHub] cordova-plugin-camera pull request: CB-8879 fix stripe issue with ...

2015-05-13 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/94#discussion_r30210493 --- Diff: src/windows/CameraProxy.js --- @@ -438,6 +457,61 @@ function takePictureFromCameraWP(successCallback, errorCallback, args) {

[GitHub] cordova-plugin-camera pull request: CB-8879 fix stripe issue with ...

2015-05-13 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/94#discussion_r30210477 --- Diff: src/windows/CameraProxy.js --- @@ -438,6 +457,61 @@ function takePictureFromCameraWP(successCallback, errorCallback, args) {

[GitHub] cordova-plugin-camera pull request: CB-8879 fix stripe issue with ...

2015-05-13 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/94#discussion_r30210599 --- Diff: src/windows/CameraProxy.js --- @@ -337,28 +336,48 @@ function takePictureFromCameraWP(successCallback, errorCallback, args)

Re: Hi Everyone

2015-05-13 Thread Shazron
Hi Rakesh, Good to have you on board. You won't have direct repo access -- instead send a pull request against the repos: https://github.com/apache?utf8=✓query=cordova- On Wed, May 13, 2015 at 7:01 AM, Rakesh Kalyankar k.rakesh...@gmail.com wrote: Hello Community I am Rakesh. I am currently