Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-geolocation/pull/36#issuecomment-103808749
Android geolocation plugin code doesn't exist anymore, it just uses the
HTML 5 geolocation API, so nothing has to be copied to the platform
GitHub user mbektchiev opened a pull request:
https://github.com/apache/cordova-lib/pull/222
CB-9048 Clean up git cloned directories
Fixes https://issues.apache.org/jira/browse/CB-9048
Also fix ***jshint*** error: `src/gitclone.js: line 71, col 106, Mixed
double and single
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/78#discussion_r30698930
--- Diff: src/merge-pr.js ---
@@ -0,0 +1,62 @@
+
+var flagutil = require('./flagutil');
+var optimist = require('optimist');
+var
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/78#discussion_r30698950
--- Diff: src/merge-pr.js ---
@@ -0,0 +1,62 @@
+
+var flagutil = require('./flagutil');
+var optimist = require('optimist');
+var
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/78#discussion_r30699407
--- Diff: src/merge-pr.js ---
@@ -0,0 +1,62 @@
+
+var flagutil = require('./flagutil');
+var optimist = require('optimist');
+var
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/78#discussion_r30698706
--- Diff: src/main.js ---
@@ -172,11 +177,6 @@ module.exports = function() {
var command;
var argv = optimist
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-coho/pull/60#issuecomment-103881989
@sgrebnov Is this still relevant?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/78#discussion_r30698749
--- Diff: src/gitutil.js ---
@@ -43,12 +43,14 @@ exports.tagExists = function*(tagName) {
}
exports.retrieveCurrentBranchName =
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/78#discussion_r30698765
--- Diff: src/repo-update.js ---
@@ -129,8 +129,9 @@ function *updateRepos(repos, branches, noFetch) {
yield
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-coho/pull/78#issuecomment-103881305
Thanks, @agrieve @dblotsky for the review. I have made some changes based
on feedback and added a summary message listing commits that were merged at the
end.
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/78#discussion_r30698977
--- Diff: src/merge-pr.js ---
@@ -0,0 +1,62 @@
+
--- End diff --
Good catch! Fixed.
---
If your project is set up for it, you can
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/78#discussion_r30699028
--- Diff: src/merge-pr.js ---
@@ -0,0 +1,62 @@
+
+var flagutil = require('./flagutil');
+var optimist = require('optimist');
+var
GitHub user humhann opened a pull request:
https://github.com/apache/cordova-plugin-network-information/pull/27
Correct installation command in README.md
Current command within documentation: ```cordova plugin add
cordova-plugin-network-information``` produces 404 error.
You can
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-lib/pull/219#issuecomment-103903180
Looks like this pr breaks tests. Could you please address? (run npm test)
---
If your project is set up for it, you can reply to this email and have your
reply
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/222
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/27#issuecomment-103928012
No. This is the new way. Please close.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-coho/pull/78#issuecomment-103952930
Command:
git remote -v
Output:
dev g...@github.com:MSOpenTech/cordova-medic.git (fetch)
dev
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/116#discussion_r30721845
--- Diff: tests/tests.js ---
@@ -3523,7 +3523,7 @@ exports.defineAutoTests = function () {
}, failed.bind(null,
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-coho/pull/78#issuecomment-103968703
My latest commit removes these class of errors with not specifying the
correct remote 'origin' remote. It implements @agrieve suggestion of
auto-detecting the
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/78#discussion_r30716069
--- Diff: template/CordovaApp.Windows10.jsproj ---
@@ -86,12 +93,11 @@
Content Include=WinJS\js\WinJS.js /
None
GitHub user superdecimal opened a pull request:
https://github.com/apache/cordova-plugin-media-capture/pull/37
Add CaptureVideoOption for quality
This adds quality CaptureVideoOption for Android. 0 is low 1 is high.
You can merge this pull request into a Git repository by running:
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-coho/pull/78#issuecomment-103945755
Sorry, seems there is a bug somewhere. I tried to merge an actual PR with
the following command while inside `cordova-medic` and on branch `CB-9011`:
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-coho/pull/78#issuecomment-103956908
You need to specify the remote of the branch which is
'target'/'destination' of the PR i.e.
https://github.com/apache/cordova-medic.git
---
If your project is
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/78#discussion_r30723083
--- Diff: template/CordovaApp.Windows10.jsproj ---
@@ -86,12 +93,11 @@
Content Include=WinJS\js\WinJS.js /
None
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-medic/pull/54#issuecomment-103935990
This is a significant improvement in our BuildBot capability! Let's get
this in and up on Apache CI.
---
If your project is set up for it, you can reply to this
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-coho/pull/78#issuecomment-103941841
There is no 'dry run' feature now. I can see it would nice to preview what
the black box command will do - but I don't have a good way to do that
especially
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-coho/pull/78#discussion_r30717099
--- Diff: src/executil.js ---
@@ -52,7 +52,7 @@ function execHelper(cmdAndArgs, silent, allowError) {
var result =
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-coho/pull/78#issuecomment-103934974
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/78#issuecomment-103932432
LGTM. I prefer the revised version which ends up with only a single
solution file. Consider squashing the two commits before merging.
---
If your project is
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-medic/pull/54#issuecomment-103939982
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-coho/pull/78#issuecomment-103939716
LGTM. Small question: without `pretend`, could we still do something like a
dry run of the command before actually running it?
---
If your project is set up for
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-coho/pull/78#issuecomment-103947763
Can you share output of git remote -v for this repo? It does not look like
`dev` points to the correct github repo. It should point to
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-medic/pull/54
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Jesse, I said that on my last sentence
the only way is to create a plugin that writes the values there on
install.
But I think it's a bit overkill to create a dummy plugin just to add values
to that files, and as phonegap build has a way of doing this, and I think
telerik platform too, shouldn't
No, this does not exist in cordova's config.xml
You could possibly achieve this with a plugin, and a plugin.xml file that
does nothing more than specify config options.
See the config-file element here:
http://cordova.apache.org/docs/en/edge/plugin_ref_spec.md.html#Plugin%20Specification
On phonegap build you can add values to the info.plist or
androidManifest.xml from the config.xml, but I didn't see that features
available on cordova
http://phonegap.com/blog/2014/01/30/customizing-your-android-manifest-and-ios-property-list-on-phonegap-build/
I'm not sure if it isn't possible
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/74#issuecomment-103980396
@robpaveza Has this been documented?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user nikhilkh closed the pull request at:
https://github.com/apache/cordova-coho/pull/78
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-coho/pull/78#issuecomment-103970568
Merged with e337cab.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-blackberry/pull/183
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/96#issuecomment-104064883
:shipit: looks awesome thanks for doing this!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Please review and vote on this 3.7.2 Android Release
by replying to this email (and keep discussion on the DISCUSS thread)
Release issue: https://issues.apache.org/jira/browse/CB-9042
The archive has been published to
dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9042
The package
Argh. Ignore this. This vote is closed
On Wed, May 20, 2015 at 4:19 PM, Steven Gill stevengil...@gmail.com wrote:
Please review and vote on this 3.7.2 Android Release
by replying to this email (and keep discussion on the DISCUSS thread)
Release issue:
The Buildbot working for 'ASF Buildbot'
has noticed that the buildslave named cordova-windows-slave went away
It last disconnected at Wed May 20 22:31:46 2015 (buildmaster-local time)
The admin on record (as reported by BUILDSLAVE:info/admin)
was 'Dmitry Blotsky dblot...@microsoft.com
'.
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-lib/pull/223
CB-9051 Plugins don't get re-added if platforms folder deleted.
To avoid attempting to add a plugin twice while adding a platform (a
scenario that can occur now with automatic restore of
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/96#discussion_r30757483
--- Diff: src/windows/CameraProxy.js ---
@@ -69,11 +83,13 @@ function resizeImage(successCallback, errorCallback,
file, targetWidth, targetHe
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/96#discussion_r30757496
--- Diff: src/windows/CameraProxy.js ---
@@ -111,8 +127,8 @@ function resizeImage(successCallback, errorCallback,
file, targetWidth, targetHe
Github user muratsu commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-camera/pull/96#discussion_r30757436
--- Diff: src/windows/CameraProxy.js ---
@@ -546,20 +575,31 @@ function
takePictureFromCameraWindows(successCallback, errorCallback, args) {
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/96
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user ogoguel commented on the pull request:
https://github.com/apache/cordova-lib/pull/219#issuecomment-104068019
Fix Test And Make the Test More Reliable
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Take the night off Dmitry, we'll survive.
Thank you for your continued dedication!
@purplecabbage
risingj.com
On Wed, May 20, 2015 at 7:18 PM, Dmitry Blotsky dblot...@microsoft.com
wrote:
Looks like the machine died. I am currently out of the office and the
machine is inaccessible via any way
Looks like the machine died. I am currently out of the office and the machine
is inaccessible via any way other than my desk. If in the following hour
someone replies that they need it up this evening, I will exercise my paladin
duties and go resurrect it. If nobody replies, I will resurrect it
52 matches
Mail list logo
