Re: Translation QA tools

2015-06-08 Thread Andrey Kurdumov
Thanks Victor for updating CrowdIn Could someone other take a look at https://github.com/apache/cordova-docs/pull/289 ? 2015-06-05 19:49 GMT+06:00 Victor Sosa : > Hi Andrey, I'll work on that today or tomorrow, depending on the workload > on back today > > On Fri, Jun 5, 2015 at 1:28 AM Andrey K

[GitHub] cordova-osx pull request: Fix OS X, see CB-7143

2015-06-08 Thread hypery2k
Github user hypery2k commented on the pull request: https://github.com/apache/cordova-osx/pull/12#issuecomment-110231057 is it possible that within the next cordova release OS X is officially supported? --- If your project is set up for it, you can reply to this email and have your r

[GitHub] cordova-android pull request: CB-9119 Fixing intermittent 'adb ins...

2015-06-08 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/180#discussion_r31978041 --- Diff: bin/templates/cordova/lib/exec.js --- @@ -19,16 +19,42 @@ under the License. */ -var child_process = require('ch

[GitHub] cordova-android pull request: CB-9119 Fixing intermittent 'adb ins...

2015-06-08 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/180#discussion_r31977946 --- Diff: bin/templates/cordova/lib/retry.js --- @@ -0,0 +1,63 @@ +#!/usr/bin/env node + +/* +Licensed to the Apache Software Fou

[GitHub] cordova-android pull request: CB-9119 Fixing intermittent 'adb ins...

2015-06-08 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/180#discussion_r31977846 --- Diff: bin/templates/cordova/lib/retry.js --- @@ -0,0 +1,63 @@ +#!/usr/bin/env node + +/* +Licensed to the Apache Software Fou

[GitHub] cordova-android pull request: CB-9119 Fixing intermittent 'adb ins...

2015-06-08 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/180#discussion_r31977783 --- Diff: bin/templates/cordova/lib/emulator.js --- @@ -298,37 +306,67 @@ module.exports.resolveTarget = function(target) { * If no started emu

[GitHub] cordova-android pull request: CB-9119 Fixing intermittent 'adb ins...

2015-06-08 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/180#discussion_r31976180 --- Diff: bin/templates/cordova/lib/retry.js --- @@ -0,0 +1,63 @@ +#!/usr/bin/env node + +/* +Licensed to the Apache Software Fou

[GitHub] cordova-android pull request: CB-9119 Fixing intermittent 'adb ins...

2015-06-08 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-android/pull/180#issuecomment-110188933 Mostly looks good - some stylistic comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-android pull request: CB-9119 Fixing intermittent 'adb ins...

2015-06-08 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/180#discussion_r31976074 --- Diff: bin/templates/cordova/lib/retry.js --- @@ -0,0 +1,63 @@ +#!/usr/bin/env node + +/* +Licensed to the Apache Software Fou

[GitHub] cordova-android pull request: CB-9119 Fixing intermittent 'adb ins...

2015-06-08 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/180#discussion_r31976044 --- Diff: bin/templates/cordova/lib/emulator.js --- @@ -298,37 +306,67 @@ module.exports.resolveTarget = function(target) { * If no started emu

[GitHub] cordova-android pull request: CB-9119 Fixing intermittent 'adb ins...

2015-06-08 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/180#discussion_r31975924 --- Diff: bin/templates/cordova/lib/exec.js --- @@ -19,16 +19,42 @@ under the License. */ -var child_process = require('ch

[GitHub] cordova-medic pull request: CB-9000 Failing properly if no test re...

2015-06-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/55 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-medic pull request: CB-9000 Failing properly if no test re...

2015-06-08 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-medic/pull/55#issuecomment-110186774 Sorry for delay. Verified, LGTM. :+1: Rebased and merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

Re: [VOTE] Tools Release June 4th

2015-06-08 Thread Steven Gill
Need one more +1 On Mon, Jun 8, 2015 at 10:51 AM, Tim Barham wrote: > I vote +1 > > Verified: > * cordova verify-tags (note this failed for cordova-lib as my origin is > github which still shows 5.1.1 tag on ffb02197e9, but I verified manually > on apache.org). > * cordova audit-license-headers.

[GitHub] cordova-android pull request: CB-9119 Fixing intermittent 'adb ins...

2015-06-08 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-android/pull/180 CB-9119 Fixing intermittent 'adb install' hanging issue Adding lib/retry.js for retrying promise-returning functions. Retrying 'adb install' in emulator.js to work around it hanging someti

[GitHub] cordova-lib pull request: Implementation for Unified platform API

2015-06-08 Thread kamrik
Github user kamrik commented on the pull request: https://github.com/apache/cordova-lib/pull/235#issuecomment-110155367 I don't have strong opinion here, but a bit more inclined towards dependency injection. For some modules like ConfigParser having different versions imported by diff

Re: [iOS 8] WKWebView moving forward

2015-06-08 Thread Shazron
There is a WWDC session: "Safari Extensibility: Content Blocking and Shared Links". So I'm hopeful for whitelisting On Mon, Jun 8, 2015 at 1:22 PM, Shazron wrote: > Moar news https://twitter.com/wkwebview/status/608005652720451584 > > > On Monday, June 8, 2015, Shazron wrote: > >> Cordova devel

[GitHub] cordova-medic pull request: CB-9000 Failing properly if no test re...

2015-06-08 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-medic/pull/55#issuecomment-110138958 @dblotsky Can you please review and help merge. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

Re: [iOS 8] WKWebView moving forward

2015-06-08 Thread Shazron
Moar news https://twitter.com/wkwebview/status/608005652720451584 On Monday, June 8, 2015, Shazron wrote: > Cordova developers rejoice, iOS 9 includes the API to load pages from > file:// urls https://twitter.com/wkwebview/status/608002548151119872 > > On Mon, Feb 9, 2015 at 2:19 PM, Shazron >

Re: [iOS 8] WKWebView moving forward

2015-06-08 Thread Shazron
No idea yet Darryl On Monday, June 8, 2015, Darryl Pogue wrote: > Any news on IndexedDB bug fixes? Or working URL interceptors? > > On 8 June 2015 at 13:13, Shazron > wrote: > > Cordova developers rejoice, iOS 9 includes the API to load pages from > > file:// urls https://twitter.com/wkwebview/s

Re: [iOS 8] WKWebView moving forward

2015-06-08 Thread Kerri Shotts
Why am I hearing the Hallelujah chorus? I’m dong my happy dance now! :-) On June 8, 2015 at 3:14:14 PM, Shazron (shaz...@gmail.com) wrote: Cordova developers rejoice, iOS 9 includes the API to load pages from file:// urls https://twitter.com/wkwebview/status/608002548151119872 On Mon, Fe

Re: [iOS 8] WKWebView moving forward

2015-06-08 Thread Darryl Pogue
Any news on IndexedDB bug fixes? Or working URL interceptors? On 8 June 2015 at 13:13, Shazron wrote: > Cordova developers rejoice, iOS 9 includes the API to load pages from > file:// urls https://twitter.com/wkwebview/status/608002548151119872 > > On Mon, Feb 9, 2015 at 2:19 PM, Shazron wrote:

Re: [iOS 8] WKWebView moving forward

2015-06-08 Thread Shazron
Cordova developers rejoice, iOS 9 includes the API to load pages from file:// urls https://twitter.com/wkwebview/status/608002548151119872 On Mon, Feb 9, 2015 at 2:19 PM, Shazron wrote: > Also Xcode 6.3 now *requires* Yosemite. Fair warning to upgrade I > suppose for your dev machines and build

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2015-06-08 Thread clelland
Github user clelland commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-110114815 @machenmusik, I definitely see the CLA now -- thanks! And it's merged -- if there are any issues with it, please keep the bug at [CB-6503](http

Re: Should files in cordova-lib/templates have license headers?

2015-06-08 Thread Shazron
We should add license headers. On Mon, Jun 8, 2015 at 11:21 AM, Tim Barham wrote: > Currently these files are flagged by RAT. We should either add license > headers or exclude them (from RAT) to clean up the noise. They're small > pieces of template code used by plugman. The Apache rules for whe

[GitHub] cordova-cli pull request: CB-8993 Plugin restore ignores search pa...

2015-06-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/213 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...

2015-06-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/224 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2015-06-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/27 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

Should files in cordova-lib/templates have license headers?

2015-06-08 Thread Tim Barham
Currently these files are flagged by RAT. We should either add license headers or exclude them (from RAT) to clean up the noise. They're small pieces of template code used by plugman. The Apache rules for whether a file needs to have a license header [1] specifies: > What files in an Apache rel

RE: [VOTE] Tools Release June 4th

2015-06-08 Thread Tim Barham
I vote +1 Verified: * cordova verify-tags (note this failed for cordova-lib as my origin is github which still shows 5.1.1 tag on ffb02197e9, but I verified manually on apache.org). * cordova audit-license-headers. * Verified builds are green. * Created and ran blank app on Android and Windows.

Re: Cordova Meetup/Beerup at WWDC?

2015-06-08 Thread Brian LeRoux
right on! lets plan a mini meetup this week! On Fri, Jun 5, 2015 at 5:24 PM, Carlos Santana wrote: > I will be in SF this week starting Sunday for WWDC, somehow I was able to > get a ticket thru IBM ;-) > > I will be there Sunday to Friday, if anyone wants to meet to talk, hack, > eat or drink l

[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...

2015-06-08 Thread marcuspridham
Github user marcuspridham commented on the pull request: https://github.com/apache/cordova-lib/pull/224#issuecomment-110080565 Thanks. I filled out a Apache CLA back in January and got confirmation from Apache Secretary Craig Russell. I have done a pull request in the past for CB-83

[GitHub] cordova-plugin-whitelist pull request: See new pull request.

2015-06-08 Thread agamemnus
Github user agamemnus closed the pull request at: https://github.com/apache/cordova-plugin-whitelist/pull/5 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-whitelist pull request: update

2015-06-08 Thread agamemnus
GitHub user agamemnus opened a pull request: https://github.com/apache/cordova-plugin-whitelist/pull/6 update You can merge this pull request into a Git repository by running: $ git pull https://github.com/agamemnus/cordova-plugin-whitelist master Alternatively you can review

[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...

2015-06-08 Thread gorkem
Github user gorkem commented on the pull request: https://github.com/apache/cordova-lib/pull/224#issuecomment-110066248 @marcuspridham PR looks. Do you have Apache CLA signed? I can not seem to find it if you have. Before I can merge this one, you need to sign Apache’s Contributor L

[GitHub] cordova-plugin-whitelist pull request: NEEDS CONTENT:// AND CDVFIL...

2015-06-08 Thread agamemnus
Github user agamemnus commented on the pull request: https://github.com/apache/cordova-plugin-whitelist/pull/5#issuecomment-110064176 This doesn't look like a full solution... it is a start, anyway. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-whitelist pull request: NEEDS CONTENT:// AND CDVFIL...

2015-06-08 Thread agamemnus
GitHub user agamemnus opened a pull request: https://github.com/apache/cordova-plugin-whitelist/pull/5 NEEDS CONTENT:// AND CDVFILE://!!! MAYBE MORE? You can merge this pull request into a Git repository by running: $ git pull https://github.com/agamemnus/cordova-plugin-whitel

[GitHub] cordova-lib pull request: Implementation for Unified platform API

2015-06-08 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/235#issuecomment-110038030 @kamrik, thanks for feedback. Dependency injection of cordova logic to platform was our very first idea, but in addition to limitations, you mentio

[GitHub] cordova-lib pull request: Implementation for Unified platform API

2015-06-08 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/235#discussion_r31924092 --- Diff: cordova-lib/src/platforms/PlatformApi.js --- @@ -0,0 +1,365 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-js pull request: CB-9137 Fixes module inclusion failure on...

2015-06-08 Thread vladimir-kotikov
Github user vladimir-kotikov closed the pull request at: https://github.com/apache/cordova-js/pull/115 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] cordova-plugin-camera pull request: Major refactor

2015-06-08 Thread dieppe
Github user dieppe commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/101#issuecomment-109964558 The most probable is that it is a side effect, since I did not touch the implementation of `imageByScalingNotCroppingForSize` one bit :wink: --- If your

[GitHub] cordova-ios pull request: * is a Right-to-left associative operato...

2015-06-08 Thread Coeur
GitHub user Coeur opened a pull request: https://github.com/apache/cordova-ios/pull/145 * is a Right-to-left associative operator in C and Objective-C See: http://en.wikipedia.org/wiki/Operators_in_C_and_C%2B%2B#Operator_precedence http://www.techotopia.com/index.php/Objecti

[GitHub] cordova-lib pull request: CB-9124 Makes network-related error mess...

2015-06-08 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/240 CB-9124 Makes network-related error messages more descriptive. You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-

[GitHub] cordova-js pull request: CB-9137 Fixes module inclusion failure on...

2015-06-08 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-js/pull/115 CB-9137 Fixes module inclusion failure on Windows You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-js CB-9137 Al