Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/235#issuecomment-58775
Since you've already ported the android implementation from cordova-lib to
cordova-android, shouldn't you delete the android parser file from the metadata
Github user samkelleher commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/94#issuecomment-66441
One side effect of this is that the main cordova webview will also have its
userAgent changed (navigator.appVersion) once at least one instance
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/235#discussion_r32236650
--- Diff: cordova-lib/src/platforms/PlatformApi.js ---
@@ -0,0 +1,414 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/235#issuecomment-84250
cool. (ref: android_parser backward compatibility).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/235#discussion_r32236936
--- Diff: cordova-lib/src/platforms/PlatformApi.js ---
@@ -0,0 +1,414 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+1 for moving towards consistency, following the same strategy as platforms
that we pin down.
Thanks,
Mefire
-Original Message-
From: Tim Barham [mailto:tim.bar...@microsoft.com]
Sent: Thursday, June 11, 2015 8:23 AM
To: 'dev@cordova.apache.org'
Subject: [DISCUSS] Switch to tilde
Dear team,
Am not sure if I can do this but any assistance would be appreciated.
I have a windows cordova app, within this app am opening another external
app, as soon as I open the external app cordova app is minimised in the
background. What I want to do is keep my Cordova app maximised so I
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-js/pull/117#issuecomment-94328
LGTM. Thanks for making this change!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Hey, guys.
I've tried to run mobilespec today with '--browserify' option, and it seems
that it still doesn't work.
The application builds and runs, but after running none of tests are working
(I'm aware of issues with test-framework, so I've tried to run non-plugin
tests), and there is a lot
Thanks for making this change. I know createmobilspec (and in turn the Buildbot
CI) depends on this as it attempts to create the latest cordova.js. After this
change it will generate the latest cordova.js (instead of the released one) for
testing purposes which IMO is the correct default
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/235#issuecomment-111213610
Ah, I see. (ref: android_parser backward compatibility).
However, in case a platform is implemented via the new way, shouldn't we be
actually using that ?
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/235#discussion_r32246260
--- Diff: cordova-lib/src/platforms/PlatformApi.js ---
@@ -0,0 +1,414 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
Our thought process to use ~ over ^ for pinned platforms was because we
don't have a solid testing matrix to make sure we are supporting backwards
compatibility. If we are all sticking to semver (which I think we are), we
should be able to allow minor updates too. It is just safer to allow only
Yep, you summarized my thinking on this exactly :).
-Original Message-
From: Steven Gill [mailto:stevengil...@gmail.com]
Sent: Thursday, June 11, 2015 10:51 AM
To: dev@cordova.apache.org
Subject: Re: [DISCUSS] Switch to tilde versions for --save
Our thought process to use ~ over ^ for
Thanks Nikhil,
I will take a look at that PR as I work on this and provide feedback.
On Wed, Jun 10, 2015 at 5:34 PM, Nikhil Khandelwal nikhi...@microsoft.com
wrote:
There is a massive PR currently in the works that is looking to change how
platforms should expose their functionality:
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-ios/pull/146
CB-8197 Switch to nodejs for ios platform scripts
Convert `copy-www-build-step.sh` to nodejs
Adds `glob` module and `bundledDependencies` to `package.json`
[Jira
Could maybe try creating symlinks / hardlinks to save on space / creation
time?
On Wed, Jun 10, 2015 at 12:00 PM, Shazron shaz...@gmail.com wrote:
Safari View Controller video:
https://developer.apple.com/videos/wwdc/2015/?id=504
What's New in Web Development in WebKit and Safari video:
Hmmm. Symlinks will break if the code ever touches Windows but they could be
safely created as a part of a before_compile hook since that would only ever
run on OSX practically speaking. (after_prepare would still fire if you add
iOS on Windows - which is something we talked about being a
The potential maintainer for cordova-osx in this thread has decided to go
in another direction -- the final nail in its coffin. Full speed ahead
cordova-electron! Godspeed
On Thu, Jun 11, 2015 at 10:59 AM, Steven Gill stevengil...@gmail.com
wrote:
Thanks Nikhil,
I will take a look at that PR
I've already tried both sym and hard links. They result in errors, which is
to be expected (if not there's some 'splaining to do) :P
GOOD news though today! They are fixing the app bundle loadFileURL bug:
https://twitter.com/grorgwork/status/609052546179530752
Apparently you can also UI test in
I’ll throw in my +1. Electron is awesome, and I’ve used it to wrap a PG project
for a client where they are demoing the app to their potential clients because
they don’t have devices to share from, and they don’t have the expertise for
emulators (they are sales reps). Because I can wrap
Yeah, I was just about to say that I was pretty sure that sym/hard links was
going to error.
But that tweet looks promising! I hope that means the fix makes it in time for
Beta 2 so we can play with it. :-)
On June 11, 2015 at 1:55:58 PM, Shazron (shaz...@gmail.com) wrote:
I've already
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-coho/pull/84#issuecomment-111257786
Haven't tested this yet, but first question that comes to mind is how would
this affect repo-clone?
---
If your project is set up for it, you can reply to
Thanks Vladimir for giving this a go.
mobilespec with --browserify was working for me last time I tried but I
will have to try it again. I'm assuming you are using the latest versions
of things.
Appreciate the tips for the windows environment. I need to test this on
Windows and make some of the
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-js/pull/117#issuecomment-111261704
I am going to take another pass it this before I commit it. See if I can
improve some of the path.join/fs.existSync logic. I also want to test this on
Windows +
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-coho/pull/84#issuecomment-111262521
Ah, good question. I'll try it out. I tried a few scenarios, and was trying
to think of one where having two items in the repo list pointing to the same
repo
Nice list of tasks. I'll try to find some time to look at the PR in the
next few days.
It might be nice to turn this search functionality (with the blacklist)
into a module others can incorporate into their tools. We could potentially
use it in the cordova cli (cordova plugin search) and maybe
It's for excluding certain files from code signing from a bundle. In
Mavericks this has been removed -- all bundle files are signed, so I think
that should go away.
We might have a JIRA for this already.
Hey Steve, let's set you up with access and sudo powers to
cordova-vm.apache.org. Once you've successfully logged in to the machine,
follow these steps to set up OPIE: https://reference.apache.org/committer/opie.
Then Infra will grant you sudo powers, and we can close this ticket:
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/246#discussion_r32271456
--- Diff: cordova-lib/spec-cordova/save.spec.js ---
@@ -0,0 +1,435 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/246#discussion_r32271532
--- Diff: cordova-lib/spec-cordova/save.spec.js ---
@@ -0,0 +1,435 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/246#discussion_r32273251
--- Diff: cordova-lib/spec-cordova/save.spec.js ---
@@ -0,0 +1,435 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/246#discussion_r32273230
--- Diff: cordova-lib/spec-cordova/save.spec.js ---
@@ -0,0 +1,435 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-coho/pull/60#issuecomment-111293178
@sgrebnov Shall we close this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/246#discussion_r32275447
--- Diff: cordova-lib/spec-cordova/helpers.js ---
@@ -43,17 +54,101 @@ if (host.match(/win/)) {
}
*/
-// Just use Android everywhere;
looks great shaz: thank you!
On Thu, Jun 11, 2015 at 4:25 PM, Shazron shaz...@gmail.com wrote:
https://github.com/cordova/apache-board-reports/blob/master/2015/2015-06.md
Let me know your comments, if any -- this time I just used the automatic
tool at reporter.apache.org which collects stats
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-registry-web/pull/11
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
GitHub user muratsu opened a pull request:
https://github.com/apache/cordova-windows/pull/90
CB-9164 Better error message when deploying to Windows10 phone emulator
Windows 10 Phone emulator is currently not supported but deployment from VS
is possible.
We should tell users to
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/246#discussion_r32275358
--- Diff: cordova-lib/spec-cordova/helpers.js ---
@@ -43,17 +54,101 @@ if (host.match(/win/)) {
}
*/
-// Just use Android everywhere;
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/246#discussion_r32272314
--- Diff: cordova-lib/spec-cordova/save.spec.js ---
@@ -0,0 +1,435 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/237#issuecomment-111293336
LGTM. Good find!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-lib/pull/245#issuecomment-111305397
@TimBarham @omefire to take a quick look
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
https://github.com/cordova/apache-board-reports/blob/master/2015/2015-06.md
Let me know your comments, if any -- this time I just used the automatic
tool at reporter.apache.org which collects stats that I had been doing
manually.
Releases still have to be added manually using that tool.
Hi,
I would like that docs for `clean` hooks would be also included, so both
English and Russian version would be exactly the same.
This is require that docs would be updated, very easy fix - See (
https://github.com/apache/cordova-docs/pull/293/files)
Also before releasing Russian docs, I have
Github user jcesarmobile commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/26#issuecomment-111018380
using [[UIDevice currentDevice] orientation] is not reliable
maybe you can try with
[[UIApplication sharedApplication]
GitHub user rakatyal opened a pull request:
https://github.com/apache/cordova-registry-web/pull/12
Adding download count for plugin list
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rakatyal/cordova-registry-web
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-registry-web/pull/12
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/245#issuecomment-111337985
I'm trying to reproduce this error. @sencenan does this happen as well when
you use different partitions of the same device ? or is it only on totally
different
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/182#discussion_r32287653
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -245,18 +258,29 @@ var builders = {
}
}
+
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/182#discussion_r32287669
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -245,18 +258,29 @@ var builders = {
}
}
+
Github user agrieve commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/182#discussion_r3228
--- Diff: bin/templates/cordova/lib/build.js ---
@@ -102,6 +102,19 @@ function hasCustomRules() {
return fs.existsSync(path.join(ROOT,
Github user agrieve commented on the pull request:
https://github.com/apache/cordova-android/pull/182#issuecomment-111340031
a few nits, but LGTM! Thanks for doing this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/235#discussion_r32198647
--- Diff: cordova-lib/src/platforms/PlatformApi.js ---
@@ -0,0 +1,365 @@
+/**
+Licensed to the Apache Software Foundation (ASF)
GitHub user syndbg opened a pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/104
[] Fix zoom option not respected on Android.
Also minor whitespaces fixes.
You can merge this pull request into a Git repository by running:
$ git pull
Github user syndbg commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/104#discussion_r32199198
--- Diff: src/android/InAppBrowser.java ---
@@ -656,7 +647,7 @@ public void onClick(View v) {
WebSettings settings =
When we implemented --save for platforms and plugins, we decided to save
versions as caret ranges to be consistent with current npm behavior. However,
when we made our pinned platforms more flexible we decided to go with tilde
ranges rather than caret ranges to keep things a bit more locked
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/235#issuecomment-70935
`android_parser` is left for backward compatibility, since user can install
older version of cordova-android, which doesn't provides own `PlatformAPI`. In
57 matches
Mail list logo
