Re: Facebook infer on Cordova / plugins

2015-06-17 Thread Steven Gill
+1 On Wed, Jun 17, 2015 at 12:09 PM, Dmitry Blotsky dblot...@microsoft.com wrote: We could incorporate this into our CI. I've also been reading about Infer recently. Folks: thoughts? Kindly, Dmitry -Original Message- From: Axel Nennker [mailto:ignisvul...@gmail.com] Sent:

[GitHub] cordova-plugin-file pull request: CB-8728 fix write after seek on ...

2015-06-17 Thread aroberson
Github user aroberson commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/106#issuecomment-112909588 Is anyone looking at the pull requests to determine if they should be merged or not. --- If your project is set up for it, you can reply to this email

Update plugin's package.json git url to github mirrors.

2015-06-17 Thread Steven Gill
How do people feel about changing the repo field in the package.json for our plugins to point to the github mirror instead of apache git repo? The url gets listed at https://www.npmjs.com/package/cordova-plugin-camera on the left. The github mirror is much nicer looking and we receive all of our

[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores

2015-06-17 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/86#discussion_r32667023 --- Diff: src/audit-license-headers.js --- @@ -44,11 +46,27 @@ var COMMON_RAT_EXCLUDES = [ '*.xcworkspacedata', '*.xccheckout',

[GitHub] cordova-plugin-statusbar pull request: fix warning message

2015-06-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-statusbar pull request: Update readme with correct ...

2015-06-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/23 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-statusbar pull request: update docs for StatusBarBa...

2015-06-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/20 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

Re: Update plugin's package.json git url to github mirrors.

2015-06-17 Thread Shazron
+1 this will drive more contribution. Keeping it to Apache git doesn't help the project -- since the committers already know where the main repo is, but this would confuse others. Not sure about multiple repository fields, I suppose it's possible... On Wed, Jun 17, 2015 at 11:37 AM, Steven Gill

[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores

2015-06-17 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/86#discussion_r32664260 --- Diff: src/audit-license-headers.js --- @@ -44,11 +46,27 @@ var COMMON_RAT_EXCLUDES = [ '*.xcworkspacedata', '*.xccheckout',

[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores

2015-06-17 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/86#discussion_r32664301 --- Diff: src/audit-license-headers.js --- @@ -44,11 +46,27 @@ var COMMON_RAT_EXCLUDES = [ '*.xcworkspacedata', '*.xccheckout',

Re: [DISCUSS] Plugins Release

2015-06-17 Thread Steven Gill
Updated RELEASENOTES as a comment on the issue. https://issues.apache.org/jira/browse/CB-9192 On Tue, Jun 2, 2015 at 11:50 PM, Serge Huijben s.huij...@gmail.com wrote: https://github.com/apache/cordova-plugin-camera/pull/97, if you please Serge Op di 2 jun. 2015 om 20:15 schreef Joe

Re: Update plugin's package.json git url to github mirrors.

2015-06-17 Thread Jesse
+1 easier onboarding of contributors My team is hiring! @purplecabbage risingj.com On Wed, Jun 17, 2015 at 11:54 AM, Shazron shaz...@gmail.com wrote: +1 this will drive more contribution. Keeping it to Apache git doesn't help the project -- since the committers already know where the main

RE: Update plugin's package.json git url to github mirrors.

2015-06-17 Thread Murat Sutunc
Yes +1 ! Now if only we could move our bugs as well :P -Original Message- From: Jesse [mailto:purplecabb...@gmail.com] Sent: Wednesday, June 17, 2015 11:57 AM To: dev@cordova.apache.org Subject: Re: Update plugin's package.json git url to github mirrors. +1 easier onboarding of

[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores

2015-06-17 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/86#discussion_r32665147 --- Diff: src/audit-license-headers.js --- @@ -44,11 +46,27 @@ var COMMON_RAT_EXCLUDES = [ '*.xcworkspacedata', '*.xccheckout',

[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores

2015-06-17 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-coho/pull/86#issuecomment-112934635 Looks good (well, apart from those blank lines you insist on adding at the beginning of blocks :smile:). --- If your project is set up for it, you can reply to

[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

2015-06-17 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-112923305 @thehuijb hey. I will need to review this and see if it has any impact for other platforms before I can merge it in. --- If your project is set up

[GitHub] cordova-registry-web pull request: CB-9195 Sorting platforms and a...

2015-06-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-registry-web/pull/14 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: Javascript - Infinite cycle

2015-06-17 Thread Jesse
Thank you Tim, There are several known issues around search on the plugins.cordova.io site, this is probably related to https://issues.apache.org/jira/browse/CB-8141 You are probably better off searching npmjs.org as we are moving to use npm as our plugin registry. @purplecabbage risingj.com

Re: Update plugin's package.json git url to github mirrors.

2015-06-17 Thread Steven Gill
On Wed, Jun 17, 2015 at 11:37 AM, Steven Gill stevengil...@gmail.com wrote: How do people feel about changing the repo field in the package.json for our plugins to point to the github mirror instead of apache git repo? The url gets listed at https://www.npmjs.com/package/cordova-plugin-camera

[GitHub] cordova-registry-web pull request: CB-9204 Adding mouseover to mor...

2015-06-17 Thread rakatyal
GitHub user rakatyal opened a pull request: https://github.com/apache/cordova-registry-web/pull/15 CB-9204 Adding mouseover to more button You can merge this pull request into a Git repository by running: $ git pull https://github.com/rakatyal/cordova-registry-web

[GitHub] cordova-plugin-inappbrowser pull request: CB-9158 - InAppBrowser z...

2015-06-17 Thread syndbg
Github user syndbg commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/104#issuecomment-112974072 @purplecabbage Good catch. In the JIRA ticket, unfortunately I've pasted the wrong option parameter, `location`, when in fact I meant `zoom`.

[GitHub] cordova-registry-web pull request: Updated the look and feel of th...

2015-06-17 Thread cpsloal
GitHub user cpsloal opened a pull request: https://github.com/apache/cordova-registry-web/pull/18 Updated the look and feel of the plugin card You can merge this pull request into a Git repository by running: $ git pull https://github.com/cpsloal/cordova-registry-web master

[GitHub] cordova-ios pull request: [CB-8838]Moved commandQueue push into no...

2015-06-17 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/136#issuecomment-112975173 FYI this is in 4.0.x, will be auto-closed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-medic pull request: CB-9196 Medic cleanup

2015-06-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/56 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-registry-web pull request: CB-9209 add link from old page ...

2015-06-17 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-registry-web/pull/17#issuecomment-112985415 This should only be merged once we have done [DISCUSS] on the new search page and got buy off to release. --- If your project is set up for it, you can

[GitHub] cordova-ios pull request: proof of concept for proposal discussed ...

2015-06-17 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/119#issuecomment-112975897 Auto-closing since 4.0.x method has a transformURL method in the CommandDelegate that plugins check --- If your project is set up for it, you can reply to this

[GitHub] cordova-plugin-file pull request: CB-8728 fix write after seek on ...

2015-06-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/106 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-ios pull request: CB-7428: Enable Swift development of Plu...

2015-06-17 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/133#issuecomment-112976058 Auto-closing since it has been merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-ios pull request: CB-7428: Enable Swift development of Plu...

2015-06-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/133 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-ios pull request: proof of concept for proposal discussed ...

2015-06-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/119 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-ios pull request: [CB-8838]Moved commandQueue push into no...

2015-06-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/136 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-ios pull request: Created strongly typed configuration cla...

2015-06-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/98 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-registry-web pull request: CB-9209 add link from old page ...

2015-06-17 Thread muratsu
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-registry-web/pull/17 CB-9209 add link from old page to new Create a link from old page to new: ![](http://i.imgur.com/c6hAHsD.png) You can merge this pull request into a Git repository by running:

Implications of Apple iOS 9 statements on IPv6

2015-06-17 Thread Shane MacPhillamy
Hi Apple has been reported to say in http://arstechnica.com/apple/2015/06/apple-to-ios-devs-ipv6-only-cell-service-is-coming-soon-get-your-apps-ready/ http://arstechnica.com/apple/2015/06/apple-to-ios-devs-ipv6-only-cell-service-is-coming-soon-get-your-apps-ready/ that IPv6 support will be an

[GitHub] cordova-registry-web pull request: CB-9209 add link from old page ...

2015-06-17 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-registry-web/pull/17#issuecomment-112984913 Consider re-wording: Cordova plugin registry is moving to npm. Go the [new plugin search page](http://plugins.cordova.io/npm/index.html). I think

[GitHub] cordova-plugin-inappbrowser pull request: CB-9158 - InAppBrowser z...

2015-06-17 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/104#issuecomment-112974712 It is a blocker typically. Modifications should be restricted to resolving the issue at hand, or at the bare minimum whitespace/formatting

[GitHub] cordova-ios pull request: Created strongly typed configuration cla...

2015-06-17 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/98#issuecomment-112975445 Thanks but due to the pluggable webview feature, each WebView plugin has its own configuration now (4.0.x branch). This PR will be auto-closed. --- If your project

[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores

2015-06-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/86 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: cordova-plugin-file-transfer travis CI failing

2015-06-17 Thread Jesse
No, the Travis integration is only meaningful if it is green on master, which it is not file-transfer. Also, the travis integration is only testing the plugin's tests on an iOS simulator, so these are really just smoke tests in most cases anyway. @purplecabbage risingj.com On Wed, Jun 17, 2015

RE: Facebook infer on Cordova / plugins

2015-06-17 Thread Dmitry Blotsky
We could incorporate this into our CI. I've also been reading about Infer recently. Folks: thoughts? Kindly, Dmitry -Original Message- From: Axel Nennker [mailto:ignisvul...@gmail.com] Sent: Tuesday, June 16, 2015 3:39 PM To: dev Subject: Facebook infer on Cordova / plugins Hi, I ran

[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores

2015-06-17 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/86#discussion_r3248 --- Diff: src/audit-license-headers.js --- @@ -44,11 +46,27 @@ var COMMON_RAT_EXCLUDES = [ '*.xcworkspacedata', '*.xccheckout',

[GitHub] cordova-registry-web pull request: CB-9206 add search icon to sear...

2015-06-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-registry-web/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores

2015-06-17 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-coho/pull/86#issuecomment-112943481 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-camera pull request: Fix returning native url on wi...

2015-06-17 Thread vldmrrr
GitHub user vldmrrr opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/102 Fix returning native url on windows. Fix code changed after first pull request for this CB was created. You can merge this pull request into a Git repository by running: $ git

[GitHub] cordova-registry-web pull request: CB-9206 add search icon to sear...

2015-06-17 Thread muratsu
GitHub user muratsu opened a pull request: https://github.com/apache/cordova-registry-web/pull/16 CB-9206 add search icon to search box You can merge this pull request into a Git repository by running: $ git pull https://github.com/MSOpenTech/cordova-registry-web CB-9206

[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

2015-06-17 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-112941486 I think we should wait for @purplecabbage's design to improve the resume behavior for apps. This API looks very leaky and specific to Android - there is

[GitHub] cordova-registry-web pull request: CB-9204 Adding mouseover to mor...

2015-06-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-registry-web/pull/15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

2015-06-17 Thread thehuijb
Github user thehuijb commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-113041333 @stevengill, I would appreciate the review. @nikhilkh, this API is indeed specific to Android but I don't know what you mean by it looks very leaky,

[DISCUSS] Organizing CI

2015-06-17 Thread Dmitry Blotsky
Hi all, With commits triggering builds, we're starting to hit scaling problems on our CI: https://paste.apache.org/ktJr. We have some awesome new things for which we can use the CI: - Static analysis (FB Infer) - Automated releases - Documentation generation -

[GitHub] cordova-plugin-file-transfer pull request: Fixed Browser to set wi...

2015-06-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/89 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-camera pull request: Fix returning native url on wi...

2015-06-17 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/102 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[VOTE] Plugins Release June 17th, 2015

2015-06-17 Thread Steven Gill
Please review and vote on the release of this plugins release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9192 The plugins have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9192/

Re: [VOTE] Plugins Release

2015-06-17 Thread Steven Gill
I swear I created a new thread for this with [VOTE] as the heading. Will try again. On Wed, Jun 17, 2015 at 6:03 PM, Steven Gill stevengil...@gmail.com wrote: Please review and vote on the release of this plugins release by replying to this email (and keep discussion on the DISCUSS thread)

[VOTE] Plugins Release

2015-06-17 Thread Steven Gill
Please review and vote on the release of this plugins release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9192 The plugins have been published to dist/dev:https://dist.apache.org/repos/dist/dev/cordova/CB-9192/

Re: [VOTE] Plugins Release

2015-06-17 Thread Steven Gill
Please review blog post https://github.com/cordova/apache-blog-posts/blob/master/2015-06-19-plugins.release.md On Wed, Jun 17, 2015 at 6:05 PM, Steven Gill stevengil...@gmail.com wrote: I swear I created a new thread for this with [VOTE] as the heading. Will try again. On Wed, Jun 17, 2015

Apache git servers are not writable

2015-06-17 Thread Shazron
https://issues.apache.org/jira/browse/INFRA-9838

Re: Apache git servers are not writable

2015-06-17 Thread Shazron
The INFRA guys just fixed and resolved it - that was fast On Wed, Jun 17, 2015 at 10:35 AM, Shazron shaz...@gmail.com wrote: https://issues.apache.org/jira/browse/INFRA-9838

[GitHub] cordova-plugin-camera pull request: CB-8804 implement check for sa...

2015-06-17 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/97#issuecomment-112943279 Sounds good. Thanks for the input @nikhilkh --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-medic pull request: CB-9196 Medic cleanup

2015-06-17 Thread dblotsky
GitHub user dblotsky opened a pull request: https://github.com/apache/cordova-medic/pull/56 CB-9196 Medic cleanup CB-9196 Adding JSHint config for medic. Making medic-log return an error code. Making `medic-clean`'s `--exclude` flag repeatable. Making `medic-clean` take a target

[GitHub] cordova-plugin-file pull request: NPE fix

2015-06-17 Thread Greunlis
GitHub user Greunlis opened a pull request: https://github.com/apache/cordova-plugin-file/pull/117 NPE fix Our application suddenly stopped working on Android, I found out, it was because of this NullPointerException. You can merge this pull request into a Git repository by

cordova-plugin-file-transfer travis CI failing

2015-06-17 Thread Marco Laponder
Hi everyone, Yesterday we submitted a pull request for cordova-plugin-file-transfer. After having submitted the request, we noticed that TravisCI failed on our code. We tried to replicate the failure locally and found out that the failure also occurs on master. Should we file a ticket for

Re: [iOS] Remove non-CLI template

2015-06-17 Thread Andrew Grieve
I think the difference between the two templates is that the CLI template adds extra navigator entries to point to ../../www and ../../config.xml. Might still be worth not keeping two templates though, and just have these entries be red for non-CLI projects (doesn't break builds). On Tue, Jun

[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores

2015-06-17 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/86#discussion_r32650218 --- Diff: src/audit-license-headers.js --- @@ -44,11 +46,27 @@ var COMMON_RAT_EXCLUDES = [ '*.xcworkspacedata', '*.xccheckout',

[GitHub] cordova-coho pull request: CB-9109 Switching to using .ratignores

2015-06-17 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-coho/pull/86#discussion_r32650376 --- Diff: src/audit-license-headers.js --- @@ -44,11 +46,27 @@ var COMMON_RAT_EXCLUDES = [ '*.xcworkspacedata', '*.xccheckout',

[GitHub] cordova-medic pull request: CB-9196 Medic cleanup

2015-06-17 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-medic/pull/56#issuecomment-112836441 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Javascript - Infinite cycle

2015-06-17 Thread Тимур Сейидов
hello. I bring apologies for my English. On the site http://plugins.cordova.io/ if we assign in the search phrase in the Russian language, javascript infinitely changes url and leads to the crash of the supplementary sheet of the browser