Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/246#issuecomment-115113713
Please, do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this featu
Github user alsorokin commented on the pull request:
https://github.com/apache/cordova-lib/pull/246#issuecomment-115107676
This commit came from you, @omefire
I can delete it if you want.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-ios/pull/145#issuecomment-115087441
I agree with Shazron. It is a semantic discussion without benefit, and
ultimately would obscure other's contributions.
---
If your project is set up for it,
I agree with Shaz about the engine fix. As we move on, more and more
plugins could start requiring a minimum version of a certain platform. It
is a bug in cordova lib to throw an error when a requirement isn't met.
Instead a warning about skipping that plugin should be expected behavior.
Until the
Github user adrianchia commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/82#issuecomment-115076069
Hi,
Is this pull request going to be in the cordova inappbrowser plugin soon?
---
If your project is set up for it, you can reply to thi
The whitelist property was removed:
https://github.com/apache/cordova-ios/blob/master/guides/API%20changes%20in%204.0.md
On Wed, Jun 24, 2015 at 6:41 PM, Shazron wrote:
> The whitelist plugin itself is fine, it's the plugin's tests that are
> failing:
>
> https://github.com/apache/cordova-mobile
The whitelist plugin itself is fine, it's the plugin's tests that are
failing:
https://github.com/apache/cordova-mobile-spec/blob/1f1b08f2a7dbea55f68c560404b94efaa2108d0c/cordova-plugin-whitelist/src/ios/CDVWhitelistAPI.m#L41
On Wed, Jun 24, 2015 at 6:38 PM, Shazron wrote:
> Ah I see it's a whit
Ah I see it's a whitelist plugin thing, strange -- when I used it last in
4.0.x it was fine:
/Users/buildbot/slaves/apache/cordova-ios/mobilespec/platforms/ios/mobilespec/Plugins/org.apache.cordova.test.whitelist/CDVWhitelistAPI.m:41:73:
error: no visible @interface for 'CDVViewController' declares
Not sure.. I did the "npm test" platform tests and they were fine.
On Wed, Jun 24, 2015 at 6:23 PM, Dmitry Blotsky
wrote:
> The latest build of iOS failed:
> http://ci.apache.org/builders/cordova-ios/builds/1150. Output here:
> http://ci.apache.org/builders/cordova-ios/builds/1150/steps/running-
The latest build of iOS failed:
http://ci.apache.org/builders/cordova-ios/builds/1150. Output here:
http://ci.apache.org/builders/cordova-ios/builds/1150/steps/running-tests/logs/stdio.
Sorry, I don't have the context to investigate: is it something related to
this change?
Kindly,
Dmitry
Also CB-5898 and CB-6441 fixes related to plugins not
installing/uninstalling properly (which has been a long time annoyance)
On Wed, Jun 24, 2015 at 4:40 PM, Shazron wrote:
> This is a bug in the CLI that was fixed, and not a bug in the plugin.
>
> On Wed, Jun 24, 2015 at 4:38 PM, Nikhil Khande
after a test merge, all platform tests pass (using "npm test"), so I'll be
doing the actual merge (forgive the commits@ email barrage)
On Wed, Jun 24, 2015 at 4:45 PM, Shazron wrote:
> Also, with cordova-ios 4.x, ios-sim 4.x and iso-deploy 2.x release (which
> again, I'm the only maintainer :)
>
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/145#issuecomment-115053099
Not sure I see the entire point of this, we've decided Objective-C object
pointer declaration should be "NSString* foo" instead of "NSString *foo". This
change woul
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-registry-web/pull/22
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-registry-web/pull/21
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
Also, with cordova-ios 4.x, ios-sim 4.x and iso-deploy 2.x release (which
again, I'm the only maintainer :)
https://shazronatadobe.wordpress.com/2015/05/18/ios-deploy-and-ios-sim-roadmaps/
On Wed, Jun 24, 2015 at 4:42 PM, Shazron wrote:
> The main thing is pluggable webview support in the plat
The main thing is pluggable webview support in the platform, i.e.
WKWebView. Don't have time to write this up (since, I like to remind
people, I work on this alone, hint hint). I'll write it up once I get the
merge going.
On Wed, Jun 24, 2015 at 4:36 PM, Nikhil Khandelwal
wrote:
> I would love t
This is a bug in the CLI that was fixed, and not a bug in the plugin.
On Wed, Jun 24, 2015 at 4:38 PM, Nikhil Khandelwal
wrote:
> Would it not be better to remove the iOS implementation from the whitelist
> plugin, so that it's install can be successful all the people using iOS 3.8
> and Android
Would it not be better to remove the iOS implementation from the whitelist
plugin, so that it's install can be successful all the people using iOS 3.8 and
Android 4.0?
When iOS 4.0 release happens, this support could be added back.
Thanks,
Nikhil
-Original Message-
From: Jesse [mailto
I would love to see a high level summary of what's in the 4.0.x branch? I have
not been closely keeping tab of this branch. We'll need to prepare such a
summary anyway - when blogging and doing a release notes about it anyway.
Thanks,
Nikhil
-Original Message-
From: tommy-carlos willia
Do it!
My team is hiring!
@purplecabbage
risingj.com
On Wed, Jun 24, 2015 at 11:11 AM, Shazron wrote:
> +1++
>
> On Wed, Jun 24, 2015 at 10:35 AM, Steven Gill
> wrote:
>
> > I'd like to get a tools release out that has the fix for skipping a
> plugin
> > if the platform version isn't met. Th
Github user icaro56 commented on the pull request:
https://github.com/apache/cordova-plugin-inappbrowser/pull/102#issuecomment-114992595
I follow your sample. Now the window shows. But, it does not scale in
screen. See the picture.
---
If your project is set up for it, you can reply to this
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/246#issuecomment-114947739
Added a few minor comments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/246#issuecomment-114946797
LGTM !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
en
Github user omefire commented on the pull request:
https://github.com/apache/cordova-lib/pull/234#issuecomment-114946578
Tim, your suggestions have been taken into account, please review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on G
Github user omefire commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/214#discussion_r33171432
--- Diff: doc/platform.txt ---
@@ -5,7 +5,10 @@ Synopsis
Manage project platforms
add [...].. add specified platforms
Github user onflapp closed the pull request at:
https://github.com/apache/cordova-osx/pull/9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user Uldax opened a pull request:
https://github.com/apache/cordova-plugin-battery-status/pull/24
Alignment with W3C Battery API
Addition of the methode navigator.getBattery which return a BatteryManager
object using promises to align with the [W3C
API](http://www.w3.org/TR/
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/146
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/237
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
34 matches
Mail list logo
