[GitHub] cordova-lib pull request: CB-9114: Log deprecation message when --...

2015-06-26 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/234#issuecomment-115732883 @stevengill , Thanks for the fix ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

Re: [CI] iOS build can't find simulator

2015-06-26 Thread Shazron
You'll have to specify a --target. First run: $ ios-sim showdevicetypes Choose your device string from that list, then do, for example: $ cordova run --target iPhone-5, 8.3 On Thu, Jun 25, 2015 at 9:08 PM, Dmitry Blotsky dblot...@microsoft.com wrote: Hi folks, Steve and Shaz swiftly

Re: [CI] iOS build can't find simulator

2015-06-26 Thread Shazron
Actually you can specify iPhone 5 whithout the runtime requirement as well. You can get the device list of course also using: $cordova run --list The default is indeed iPhone-6:

[GitHub] cordova-lib pull request: CB-8052: [webOS] Update cordova-lib for ...

2015-06-26 Thread omefire
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/239#discussion_r33370214 --- Diff: cordova-lib/src/plugman/platforms/webos.js --- @@ -0,0 +1,99 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-windows pull request: CB-9252: Migrate WinJS to an NPM dep...

2015-06-26 Thread TimBarham
Github user TimBarham commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/93#discussion_r33372216 --- Diff: bin/lib/create.js --- @@ -98,6 +106,16 @@ module.exports.run = function (argv) { return Q.resolve(); }; +function

[GitHub] cordova-android pull request: CB-9255: make getUriType case insens...

2015-06-26 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-android/pull/186#issuecomment-115755970 the code looks good. However, I'm curious : is there any specific use case this breaks ? or is it more like cleanup ? --- If your project is set up for it,

[GitHub] cordova-registry-web pull request: Raghav/routing

2015-06-26 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-registry-web/pull/23#discussion_r33378042 --- Diff: npm-search/assets/css/base.css --- @@ -5,6 +5,11 @@ body { margin: 0; } +h1 { + -webkit-margin-before:

[GitHub] cordova-android pull request: CB-9255: make getUriType case insens...

2015-06-26 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-android/pull/186#issuecomment-115805953 @cjpearson, it does make sense. thanks for the explanation. --- If your project is set up for it, you can reply to this email and have your reply appear on

Introduction

2015-06-26 Thread Suraj Pindoria
Hi All, My name is Suraj Pindoria and I am a new hire with the Adobe Phonegap team. I spent last summer here as an intern and worked primarily with cordova-browser and tried to get browserify up and running. I am now back and excited to be contributing to the project once again. Looking

[GitHub] cordova-registry-web pull request: Raghav/routing

2015-06-26 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-registry-web/pull/23#discussion_r33380658 --- Diff: npm-search/assets/js/app.js --- @@ -168,7 +168,15 @@ var Plugin = React.createClass({ /li ) }

[GitHub] cordova-registry-web pull request: Raghav/routing

2015-06-26 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-registry-web/pull/23#discussion_r33378891 --- Diff: npm-search/assets/js/app.js --- @@ -168,7 +168,15 @@ var Plugin = React.createClass({ /li ) }

[GitHub] cordova-registry-web pull request: Raghav/routing

2015-06-26 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-registry-web/pull/23#discussion_r33378953 --- Diff: npm-search/assets/js/app.js --- @@ -168,7 +168,15 @@ var Plugin = React.createClass({ /li ) }

Adobe Commiters offline

2015-06-26 Thread Steven Gill
Hey All, Adobe has a company wide shutdown next week (every summer). I just wanted to let you all know that we won't be around much during it. We will be back July 6th. Feel free to email or slack me if anything comes up. I won't respond very quickly though ;). Cheers, -Steve P.S. My team is

[GitHub] cordova-windows pull request: CB-9252: Migrate WinJS to an NPM dep...

2015-06-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/93 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request: CB-8052: [webOS] Update cordova-lib for ...

2015-06-26 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/239#discussion_r33377496 --- Diff: cordova-lib/src/plugman/platforms/webos.js --- @@ -0,0 +1,99 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-registry-web pull request: Add support for uglify fix is...

2015-06-26 Thread nikhilkh
GitHub user nikhilkh opened a pull request: https://github.com/apache/cordova-registry-web/pull/24 Add support for uglify fix issues with JSX and favicon.ico url references You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-android pull request: CB-9255: make getUriType case insens...

2015-06-26 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-android/pull/186#issuecomment-115805244 Makes sense to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-lib pull request: CB-8052: [webOS] Update cordova-lib for ...

2015-06-26 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/239#discussion_r33379893 --- Diff: cordova-lib/src/plugman/platforms/webos.js --- @@ -0,0 +1,99 @@ +/** +Licensed to the Apache Software Foundation (ASF) under

[GitHub] cordova-registry-web pull request: Raghav/routing

2015-06-26 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-registry-web/pull/23#discussion_r33378448 --- Diff: npm-search/assets/css/base.css --- @@ -5,6 +5,11 @@ body { margin: 0; } +h1 { + -webkit-margin-before:

[GitHub] cordova-lib pull request: CB-8052: [webOS] Update cordova-lib for ...

2015-06-26 Thread omefire
Github user omefire commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/239#discussion_r33378482 --- Diff: cordova-lib/src/plugman/platforms/webos.js --- @@ -0,0 +1,99 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-android pull request: CB-9255: make getUriType case insens...

2015-06-26 Thread cjpearson
Github user cjpearson commented on the pull request: https://github.com/apache/cordova-android/pull/186#issuecomment-115784095 The file transfer plugin uses this method to ensure that a url uses http or https. We would get INVALID_URL_ERR whenever a user entered a url with a capital

[GitHub] cordova-registry-web pull request: Raghav/routing

2015-06-26 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-registry-web/pull/23#discussion_r33380810 --- Diff: npm-search/assets/js/app.js --- @@ -168,7 +168,15 @@ var Plugin = React.createClass({ /li ) }

[GitHub] cordova-ios pull request: * is a Right-to-left associative operato...

2015-06-26 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/145#issuecomment-115829041 Stroustrup's take on this (who I think we can agree is an authority): http://www.stroustrup.com/bs_faq2.html#whitespace ``` The critical confusion

RE: Introduction

2015-06-26 Thread Parashuram N
Welcome Suraj -Original Message- From: Suraj Pindoria [mailto:suraj.pindo...@yahoo.com.INVALID] Sent: Friday, June 26, 2015 11:09 AM To: Dev Subject: Introduction Hi All, My name is Suraj Pindoria and I am a new hire with the Adobe Phonegap team. I spent last summer here as an intern

[GitHub] cordova-ios pull request: CB-8965 Copy cordova-js-src directory to...

2015-06-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/147 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

RE: Introduction

2015-06-26 Thread Mefire O .
Welcome Suraj, Good to have you among us. Thanks, Mefire -Original Message- From: Parashuram N [mailto:panar...@microsoft.com] Sent: Friday, June 26, 2015 11:27 AM To: dev@cordova.apache.org; Suraj Pindoria Subject: RE: Introduction Welcome Suraj -Original Message- From: Suraj

[GitHub] cordova-registry-web pull request: Raghav/routing

2015-06-26 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-registry-web/pull/23#discussion_r33397255 --- Diff: npm-search/assets/js/app.js --- @@ -168,7 +168,15 @@ var Plugin = React.createClass({ /li ) }

[GitHub] cordova-registry-web pull request: Raghav/routing

2015-06-26 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-registry-web/pull/23#discussion_r33397305 --- Diff: npm-search/assets/css/base.css --- @@ -5,6 +5,11 @@ body { margin: 0; } +h1 { + -webkit-margin-before:

[GitHub] cordova-registry-web pull request: Raghav/routing

2015-06-26 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-registry-web/pull/23#discussion_r33397998 --- Diff: npm-search/assets/js/app.js --- @@ -168,7 +168,15 @@ var Plugin = React.createClass({ /li ) }

Re: I'm back!

2015-06-26 Thread Carlos Santana
welcome, congrats on the new family member On Thu, Jun 25, 2015 at 6:39 PM, Jesse purplecabb...@gmail.com wrote: Welcome back, and congratulations! My team is hiring! @purplecabbage risingj.com On Thu, Jun 25, 2015 at 3:31 PM, Steven Gill stevengil...@gmail.com wrote: Wooo! Welcome

[GitHub] cordova-registry-web pull request: Raghav/routing

2015-06-26 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-registry-web/pull/23#discussion_r33393473 --- Diff: npm-search/assets/js/app.js --- @@ -280,12 +299,23 @@ var App = React.createClass({ } else {

[GitHub] cordova-registry-web pull request: Raghav/routing

2015-06-26 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-registry-web/pull/23#discussion_r33394125 --- Diff: npm-search/assets/css/base.css --- @@ -5,6 +5,11 @@ body { margin: 0; } +h1 { + -webkit-margin-before:

Re: [CI] iOS build can't find simulator

2015-06-26 Thread Shazron
run On Fri, Jun 26, 2015 at 12:25 PM, Carlos Santana csantan...@gmail.com wrote: Is it $cordova run --list or $cordova emulate --list On Fri, Jun 26, 2015 at 11:48 AM, Shazron shaz...@gmail.com wrote: Actually you can specify iPhone 5 whithout the runtime requirement as well. You can

Re: [CI] iOS build can't find simulator

2015-06-26 Thread Carlos Santana
Is it $cordova run --list or $cordova emulate --list On Fri, Jun 26, 2015 at 11:48 AM, Shazron shaz...@gmail.com wrote: Actually you can specify iPhone 5 whithout the runtime requirement as well. You can get the device list of course also using: $cordova run --list The default is indeed

[GitHub] cordova-registry-web pull request: Raghav/routing

2015-06-26 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-registry-web/pull/23#discussion_r33393252 --- Diff: npm-search/assets/js/app.js --- @@ -168,7 +168,15 @@ var Plugin = React.createClass({ /li ) }

[GitHub] cordova-registry-web pull request: Raghav/routing

2015-06-26 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-registry-web/pull/23#discussion_r33393702 --- Diff: npm-search/assets/js/app.js --- @@ -168,7 +168,15 @@ var Plugin = React.createClass({ /li ) }

[GitHub] cordova-ios pull request: * is a Right-to-left associative operato...

2015-06-26 Thread Coeur
Github user Coeur commented on the pull request: https://github.com/apache/cordova-ios/pull/145#issuecomment-115620070 But the original decision was semantically incorrect. It teaches a bad habit. And `blame` can also be configured to hide specific contributions, like the ones

[GitHub] cordova-ios pull request: * is a Right-to-left associative operato...

2015-06-26 Thread Coeur
Github user Coeur commented on the pull request: https://github.com/apache/cordova-ios/pull/145#issuecomment-115621019 Also, the day you move to, let say, Swift, you won't avoid changing latest contribution to someone else. --- If your project is set up for it, you can reply to this

[GitHub] cordova-plugin-inappbrowser pull request: Fixed zIndex issue on Wi...

2015-06-26 Thread aroberson
Github user aroberson commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/102#issuecomment-115919772 No, after making the zindex change, you have have your apps css right for the content displayed. On Jun 26, 2015, at 6:54 AM,

[GitHub] cordova-registry-web pull request: Add support for uglify fix is...

2015-06-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-registry-web/pull/24 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-registry-web pull request: Raghav/routing

2015-06-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-registry-web/pull/23 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-contacts pull request: Do not return absolute path ...

2015-06-26 Thread darkyen
GitHub user darkyen opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/65 Do not return absolute path for contact images. If an absolute url is returned the developer must use the file system api to get a reference to the image, instead returning a blob

Buildbot: buildslave cordova-osx-slave was lost

2015-06-26 Thread buildbot
The Buildbot working for 'ASF Buildbot' has noticed that the buildslave named cordova-osx-slave went away It last disconnected at Fri Jun 26 22:14:05 2015 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Dmitry Blotsky dblot...@microsoft.com '. Sincerely,

[cordova-lib] nom version too old, cannot use cnpm @scoped syntax

2015-06-26 Thread huz's gmail
Hi, Dear Cordova Team, I’m in a dilemma where i’d like to publish company private cordova plugins using cnpm: https://github.com/cnpm/cnpmjs.org https://github.com/cnpm/cnpmjs.org while its syntax is rejected by cordova-cli’s (5.1.1) npm max version: 1.3.4 I understand that

[GitHub] cordova-lib pull request: CB-9122 Added tests for platform/plugin ...

2015-06-26 Thread alsorokin
Github user alsorokin commented on the pull request: https://github.com/apache/cordova-lib/pull/246#issuecomment-115596356 - Disabling console logging seems to be really tricky in this case.Most of it comes from android platform code which runs in child_process.spawn. i've tried

[GitHub] cordova-plugin-inappbrowser pull request: Fixed zIndex issue on Wi...

2015-06-26 Thread icaro56
Github user icaro56 commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/102#issuecomment-115655215 aroberson, Have I change the InAppBrowserProxy.js file to solved this? --- If your project is set up for it, you can reply to this email

[GitHub] cordova-lib pull request: CB-9122 Added tests for platform/plugin ...

2015-06-26 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/246#issuecomment-115693183 Merging. The AppVeyor failures, caused by node-xcode fixed in https://github.com/apache/cordova-lib/pull/253 --- If your project is set up for it, you

[GitHub] cordova-android pull request: CB-9255: make getUriType case insens...

2015-06-26 Thread cjpearson
GitHub user cjpearson opened a pull request: https://github.com/apache/cordova-android/pull/186 CB-9255: make getUriType case insensitive You can merge this pull request into a Git repository by running: $ git pull https://github.com/cjpearson/cordova-android uri-fix

[GitHub] cordova-lib pull request: CB-9122 Added tests for platform/plugin ...

2015-06-26 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/246#issuecomment-115695959 @alsorokin, sounds good. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-ios pull request: * is a Right-to-left associative operato...

2015-06-26 Thread cjpearson
Github user cjpearson commented on the pull request: https://github.com/apache/cordova-ios/pull/145#issuecomment-115654625 The current style is not incorrect or a bad habit. It may not follow Apple's style, but both styles are valid and readable. Many C programmers choose to

[GitHub] cordova-lib pull request: Fixed ios node-xcode related tests faili...

2015-06-26 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-lib/pull/253 Fixed ios node-xcode related tests failing on Windows according to version update You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-lib pull request: Fixed ios node-xcode related tests faili...

2015-06-26 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/253#issuecomment-115691375 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-lib pull request: Fixed ios node-xcode related tests faili...

2015-06-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/253 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-9122 Added tests for platform/plugin ...

2015-06-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/246 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature