[GitHub] cordova-android pull request: CB-9185 Fix signed release build exc...

2015-07-06 Thread josschne
GitHub user josschne opened a pull request: https://github.com/apache/cordova-android/pull/193 CB-9185 Fix signed release build exception You can merge this pull request into a Git repository by running: $ git pull https://github.com/josschne/cordova-android master Alternativ

RE: Introduction

2015-07-06 Thread Murat Sutunc
Hey Paul, Welcome to Cordova! I've looked at your changes on github and have some early feedback. 1) As per spec you return a Promise on battery.js but to my knowledge we don't have a fallback for ES6 Promises on platforms that don't support it yet. I would like to know what other committers th

[GitHub] cordova-coho pull request: Add support for launching URL to create...

2015-07-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/88 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-coho pull request: Make repo-update more resilient to fail...

2015-07-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/87 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...

2015-07-06 Thread nikhilkh
Github user nikhilkh commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/96#discussion_r33999448 --- Diff: template/cordova/lib/deployment.js --- @@ -0,0 +1,272 @@ +/* + Licensed to the Apache Software Foundation (ASF) under one

[GitHub] cordova-android pull request: CB-9172 Improved emulator deploy sta...

2015-07-06 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-android/pull/188#issuecomment-119036955 @dblotsky Can you please help review and merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-windows pull request: CB-9235 Adds more checks based on th...

2015-07-06 Thread robpaveza
Github user robpaveza commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/92#discussion_r33998489 --- Diff: bin/lib/check_reqs.js --- @@ -19,15 +19,226 @@ /*jshint node:true*/ -var Q = require('Q'); +var Q = requir

[GitHub] cordova-windows pull request: CB-9235 Adds more checks based on th...

2015-07-06 Thread robpaveza
Github user robpaveza commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/92#discussion_r33998435 --- Diff: bin/lib/check_reqs.js --- @@ -19,15 +19,226 @@ /*jshint node:true*/ -var Q = require('Q'); +var Q = requir

[GitHub] cordova-windows pull request: CB-9235 Adds more checks based on th...

2015-07-06 Thread robpaveza
Github user robpaveza commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/92#discussion_r33998401 --- Diff: bin/lib/check_reqs.js --- @@ -19,15 +19,226 @@ /*jshint node:true*/ -var Q = require('Q'); +var Q = requir

Re: Android: config.xml prefs can't be read by plugins

2015-07-06 Thread Joe Bowser
It was pointed out to me that CordovaPlugin does have an instance of the preference object. I missed that when I was working on this earlier. Closed the pull request. On Mon, Jul 6, 2015 at 3:57 PM Joe Bowser wrote: > Hey > > So, since we decided to stop using Intents to manipulate plugins for

[GitHub] cordova-windows pull request: CB-9235 Adds more checks based on th...

2015-07-06 Thread robpaveza
Github user robpaveza commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/92#discussion_r33998339 --- Diff: bin/lib/check_reqs.js --- @@ -19,15 +19,226 @@ /*jshint node:true*/ -var Q = require('Q'); +var Q = requir

[GitHub] cordova-windows pull request: CB-9283: Add support for Windows 10 ...

2015-07-06 Thread robpaveza
GitHub user robpaveza opened a pull request: https://github.com/apache/cordova-windows/pull/96 CB-9283: Add support for Windows 10 WinAppDeployCmd The Windows 10 SDK uses a new "WinAppDeployCmd" utility for deployment to phones. This change abstracts out the differences between Win

[GitHub] cordova-android pull request: CB-9298: Preferences are now passed ...

2015-07-06 Thread infil00p
Github user infil00p commented on the pull request: https://github.com/apache/cordova-android/pull/192#issuecomment-119032970 Didn't read the plugin info. Closing. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-android pull request: CB-9298: Preferences are now passed ...

2015-07-06 Thread infil00p
Github user infil00p closed the pull request at: https://github.com/apache/cordova-android/pull/192 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] cordova-plugin-media pull request: CB-9300 remove spontaneous inte...

2015-07-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/59 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-plugin-media pull request: CB-9300 remove spontaneous inte...

2015-07-06 Thread purplecabbage
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-plugin-media/pull/59 CB-9300 remove spontaneous integration tests You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/cordova-plugin-me

[GitHub] cordova-android pull request: CB-9298: Preferences are now passed ...

2015-07-06 Thread infil00p
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-android/pull/192 CB-9298: Preferences are now passed to the Cordova Interface I'm doing a pull request instead of just slamming this in because this is actually a pretty important change that will impact p

Android: config.xml prefs can't be read by plugins

2015-07-06 Thread Joe Bowser
Hey So, since we decided to stop using Intents to manipulate plugins for Security Reasons, we have this problem of not being able to read the values from config.xml into any of the plugins, since they don't have access to the preferences object. I have a pull request here where I copy the object

[GitHub] cordova-plugin-camera pull request: CB-9193: Add 'showLibraryButto...

2015-07-06 Thread dpolivy
Github user dpolivy commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/104#issuecomment-119015527 @muratsu Valid question, thanks for starting the discussion. The Android implementation is more like the Messages/Slack experience you highlight above. I

RE: [DISCUSS] Remove 'plugman publish' functionality from cordova-lib

2015-07-06 Thread Nikhil Khandelwal
+1 on moving to new npm dependency. There are a bunch of JIRAs (around proxy support) that would be resolved with the latest & greatest dependencies. As for making the CPR read-only, there is still some usage of this: Last updated from the CPR: 5 hours ago com.purplebrain.adbuddiz.sdk 12 hour

[GitHub] cordova-plugin-camera pull request: CB-9193: Add 'showLibraryButto...

2015-07-06 Thread muratsu
Github user muratsu commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/104#issuecomment-119003640 I would like to hear everyone's opinion on this before going with the code review. Showing the photo gallery on bottom left seems like a custom v

Re: Release testing gaps

2015-07-06 Thread Steven Gill
Do we currently just test master plugins with master platforms? It would be nice to test master plugins against released platforms and master platforms with released plugins. cordova-plugin-whitelist problem got solved in a unreleased fix to cordova-lib. It would have made sense to hold off on rel

Re: Questions about cordova

2015-07-06 Thread Raymond Camden
This listserv is for questions about the project itself, not technical questions about using it. I'd suggest the Phonegap Google group or StackOverflow. On Mon, Jul 6, 2015 at 8:24 AM, Anas Asiri wrote: > Hello, > > > I’m working on an app with cordova. I have some trouble with the login thing.

Questions about cordova

2015-07-06 Thread Anas Asiri
Hello, I’m working on an app with cordova. I have some trouble with the login thing. I don’t know how to make sure that the user can login and doesn’t need to login anymore if he re-use my app. Do you know what technology I can use ? And I wanted to know if the WebSQL API is a database viewab

Re: Google Analytics on Cordova Docs

2015-07-06 Thread Andrey Kurdumov
I will pickup that task. That's trivial fix, but somebody else should generate all other versions and publish, I could only ensure that generation should works for all versions. Will let you know about the progress 2015-07-06 22:56 GMT+06:00 Nikhil Khandelwal : > I've create a JIRA here with all

Release testing gaps

2015-07-06 Thread Nikhil Khandelwal
https://issues.apache.org/jira/browse/CB-9248 highlights a testing gap with our release process: * cordova-plugin-whitelist should not have been released with having iOS platform >= 4.0 without iOS platform release. While reverting the 'latest' tag was a good move to get this fixed, it

Re: Cordova July Hangout

2015-07-06 Thread Steven Gill
Let's do it! On Jul 1, 2015 10:57 AM, "Nikhil Khandelwal" wrote: > I was wondering if it is a good time for a hangout. Here are few good > topics for discussion: > 1. Re-working cordova-lib <-> cordova platform interactions. > Review new API - Vladimir > https://github.com/cordova/cordova

Re: [DISCUSS] Remove 'plugman publish' functionality from cordova-lib

2015-07-06 Thread Steven Gill
+1! I'm going to start preparing the registry to switch to read only as well. That way users can't use a old version of plugman to publish. On Jul 6, 2015 7:46 AM, "Vladimir Kotikov (Akvelon)" wrote: > Hi, list. > > Wanted to bump 'CPR vs NPM' topic again. July 15 is coming, so probably > we'll

[GitHub] cordova-plugin-file-transfer pull request: CB-9275 [WP8] Fix build...

2015-07-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/91 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

RE: Google Analytics on Cordova Docs

2015-07-06 Thread Nikhil Khandelwal
I've create a JIRA here with all details: https://issues.apache.org/jira/browse/CB-9295 We can use it to track who picks it up. Thanks, Nikhil -Original Message- From: Victor Sosa [mailto:sosah.vic...@gmail.com] Sent: Monday, July 6, 2015 9:42 AM To: dev@cordova.apache.org Subject: Re

[GitHub] cordova-medic pull request: CB-8936 Gathering logs on Windows

2015-07-06 Thread robpaveza
Github user robpaveza commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/58#discussion_r33955365 --- Diff: medic/medic-run.js --- @@ -232,12 +233,18 @@ function windowsSpecificPreparation(argv) { /^\s*\$appActivator .*$/gim,

[GitHub] cordova-medic pull request: CB-8936 Gathering logs on Windows

2015-07-06 Thread robpaveza
Github user robpaveza commented on a diff in the pull request: https://github.com/apache/cordova-medic/pull/58#discussion_r33955321 --- Diff: medic/medic-run.js --- @@ -232,12 +233,18 @@ function windowsSpecificPreparation(argv) { /^\s*\$appActivator .*$/gim,

Re: Google Analytics on Cordova Docs

2015-07-06 Thread Victor Sosa
Hi Nikhil. What's the due date for this? I'm currently bloated with work, but I can help perhaps starting next July 20th. On Mon, Jul 6, 2015 at 11:30 AM Nikhil Khandelwal wrote: > We just setup a new GA account for Cordova project. All of the Cordova PMC > has access to the GA account, we'll ha

RE: Google Analytics on Cordova Docs

2015-07-06 Thread Nikhil Khandelwal
We just setup a new GA account for Cordova project. All of the Cordova PMC has access to the GA account, we'll have to figure out how to provide you access. We need to update the current set of docs with the new GA ID for it to generate any data currently. Would you be able to help with that? T

[GitHub] cordova-plugin-media pull request: CB-9238 Media plugin cannot rec...

2015-07-06 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33950380 --- Diff: src/windows/MediaProxy.js --- @@ -159,7 +176,21 @@ module.exports = { var id = args[0]; var src = args[1];

[GitHub] cordova-plugin-media pull request: CB-9238 Media plugin cannot rec...

2015-07-06 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33950096 --- Diff: src/windows/MediaProxy.js --- @@ -33,8 +42,11 @@ module.exports = { create:function(win, lose, args) { var id = ar

[GitHub] cordova-plugin-media pull request: CB-9238 Media plugin cannot rec...

2015-07-06 Thread daserge
Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-media/pull/58#discussion_r33950043 --- Diff: src/windows/MediaProxy.js --- @@ -33,8 +42,11 @@ module.exports = { create:function(win, lose, args) { var id = ar

[GitHub] cordova-lib pull request: CB-9033 : fix WatchKit support

2015-07-06 Thread sdesapio
Github user sdesapio commented on the pull request: https://github.com/apache/cordova-lib/pull/219#issuecomment-118887096 @ogoguel You're definitely not the only one. I'm the one that posted that bug report you're referring to. Waiting patiently. --- If your project is set up for it,

[DISCUSS] Remove 'plugman publish' functionality from cordova-lib

2015-07-06 Thread Vladimir Kotikov (Akvelon)
Hi, list. Wanted to bump 'CPR vs NPM' topic again. July 15 is coming, so probably we'll need to make some changes to remove CPR publishing related functionality from Cordova. Things, that needs to be removed: 1. 'plugman publish/unpublish' commands, 2. 'registry.publish/unpublish' methods a

[GitHub] cordova-plugin-file-transfer pull request: README :: remove duplic...

2015-07-06 Thread danjarvis
GitHub user danjarvis opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/92 README :: remove duplicate httpMethod option. The `httpMethod` option was duplicated as an upload option in [04f088b6c906e0b74bf3610005787b90aa548b9e](https://github.com/a

Re: Adobe Commiters offline

2015-07-06 Thread julio cesar sanchez
Welcome back 2015-06-30 18:46 GMT+02:00 Shazron : > Just a reminder about this in case you all think we dropped off the face of > the Earth :) > > On Friday, June 26, 2015, Steven Gill wrote: > > > Hey All, > > > > Adobe has a company wide shutdown next week (every summer). I just wanted > > to

[GitHub] cordova-plugin-file-transfer pull request: CB-9275 [WP8] Fix build...

2015-07-06 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/91#issuecomment-118762487 LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-file-transfer pull request: CB-9275 [WP8] Fix build...

2015-07-06 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/91#discussion_r33911944 --- Diff: src/wp/FileTransfer.cs --- @@ -437,10 +438,10 @@ public void upload(string options) { tr

[GitHub] cordova-android pull request: CB-9286 Fixes build failure when AND...

2015-07-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/191 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur