Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/98
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/257
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/259#issuecomment-121459962
Thanks @giuseppelt. Saw your ICLA came through. Change is merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/259
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/97
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-windows/pull/97#issuecomment-121430365
This is merged and should close soon.
The mirrors are slow today.
---
If your project is set up for it, you can reply to this email and have your
repl
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-js/pull/119
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-js/pull/120
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-js/pull/120
CB-9368 remove old debug build steps
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/purplecabbage/cordova-js CB-9368
Alternatively y
So, since Cordova-Android wasn't completely killed off by Google at the
last Google IO like I thought it would be, we're going to have to make sure
it's compatible with Android M (Marshmellow? Marzipan?). The good news is
that this only affects the following plugins:
MediaRecorder
Contacts
File
F
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-js/pull/119
CB-8972 Added common 'activated' channel
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/purplecabbage/cordova-js CB-8972
Alternative
Github user muratsu commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/56#issuecomment-121375282
@kiwinewt thanks for the contribution. The right approach here is to take
into account the max num of pixels instead of a certain height or width limit.
Github user typevitor commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/67#issuecomment-121346507
Sorry, my mistake the removed hasPhoneNumber.
I'll start a discussion then.
---
If your project is set up for it, you can reply to this email and
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-registry-web/pull/17
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the fe
GitHub user jcesarmobile opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/108
CB-6190 - iOS camera plugin ignores quality parameter
CB-6190 - iOS camera plugin ignores quality parameter in some
circunstances
Added a check to not downscale if quality
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-js/pull/118#issuecomment-121336324
I would leave this to userland.
```window.onerror = function(err,filename,lineNumber) {
...
}```
Also, on iOS this is going to look like :
GitHub user nikhilkh opened a pull request:
https://github.com/apache/cordova-js/pull/118
CB-9366 Log error.stack as it helps with diagnosing the source of theâ¦
⦠error
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTec
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-windows/pull/99#issuecomment-121325599
I like the change overall but I need to still merge it with my latest to
make sure it functionally works as expected.
---
If your project is set up for it,
Github user robpaveza commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/58#issuecomment-121324570
Pending my other comments, LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-contacts/pull/67#issuecomment-121323697
Um, no.
You just removed the hasPhoneNumber functionality which was just added a
couple weeks ago?
You need to consider more than just Andr
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/99#issuecomment-121308567
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
GitHub user typevitor opened a pull request:
https://github.com/apache/cordova-plugin-contacts/pull/67
custom label for phoneNumber
writing the possibility for adding custom label for phoneNumbers.
You can merge this pull request into a Git repository by running:
$ git pull htt
Github user giuseppelt commented on the pull request:
https://github.com/apache/cordova-lib/pull/259#issuecomment-121279489
I made the changes to use the promise.
I signed the icla and mailed to secretary at apache. Do I have to do
further actions?
---
If your project is set up f
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/259#discussion_r34565570
--- Diff: cordova-lib/src/cordova/prepare.js ---
@@ -106,28 +106,29 @@ function prepare(options) {
if (options.browserify) {
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/99#issuecomment-121214310
@nikhilkh, i've added tests + Travis config. See
https://github.com/vladimir-kotikov/cordova-windows/pull/1 for build status.
Not sure about adding e2e
Github user giuseppelt commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/259#discussion_r34558047
--- Diff: cordova-lib/src/cordova/prepare.js ---
@@ -106,28 +106,29 @@ function prepare(options) {
if (options.browserify) {
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/259#discussion_r34557772
--- Diff: cordova-lib/src/cordova/prepare.js ---
@@ -106,28 +106,29 @@ function prepare(options) {
if (options.browserify) {
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/259#discussion_r34557461
--- Diff: cordova-lib/src/cordova/prepare.js ---
@@ -106,28 +106,29 @@ function prepare(options) {
if (options.browserify) {
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-lib/pull/259#issuecomment-121200391
Thanks @giuseppelt. Looks good to me apart from the one stylistic comment.
@stevengill does this look right to you?
---
If your project is set up for it, you can
Github user TimBarham commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/259#discussion_r34556418
--- Diff: cordova-lib/src/cordova/prepare.js ---
@@ -106,28 +106,29 @@ function prepare(options) {
if (options.browserify) {
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-windows/pull/100
Cb 9239
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vladimir-kotikov/cordova-windows CB-9239
Alternatively you can review
Github user vladimir-kotikov closed the pull request at:
https://github.com/apache/cordova-windows/pull/100
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user foxgeere commented on the pull request:
https://github.com/apache/cordova-plugin-media/pull/39#issuecomment-121192973
Is this going to be merged in any time soon? Really need to be able to play
sound effects in app without it stopping system music in its tracks
---
If yo
GitHub user giuseppelt opened a pull request:
https://github.com/apache/cordova-lib/pull/259
Fix prepare to wait the promise from plugman prepare.
This fixes the issue where after_prepare hook is fired before the prepare
process ends.
You can merge this pull request into a Git repo
34 matches
Mail list logo
