Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/203#issuecomment-125478024
@alsorokin, please delete MSOT branch, if not needed anymore.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user vladimir-kotikov closed the pull request at:
https://github.com/apache/cordova-windows/pull/92
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/99
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user galexandrov commented on the pull request:
https://github.com/apache/cordova-lib/pull/236#issuecomment-125530595
In our case we don't use the Cordova CLI we use cordova-{platform} scripts
for project creation and that's why we don't have the Cordova CLI Project
structure.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-windows/pull/92#issuecomment-125482377
This was merged in 9be50cd43a893f6af532b585baa7fa00e71772c9 but not
auto-closed. Closing it now.
---
If your project is set up for it, you can reply
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/92#issuecomment-125480333
lgtm :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user sgrebnov commented on the pull request:
https://github.com/apache/cordova-windows/pull/99#issuecomment-125480365
lgtm :+1:
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-android/pull/203
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/255#issuecomment-125785840
Plugins don't have to have the id XXX-XXX-XXX. They can be anything now.
Does this change account for that?
---
If your project is set up for it, you can reply
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/33#issuecomment-125794448
Yeah, I have just been wondering the same thing. The only `browser`
specific thing is that it starts firing the `devicemotion` event when you
Github user morenoh149 commented on the pull request:
https://github.com/apache/cordova-js/pull/86#issuecomment-125773476
Any word on this from 2015? This PR should be closed if it's been decided
the api's dont concern the same thing.
---
If your project is set up for it, you can
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/33#issuecomment-125793282
Actually, on second thought ...
I don't think there is much reason for the browser implementation to have
it's own version of
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/270
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
http://cordova.apache.org/announcements/2015/07/21/cordova-android-4.1.0.html
Tweet: https://twitter.com/apachecordova/status/626174226962227200
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/272
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/33
CB-9426 Fix exception using device motion plugin on browser platform
The plugin's `plugin.xml` defines a general `js-module` with the name
`accelerometer`. It defines another
It seems to me like it would be good to get a cordova-browser release out.
There have been a few changes since the last release - most significantly
launching from a server rather than the local file system, which I think is an
important change to release.
Any objections? Would 3.7.0 be the
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/33#issuecomment-125805744
Ok, I've deleted the browser specific implementation and moved the browser
specific logic into the general implementation, and also added some
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/33#issuecomment-125791006
@stevengill and @purplecabbage - interested in whether this fix looks right
to you guys, since I've not worked in this code much before.
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/33#issuecomment-125792526
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/269#discussion_r35641611
--- Diff: cordova-lib/src/plugman/fetch.js ---
@@ -236,7 +236,7 @@ function findLocalPlugin(plugin_src, searchpath,
pluginInfoProvider) {
Github user galexandrov commented on the pull request:
https://github.com/apache/cordova-lib/pull/271#issuecomment-125624618
run ci
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-android/pull/203#issuecomment-125472941
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user galexandrov opened a pull request:
https://github.com/apache/cordova-lib/pull/271
Add platform project instance in hook options context
Add platform project instance in hook options context for install/uninstall
plugman commands.
This is handy when you need to make
GitHub user galexandrov opened a pull request:
https://github.com/apache/cordova-lib/pull/272
Update xcode dependency to latest stable version
Update to latest stable version, because new features and bug fixes are
introduced in it
You can merge this pull request into a Git
Github user tohagan commented on the pull request:
https://github.com/apache/cordova-ios/pull/132#issuecomment-12582
+1 Still can't build.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/127#issuecomment-125668467
When I say user, I mean someone with an app on their phone.
Either we migrate the users files, or we make app developers do it. The
major
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-plugin-file/pull/127#issuecomment-125647394
@purplecabbage I don't think we need to do this as a user of an older
version of this plugin only needs to set the preference
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-lib/pull/269
CB-9421 Fixed searchpath parameter being ignored
https://issues.apache.org/jira/browse/CB-9421
You can merge this pull request into a Git repository by running:
$ git pull
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/270
CB-9420 Fixes malformed require calls in browserify bundle
This fixes browserify bundle generation problems, desctibed in
[CB-9420](https://issues.apache.org/jira/browse/CB-9420)
You
Please review and vote on this 3.9.0 iOS Release
by replying to this email (and keep discussion on the DISCUSS thread)
Release issue: https://issues.apache.org/jira/browse/CB-9406
The archive has been published to dist/dev:
https://dist.apache.org/repos/dist/dev/cordova/CB-9406
The package was
GitHub user TimBarham opened a pull request:
https://github.com/apache/cordova-plugin-device-orientation/pull/21
CB-9426 Fix exception using device orientation plugin on browser platform
Initially reported for the `device motion` plugin, the same problem exists
for the `device
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-lib/pull/267
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-network-information/pull/16
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-device/pull/36
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/22#issuecomment-125700329
If that is the case, then it is a separate defect, however, I do not
believe this is happening.
Please revisit/close this pull
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-lib/pull/269#issuecomment-125695914
lgtm!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/23#issuecomment-125699962
This pr is hopelessly out of sync. Please fix it if you still think it is
valid, or close it.
---
If your project is set up for it,
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/92
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/96
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-statusbar/pull/27
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-network-information/pull/29
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user stevengill commented on the pull request:
https://github.com/apache/cordova-lib/pull/270#issuecomment-125729265
LGTM! I'll test and merge it in!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user SidFerreira opened a pull request:
https://github.com/apache/cordova-plugin-network-information/pull/30
Performance-related fix
Move all conversions to line 236, saving ~14 tests
You can merge this pull request into a Git repository by running:
$ git pull
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/30#issuecomment-125736123
Thanks, I am planning to remove all string comparisons one day and actually
use the defined types, but this does help in the meantime.
Github user SidFerreira commented on the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/29#issuecomment-125732348
Why not make the toLowerCase on the line #236 and saving all the conversion
and tests on the other lines?
---
If your project is set up
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-plugin-network-information/pull/29#issuecomment-125734549
Send a pull request.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user TheBikingViking commented on the pull request:
https://github.com/apache/cordova-plugin-statusbar/pull/27#issuecomment-125466147
When will this pull request be merged back?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-network-information/pull/30
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
49 matches
Mail list logo
