[GitHub] cordova-lib pull request:

2015-08-12 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/commit/ed2f06368b650aca56622c90025211bdc69ea482#commitcomment-12681093 In cordova-lib/src/configparser/ConfigParser.js: In cordova-lib/src/configparser/ConfigParser.js on line 290: conside

[GitHub] cordova-lib pull request:

2015-08-12 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/commit/ed2f06368b650aca56622c90025211bdc69ea482#commitcomment-12681084 In cordova-lib/package.json: In cordova-lib/package.json on line 47: Perhaps we should not have this plugin in the fi

[GitHub] cordova-lib pull request:

2015-08-12 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/commit/ed2f06368b650aca56622c90025211bdc69ea482#commitcomment-12681014 In cordova-lib/package.json: In cordova-lib/package.json on line 48: lodash is not being used and hence, should be re

[GitHub] cordova-plugin-splashscreen pull request: Implementing FadeSplashS...

2015-08-12 Thread trancee
Github user trancee commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/53#issuecomment-130521975 I agree with your point, but due to the already implemented FadeSplashScreenDuration (splash-screen Fade duration in seconds) I can not simply chang

[GitHub] cordova-plugin-splashscreen pull request: Implementing FadeSplashS...

2015-08-12 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/53#issuecomment-130511210 SplashScreenDelay (number, default to 1). Amount of time in milliseconds to wait before automatically hide splash screen. --- If your pr

Re: [Vote] Tools Release

2015-08-12 Thread Carlos Santana
I'm right now in the middle of it and found something weird with cordova-lib It has an extra src/plugman/temp that I don't see on git - Carlos Sent from my iPhone > On Aug 12, 2015, at 8:50 PM, Steven Gill wrote: > > Need one more vote > > On Tue, Aug 11, 2015 at 4:45 PM, Nikhil Khandelwal >

[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...

2015-08-12 Thread ghenry22
Github user ghenry22 commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-130505127 avplayer which is used for streaming does not have an equivalent stop method. You can just pause() and then release() there is no need to stop(). --- If

Re: [Vote] Tools Release

2015-08-12 Thread Steven Gill
Need one more vote On Tue, Aug 11, 2015 at 4:45 PM, Nikhil Khandelwal wrote: > +1. > > * Ran coho audit -license-headers > * Ran coho verify-tags and validated all the tags > * Created a hello world app to ensure the correct versions of the > platforms are pinned. > > Thanks, > Nikhil > > >

[GitHub] cordova-plugin-file pull request: Make Android default persistent ...

2015-08-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/127 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-plugin-splashscreen pull request: Implementing FadeSplashS...

2015-08-12 Thread trancee
Github user trancee commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/53#issuecomment-130476012 I am just being compatible to the already existing preference which is given in seconds (coming from iOS). --- If your project is set up for it, yo

[GitHub] cordova-windows pull request: CB-9482: Upon further investigation ...

2015-08-12 Thread robpaveza
Github user robpaveza commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/113#discussion_r36926008 --- Diff: template/cordova/lib/deployment.js --- @@ -194,13 +194,28 @@ AppDeployCmdTool.prototype.enumerateDevices = function() { });

[GitHub] cordova-windows pull request: CB-9482: Upon further investigation ...

2015-08-12 Thread robpaveza
Github user robpaveza commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/113#discussion_r36925808 --- Diff: template/cordova/lib/deployment.js --- @@ -194,13 +194,28 @@ AppDeployCmdTool.prototype.enumerateDevices = function() { });

[GitHub] cordova-windows pull request: CB-9482: Upon further investigation ...

2015-08-12 Thread robpaveza
Github user robpaveza commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/113#discussion_r36925416 --- Diff: template/cordova/lib/deployment.js --- @@ -35,7 +35,7 @@ function run(cmd, args, opt_cwd) { child.stderr.on('data', function(

[GitHub] cordova-windows pull request: CB-9482: Upon further investigation ...

2015-08-12 Thread robpaveza
Github user robpaveza commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/113#discussion_r36925333 --- Diff: template/cordova/lib/deployment.js --- @@ -194,13 +194,28 @@ AppDeployCmdTool.prototype.enumerateDevices = function() { });

[GitHub] cordova-windows pull request: CB-9482: Upon further investigation ...

2015-08-12 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/113#discussion_r36921448 --- Diff: template/cordova/lib/deployment.js --- @@ -35,7 +35,7 @@ function run(cmd, args, opt_cwd) { child.stderr.on('data', function(s

[GitHub] cordova-windows pull request: CB-9482: Upon further investigation ...

2015-08-12 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/113#discussion_r36921360 --- Diff: template/cordova/lib/deployment.js --- @@ -194,13 +194,28 @@ AppDeployCmdTool.prototype.enumerateDevices = function() { });

[GitHub] cordova-windows pull request: CB-9482: Upon further investigation ...

2015-08-12 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/113#discussion_r36921320 --- Diff: template/cordova/lib/deployment.js --- @@ -194,13 +194,28 @@ AppDeployCmdTool.prototype.enumerateDevices = function() { });

[GitHub] cordova-app-hello-world pull request: CB-9009 default CSP needs to...

2015-08-12 Thread timwindsor
Github user timwindsor commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/10#issuecomment-130459377 Thanks everyone - I've got a potential solution that we're testing here. We can close this request. --- If your project is set up for it, you can re

[GitHub] cordova-windows pull request: CB-9482: Upon further investigation ...

2015-08-12 Thread robpaveza
GitHub user robpaveza opened a pull request: https://github.com/apache/cordova-windows/pull/113 CB-9482: Upon further investigation of CI failures, we saw that AppDeployCmd also failed to install an app when: - The emulator had been off previously - It had been started with

[GitHub] cordova-windows pull request: CB-9482: Modifies the deployment cod...

2015-08-12 Thread robpaveza
Github user robpaveza closed the pull request at: https://github.com/apache/cordova-windows/pull/112 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] cordova-plugin-statusbar pull request: fix warning on IOS8

2015-08-12 Thread S8ER01Z
Github user S8ER01Z commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/pull/26#issuecomment-130427802 Any chance of this change going in? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

Re: Buildbot: buildslave cordova-osx-slave was lost

2015-08-12 Thread Dmitry Blotsky
The slave was shut down to diagnose and subsequently file CB-9483 (https://issues.apache.org/jira/browse/CB-9483). It went back up an hour after. Kindly, Dmitry On Aug 11, 2015, at 7:27 PM, build...@apache.org wrote: The Buildbot working for 'ASF Buildbot' has notic

Buildbot: buildslave cordova-windows-slave was lost

2015-08-12 Thread buildbot
The Buildbot working for 'ASF Buildbot' has noticed that the buildslave named cordova-windows-slave went away It last disconnected at Wed Aug 12 17:23:55 2015 (buildmaster-local time) The admin on record (as reported by BUILDSLAVE:info/admin) was 'Dmitry Blotsky '. Sincerely, The Buildbot htt

[GitHub] cordova-plugin-media pull request: Streaming & Background threadin...

2015-08-12 Thread nbazzeghin
Github user nbazzeghin commented on the pull request: https://github.com/apache/cordova-plugin-media/pull/62#issuecomment-130364027 Been testing this and the stop() method does not seem to work, I had to use pause() to get the audio to actually stop when streaming an mp3 file. --- I

Re: CORS for http://cordova-filetransfer.jitsu.com

2015-08-12 Thread Shazron
This might be why we're encountering https://issues.apache.org/jira/browse/CB-9483 To update you will have to PR to this repo and branch https://github.com/apache/cordova-labs/tree/cordova-filetransfer Then someone with access rights to the account (I do, plus others not sure whom) has to push the

[GitHub] cordova-plugin-splashscreen pull request: Implementing FadeSplashS...

2015-08-12 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/53#issuecomment-130359281 Other time values are given in msecs. You should be consistent. --- If your project is set up for it, you can reply to this email and have yo

[GitHub] cordova-plugin-camera pull request: CB-8054 Support taking picture...

2015-08-12 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/86#issuecomment-130357726 You can try this: https://msdn.microsoft.com/en-us/library/windows/apps/jj735579(v=vs.105).aspx To enable Fast Resume for your ap

Re: Record Audio using on Browser platform

2015-08-12 Thread Jesse
... Not currently. Pull requests are always welcome. > On Aug 11, 2015, at 7:27 PM, Shazron wrote: > > No. > > Media Capture plugin only supports Camera: > https://github.com/apache/cordova-plugin-media-capture/tree/master/src > Media plugin does not support browser: > https://github.com/ap

[GitHub] cordova-windows pull request: CB-9482: Modifies the deployment cod...

2015-08-12 Thread robpaveza
Github user robpaveza commented on the pull request: https://github.com/apache/cordova-windows/pull/112#issuecomment-130335077 There isn't a way to get a "proper" fix. The tool doesn't have a mechanism to query for the presence of a device (AppDeployCmd /EnumerateDevices always lists

[GitHub] cordova-lib pull request: Change cordova-lib to execute plugin hoo...

2015-08-12 Thread galexandrov
Github user galexandrov commented on the pull request: https://github.com/apache/cordova-lib/pull/236#issuecomment-130315580 ping @omefire --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

CORS for http://cordova-filetransfer.jitsu.com

2015-08-12 Thread Sergey Shakhnazarov (Akvelon)
Hi guys, I was testing mobilespec in hosted environment recently and encountered an issue with file-transfer plugin: org.apache.cordova.mobilespec.tests.localXHR.tests >> XMLHttpRequest XMLHttpRequest.spec.9 calls onload from successful http get Expected spy onError not to have been called. Thi

[GitHub] cordova-js pull request: CB-9342 Fix deviceReady event not fired o...

2015-08-12 Thread daserge
GitHub user daserge opened a pull request: https://github.com/apache/cordova-js/pull/125 CB-9342 Fix deviceReady event not fired on Windows 10 in hosted envir… …onment [Jira issue](https://issues.apache.org/jira/browse/CB-9342) You can merge this pull request into a Git

[GitHub] cordova-plugin-globalization pull request: CB-9336 Fix Globalizati...

2015-08-12 Thread daserge
Github user daserge closed the pull request at: https://github.com/apache/cordova-plugin-globalization/pull/38 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-dialogs pull request: set cancelable to false by de...

2015-08-12 Thread RomainFallet
GitHub user RomainFallet opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/56 set cancelable to false by default on Android To match with the iOS behavior where all modals cannot be canceled by a click outside of it (or a back button). First of all, th