[GitHub] cordova-plugin-file pull request: CB-9539 Fixed test failure on An...

2015-08-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/129 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[VOTE] 0.1.3 cordova-serve release

2015-08-24 Thread Tim Barham
Please review and vote on this 0.1.3 release of cordova-serve by replying to this email (and keep discussion on the DISCUSS thread). Release issue: https://issues.apache.org/jira/browse/CB-9547 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-9547

[GitHub] cordova-lib pull request: CB-9549 Removes excess JS files from bro...

2015-08-24 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/285#issuecomment-134201224 @stevengill, please review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-android pull request: CB-9496 removed permissions added fo...

2015-08-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/206 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-file pull request: CB-9539 Fixed test failure on An...

2015-08-24 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/129#issuecomment-134175958 Tested, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-lib pull request: Adds implementation for PlatformApiPoly ...

2015-08-24 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/282#issuecomment-134241500 Thanks for advice, Mark. I have some plans about tests update and definitely will try fixtures-based approach. --- If your project is set up for it, you

[GitHub] cordova-lib pull request: Adds implementation for PlatformApiPoly ...

2015-08-24 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/282#discussion_r37758129 --- Diff: cordova-lib/src/plugman/util/config-changes.js --- @@ -168,22 +167,18 @@ function remove_plugin_changes(plugin_name, plugin_id,

[GitHub] cordova-lib pull request: CB-9549 Removes excess JS files from bro...

2015-08-24 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-lib/pull/285#issuecomment-134289584 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: Issue in config.xml passing

2015-08-24 Thread Rob Paveza
Hi Abid, Your version value is in Smart Quotes, i.e., angle quotes, like you would get from writing code in Word or Outlook: id=com.sparteqz.ezone version=“1.3.1” Change those back in your text editor and you should be good. -Rob From: Abid Kh

Fwd: Issue in config.xml passing

2015-08-24 Thread Abid Kh
-- Forwarded message -- From: Abid Kh a...@sparteqz.com Date: Mon, Aug 24, 2015 at 11:05 AM Subject: Issue in config.xml passing To: issues-h...@cordova.apache.org, dev-h...@cordova.apache.org Sir, I need to update my apk in playstore. So i changed my version in config.xml as

Re: [DISCUSS] cordova-windows release

2015-08-24 Thread Rob Paveza
Bringing the cordova-windows release DISCUSS thread upwards. From: Rob Paveza rob.pav...@microsoft.com Sent: Tuesday, August 18, 2015 3:15 PM To: dev@cordova.apache.org Subject: RE: [DISCUSS] cordova-windows release Blog post for review / PR

RE: [DISCUSS] CORDOVA AND LIVERELOAD

2015-08-24 Thread Mefire O .
Thanks for the feedback, guys. As a result of your comments, I've done the following changes : - Pivoted towards a plugin-based architecture : https://github.com/omefire/cordova-plugin-livereload - The plugin is going to be activated only when the '--livereload' option is passed to the CLI. -

Re: Issue in config.xml passing

2015-08-24 Thread Tommy-Carlos Williams
Gah. Answered and didn't see you already had, Rob :) On 25 Aug 2015, at 02:29, Rob Paveza rob.pav...@microsoft.com wrote: Hi Abid, Your version value is in Smart Quotes, i.e., angle quotes, like you would get from writing code in Word or Outlook: id=com.sparteqz.ezone

[GitHub] cordova-docs pull request: Cordova website

2015-08-24 Thread bgashler1
GitHub user bgashler1 opened a pull request: https://github.com/apache/cordova-docs/pull/310 Cordova website You can merge this pull request into a Git repository by running: $ git pull https://github.com/bgashler1/cordova-docs cordova-website Alternatively you can review

Re: Issue in config.xml passing

2015-08-24 Thread Tommy-Carlos Williams
Just off the top of my head, are the quotes in the version attribute smart quotes like from a word processor, etc? id=com.sparteqz.ezone version=“1.3.1” They certainly appear to be in the config.xml included below... On 24 Aug 2015, at 15:50, Abid Kh a...@sparteqz.com wrote: widget

[GitHub] cordova-docs pull request: Cordova website

2015-08-24 Thread bgashler1
Github user bgashler1 closed the pull request at: https://github.com/apache/cordova-docs/pull/310 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-docs pull request: Cordova website

2015-08-24 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/310#issuecomment-134338974 Hey, sir. You may now close this pull request. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-plugin-statusbar pull request:

2015-08-24 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-statusbar/commit/07b55b752960e66ca4d0ba33b9c49d41b7241b43#commitcomment-12853928 And there is already an issue for that bug and has been fixed, but the last plugin release was in june,

[GitHub] cordova-plugin-file pull request: CB-9539 Fixed test failure on An...

2015-08-24 Thread alsorokin
Github user alsorokin commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/129#issuecomment-134160230 Added a comment with links to the JIRA issue and the discussion thread. Could someone review this please? --- If your project is set up for it, you can

[GitHub] cordova-lib pull request: CB-9549 Removes excess JS files from bro...

2015-08-24 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/285 CB-9549 Removes excess JS files from browserified app This PR fixes https://issues.apache.org/jira/browse/CB-9549 It also includes

[GitHub] cordova-osx pull request: replace __PROJECT_NAME__ also in config....

2015-08-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-osx/pull/15 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: CordovaPlugin lifecycle differs from Activity lifecycle

2015-08-24 Thread Shazron
Sorry not much of an Android expert -- but seeing as no one has replied -- is this a bug, since it appears to be not working as expected? If so, please file an issue at issues.cordova.io On Sun, Aug 23, 2015 at 1:35 PM, Kai Schlamp schl...@gmx.de wrote: The CordovaPlugin has the same onStart

[GitHub] cordova-osx pull request: CB-9541 Add preferences to put app into ...

2015-08-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-osx/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: Plugin local configuration (ios)

2015-08-24 Thread Shazron
Hi Tobias, You are correct it is not supported. I might be mistaken but I think the feature tag params are for the loading of the plugin themselves by the platform, and not for its configuration. We could support this scenario, it probably should go in a major release if adopted -- propose it,

[GitHub] cordova-plugman pull request: CB-7143 OSX platform cannot be insta...

2015-08-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugman/pull/86 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: WKWebView and iOS 9

2015-08-24 Thread Shazron
I like the two plugin idea. Using file:// would be the recommended and default, iOS 9 only -- and this should be wkwebview-engine Using the local webserver -- and this could be wkwebview-engine-local-webserver On Thu, Aug 20, 2015 at 2:42 PM, Carlos Santana csantan...@gmail.com wrote: What

Re: CordovaPlugin lifecycle differs from Activity lifecycle

2015-08-24 Thread Joe Bowser
Sorry, I was sick for a couple of days. That sounds like a bug. onStart and onResume should be called on the plugins, and this most likely got broken when the last refactor. Do you have an issue open in JIRA for this? On Sun, Aug 23, 2015 at 1:35 PM Kai Schlamp schl...@gmx.de wrote: The

[GitHub] cordova-docs pull request: Raghav/excerpts

2015-08-24 Thread rakatyal
GitHub user rakatyal opened a pull request: https://github.com/apache/cordova-docs/pull/311 Raghav/excerpts You can merge this pull request into a Git repository by running: $ git pull https://github.com/rakatyal/cordova-docs raghav/excerpts Alternatively you can review and

[GitHub] cordova-lib pull request: CB-9517 Adding a plugin on iOS/OSX that ...

2015-08-24 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-lib/pull/281#issuecomment-134374388 Fails the cordova-lib npm tests. jshint -- src/plugman/platforms/ios.js: line 107, col 34, Mixed double and single quotes. --- If your project is set up for

Re: CordovaPlugin lifecycle differs from Activity lifecycle

2015-08-24 Thread Joe Bowser
They used to be called on the Activity, but I think this was lost on a recent refactor and nobody reported it until now. This is odd, because a lot of things do rely on that code working, like garbage collection on plugins. I'd still file an issue to get more people to look at it. On Mon, Aug

Re: CordovaPlugin lifecycle differs from Activity lifecycle

2015-08-24 Thread Andrew Grieve
I noted this as weird as well, but it's just always been this way in Cordova. I think it came from the fact that on iOS you only get a resume after a pause. You can always use

Re: WKWebView and iOS 9

2015-08-24 Thread Carlos Santana
I like much better your naming suggestions for the plugins - Carlos Sent from my iPhone On Aug 24, 2015, at 4:17 PM, Shazron shaz...@gmail.com wrote: I like the two plugin idea. Using file:// would be the recommended and default, iOS 9 only -- and this should be wkwebview-engine Using

[GitHub] cordova-lib pull request: CB-9549 Removes excess JS files from bro...

2015-08-24 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-lib/pull/285#issuecomment-134417574 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-docs pull request: Raghav/excerpts

2015-08-24 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/311 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Raghav/excerpts

2015-08-24 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/311#issuecomment-134434877 Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-lib pull request: CB-9549 Removes excess JS files from bro...

2015-08-24 Thread stevengill
Github user stevengill commented on the pull request: https://github.com/apache/cordova-lib/pull/285#issuecomment-134412188 LGTM too --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this