[GitHub] cordova-docs pull request: CB-9387 Document Android Plugin Compati...

2015-08-27 Thread sgrebnov
GitHub user sgrebnov opened a pull request: https://github.com/apache/cordova-docs/pull/316 CB-9387 Document Android Plugin Compatibility Documents recommended approach for adding dependency libraries on Android to avoid conflicts. https://issues.apache.org/jira/browse/CB-9387

[GitHub] cordova-plugin-network-information pull request: Plugin returns ne...

2015-08-27 Thread VinuL
GitHub user VinuL opened a pull request: https://github.com/apache/cordova-plugin-network-information/pull/32 Plugin returns network = none over Ethernet on Android I tried to use Ethernet link to my Android tablet using this cable

[GitHub] cordova-docs pull request: Cordova website

2015-08-27 Thread bgashler1
GitHub user bgashler1 opened a pull request: https://github.com/apache/cordova-docs/pull/315 Cordova website Can you merge these commits in? They address various bugs and improve layout. Thanks, Brad You can merge this pull request into a Git repository by

Re: Cordova Face to Face meeting

2015-08-27 Thread Parashuram N
Let us make it Oct 14 and Oct 15. How about this being a rough agenda. I was not present at the Google Face-to-Face meeting, but we could use parts of that agenda too. Oct 14 Starts 10:30 (so that folks driving from Vancouver/Portland can get here in time) 10:30 - 11:00: Introductions 11:00 -

[GitHub] cordova-docs pull request: CB-9387 Document Android Plugin Compati...

2015-08-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/316 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-geolocation pull request: Added send location to ge...

2015-08-27 Thread nznelson
GitHub user nznelson opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/47 Added send location to geolocation plugin, so we can send current loc… …ation for each transaction You can merge this pull request into a Git repository by running: $

[GitHub] cordova-docs pull request: Cordova website plugin fixes

2015-08-27 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/317 Cordova website plugin fixes Added in some plugins content from cordova-registry-web (FAQ and contributors pages) and made various tweaks to the plugins page including: * Searchbar

Re: Cordova Face to Face meeting

2015-08-27 Thread Jesse
This sounds good. We may want to do a hangout for some of this, so those who cannot attend can still take part, and express opinions, maybe in the Finalize Agenda portion? Either that or we hire a film crew ... I am available to stay later on the 15th, so I am fine with whatever. My team is

RE: [DISCUSS] cordova-windows release

2015-08-27 Thread vldmrrr
Created CB-9565: Failure to build release package for Windows 10 project from CLI On 8/26/2015 8:53 PM, Nikhil Khandelwal wrote: +1 to filing a JIRA for this with repro steps. We should address this in the next release. Vldmrrr is there already a JIRA for this? -Nikhil -Original

[GitHub] cordova-lib pull request: CB-7827: Allow user to specify android a...

2015-08-27 Thread fredgalvao
Github user fredgalvao commented on the pull request: https://github.com/apache/cordova-lib/pull/171#issuecomment-13548 Shouldn't this be documented somewhere? It does not appear when I run `cordova help create` as a valid option. --- If your project is set up for it, you can

Re: file transfer test failures on Android

2015-08-27 Thread Ian Clelland
... and it's already committed. Never mind :) On Thu, Aug 27, 2015 at 2:28 PM, Ian Clelland iclell...@chromium.org wrote: I think Alexander is correct; it should be coalescing any combination of whitespace characters into a single space; otherwise we risk changing the semantics of the header

Re: file transfer test failures on Android

2015-08-27 Thread Ian Clelland
I think Alexander is correct; it should be coalescing any combination of whitespace characters into a single space; otherwise we risk changing the semantics of the header value. On Wed, Aug 26, 2015 at 5:43 PM, Joe Bowser bows...@gmail.com wrote: Actually, I'm OK with either. We should be

[GitHub] cordova-plugin-network-information pull request: Plugin returns ne...

2015-08-27 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-plugin-network-information/pull/32#discussion_r38140684 --- Diff: src/android/NetworkManager.java --- @@ -240,6 +241,9 @@ private String getType(NetworkInfo info) {

Re: WKWebView and iOS 9

2015-08-27 Thread Shazron
Awesome! Filed: https://issues.apache.org/jira/browse/CB-9566 https://issues.apache.org/jira/browse/CB-9567 Overall board: https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=76 On Wed, Aug 26, 2015 at 8:02 AM, Kerri Shotts kerrisho...@gmail.com wrote: No objections at all. :)

[GitHub] cordova-docs pull request: Cordova website plugin fixes

2015-08-27 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/317#issuecomment-135557576 Wow, GitHub is just not picking up my This closes messages. This is merged. --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-camera pull request: Retaining image ratio when res...

2015-08-27 Thread trubit
GitHub user trubit opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/118 Retaining image ratio when resizing According to documentation and iOS/Android behavior, resized images should retain ratio. This code fixes windows scaling. You can merge this pull

[GitHub] cordova-docs pull request: Platform icons in search results and mi...

2015-08-27 Thread riknoll
Github user riknoll closed the pull request at: https://github.com/apache/cordova-docs/pull/312 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Cordova website plugin fixes

2015-08-27 Thread riknoll
Github user riknoll closed the pull request at: https://github.com/apache/cordova-docs/pull/317 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

Re: [DISCUSS] cordova-windows release

2015-08-27 Thread Carlos Santana
Thanks ! - Carlos Sent from my iPhone On Aug 27, 2015, at 11:42 AM, vldmrrr vldm...@gmail.com wrote: Created CB-9565: Failure to build release package for Windows 10 project from CLI On 8/26/2015 8:53 PM, Nikhil Khandelwal wrote: +1 to filing a JIRA for this with repro steps. We should

[GitHub] cordova-lib pull request: CB-9560 Issue using plugin restore for p...

2015-08-27 Thread marcuspridham
Github user marcuspridham commented on the pull request: https://github.com/apache/cordova-lib/pull/288#issuecomment-135566988 Added comments. I'll try to put together a sample that shows the issue. The ones I am using are not available on NPM. --- If your project is set up for

[GitHub] cordova-plugin-globalization pull request: CB-9409 check that loca...

2015-08-27 Thread eymorale
Github user eymorale commented on the pull request: https://github.com/apache/cordova-plugin-globalization/pull/39#issuecomment-135553374 @shazron Your comparison makes more sense to me as well. I've updated the commit. Thanks! --- If your project is set up for it, you can reply to

[GitHub] cordova-plugin-geolocation pull request: Added send location to ge...

2015-08-27 Thread nznelson
Github user nznelson closed the pull request at: https://github.com/apache/cordova-plugin-geolocation/pull/47 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-lib pull request: CB-9560 Issue using plugin restore for p...

2015-08-27 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/288#issuecomment-135564467 Also, does this happen when you use the following two plugins : cordova-plugin-file and cordova-plugin-file-transfer ? Otherwise, could you please provide some

[GitHub] cordova-docs pull request: Translated docs version warning strings

2015-08-27 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/318 Translated docs version warning strings You can merge this pull request into a Git repository by running: $ git pull https://github.com/riknoll/cordova-docs cordova-website-translation

Re: [iOS] proposed major whitelist change

2015-08-27 Thread Shazron
Carlos - I'll add your notes to the JIRA issue below. Filed: https://issues.apache.org/jira/browse/CB-9568 Overall board: https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=76 On Wed, Aug 26, 2015 at 7:58 AM, Carlos Santana csantan...@gmail.com wrote: +1 But we need better

[GitHub] cordova-lib pull request: CB-9560 Issue using plugin restore for p...

2015-08-27 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/288#issuecomment-135557411 @marcuspridham, could you please add a comment like the one added for CB-9278 ? That way, we could signal other devs not to try and optimize this piece of code

Re: [DISCUSS] Docs release

2015-08-27 Thread Shazron
A bit hidden: https://github.com/apache/cordova-coho/blob/master/docs/platforms-release-process.md#update-the-docs svn checkout https://svn.apache.org/repos/asf/cordova/site cordova-website You can use coho to grab it also. I usually grab all the relevant repos with: `./cordova-coho/coho

[GitHub] cordova-lib pull request: CB-9560 Issue using plugin restore for p...

2015-08-27 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/288#issuecomment-135565178 Also, does this happen when you use the following two plugins : cordova-plugin-file and cordova-plugin-file-transfer ? Otherwise, could you please provide some

[GitHub] cordova-docs pull request: Translated docs version warning strings

2015-08-27 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/318#issuecomment-135567760 Merged. Feel free to delete the branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

Re: CordovaPlugin lifecycle differs from Activity lifecycle

2015-08-27 Thread Kai Schlamp
https://issues.apache.org/jira/browse/CB-9570 2015-08-25 3:04 GMT+02:00 Joe Bowser bows...@gmail.com: They used to be called on the Activity, but I think this was lost on a recent refactor and nobody reported it until now. This is odd, because a lot of things do rely on that code working,

[GitHub] cordova-docs pull request: Added zeroclipboard for all copy links

2015-08-27 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/319 Added zeroclipboard for all copy links Fixes copy links on the main page (getting started) and plugins page. Also adds the [ZeroClipboard](http://zeroclipboard.org/) library by Jon Rohan,

[GitHub] cordova-docs pull request: Cordova website

2015-08-27 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/315#issuecomment-135572809 Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-docs pull request: Updating blog readme, adding new blog p...

2015-08-27 Thread rakatyal
GitHub user rakatyal opened a pull request: https://github.com/apache/cordova-docs/pull/320 Updating blog readme, adding new blog posts and adding hyperlinks to … …blog post authors You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-docs pull request: Updating blog readme, adding new blog p...

2015-08-27 Thread rakatyal
Github user rakatyal commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/320#discussion_r38158338 --- Diff: README.md --- @@ -129,27 +129,22 @@ Ask for help on the IRC channel: #cordova on irc.freenode.net. Writing a Blog Post

[GitHub] cordova-docs pull request: Updating blog readme, adding new blog p...

2015-08-27 Thread dblotsky
Github user dblotsky commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/320#discussion_r38158172 --- Diff: README.md --- @@ -129,27 +129,22 @@ Ask for help on the IRC channel: #cordova on irc.freenode.net. Writing a Blog Post

Re: CordovaPlugin lifecycle differs from Activity lifecycle

2015-08-27 Thread Kai Schlamp
Wouldn't it make sense to have onCreate and onRestart also in CordovaPlugin? We could then interact on the full lifecyle of an activity without overwriting the MainActivity itself (I even don't know how I would do that). 2015-08-28 0:13 GMT+02:00 Kai Schlamp schl...@gmx.de:

[GitHub] cordova-docs pull request: Added zeroclipboard for all copy links

2015-08-27 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/319#issuecomment-135572796 Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-docs pull request: Translated docs version warning strings

2015-08-27 Thread riknoll
Github user riknoll closed the pull request at: https://github.com/apache/cordova-docs/pull/318 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-9559 Adding a plugin with caret in ve...

2015-08-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/291 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-osx pull request: @trivial remove patches and update docu

2015-08-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-osx/pull/20 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

Re: [DISCUSS] Local plugin configuration

2015-08-27 Thread Shazron
I think this is way overdue, good idea. I think preference tags can already be global to the plugin, and these are plugin variables -- so it will conflict: http://docs.phonegap.com/en/edge/guide_plugins_plugin_spec.md.html I think its safer to just add it under feature. All relevant platforms

[GitHub] cordova-lib pull request: CB-9559 Adding a plugin with caret in ve...

2015-08-27 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/291#issuecomment-135637692 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

Re: [DISCUSS] Tools Release?

2015-08-27 Thread Carlos Santana
+1 minor release bump not major - Carlos Sent from my iPhone On Aug 27, 2015, at 11:45 PM, Nikhil Khandelwal nikhi...@microsoft.com wrote: Also, there has been a browser release that we need to pin. -Nikhil -Original Message- From: Nikhil Khandelwal

RE: [DISCUSS] Tools Release?

2015-08-27 Thread Nikhil Khandelwal
Also, there has been a browser release that we need to pin. -Nikhil -Original Message- From: Nikhil Khandelwal [mailto:nikhi...@microsoft.com] Sent: Wednesday, August 26, 2015 6:21 PM To: dev@cordova.apache.org Subject: RE: [DISCUSS] Tools Release? +1. Not sure if it will be a patch

[GitHub] cordova-medic pull request: CB-8936 Windows logs gathering

2015-08-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-medic/pull/59 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request: CB-9559 Adding a plugin with caret in ve...

2015-08-27 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/291 CB-9559 Adding a plugin with caret in version results in an error When Cordova used `npm 1.3.x` internally, we had to process caret versions since `npm 1.3.x` didn't understand them. As part

Re: [DISCUSS] Tools Release?

2015-08-27 Thread Steven Gill
It is interesting. Adding a new platform could be consideration for a major or minor. The platform (OSX) is having a major jump. According to semver, a major would be making a incompatible api change and a minor would be adding functionality in a backwards-compatible manner. We don't break

[GitHub] cordova-plugin-file-transfer pull request: CB-9562 Fixed incorrect...

2015-08-27 Thread alsorokin
Github user alsorokin closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/99 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-android pull request: CB-9557 Fixes apk install failure wh...

2015-08-27 Thread vladimir-kotikov
Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/209#discussion_r38066504 --- Diff: bin/templates/cordova/lib/device.js --- @@ -96,10 +96,15 @@ module.exports.install = function(target, buildResults) {

[GitHub] cordova-lib pull request: CB-7015 Add support for parent and custo...

2015-08-27 Thread mbektchiev
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-lib/pull/290 CB-7015 Add support for parent and custom attributes in lib-file element This enables referring to libraries from the Android SDK directory. Refs

[GitHub] cordova-docs pull request: CB-7015 Support copying a lib-file from...

2015-08-27 Thread mbektchiev
GitHub user mbektchiev opened a pull request: https://github.com/apache/cordova-docs/pull/314 CB-7015 Support copying a lib-file from the SDK directory Documents the behavior introduced with: https://github.com/apache/cordova-lib/pull/290 You can merge this pull request into

[GitHub] cordova-plugin-camera pull request: Manual dismissal method for iO...

2015-08-27 Thread jcesarmobile
Github user jcesarmobile commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/117#issuecomment-135329615 I think, everything you put after [self.pickerController dismissViewControllerAnimated:NO completion:nil]; should be on the completion block

[GitHub] cordova-docs pull request: Added zeroclipboard for all copy links

2015-08-27 Thread riknoll
Github user riknoll closed the pull request at: https://github.com/apache/cordova-docs/pull/319 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Gulp now correctly serves the productio...

2015-08-27 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/321 Gulp now correctly serves the production build You can merge this pull request into a Git repository by running: $ git pull https://github.com/riknoll/cordova-docs cordova-website

[GitHub] cordova-osx pull request: @trivial remove patches and update docu

2015-08-27 Thread tripodsan
GitHub user tripodsan opened a pull request: https://github.com/apache/cordova-osx/pull/20 @trivial remove patches and update docu You can merge this pull request into a Git repository by running: $ git pull https://github.com/tripodsan/cordova-osx minor_changes