RE: [VOTE] 3.8.0 BlackBerry Release

2015-09-01 Thread Tim Windsor
Sorry, I thought I was already to vote for release but I found an issue when updating projects. Pull request is in for the fix: https://github.com/apache/cordova-blackberry/pull/191 Otherwise the RC seems good. Tested mobile spec on 3.7.0 and RC, new project creation, platform add of RC, and

[GitHub] cordova-docs pull request: Cordova website plugin improvements

2015-09-01 Thread riknoll
Github user riknoll closed the pull request at: https://github.com/apache/cordova-docs/pull/325 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Cordova website plugin improvements

2015-09-01 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/325#issuecomment-136824707 Merged. Feel free to delete. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-blackberry pull request: CB-7807 Adds init_reqs files to U...

2015-09-01 Thread timwindsor
GitHub user timwindsor opened a pull request: https://github.com/apache/cordova-blackberry/pull/191 CB-7807 Adds init_reqs files to Update script This was missed in CB-7807 and causes an issue on platform update if not included You can merge this pull request into a Git repository

Re: Update: Plugins Registry warnings

2015-09-01 Thread Steven Gill
Good call. No redirection yet. Last tools change in regards to CPR was making it so npm gets hit first and then plugins registry. I will add the redirection in the next few days (after vlad's merge). Created an issue: https://issues.apache.org/jira/browse/CB-9589 On Mon, Aug 31, 2015 at 6:29

[GitHub] cordova-lib pull request: CB-9590 - Ubuntu support for the new plu...

2015-09-01 Thread david-barth-canonical
GitHub user david-barth-canonical opened a pull request: https://github.com/apache/cordova-lib/pull/294 CB-9590 - Ubuntu support for the new plugin naming convention This patch allows ubuntu users to add plugins using the new naming convention and build properly. This also leaves

[GitHub] cordova-plugin-vibration pull request: [CB-7966] Add cordova-plugi...

2015-09-01 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-vibration/pull/37#issuecomment-136822984 This is not a proxy, this is a clobbers. You can remove your call to add the proxy and I would rename the file to just be vibration.js

Re: Merges as a feature

2015-09-01 Thread Raymond Camden
That's not what I'm asking though. What I'm asking is - as a "Feature" (capital F ;) of Cordova, is it something that is going away? On Tue, Sep 1, 2015 at 11:07 AM, Carlos Santana wrote: > For mfp cordova it's not needed, there are modern ways of achieving this. > > In

Re: [DISCUSS] Tools Release?

2015-09-01 Thread Steven Gill
I'm going to wait until blackberry gets released before releasing tools. Just leave it behind RC for a few more days because I pinned blackberry to the new version which is being voted on so we wouldn't have to pump out another vote just for it. -Steve On Mon, Aug 31, 2015 at 4:46 PM, Tim Barham

Re: [VOTE] 3.8.0 BlackBerry Release

2015-09-01 Thread Bryan Higgins
Thanks Tim. I'll merge that PR and get a new RC ready. Vote is cancelled. On Tue, Sep 1, 2015 at 1:09 PM, Tim Windsor wrote: > Sorry, I thought I was already to vote for release but I found an issue > when updating projects. > > Pull request is in for the fix: >

[GitHub] cordova-android pull request: CB-9557 Fixes apk install failure wh...

2015-09-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/209 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-js pull request: CB-9370 Switches to another jsdom depende...

2015-09-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/127 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-docs pull request: Website old content removal and layout ...

2015-09-01 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/326 Website old content removal and layout fixes Fixes: * Tooltips now work in plugins results * Plugin results copy icon no longer becomes un-clickable in narrow windows Removes:

[GitHub] cordova-docs pull request: Adding linting, link verifier and slack...

2015-09-01 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/323#issuecomment-136913243 Merged! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-docs pull request: Website old content removal and layout ...

2015-09-01 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/326#issuecomment-136915468 Merged! Feel free to close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

Re: Merges as a feature

2015-09-01 Thread Carlos Santana
In my personal opinion it's not a best practice anymore to use merges. The feature works today if you create a folder "merges" cordova create doesn't create it by default It will not go away, visual studio leverages the "merges" folder in their cordova templates. It will not be remove or

Re: Merges as a feature

2015-09-01 Thread Carlos Santana
Ok I agree for simple use case is very simple to drop files in merges. Which is the use case for visual studio template. Just curious on why an open ended question? It will be the same as me asking "Is hooks as a Feature going away?" With not other context. What prompted you to ask a the

[GitHub] cordova-plugin-media-capture pull request: CB-9249 Fix iOS warning...

2015-09-01 Thread macdonst
GitHub user macdonst opened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/41 CB-9249 Fix iOS warnings in Media Capture plugin Needs a code review. This removes the compiler warnings in Xcode. You can merge this pull request into a Git

[DISCUSS] cordova-ios 4.0.0 release

2015-09-01 Thread Shazron
Gotta get the train going again, it's been too long. The kanban board for this is at: https://issues.apache.org/jira/secure/RapidBoard.jspa?rapidView=76 Please help if you can by assigning an issue to yourself, and selecting the "Start Progress" button. This will show who is working on what in

[GitHub] cordova-plugin-network-information pull request: Plugin returns ne...

2015-09-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-network-information/pull/32 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-registry pull request: Revert "Revert "made registry read-...

2015-09-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-registry/pull/1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: [DISCUSS] Local plugin configuration

2015-09-01 Thread Shazron
> > > So what I'm missing from the plugin spec is the possibility to > describe what preferences are available/required for the plugin to > work. > > It being under would imply this but I think you are asking about the way currently things are. Yeah right now if preference is not added under the

Re: Merges as a feature

2015-09-01 Thread Jesse
I would like to get rid of merges, now that you bring it up. We have far too many nuanced features that just sort of go undoc'd. I may change my mind if someone can point me at a page in the docs that explains the full use and value of this feature because currently it just sounds like technical

Re: Merges as a feature

2015-09-01 Thread Carlos Santana
TACO? I'm hungry now :-p - Carlos Sent from my iPhone > On Sep 1, 2015, at 6:18 PM, Jesse wrote: > > Well finding it in the docs is/was. > This functionality is depended on by Visual Studio TACO so I don't think it > is going anywhere soon. > > > > > My team is

Re: Merges as a feature

2015-09-01 Thread Raymond Camden
Oh sorry - well - I brought it up in an issue report for Ionic. They've got a few different ways of handling this, and I thought it might make sense to mention the Cordova Merges feature too. I was asked if it was possibly going away, hence me asking the Powers that Be here. (Wait, I think I'm one

Re: Merges as a feature

2015-09-01 Thread Jesse
Well finding it in the docs is/was. This functionality is depended on by Visual Studio TACO so I don't think it is going anywhere soon. My team is hiring! @purplecabbage risingj.com On Tue, Sep 1, 2015 at 3:03 PM, Raymond Camden wrote: > Yeah I don't think

Re: Merges as a feature

2015-09-01 Thread Raymond Camden
K good enough for me. I don't agree with you. ;) On Tue, Sep 1, 2015 at 3:25 PM, Carlos Santana wrote: > In my personal opinion it's not a best practice anymore to use merges. > > The feature works today if you create a folder "merges" > > cordova create doesn't create it

Re: Merges as a feature

2015-09-01 Thread Carlos Santana
Merges doc is here: https://cordova.apache.org/docs/en/edge/guide_cli_index.md.html#The%20Command-Line%20Interface_using_merges_to_customize_each_platform - Carlos Sent from my iPhone > On Sep 1, 2015, at 5:53 PM, Jesse wrote: > > I would like to get rid of merges,

Re: Merges as a feature

2015-09-01 Thread Raymond Camden
Yeah I don't think documentation is a problem. :) On Tue, Sep 1, 2015 at 4:58 PM, Carlos Santana wrote: > Merges doc is here: > https://cordova.apache.org/docs/en/edge/guide_cli_index.md.html#The%20Command-Line%20Interface_using_merges_to_customize_each_platform > > > -

Re: Merges as a feature

2015-09-01 Thread Carlos Santana
If people wants achieve to do what merges do, I recommend hooks or custom build process (i.e. npm scripts, gulp, grunt, ant, perl, ruby, etc) or running custom build from hooks. There is more flexibility and control thru hooks than merges. - Carlos Sent from my iPhone > On Sep 1, 2015, at

Re: Merges as a feature

2015-09-01 Thread Raymond Camden
Ok, so now we're off my initial question and into a debate. :) I think you are absolutely right - there are more powerful solutions - but that doesn't negate the ease of use of merges. The simplicity of it may be just fine for many use cases. On Tue, Sep 1, 2015 at 4:10 PM, Carlos Santana

Re: Merges as a feature

2015-09-01 Thread Carlos Santana
You have the power - Carlos Sent from my iPhone > On Sep 1, 2015, at 5:38 PM, Raymond Camden wrote: > > Oh sorry - well - I brought it up in an issue report for Ionic. > They've got a few different ways of handling this, and I thought it > might make sense to

RE: [Vote] Tools Release Aug 28th

2015-09-01 Thread Sergey Grebnov (Akvelon)
I vote +1: * Installed cordova@rc on OSX * Created, built and run blank app on ios -Sergey Grebnov -Original Message- From: Tim Barham [mailto:tim.bar...@microsoft.com] Sent: Tuesday, September 1, 2015 4:35 AM To: dev@cordova.apache.org Subject: RE: [Vote] Tools Release Aug 28th +1 *

[GitHub] cordova-plugin-vibration pull request: [CB-7966] Add cordova-plugi...

2015-09-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-vibration/pull/37 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-wp8 pull request: Added the XHR upload attribute

2015-09-01 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-wp8/pull/84#issuecomment-136737313 Merging anyway. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...

2015-09-01 Thread m1r4ge
Github user m1r4ge commented on the pull request: https://github.com/apache/cordova-lib/pull/256#issuecomment-136740512 Closed. Thank you Vladimir. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...

2015-09-01 Thread m1r4ge
Github user m1r4ge closed the pull request at: https://github.com/apache/cordova-lib/pull/256 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-wp8 pull request: Added the XHR upload attribute

2015-09-01 Thread SunboX
Github user SunboX closed the pull request at: https://github.com/apache/cordova-wp8/pull/84 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

RE: Cordova-lib refactoring implementation

2015-09-01 Thread Vladimir Kotikov (Akvelon)
FYI, I'm going to merge this in next 12 hours. Best regards, Vladimir. -Original Message- From: Vladimir Kotikov (Akvelon) [mailto:v-vlk...@microsoft.com] Sent: Wednesday, August 26, 2015 6:27 PM To: dev@cordova.apache.org Subject: RE: Cordova-lib refactoring implementation Jesse

Re: Marshmallow Update and Cordova-Android 5.0

2015-09-01 Thread Carlos Santana
Joe I understand the feeling. One part of me saying that we should name the version 4.2 since there are no API changes. But my other part says that if developer's ignore because is 4.x stuff will break in new major release of Android M (23) I would say that also agree that best option is to name

[GitHub] cordova-wp8 pull request: Added the XHR upload attribute

2015-09-01 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-wp8/pull/84#issuecomment-136738214 @SunboX, this was merged in https://git1-us-west.apache.org/repos/asf?p=cordova-wp8.git;a=commit;h=81a8d3e17c9d879c92d3349bd7166557d14e5bf9. Please close

[GitHub] cordova-lib pull request: CB-9354 Fix array merging with complex i...

2015-09-01 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/256#issuecomment-136734142 his was merged in https://github.com/apache/cordova-lib/commit/b0c196510aa73b3ef0752c78f06e2a99afe04a95. @m1r4ge, could you please close this PR. --- If

Re: Merges as a feature

2015-09-01 Thread Carlos Santana
For mfp cordova it's not needed, there are modern ways of achieving this. In cordova you can use hooks and merges More advance users can use their build tooling like grunt, gulp, etc. - Carlos Sent from my iPhone > On Sep 1, 2015, at 11:54 AM, Raymond Camden wrote:

[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...

2015-09-01 Thread omefire
Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/292#issuecomment-136774986 Awesome, Thanks for validating. The case where we specify a searchpath on the CLI and another one in the ./cordova/config.json doesn't go through. I will open

Re: Cordova-lib refactoring implementation

2015-09-01 Thread Jesse
Yes. I am done. Looks good! > On Sep 1, 2015, at 6:06 AM, Vladimir Kotikov (Akvelon) > wrote: > > FYI, I'm going to merge this in next 12 hours. > > Best regards, Vladimir. > > -Original Message- > From: Vladimir Kotikov (Akvelon)

Merges as a feature

2015-09-01 Thread Raymond Camden
Just a quick question - is merges as a feature going away? I haven't seen anything about that here, but just checking. -- === Raymond Camden, Developer Advocate for MobileFirst at IBM Email : raymondcam...@gmail.com Blog :

[GitHub] cordova-lib pull request: CB-9587 Check if browser platform added ...

2015-09-01 Thread vladimir-kotikov
GitHub user vladimir-kotikov opened a pull request: https://github.com/apache/cordova-lib/pull/293 CB-9587 Check if browser platform added properly before creating parser This fixes weird error when trying to run app on browser platform but the platform isn't added to project. See