[GitHub] cordova-lib pull request: CB-9604 Fix error adding browser platfor...

2015-09-02 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/pull/295#issuecomment-137353546 Looks good. However there is another chance to access `this._config` before it will be initialized: https://github.com/MSOpenTech/cordova-lib/blob/CB-9604/

Re: [DISCUSS] cordova-ios 4.0.0 release

2015-09-02 Thread Carlos Santana
+1 Choo Choo ... I reviewed all links in your proposal and they look and don't have concerns IBM MobileFirst was affected only by the API change of using webviewengine now but that's so far the only major change In the kaban board for 4.0 there are some issues I consider nice to have that are no

[GitHub] cordova-coho pull request: CB-9585 Support globs with 'coho verify...

2015-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-coho/pull/93 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-lib pull request: CB-9604 Fix error adding browser platfor...

2015-09-02 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/295#issuecomment-137297111 @vladimir-kotikov - does this fix look right to you? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] cordova-lib pull request: CB-9604 Fix error adding browser platfor...

2015-09-02 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-lib/pull/295 CB-9604 Fix error adding browser platform with PlatformApi polyfill. Don't try to create `ConfigParser()` in `PlatformApiPoly` constructor, since we may not have copied the `config.xml` file

[GitHub] cordova-docs pull request: Fixed autoscrolling code breaking on no...

2015-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/327 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-plugin-contacts pull request: CB-9579 Fixed failed tests w...

2015-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/74 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request:

2015-09-02 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/commit/07271a5c6162c0b2bee55e1ea23f91ebdfbbb34c#commitcomment-13037479 Hey Vlad - with this change in I get the following error trying to add the `browser` platform to a project: ```

[GitHub] cordova-lib pull request: CB-9587 Check if browser platform added ...

2015-09-02 Thread TimBarham
Github user TimBarham commented on the pull request: https://github.com/apache/cordova-lib/pull/293#issuecomment-137282883 Seems reasonable. One minor concern... The check for the `cordova` directory doesn't really validate that this is a `browser` platform directory. Not sure of what

[GitHub] cordova-docs pull request: CB-9603 Document iOS config.xml prefere...

2015-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/328 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: CB-9603 Document iOS config.xml prefere...

2015-09-02 Thread purplecabbage
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-docs/pull/328 CB-9603 Document iOS config.xml preferences added in CB-7118 iOS preferences are `deployment-target` and `target-device` You can merge this pull request into a Git repository by running:

[GitHub] cordova-docs pull request: Fixed autoscrolling code breaking on no...

2015-09-02 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/327 Fixed autoscrolling code breaking on non-heading links Fixes an exception thrown on plugins page by the auto-scrolling code when an item is selected in the sort dropdown You can merge this pu

Re: Embedding Android activity into WebView, is it possible?

2015-09-02 Thread julio cesar sanchez
Doing a quick search on Google, it isn't possible to put a native view inside a webview, just over it so it might seem that it's inside, but it's not El 2/9/2015 23:11, "Jan Velecký" escribió: > Hello > is it possible embedding Android native view inside webview? Actually we > are > able to embed

Re: [DISCUSS] Tools Release?

2015-09-02 Thread Bryan Higgins
BB vote thread is up. I will need a couple more PMC members to chime in. Thanks, Bryan On Tue, Sep 1, 2015 at 3:55 PM, Steven Gill wrote: > I'm going to wait until blackberry gets released before releasing tools. > Just leave it behind RC for a few more days because I pinned blackberry to > the

RE: [VOTE] 3.8.0 BlackBerry Release (take 2)

2015-09-02 Thread Tim Windsor
+1 (non-PMC member) Tested: - new project creation, platform add and build to device. - webworks-cli (3.6.0) new project creation, update to 3.8.0 and deploy to device - new cordova project, add blackberry10 3.7.0 platfrom, update to 3.8.0 and deploy to device - build and run mobile-spec app Ti

[VOTE] 3.8.0 BlackBerry Release (take 2)

2015-09-02 Thread Bryan Higgins
Please review and vote on this 3.8.0 BlackBerry Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-9576 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-9576 The packag

[GitHub] cordova-plugin-media-capture pull request: CB-9249 Fix iOS warning...

2015-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/42 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

Embedding Android activity into WebView, is it possible?

2015-09-02 Thread Jan Velecký
Hello is it possible embedding Android native view inside webview? Actually we are able to embed webview inside native view, but we are not able to do inverse thing. Is there some way to do plugin, that we could instance in /< embed> tag inside webview? It would be great if we can do so – imagine

[GitHub] cordova-ios pull request: Prevent Compilation Warning : Conflictin...

2015-09-02 Thread fatty1380
GitHub user fatty1380 opened a pull request: https://github.com/apache/cordova-ios/pull/157 Prevent Compilation Warning : Conflicting Return Type The `supportedInterfaceOrientationsForWindow` method currently returns a value of type `NSUInteger`. This causes a warning in the Xcode c

[GitHub] cordova-plugin-geolocation pull request: Prevent API Deprecation W...

2015-09-02 Thread fatty1380
GitHub user fatty1380 opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/48 Prevent API Deprecation Warnings thru pre-processor macros I've wrapped the call to `locationServicesEnabled` which is causing a Deprecation warning under compilation, in a `#if

[GitHub] cordova-plugin-media-capture pull request: CB-9249 Fix iOS warning...

2015-09-02 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/42#issuecomment-137237823 :+1: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

Re: [DISCUSS] cordova-ios 4.0.0 release

2015-09-02 Thread Shazron
Thanks Julio - since I'm going to communicate to the general public that they test now, I think any API changes should wait for 5.x. On Wed, Sep 2, 2015 at 8:30 AM, julio cesar sanchez wrote: > Right now I'm on vacation and I think at least one of the issues is > assigned to me, so if anyone wa

Re: [Discuss] BlackBerry Release

2015-09-02 Thread Steven Gill
Let's get this out asap. Waiting on BB to get last tools release out On Aug 31, 2015 4:02 PM, "Bryan Higgins" wrote: > I'm on it :) > > On Mon, Aug 31, 2015 at 7:00 PM, Steven Gill > wrote: > > > Lets get this vote thread started! > > > > On Mon, Aug 31, 2015 at 1:06 PM, Tim Windsor > > wrote:

Re: [DISCUSS] cordova-ios 4.0.0 release

2015-09-02 Thread Shazron
I'm writing up a blog post for the general public, and adding guidance on how to fix some issues with the API changes (migration). I did something some time ago where I tested all of the iOS plugins on CPR using a script, and during that time they all passed, but it was time consuming testing 400+

[GitHub] cordova-lib pull request: CB-9559 Adding a plugin with caret in ve...

2015-09-02 Thread macdonst
Github user macdonst commented on the pull request: https://github.com/apache/cordova-lib/pull/291#issuecomment-137230594 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabl

[GitHub] cordova-blackberry pull request: Adds init_reqs files to Update sc...

2015-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-blackberry/pull/192 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] cordova-blackberry pull request: CB-7807 Adds init_reqs files to U...

2015-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-blackberry/pull/191 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fea

[GitHub] cordova-plugin-media-capture pull request: CB-9249 Fix iOS warning...

2015-09-02 Thread macdonst
GitHub user macdonst opened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/42 CB-9249 Fix iOS warnings in Media Capture plugin Part 2 Apparently this is a trivial change but I'd like someone to look it over. This is where I got the fix:

[GitHub] cordova-ios pull request: * is a Right-to-left associative operato...

2015-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/145 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-docs pull request: Adding linting, link verifier and slack...

2015-09-02 Thread rakatyal
Github user rakatyal closed the pull request at: https://github.com/apache/cordova-docs/pull/323 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-blackberry pull request: Adds init_reqs files to Update sc...

2015-09-02 Thread timwindsor
GitHub user timwindsor opened a pull request: https://github.com/apache/cordova-blackberry/pull/192 Adds init_reqs files to Update script You can merge this pull request into a Git repository by running: $ git pull https://github.com/timwindsor/cordova-blackberry 3.8.x Altern

[GitHub] cordova-docs pull request: Website old content removal and layout ...

2015-09-02 Thread riknoll
Github user riknoll closed the pull request at: https://github.com/apache/cordova-docs/pull/326 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

RE: [DISCUSS] cordova-ios 4.0.0 release

2015-09-02 Thread julio cesar sanchez
Right now I'm on vacation and I think at least one of the issues is assigned to me, so if anyone want to take it feel free. I'll be back on Sunday I have some other issues with pull requests ready to be reviewed, but they aren't on the list, so they can wait, but in one of them (the one about aler

[GitHub] cordova-plugin-splashscreen pull request: Don't rotate the iPhone ...

2015-09-02 Thread caseywebdev
GitHub user caseywebdev opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/59 Don't rotate the iPhone 6 Plus splash The iPhone 6 Plus splash screen is already in landscape mode, so it should also be excluded from rotation like the iPad is. You can mer

[GitHub] cordova-plugin-media-capture pull request: CB-9249 Fix iOS warning...

2015-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/41 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or i

[GitHub] cordova-wp8 pull request: Move AutoLoadCommand execution in Framew...

2015-09-02 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-wp8/pull/87#issuecomment-137091123 The plugins should be called for every page load, so while this is great the first time we break functionality in multi page apps. I also worry that some p

Re: Merges as a feature

2015-09-02 Thread Raymond Camden
On Wed, Sep 2, 2015 at 7:33 AM, Nikhil Khandelwal wrote: > I sort of agree with Raymond that is a useful functionality and is easy > enough to do this for users - by using a 'convention'. Customizing the build > system using hooks sounds more complicated for the developer. How does ionic > & mf

RE: [DISCUSS] Local plugin configuration

2015-09-02 Thread Nikhil Khandelwal
I like this design (we should have had this in the first place) - but am concerned of the breaking nature. Do we have a specific case of a name conflict that we know of? Another way to do this would be to use naming conventions - similar to a namespace. The recommendation would be to prefix the

RE: [DISCUSS] cordova-ios 4.0.0 release

2015-09-02 Thread Nikhil Khandelwal
This is great level of detail. Since there are plugin API changes - it would be great to make a broader post - on slack, twitter, our blog. Do we have a sense of how impactful are the breaking changes - say how many of the top 50 plugins will not compile when ios 4.0 releases? If not, I can hel

RE: Merges as a feature

2015-09-02 Thread Nikhil Khandelwal
I sort of agree with Raymond that is a useful functionality and is easy enough to do this for users - by using a 'convention'. Customizing the build system using hooks sounds more complicated for the developer. How does ionic & mfp actually achieve this? How does a developer specify specific ver

[GitHub] cordova-windows pull request: CB-8936 Introduced --dump arg in log...

2015-09-02 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-windows/pull/119 CB-8936 Introduced --dump arg in log script https://issues.apache.org/jira/browse/CB-8936 You can merge this pull request into a Git repository by running: $ git pull https://github.

[GitHub] cordova-lib pull request: Add platform project instance in hook op...

2015-09-02 Thread galexandrov
Github user galexandrov commented on the pull request: https://github.com/apache/cordova-lib/pull/271#issuecomment-137046802 ping @omefire --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-lib pull request: CB-9597 Adds implementation for Platform...

2015-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/282 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-cli pull request: CB-9597 Updates cli to pass arguments pr...

2015-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/220 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-plugin-contacts pull request: CB-9579 Fixed failed tests w...

2015-09-02 Thread alsorokin
Github user alsorokin commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/74#issuecomment-137027772 Yes, I've tested and verified that with one or more existing "DeleteMe" account.tests still pass. --- If your project is set up for it, you can reply

[GitHub] cordova-wp8 pull request: Move AutoLoadCommand execution in Framew...

2015-09-02 Thread galexandrov
Github user galexandrov commented on the pull request: https://github.com/apache/cordova-wp8/pull/87#issuecomment-136988297 ping @purplecabbage --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-statusbar pull request: [CB-7965] Add cordova-plugi...

2015-09-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-statusbar/pull/31 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th