[GitHub] cordova-ios pull request: Prevent Compilation Warning : Conflictin...

Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/157#issuecomment-137696927 Hi can you add a prefix of "CB-9610" to the title to enable Apache's JIRA issue tracker auto-magic linking? https://issues.apache.org/jira/browse/CB-9610 ---

[GitHub] cordova-plugin-vibration pull request: CB-9365 Add support for 'vi...

Github user daserge commented on the pull request: https://github.com/apache/cordova-plugin-vibration/pull/38#issuecomment-137694325 @nikhilkh, @robpaveza thanks for review! Please take a look once more - I have addressed your comments. --- If your project is set up for it, you

[GitHub] cordova-docs pull request: Added Monaca and Onsen logo and descrip...

GitHub user masahirotanaka opened a pull request: https://github.com/apache/cordova-docs/pull/332 Added Monaca and Onsen logo and description. Hi. I added some descriptions for the new Cordova Website. Thanks! You can merge this pull request into a Git repository by running: $

[GitHub] cordova-plugin-media pull request: CB-9606 Fixes arguments parsing...

Github user vladimir-kotikov closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/65 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-windows pull request: CB-8936 Introduced --dump arg in log...

Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/119#discussion_r38773249 --- Diff: template/cordova/lib/log.js --- @@ -30,33 +30,87 @@ var platformRoot = path.join(__dirname, '..', '..'), configPath =

Plugin docs generation

Hi guys, Please review a proposal on plugin documentation generation: https://github.com/cordova/cordova-discuss/issues/15 Best regards, Sergey Shakhnazarov

[GitHub] cordova-plugin-dialogs pull request: On iOS8+ allow this dialog to...

GitHub user kurtisf opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/57 On iOS8+ allow this dialog to be presented from alternate web views. - On iOS8+ allow this dialog to be presented from alternate web views such as the Cordova InAppBrowser. Finds

[GitHub] cordova-plugin-dialogs pull request: On iOS8+ allow this dialog to...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/57#issuecomment-137843882 No. InAppBrowser should not be able to call cordova native functions. --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-ios pull request: CB-9558 Blob schemes won't load in ifram...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/156 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-ios pull request: CB-8772 ios bin scripts are nonexecutabl...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/158 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-ios pull request: CB-9512 Cordova-ios build/run should fai...

Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-ios/pull/154#issuecomment-137843411 I have essentially done the same thing in #158, but for build/log/run/clean --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-dialogs pull request: On iOS8+ allow this dialog to...

Github user kurtisf commented on the pull request: https://github.com/apache/cordova-plugin-dialogs/pull/57#issuecomment-137844576 The use case is the app receives and event, such as a push notification while the InAppBrowser is presented. If you use this plugin

[GitHub] cordova-ios pull request: CB-9512 Cordova-ios build/run should fai...

Github user daserge closed the pull request at: https://github.com/apache/cordova-ios/pull/154 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-whitelist pull request: remove alert msg in console...

GitHub user cleiton-tavares opened a pull request: https://github.com/apache/cordova-plugin-whitelist/pull/10 remove alert msg in console for develop app You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...

Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/292#issuecomment-137912540 CB-9560 is merged as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] cordova-lib pull request: CB-9560 Issue using plugin restore for p...

Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/288#issuecomment-137900148 Merged ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-lib pull request: CB-9560 Issue using plugin restore for p...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/288 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-plugin-whitelist pull request: remove alert msg in console...

Github user cleiton-tavares closed the pull request at: https://github.com/apache/cordova-plugin-whitelist/pull/10 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...

Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/292#issuecomment-137877915 @marcuspridham , did you sign the [ICLA](http://www.apache.org/licenses/#clas) ? --- If your project is set up for it, you can reply to this email and have your

Re: [GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...

Confirmed here: https://people.apache.org/committer-index.html Middle name and all ... My team is hiring! @purplecabbage risingj.com On Fri, Sep 4, 2015 at 4:36 PM, marcuspridham wrote: > Github user marcuspridham commented on the pull request: > >

[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...

Github user marcuspridham commented on the pull request: https://github.com/apache/cordova-lib/pull/292#issuecomment-137878645 Yep. I signed the ICLA awhile ago. I have done some pull requests to Cordova before. --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...

Github user marcuspridham commented on the pull request: https://github.com/apache/cordova-lib/pull/292#issuecomment-137896650 Thanks! Please look at merging CB-9560 when you time. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...

Github user marcuspridham closed the pull request at: https://github.com/apache/cordova-lib/pull/292 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-lib pull request: CB-8993 Plugin restore ignores search pa...

Github user omefire commented on the pull request: https://github.com/apache/cordova-lib/pull/292#issuecomment-137895107 #merged ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-windows pull request: CB-8936 Introduced --dump arg in log...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/119#discussion_r38726887 --- Diff: template/cordova/lib/log.js --- @@ -30,33 +30,87 @@ var platformRoot = path.join(__dirname, '..', '..'), configPath =

[GitHub] cordova-windows pull request: CB-8936 Introduced --dump arg in log...

Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/119#discussion_r38726303 --- Diff: template/cordova/lib/log.js --- @@ -30,33 +30,87 @@ var platformRoot = path.join(__dirname, '..', '..'), configPath =

[GitHub] cordova-windows pull request: CB-8936 Introduced --dump arg in log...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/119#discussion_r38726309 --- Diff: template/cordova/lib/log.js --- @@ -30,33 +30,87 @@ var platformRoot = path.join(__dirname, '..', '..'), configPath =

[GitHub] cordova-plugin-vibration pull request: CB-9365 Add support for 'vi...

Github user daserge commented on a diff in the pull request: https://github.com/apache/cordova-plugin-vibration/pull/38#discussion_r38724321 --- Diff: src/windows/VibrationProxy.js --- @@ -60,12 +61,43 @@ if (VibrationDevice) { fail(e); }

[GitHub] cordova-windows pull request: CB-8936 Introduced --dump arg in log...

Github user vladimir-kotikov commented on a diff in the pull request: https://github.com/apache/cordova-windows/pull/119#discussion_r38726108 --- Diff: template/cordova/lib/log.js --- @@ -30,33 +30,87 @@ var platformRoot = path.join(__dirname, '..', '..'), configPath =

[GitHub] cordova-lib pull request:

Github user zalun commented on the pull request: https://github.com/apache/cordova-lib/commit/07271a5c6162c0b2bee55e1ea23f91ebdfbbb34c#commitcomment-13064163 Hey, I had this pull request which wasn't reviewed yet [1] - it was this line [2] I'm wondering where to look to fix it

[GitHub] cordova-lib pull request:

Github user vladimir-kotikov commented on the pull request: https://github.com/apache/cordova-lib/commit/07271a5c6162c0b2bee55e1ea23f91ebdfbbb34c#commitcomment-13064620 @zalun, the code you searching for is now here: