Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-wkwebview-engine/pull/1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/160#issuecomment-139688293
yup. But not sure where we would add this dependency... we could just
check-in the `node_modules` in the `bin/templates/scripts/cordova/lib` folder
(after installin
Github user macdonst commented on the pull request:
https://github.com/apache/cordova-ios/pull/160#issuecomment-139687899
@shazron thanks for the feedback, I meant to ask about including npm
modules along with the cordova-ios. This way folks would not need to `npm
install ios-sim` rig
Github user shazron commented on the pull request:
https://github.com/apache/cordova-ios/pull/160#issuecomment-139687129
`require('ios-sim')` is called here, but how is the module installed?
ideally it should be installed when you create the project, inside the
project, or part of
GitHub user riknoll opened a pull request:
https://github.com/apache/cordova-docs/pull/341
Responsive mailing list
Makes the mailing list page responsive to browser width changes and also
factors the mailing list data out of the contacts page source.
You can merge this pull request
Github user timwindsor commented on the pull request:
https://github.com/apache/cordova-blackberry/pull/188#issuecomment-139657104
@kdubuc Are you able to create a jira issue on
https://issues.apache.org/jira/browse/CB for this?
I'm not able to at the moment, but I'd like to captur
GitHub user robpaveza opened a pull request:
https://github.com/apache/cordova-windows/pull/122
Fixed up "resport" to "report"
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-windows FixingResport
Alternativel
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/305#issuecomment-139655827
Thanks for explanation @vladimir-kotikov and thanks for your input @pmuellr
I agree with the change then after explanation.
I still think it should b
Github user cpsloal commented on the pull request:
https://github.com/apache/cordova-docs/pull/339#issuecomment-139654863
Thank you :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this fea
Github user cpsloal closed the pull request at:
https://github.com/apache/cordova-docs/pull/339
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/339#issuecomment-139645307
Merged. Sorry, I forgot the "This closes #339" text.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/340#issuecomment-139637653
Merged into the `cordova-website` branch. Feel free to close the PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/340#issuecomment-139636933
Naw, [it's
fine](https://36.media.tumblr.com/488e6d8f3214f689725ea25140534924/tumblr_notbb5J6IA1qa9oovo1_400.jpg).
The PR is open against master, which is why it
Github user pmuellr commented on the pull request:
https://github.com/apache/cordova-lib/pull/305#issuecomment-139631229
@csantanapr re: not a fan of sync in node.js
Sync becomes a problem if you're wasting precious cycles in a single
operation, instead of using async to pote
Github user purplecabbage commented on the pull request:
https://github.com/apache/cordova-docs/pull/340#issuecomment-139619841
@boblikesoup (great name!) You broke github.
There are 19k modified files in the pull request, which implies to me that
something is seriously wrong here.
GitHub user boblikesoup opened a pull request:
https://github.com/apache/cordova-docs/pull/340
App showcase newvo
Added NewVo to the app showcase. Folders/files were missing for
app-showcase mentioned in the documentation so created them myself (though
sample-apps did exist). Uns
Github user cpsloal commented on the pull request:
https://github.com/apache/cordova-docs/pull/339#issuecomment-139586294
Updated code with CR feedback.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
I was just rebooting the machine to install updates. The slave is up now.
Thanks,
Alexander Sorokin
-Original Message-
From: build...@apache.org [mailto:build...@apache.org]
Sent: Friday, September 11, 2015 6:25 PM
To: dev@cordova.apache.org
Subject: Buildbot: buildslave cordova-windows-
The Buildbot working for 'ASF Buildbot'
has noticed that the buildslave named cordova-windows-slave went away
It last disconnected at Fri Sep 11 15:19:31 2015 (buildmaster-local time)
The admin on record (as reported by BUILDSLAVE:info/admin)
was 'Dmitry Blotsky
'.
Sincerely,
The Buildbot
htt
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/305#issuecomment-139556202
The `xcode`'s `parse` method uses `child_process.fork` API to run parser in
a separate worker process, which then reports parsing result to parent process
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/305#issuecomment-139555231
If it's something wrong with npm package xcode, we should open an issue and
maybe help with a PR
---
If your project is set up for it, you can reply to this em
Github user csantanapr commented on the pull request:
https://github.com/apache/cordova-lib/pull/305#issuecomment-139548204
Hi @vladimir-kotikov can you give explanation why the fix is to run Sync?
In general I'm not fan on Sync in nodejs, but would like to understand
what's t
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/304#issuecomment-139542072
@TimBarham, agree with you, calling a `cordova.prepare` on each plugin
add/rm might be excess. Reworked.
---
If your project is set up for it, you can rep
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-lib/pull/308
CB-9521 Do not pass removed platform to `after_platform_rm` hook
This fixes annoying issue, already described in
[CB-9521](issues.apache.org/jira/browse/CB-9521).
You can merge this p
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-lib/pull/305#issuecomment-139524490
@nikhilkh, i've reworked tests for ios_parser so they work with real xcode
project instead of mocking it.
Regarding second question - yes, all the
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/339#discussion_r39254800
--- Diff: www/static/css-src/_plugins.scss ---
@@ -120,6 +120,13 @@
.plugin-results-show-more {
text-align: center;
cursor:pointer;
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/339#discussion_r39254660
--- Diff: www/static/css-src/_artwork.scss ---
@@ -0,0 +1,34 @@
+.iconset {
+ padding: 100px 0;
+}
+
+.button {
+display: b
Github user cpsloal commented on the pull request:
https://github.com/apache/cordova-docs/pull/339#issuecomment-139481612
Ok, done for reals now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user cpsloal commented on the pull request:
https://github.com/apache/cordova-docs/pull/339#issuecomment-139477962
Done with this PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have thi
Github user dblotsky commented on the pull request:
https://github.com/apache/cordova-docs/pull/339#issuecomment-139477814
Please comment when you feel this PR is ready to be merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
30 matches
Mail list logo
