[GitHub] cordova-cli pull request: CB-9523 Show out of date message for old...

2015-09-15 Thread nikhilkh
Github user nikhilkh commented on the pull request: https://github.com/apache/cordova-cli/pull/219#issuecomment-140625989 @daserge Would be great to merge this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proj

[GitHub] cordova-ios pull request: CB-9328 Use ios-sim as a node module, no...

2015-09-15 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/160#issuecomment-140621633 Nah no need to update to 5.0.1, thanks Simon! I'll give it a spin --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] cordova-ios pull request: CB-9328 Use ios-sim as a node module, no...

2015-09-15 Thread macdonst
Github user macdonst commented on the pull request: https://github.com/apache/cordova-ios/pull/160#issuecomment-140620008 @shazron Yeah, I didn't bother to update to 5.0.1 as it only affects the project when used as a CLI but I can do that if you'd like. I actually did get rid

[GitHub] cordova-docs pull request: Minor fixes to blog and plugins

2015-09-15 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/349#issuecomment-140591615 Merged. Sorry, forgot to add the "This closes #349." text. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-docs pull request: Make external links open another tab

2015-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/350 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: Make external links open another tab

2015-09-15 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/350 Make external links open another tab Excludes the contribute page, which needs to be refactored You can merge this pull request into a Git repository by running: $ git pull https://github

[GitHub] cordova-browser pull request: CB-9669 Browser exec should have mor...

2015-09-15 Thread purplecabbage
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-browser/pull/18 CB-9669 Browser exec should have more failsafes This makes the browser exec methods consistent with other js-only platforms. CallbackID's are used, callbacks can be 'kept' and missi

[GitHub] cordova-docs pull request: Minor fixes to blog and plugins

2015-09-15 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/349 Minor fixes to blog and plugins Fixes the ellipses being colored incorrectly in truncated blog post titles and corrects a warning that React was giving about the supported platform icons in t

[GitHub] cordova-ios pull request: CB-8789 Asset Catalog support

2015-09-15 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/148#issuecomment-140576941 This PR has been pulled in and tested (with an additional fix). You can close this PR now. (ignore the Travis CI) --- If your project is set up for it, you can

[GitHub] cordova-ios pull request: CB-9328 Use ios-sim as a node module, no...

2015-09-15 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/160#issuecomment-140576401 We also can get rid of all checks for the ios-sim requirement: https://github.com/apache/cordova-ios/blob/f2ade2282b56a560199f493a5feb32481a16b6d5/bin/lib/check_reqs

[GitHub] cordova-ios pull request: CB-9328 Use ios-sim as a node module, no...

2015-09-15 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/160#issuecomment-140575717 Just tested with `cordova emulate` -- verified I didn't have any ios-sim installed anywhere before I did so. I suppose 5.0.1 is not needed since that was a patch fo

Re: iOS 9 testing

2015-09-15 Thread Shazron
Thanks Edna! - please file issues for those and add the label "cordova-ios-4.0.x" On Tue, Sep 15, 2015 at 1:56 PM, Edna Y Morales wrote: > > > Hi all, > > I've been doing some iOS 9 testing. I'm not seeing any issues when running > mobilespec. Although, I know there is a jira item for having the

[GitHub] cordova-ios pull request: CB-8789 Asset Catalog support

2015-09-15 Thread shazron
Github user shazron commented on the pull request: https://github.com/apache/cordova-ios/pull/148#issuecomment-140555711 Going to integrate this and add a fix for the above. Please test next time it just creates more work for us :/ --- If your project is set up for it, you can reply

[GitHub] cordova-docs pull request: Cordova website misc fixes

2015-09-15 Thread riknoll
Github user riknoll closed the pull request at: https://github.com/apache/cordova-docs/pull/348 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Cordova website misc fixes

2015-09-15 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/348#issuecomment-140550853 Merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

iOS 9 testing

2015-09-15 Thread Edna Y Morales
Hi all, I've been doing some iOS 9 testing. I'm not seeing any issues when running mobilespec. Although, I know there is a jira item for having the tags in the whitelist work for ATS. I'm bypassing that for now and everything looks good on the UIWebView. Once adding the WKWebView I am seeing ab

[GitHub] cordova-docs pull request: Cordova website misc fixes

2015-09-15 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/348 Cordova website misc fixes Fixes: * Contribute page * Amazon Fire OS No longer gets covered up in small screens (expanded icons collapse) * No more duplicated icons; text l

[GitHub] cordova-docs pull request: replaced NewVo iamge in app showcase

2015-09-15 Thread boblikesoup
Github user boblikesoup commented on the pull request: https://github.com/apache/cordova-docs/pull/347#issuecomment-140508040 I just resized it and it looks legible enough to me. Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] cordova-docs pull request: replaced NewVo iamge in app showcase

2015-09-15 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/347#issuecomment-140505452 Thanks for the PR! My only concern is that this image might not be visible very well in the 100px height it receives on the front page. Are you sure you want to u

[GitHub] cordova-docs pull request: Fixing consistency and grammatical erro...

2015-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/346 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] cordova-docs pull request: Fixing consistency and grammatical erro...

2015-09-15 Thread dblotsky
Github user dblotsky commented on the pull request: https://github.com/apache/cordova-docs/pull/346#issuecomment-140504901 My thoughts: - I think we're referring to Terminal.app on OS X, which is capitalized. - Yep, the second "to create ..." is redundant and I'll remove it.

Cordova Face to Face Meeting

2015-09-15 Thread Parashuram N
Hi, We are only a month away from the Cordova Face to Face meeting on Oct 14th and 15th !! This is a friendly reminder to make your travel arrangements to Redmond, WA, USA. I will send out the exact address in Redmond in a follow up email. Note that this meet up is open to anyone who is interes

[GitHub] cordova-android pull request: Network Error

2015-09-15 Thread achercasky
Github user achercasky closed the pull request at: https://github.com/apache/cordova-android/pull/214 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the fe

[GitHub] cordova-android pull request: Network Error

2015-09-15 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-android/pull/214#issuecomment-140486636 This is a pull request, not the way to ask for help with a specific issue you are having. Please ask on StackOverflow, or join the slack.cordova.io -

[GitHub] cordova-docs pull request: replaced NewVo iamge in app showcase

2015-09-15 Thread boblikesoup
GitHub user boblikesoup opened a pull request: https://github.com/apache/cordova-docs/pull/347 replaced NewVo iamge in app showcase You can merge this pull request into a Git repository by running: $ git pull https://github.com/boblikesoup/cordova-docs cordova-website Alterna

[GitHub] cordova-docs pull request: Fixing consistency and grammatical erro...

2015-09-15 Thread riknoll
GitHub user riknoll opened a pull request: https://github.com/apache/cordova-docs/pull/346 Fixing consistency and grammatical errors on front page Other possible improvements: * In the first bullet, is "Terminal" capitalized for a reason? * In the second bullet, "Create

[GitHub] cordova-docs pull request: Cordova website restyle docs

2015-09-15 Thread riknoll
Github user riknoll closed the pull request at: https://github.com/apache/cordova-docs/pull/344 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs pull request: Removed keyword index from docs

2015-09-15 Thread riknoll
Github user riknoll closed the pull request at: https://github.com/apache/cordova-docs/pull/345 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-android pull request: Network Error

2015-09-15 Thread achercasky
GitHub user achercasky opened a pull request: https://github.com/apache/cordova-android/pull/214 Network Error Hi! I'm trying to load an url from the userwebview.class. The url is https://google.com (very simple hehe). I already add the and https://google.com/*"; />. When

[GitHub] cordova-medic pull request: CB-8936 Gather 15 minutes of logs on W...

2015-09-15 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-medic/pull/62 CB-8936 Gather 15 minutes of logs on Windows https://issues.apache.org/jira/browse/CB-8936 You can merge this pull request into a Git repository by running: $ git pull https://github.co

[GitHub] cordova-lib pull request: CB-7015 Add support for parent and custo...

2015-09-15 Thread mbektchiev
Github user mbektchiev commented on the pull request: https://github.com/apache/cordova-lib/pull/290#issuecomment-140394396 ping @stevengill --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

[GitHub] cordova-browser pull request: CB-9658 Improve 'cordova run browser...

2015-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-browser/pull/17 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-browser pull request: CB-9658 Improve 'cordova run browser...

2015-09-15 Thread TimBarham
GitHub user TimBarham opened a pull request: https://github.com/apache/cordova-browser/pull/17 CB-9658 Improve 'cordova run browser' when browser not installed Catches error and outputs the error message. You can merge this pull request into a Git repository by running: $ git p

[GitHub] cordova-browser pull request: CB-9654 'cordova run browser' -> dup...

2015-09-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-browser/pull/16 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature